Number of commits found: 30

Remove portbuild scripts from pcvs, as they now live in svn/projects.

Push PACKAGE_BUILDING and MALLOC_OPTIONS up a level.

Feature safe:   yes

Generalize the packge building scripts to be able to be run on more than
one 'head' node, rather than just pointyhat itself.

Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf.  There is
only one server.conf file.  Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.

While here, carefully document the origin of the values of the
environment variables that are passed in.

Feature safe:   yes

Catch up with master copy on pointyhat.

Note: all 3 of these files will be changing radically in the near future.
This is the last checkin from the "classic" codebase installation.

Feature safe:   yes

Add a comment.

- Remove use of X11BASE from pointyhat scripts

- Update to reflect a reality on pointyhat

* Catch up to X11R6 removal

* Keep RESTRICTED distfiles in a separate DISTDIR so we can easily
  avoid accidentally publishing them to the FTP site (idea from des@)

Add a note that processonelog and processlogs2 are finicky about the
header format of the log files.

- Add the port's Makefile ident string to the build log headers

PR:             113234
Submitted by:   Andrej Zverev <andrey.zverev@electro-com.ru>

- Sync with actual script on pointyhat (whitespace, mostly)

* Remove vestiges of procfs mounting/umounting from here; we have to
  do it in portbuild from outside the jail thesedays

* Ignore /var/db/fontconfig which does not get restored to pristine state

* Save copies of master.passwd and groups and check them after the build
  for changes, to look for user/group additions that may not be correctly
  registered in UIDs/GIDs.  Future work will hopefully automatically
  check against those files and make unregistered IDs a fatal condition

* Correct logic mistake that was keeping distfiles for collection when
  the checksum mismatched

Also filter out gconf leftover files from /usr/local as well as /usr/X11R6.

Set DISPLAY to the IP address instead of using the :<...> implied form.
This is required for jails.

* Silence gconf spam from the mtree checks (for now)

* Don't try and mount/umount procfs, it won't work when we build inside a
  jail.

* Report the uname -mr of the build environment, to ease confusion of
  people reading the error logs by mail.

jdk is buildable on amd64, so we need to also mount linprocfs there.

Add some more directories temporarily until these ports can be made to
clean themselves up properly.

Approved by:    portmgr (implicit)

* Don't try to pkg_delete packages that are not installed (the usual
  cause is because it was specified in the list twice)

* Don't panic when the list of packages to delete becomes empty

* When unexpected filesystem changes are detected, bail immediately
  instead of proceeding and hiding the error in the middle of
  the log

* Switch back to using pkg_delete -f; we are not yet ready to deal
  with all the errors from broken pkg_delete scripts

* As threatened in previous commit, move the pristine mtree spec
  generation to phase 1, and avoid having to delete and re-add the
  FETCH_DEPENDS.  We still have to keep them installed until after
  'make extract' though

Checkpoint a major round of changes:

* Only keep distfiles if the port passes 'make fetch', so we don't
  accidentally keep files with invalid checksums

* Use cleanup() instead of directly exiting in some error conditions

* When cleanup() is called indicating an unexpected error (possibly
  leaving the filesystem in an inconsistent state), mark the chroot
  as dirty so it will not be reused by another build

* Remove packages in dependency order instead of with pkg_delete -f in
  possibly incorrect order.  This paves the way for focusing on errors
  generated by pkg_delete (e.g. @dirrm that should be @dirrmtry) in the
  future. [1]

(Only the first 15 lines of the commit message are shown above )

Use LOCALBASE and X11BASE from buildenv

* Unmount linprocfs around pkg_adding dependencies, to try and work
  around silly failures in some ports when it is present

* Add a footer to completed builds that is recognised by pdispatch to
  retry truncated builds

* If ALWAYS_KEEP_DISTFILES is not present in the environment or port
  makefile, then clean up DISTDIR after the build finishes, to prevent
  collection of distfiles for this port.

* Finish flipping the switch on -noplistcheck - this is activated by
  passing in the NOPLISTCHECK environment variable instead of
  using PLISTCHECK in the opposite case

Update the list of files and directories to filter from the plist checking.

Update the plist checking to look for a subset of files and weed out some
false positives.

Fix the Xvfb code to run Xvfb before the build phase if detected
(i.e. if the package lists a dependency on the relevant package in the
PACKAGE_BUILDING case).  This allows packages that require an
available DISPLAY to again build (with some forthcoming fixes to
existing ports).

Improve the reporting of detected filesystem anomalies (extra files
left behind after deinstallation, changes to and removal of
pre-existing files)

* Recursively list all files detected as having been left behind after
  the port deinstall; mtree does not recurse into subdirectories it does
  not know about
* Break out the 'files incorrectly removed' and 'files incorrectly changed'
  into their own sections

* Add a cleanup() function and use it so that we archive the ${WRKDIR}
  if requested (".keep" file in the port directory), no matter where
  we fail.

* Add package dependencies before the corresponding build stage
  (e.g. FETCH_DEPENDS before 'make fetch'), and remove them again
  afterwards.  This allows us to catch ports that list their
  dependencies too early/late.

* No need to check for set[ug]id files here, the security-check target
  in bsd.port.mk does it for us.

* Exclude some more directories and files from showing up in the mtree
  before/after comparison, to trim down the false-positive in the
  pkg-plist check.

* Other minor changes

* Set the PACKAGE_BUILDING variable in the build environment so ports can
  detect they are being built on bento
* Update the list of "extra files" to filter to reduce some false positives

Simplify the collection of load statistics for the cluster.  Loads
are now collected by polling a small server on the client (using netcat)
instead of having the client scp the load files to the master every 10
seconds (!!!)

If the port directory contains a file called .keep, then tar up the
${WRKDIR} after the port build completes and copy it to
${arch}/${branch}/wrkdirs/${pkgname}.tbz.

Use pkg_add instead of pkg_add -f

Add PKG_PATH so packages can be found automatically (not sure what caused
this to break).  Support both .tgz and .tbz packages.

Number of commits found: 30

15 vulnerabilities affecting 22 ports have been reported in the past 14 days

^* - modified, not new

All vulnerabilities