04:58 jbeich 

devel/android-tools-{adb,fastboot}-devel: chase platform version output

 

16:09 jbeich 

devel/android-tools-adb-devel: unbreak on 10.* after r448542

In file included from adb_auth_host.cpp:33:
adb/../base/include/android-base/file.h:60:63: error: unknown type name
'off64_t'; did you mean 'off_t'?
bool ReadFullyAtOffset(int fd, void* data, size_t byte_count, off64_t offset);
                                                              ^~~~~~~
                                                              off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t         off_t;
                        ^

 

23:03 jbeich 

devel/android-tools-adb-devel: oops, don't turn off assert() in logging_test.cpp

 

22:29 jbeich 

devel/android-tools-adb-devel: unbreak TEST=on

[ RUN      ] logging.DCHECK
adb/../base/logging_test.cpp:89: Failure
Death test: {SuppressAbortUI(); if (::android::base::kEnableDChecks)
(__builtin_expect( ((false)) != 0, true )) || (false) ||
::android::base::LogMessage( "adb/../base/logging_test.cpp", 89,
::android::base::DEFAULT, ::android::base::FATAL, -1).stream() << "Check failed:
" "false" << " ";}
    Result: died but not with expected error.
  Expected: DCheck failed: false
Actual msg:
[  DEATH   ] adb_test F 07-02 17:11:02 69537 100707 logging_test.cpp:89] Check
failed: false
[  DEATH   ]
[  FAILED  ] logging.DCHECK (1 ms)

[ RUN      ] file.ReadFileToString_WriteStringToFile_symlink
adb/../base/file_test.cpp:55: Failure
      Expected: 62
To be equal to: (* __error())
      Which is: 31
[  FAILED  ] file.ReadFileToString_WriteStringToFile_symlink (0 ms)

[ RUN      ] file.Readlink
adb/../base/file_test.cpp:148: Failure
      Expected: 0
To be equal to: symlink(max.c_str(), max_path.c_str())
      Which is: -1
[  FAILED  ] file.Readlink (0 ms)

 

21:50 jbeich 

devel/android-tools-adb-devel: update to o.p.2.332

- USB transport is no longer supported on DragonFly and FreeBSD < 11
  as probing outside of libusb hotplug API isn't implemented

Changes:	https://android.googlesource.com/platform/system/core/+log/dfd30c4a169e..d1e9e7bc06f0/adb

 

03:44 jbeich 

devel/android-tools-{adb,fastboot}-devel: update to n.p.5.3582

Changes:	https://android.googlesource.com/platform/system/core/+log/2f21b7cecda2..dfd30c4a169e/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/2f21b7cecda2..dfd30c4a169e/fastboot

 

16:48 jbeich 

devel/android-tools-{adb,fastboot}-devel: update to n.p.5.126

Changes:	https://android.googlesource.com/platform/system/core/+log/80beb506cf84..2f21b7cecda2/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/80beb506cf84..2f21b7cecda2/fastboot

 

15:51 jbeich 

devel/android-tools-{adb,fastboot}-devel: update to n.p.3.101

Changes:	https://android.googlesource.com/platform/system/core/+log/d61bfb9a79e3..35d84096e9a5/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/d61bfb9a79e3..35d84096e9a5/fastboot

 

11:38 jbeich 

devel/android-tools-adb-devel: update to n.p.2.43

Changes:	https://android.googlesource.com/platform/system/core/+log/371e7ea170d7..ba430e363427/adb

 

19:22 jbeich 

devel/android-tools-adb-devel: update to n.p.1.554

Changes:	https://android.googlesource.com/platform/system/core/+log/aef26bb1a4ad..0fc006685c20/adb
(r409356 fixed link)
Changes:	https://android.googlesource.com/platform/system/core/+log/0fc006685c20..371e7ea170d7/adb

 

16:25 jbeich 

devel/android-tools-{adb,fastboot}-devel: update to m.p.6425

Changes:	https://android.googlesource.com/platform/system/core/+log/aef26bb1a4ad..aef26bb1a4ad/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/aef26bb1a4ad..aef26bb1a4ad/fastboot

 

11:30 jbeich 

devel/android-tools-{adb,fastboot}-devel: update to m.p.6225

Changes:	https://android.googlesource.com/platform/system/core/+log/461a29540c01..aef26bb1a4ad/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/461a29540c01..aef26bb1a4ad/fastboot

 

01:55 jbeich 

devel/android-tools-{adb,fastboot}-devel: update to m.p.5956

Changes:	https://android.googlesource.com/platform/system/core/+log/0bb1ce06ea46..461a29540c01/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/0bb1ce06ea46..461a29540c01/fastboot

 

22:18 jbeich 

devel/android-tools-{adb,fastboot}-devel: update to m.p.5498

Changes:	https://android.googlesource.com/platform/system/core/+log/f83766079e24..0bb1ce06ea46/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/94c617ccbba4..0bb1ce06ea46/fastboot

 

02:01 jbeich 

devel/android-tools-adb-devel: unbreak build on DragonFly (forgot in r400820)

make(1) suffix rules discard original extension as used by bsd.*.mk
which leads to unpredictable behavior if more than one candidate is
found under ${.PATH}. So, partially qualify pathname to avoid
accidentally building libcutils/sockets.c despite SRCS=sockets.cpp

  $ echo 'void foo() { }' > a.c
  $ echo 'int main() { }' > a.cxx
  $ make PROG_CXX=test SRCS=a.cxx NO_MAN= -f /usr/share/mk/bsd.prog.mk
  cc  -O -pipe    -std=gnu99  -c a.c
  c++  -O -pipe  -o test a.o
  /usr/lib/crt1.o: In function `_start':
  crt1.c:(.text+0x132): undefined reference to `main'
  *** Error code 1

which in adb case leads to (since partial C++ conversion in 6.0.0)

  adb.o: In function `handle_packet(apacket*, atransport*)':
  adb.cpp:(.text+0x2518): undefined reference to `find_local_socket(unsigned
int, unsigned int)'
  adb.cpp:(.text+0x2613): undefined reference to `find_local_socket(unsigned
int, unsigned int)'
  adb.cpp:(.text+0x276a): undefined reference to `find_local_socket(unsigned
int, unsigned int)'
  adb.cpp:(.text+0x2875): undefined reference to
`create_local_service_socket(char const*)'
  adb.cpp:(.text+0x288c): undefined reference to `create_remote_socket(unsigned
int, atransport*)'
  adb.cpp:(.text+0x2a41): undefined reference to `create_remote_socket(unsigned
int, atransport*)'
  adb_listeners.o: In function `listener_event_func(int, unsigned int, void*)':
  adb_listeners.cpp:(.text+0xe2): undefined reference to
`create_local_socket(int)'
  adb_listeners.cpp:(.text+0xfe): undefined reference to
`connect_to_remote(asocket*, char const*)'
  adb_listeners.o: In function `ss_listener_event_func(int, unsigned int,
void*)':
  adb_listeners.cpp:(.text+0x1b1): undefined reference to
`create_local_socket(int)'
  adb_listeners.cpp:(.text+0x1be): undefined reference to
`connect_to_smartsocket(asocket*)'
  services.o: In function `host_service_to_socket(char const*, char const*)':
  services.cpp:(.text+0x64d): undefined reference to `create_local_socket(int)'
  services.cpp:(.text+0x6b7): undefined reference to `create_local_socket(int)'
  transport.o: In function `input_thread(void*)':
  transport.cpp:(.text+0x1931): undefined reference to
`close_all_sockets(atransport*)'
  *** [adb] Error code 1

 

18:03 jbeich 

devel/android-tools-*: slightly improve standalone build

- Try to derive {ADB,FASTBOOT}_REVISION from git(1)
- Use pkg-config for libcrypto/libpcre/libusb (e.g. if they aren't in base)
- Convert PORTDOCS into FILES (bsd.port.mk vs. bsd.prog.mk)
- Partially convert to new testing framework
- Put -lpthread last as enforced by base r274849 but prevent
  := assignment from mucking $ escaping in $()
- |make clean| to clean files built by test target
- Move up bsd.prog.mk in order to use ${PROG} and ${OBJS} defined in it

 

22:49 jbeich 

devel/android-tools-adb-devel: update to m.p.1280

Changes:	https://android.googlesource.com/platform/system/core/+log/94c617ccbba4..659f5ade04a5/adb

 

20:25 jbeich 

devel/android-tools-*: restore CPPFLAGS support after r390135

 

15:43 jbeich 

devel/android-tools-{adb,fastboot}-devel: update to m.p.1212

platform/system/extras snapshot grew in size thanks to memory dumps:

  $ du -Ahc memory_replay/dumps/*
  2.0K    memory_replay/dumps/README
  9.2M    memory_replay/dumps/camera.zip
   12M    memory_replay/dumps/gmail.zip
  8.4M    memory_replay/dumps/maps.zip
  3.9M    memory_replay/dumps/surfaceflinger.zip
   33M    memory_replay/dumps/system_server.zip
  1.8M    memory_replay/dumps/systemui.zip
  6.5M    memory_replay/dumps/youtube.zip
   74M    total

  $ tar xOf memory_replay/dumps/youtube.zip | head
  202: malloc 0xb4827400 1024
  202: free 0xb4827400
  202: malloc 0xb4837058 20
  202: malloc 0xb4803068 4
  202: malloc 0xb48370a0 17
  202: malloc 0xb48370d0 18
  202: malloc 0xb4837100 20
  202: malloc 0xb4839040 48
  202: malloc 0xb483a020 30
  202: malloc 0xb483b080 98
  youtube.txt: Write error

Changes:	https://android.googlesource.com/platform/system/core/+log/e4c1bb53068d...94c617ccbba4/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/e4c1bb53068d...94c617ccbba4/fastboot
(no changes)

 

15:42 jbeich 

devel/android-tools-adb-devel: add unit tests like simpleperf

 

15:42 jbeich 

devel/android-tools-adb-devel: make -DFAKE_LOG_DEVICE local

 

22:49 jbeich 

devel/android-tools-{adb,fastboot}-devel: update to m.p.1112

files/usb_libusb.cpp chases the following commits:
https://android.googlesource.com/platform/system/core/+/49ee7cf%5E!/#F6
https://android.googlesource.com/platform/system/core/+/7a3f8d6%5E!/

Changes:	https://android.googlesource.com/platform/system/core/+log/94a845d..e4c1bb5/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/94a845d..e4c1bb5/fastboot

 

17:14 jbeich 

devel/android-tools-adb-devel: add new slave port for git master

A temporary port to facilitate testing and updating master.

While copying usb_libusb.c [1] under FILESDIR clean it up:
- Add static keyword for file-local functions
- Fix const usage exposed in C++ mode [2]
- Fix casting 3rd argument of libusb_bulk_transfer(3) exposed in C++ mode
- Fix inconsistent whitespace: trailing, tabs + spaces, bogus indentation
- Fix typo in usb_kick() trace message
- Fix fprintf(3) warning in scan_usb_devices() trace message
- Convert err(3) usage to fatal_errno()
- Drop BSDism of sysexits(3)
- Drop unecessary struct keyword
- Drop unused headers [2]

(Only the first 15 lines of the commit message are shown above )