14:12 mat 

Disable some checks for linux ports.

- shebang check: skip scripts in LINUXBASE.  Things like /bin/bash are
  valid in a Linux context.  Also, these scripts usually only work with
  a Linux shell so it doesn't make sense to try to make them work from a
  FreeBSD shell.
- prefixvar check: allow LINUXBASE/var.
- proxydeps check: only test FreeBSD ELF files because ldd(1) doesn't
  work with other ELF files.

PR:		212419
Submitted by:	tijl
Sponsored by:	Absolight

 

15:23 mat 

Add a stage-qa check to check for the existence of SONAME in .so's.

If a port provides .so.X files, they have to have a SONAME for them to
work correctly.

While there, incorporate a reverse soname checks in proxydeps.
A port that needs a .so.X from another port which does not have a
SONAME.

Reviewed by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D7454

 

12:43 mat 

Use LIB_DEPENDS when appropriate in KDE components.

Lots of KDE components are providing libraries, and they were,
strangely, written as BUILD_ or RUN_DEPENDS, with a full path to the
library.  Change this so that if a component is needed at both build,
and, run-time, then it gets a LIB_DEPENDS.

Reviewed by:	rakuco, tcberner
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D7625

 

18:29 mat 

Tell people to add USES=gettext-runtime, not USES=gettext.

This is done after the port has been built, so it is already building,
so it does not need to be added a BUILD_DEPENDS on gettext-tools.

Discussed with:	dumbbell
Sponsored by:	Absolight

 

09:59 mat 

Only warn about symlinks that exist in the stage directory, or that
exist nowhere.

Sponsored by:	Absolight

 

07:58 amdmi3 

- Fix typo: "you need USES=nssl" -> "you need USES=ssl"

Approved by:	mat
Differential Revision:	D6997

 

13:26 mat 

Catch up two instances of USE_OPENSSL.

Sponsored by:	Absolight

 

11:31 mat 

Replace bsd.openssl.mk with USES=ssl

Add a qa hint about needing, or not, USES=ssl.

Fix ports doing silly things, like including bsd.openssl.mk directly.

PR:		210322
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6866

 

11:31 mat 

Extend the symlink checks to warn on absolute targets.

Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6930

 

14:32 mat 

Add USE_OPENSSL to the proxy libs thing.

Sponsored by:	Absolight

 

17:16 amdmi3 

Fix sed command in proxydeps_suggest_uses qa.sh check

It led to incorrect "you need USE_XORG+" suggestion

Submitted by:	amdmi3
Approved by:	portmgr (bapt)
Differential Revision:	D6618

 

11:59 mat 

A new stage-qa test has been added, it reports all shared libraries
dependencies that are not part of the port list of dependencies.  It help
finds what is called proxy dependencies.

A is needed by B, and B is needed by C.  If C also needs A, then it needs to
be registered, and this check will tell you to do so.

Right now, it is only reporting the problems, but if you add
PROXYDEPS_FATAL=yes to your environment, it will give an error and will force
you to fix the dependencies.

PR:		195203
Submitted by:	yuri rawbw com (earlier version)
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6531

 

19:01 mat 

Ease debugging of Mk/Scripts scripts.

Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6474

 

10:12 mat 

Try to simplify how libperl.so is looked for.

PR:		209123
Submitted by:	mat
Exp-run by:	antoine
With hat:	perl@
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6107

 

16:18 swills 

exclude all gem stuff from path check

 

16:16 mat 

Be consistent and always enclose shell variables inside braces.

Sponsored by:	Absolight

 

16:16 mat 

Rework the logic of the libperl detection, making it a bit more simple,
and also a bit more verbose.

With hat:	perl
Sponsored by:	Absolight

 

23:22 antoine 

Do not advise to strip object files, it can be harmful

Reported by:	koobs
With hat:	portmgr

 

16:59 bdrewery 

Switch strip test to using readelf(1) instead of file(1) to identify symbols.

This has been slightly faster in my tests since readelf(1) will fail on the
file much quicker if it doesn't find the ELF headers.  This also more directly
finds the symbol table.

With hat:	portmgr

 

14:12 amdmi3 

Add a way to cleanly handle terminfo.db file used by devel/ncurses

This database contains compiled terminfo entries and is merged from
a large part which comes with ncurses themselves and compiled
.terminfo files installed by other ports (currently only rxvt-unicode
and jfbterm)

- Now the database is always kept up to date, regardless of port
  installation order (both ncurses installed before .terminfo files
  and the other way around work as expected)
- All affected ports now support clean deinstallation and do not
  produce stage-qa errors
- Affected ports are simplified, as they now only need to define
  USES=terminfo
- rxvt-unicode no longer pulls in ncurses: the dependency is not
  really needed for anything beside updating it's own database
- The patch contains Q/A test to check whether a port needs, or
  needs not USES=terminfo

Approved by:	portmgr (mat, bapt)
Differential Revision:	D3747

 

17:06 antoine 

Make baselibs QA check non recursive and activate it again

Reviewed by:	bapt
Differential Revision:	https://reviews.freebsd.org/D3352

 

11:41 bapt 

Disable baselibs check until it is made saner (aka non recursive)

 

10:10 antoine 

Fix a typo that made baselibs QA check run twice on some files

With hat:	portmgr

 

22:19 bapt 

Fix path of libedit

 

22:07 bapt 

Add a QA check on some base libraries (for now only libedit and libarchive)

 

20:36 amdmi3 

- Add /usr/sbin/dtrace to the list of allowed shebangs

Submitted by:	amdmi3
Approved by:	portmgr (bapt)
Differential Revision:	D3070

 

11:37 amdmi3 

- Add blacklist of files which are not intended to be executed to shebang test
- Sort shebang list

Differential Revision:	D2670
Submitted by:	amdmi3
Approved by:	portmgr (bapt)

 

19:47 amdmi3 

- Add ${PREFIX}/www to shebang check. We have many shebang problems which need
to be discovered and fixed in www category.

Differential Revision:	D2580
Approved by:	portmgr (bapt)

 

02:44 bdrewery 

Fix strip check to consider setuid binaries.

file(1) returns 'setuid' before the rest of the ELF output.

With hat:	portmgr
Sponsored by:	EMC / Isilon Storage Division

 

19:06 tijl 

- Display a stage-qa warning when ports use PREFIX/var instead of /var
- Add --localstatedir=/var to _LATE_CONFIGURE_ARGS (like --mandir) but not
  when CONFIGURE_ARGS already sets it.  (GNU configure scripts set it to
  PREFIX/var when PREFIX != /usr.)
- Add --localstatedir="${PREFIX}/var" to CONFIGURE_ARGS in some ports so
  they aren't affected by this change (for now at least).  This commit is
  meant to ensure that new ports don't make the same mistake.

- games/acm: the configure script in this port is very old; instead of
  patching it more, just replace GNU_CONFIGURE with HAS_CONFIGURE.
- irc/charybdis: it already used /var but adding --localstatedir=/var
  changed the behaviour of the configure script; adjust the port to this.

PR:		199506
Exp-run by:	antoine
Approved by:	portmgr (antoine)

 

20:41 feld 

Speed up checking for stripped binaries

Skip ascii files. This significantly speeds up stage-qa on ports with a
considerable amount of text files being installed.

Differential Revision:	https://reviews.freebsd.org/D2121
Approved by:	bdrewery

 

00:27 mat 

Don't output a warning if PERL_ARCH does not exist.

With hat:	portmgr
Sponsored by:	Absolight

 

13:21 mat 

Make Perl link all .so it builds with libperl.so.

It makes upgrading from one Perl major version to another way easier.  For
binary package users, it means pkg upgrade will detect the libperl.so.x.yy
change, and reinstall the affected packages.  For users using ports, it will
save rebuild time as it's easier to detect what ports really need to be
rebuilt.

PR:		195821
Differential Revision: https://reviews.freebsd.org/D1241
Submitted by:	mat
Reviewed by:	antoine, bdrewery
Exp-run by:	antoine
With hat:	perl
Sponsored by:	Absolight

 

18:47 bdrewery 

- Allow LINUXBASE for shebangs.

PR:		193878
Submitted by:	Jan Beich <jbeich@vfemail.net>
With hat:	portmgr

 

18:23 tijl 

Turn the installation of *.la files, without some form of USES=libtool in
the port Makefile, into a stage-qa error.  All ports that would trigger
this error have been converted.  Many thanks to all people involved in
this, especially Dmitry Marakasov (amdmi3) who handled most ports.

At this moment over 2200 ports have USES=libtool and over 20000 library
dependencies between packages have been removed.

This also marks the point where :keepla is no longer special.  It is now
only needed if a port uses *.la files at run-time.

QA-run by:	antoine
Approved by:	portmgr (antoine)

 

08:55 antoine 

Ignore references to stagedir in .fmt and .log files generated for tex formats
Those are harmless (records from which file they were generated from) and
removing them would require ugly hacks according to hrs@

PR:		ports/192933
Differential Revision:	https://reviews.freebsd.org/D684
Reviewed by:	bapt, hrs
With hat:	portmgr

 

22:10 antoine 

Check that the plist doesn't reference the stage dir during stage-qa

====> Running Q/A tests (stage-qa)
Error: '/usr/ports/www/claroline/work/.PLIST.mktmp' is referring to
/usr/ports/www/claroline/work/stage
*** Error code 1

Differential Revision: https://reviews.freebsd.org/D685
Reviewed by:	bdrewery
With hat:	portmgr

 

17:48 antoine 

Advise trying INSTALL_TARGET=install-strip before ${STRIP_CMD}

Phabric:	D477
Reviewed by:	bdrewery
With hat:	portmgr

 

14:33 rene 

Mk/Scripts/qa.sh: add /bin/tcsh as a valid shebang.

Phabric:	D231
Approved by:	portmgr (antoine)

 

22:29 bdrewery 

- Fix regression handling files with spaces from r350006.
  Separate file(1) and stat(1) output by a newline and read each line
  individually to avoid losing spaces.
- Use <<-EOF with heredocs to avoid bad indent
- Add some more comments
- Quote filenames in output so it is less unclear

Spotted by:	mandree
Reviewed by:	antoine
With hat:	portmgr

 

11:57 tijl 

Let stage-qa detect .la libraries and warn that a port needs USES=libtool.

PR:		ports/189255
Approved by:	portmgr (antoine)

 

20:17 antoine 

- Do not advise to strip non FreeBSD binaries [1]
- Shorten messages

Requested and tested by:	xmj [1]
With hat:	portmgr

 

20:49 antoine 

Do not advise to strip ELF relocatables, usually it is harmful

With hat:	portmgr

 

20:48 antoine 

Reduce the number of false positives reported by the shebang qa check
by looking only at files and symlinks in bin, sbin and libexec

Reviewed by:	bdrewery
With hat:	portmgr

 

14:15 bdrewery 

- Make shebang a warning for now, too many false-positives in files we
  do not care about.

  antoine@ is working on a better solution for this.

With hat:	portmgr

 

16:50 antoine 

Rewrite the sharedmimeinfo qa check so that it doesn't produce a false
positive on misc/shared-mime-info

With help from:	bdrewery
With hat:	portmgr

 

14:09 bdrewery 

- stage-qa: Fix absolute symlink check to look at target not fully resolved
  path. Now tested on both good and bad symlinks.

Reported by:	antoine
Pointyhat to:	bdrewery
With hat:	portmgr

 

13:00 bdrewery 

- Fix fatal checks not exiting with non-zero [1]
  This means that files referrencing stagedir or linked to stagedir will
  now be fatal errors as intended.
- Stop polluting global namespace with IFS changes
- Speedup find(1) -exec usage by execing far less
- Ignore known false-positive/harmless stagedir files in paths() [2]

Reported by:	eadler [1]
Discussed with:	antoine [2]
With hat:	portmgr

 

22:19 antoine 

- Do not check for ${WRKDIR} in staged files, there are lots of false
  positives as some .o files may embed the source path [1]
- Only check shebang of files with executable bit set

Requested by:	bapt [1]
With hat:	portmgr

 

18:43 antoine 

Fix paths check from qa.sh
IFS is set to newline so dirs was not correctly splitted

Approved by:	portmgr (bapt)

 

23:12 bapt 

/usr/bin/nawk and /bin/csh are valid shebangs

 

12:23 mandree 

- in qa.sh, properly work with filenames containing blank or tab,
  by setting IFS to just LF

- in check-stagedir.sh, properly detect unset environmental variables,
  and list them all

- in check-stagedir.sh, also list the full prefix as known, not just
  its parents

PR:		184039
Approved by:	portmgr (bapt)

 

19:07 mandree 

bsd.stage.mk: Fewer false positives, much faster, easier maintenance.

Bugfixes:

* @cmd in pkg-plist is now properly handled.
  - It was previously treated the same as though there was a directory
    following it, missing the prefix. (ordering matters in case...esac)

  - Due to the cwd=${PREFIX} inside the while read line loop, state
    tracking was broken and every new line assumed that cwd were the
    prefix.

* stage-qa no longer complains about unstripped binaries if debugging is
  active (WITH_DEBUG set && WITHOUT_DEBUG unset).

* The compress-man target uses ECHO_MSG, not ECHO_CMD, to print its
  build step.

Additions:

* The plist parser now understands @unexec rmdir ... || ... lines,
  including those with redirections, so that there are no false
  positives for directories stripped with @unexec rmdir (usually
  happens on stuff installed outside $PREFIX, as in /var).

* The system's root and var mtrees are now also expanded to avoid
  false @dirrm positives if a port installs directories under /var
  and has to create parents in the stagedir that are present in a fully
  installed system (i. e. in the real $PREFIX).

* Given that pkg_create is deemed beyond repair with respect to deleting
  files outside prefix, generate @unexec rmdir statements for such
  directories, rather than @dirrmtry, to sidestep the problem.

Speedups:

* the orphan check now generates sorted lists of staged files,
  and plisted/mtree files, and compares them with comm(1).
  This saves us the overhead of running one grep process per file
  and up to two per directory, and defers the actual list
  processing to a shell utility.  Complexity has not changed,
  but overhead per item has.

* the orphan check now uses one file for directories and one file for
  files mentioned in pkg-plist, so we need not decorate them with "dir "
  and parse them out any longer.

* qa.sh's shebang scanner only looks at the first line of a file,
  sed is told to exit from the 2nd line.

Other Changes:

* Split the makeplist/check-orphans logic out of bsd.stage.mk,
  it is too unwieldy to maintain in make-escaped shell syntax,
  and permits shell tracing with "SH=sh -x" (including quotes!)

* Unify the functions "makeplist" and "check-orphans" in one
  script.  The only difference is that makeplist assumes an empty
  pkg-plist, whereas check-orphans parses it.

* overhaul the mtree extractor, avoiding awk.

Reviewed by:	bapt
Approved by:	portmgr (bapt)

 

18:12 ak 

- Add check for suid files and directories

Approved by:	portmgr (bapt)

 

00:17 bapt 

Recommand to use STRIP_CMD to strip binaries given that it will respect the
WITH_DEBUG option

 

02:52 bdrewery 

- Fix desktopfileutils() and sharedmimeinfo() returning non-zero and causing
  failure on every port that does not use shared-mime-info or need it.

  Must return 0 at end of functions or it considers the last command ran as
  the return code.

Reported by:	eadler
With hat:	portmgr

 

17:09 antoine 

Add two QA tests for staged ports:
- check for desktop files handling MIME types
- check for share MIME-Info database

Approved by:	portmgr (bapt)

 

15:11 bapt 

First set of Q/A for staged ports.
A couple of Q/A tests are done if the DEVELOPER macros is set in make.conf
Right now the tests are:
- Check if the symlinks are properly created
- Check if the binaries are stripped (just warn)
- Check if the STAGEDIR or the WORKDIR are referenced in the final files
- Check if the ports provide script with bad shebangs.