notbugIf you buy from Amazon USA, please support us by using this link.
non port: Mk/Scripts/smart_makepatch.sh
SVNWeb

Number of commits found: 9

Fri, 8 Jun 2018
[ 09:26 mat ] Original commit   Revision:471994
471994 Mk/Scripts/qa.sh
471994 Mk/Scripts/smart_makepatch.sh
SC1004: This backslash+linefeed is literal. Break outside single quotes if you
just want to break the line.

You have a single quoted string containing a backslash followed by a
linefeed (newline). Unlike double quotes or unquoted strings, this has
no special meaning. The string will contain a literal backslash and a
linefeed.

If you wanted to break the line but not add a linefeed to the string,
stop the single quote, break the line, and reopen it.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
[ 09:26 mat ] Original commit   Revision:471993
471993 Mk/Scripts/smart_makepatch.sh
SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.

Since files and arguments are strings passed the same way, programs
can't properly determine which is which, and rely on dashes to determine
what's what.

A file named -f (touch -- -f) will not be deleted by the problematic
code. It will instead be interpreted as a command line option, and rm
will even report success.

Using ./* will instead cause the glob to be expanded into ./-f, which no
program will treat as an option.

It is not possible to use `-f *` because -f only forces the next
argument to be a directory, a later directory named -delete would mess
things up.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
[ 09:26 mat ] Original commit   Revision:471988
471988 Mk/Scripts/check_leftovers.sh
471988 Mk/Scripts/depends-list.sh
471988 Mk/Scripts/find-lib.sh
471988 Mk/Scripts/functions.sh
471988 Mk/Scripts/smart_makepatch.sh
SC2046: Quote this to prevent word splitting.

When command expansions are unquoted, word splitting and globbing will
occur. This often manifests itself by breaking when filenames contain
spaces.

Trying to fix it by adding quotes or escapes to the data will not work.
Instead, quote the command substitution itself.

If the command substitution outputs multiple pieces of data, use a loop
instead.

Add an exception when using set -- where splitting is intended.

PR:             227109
Submitted by:   mat
Exp-run by:	antoine
Sponsored by:   Absolight
Fri, 1 Jun 2018
[ 16:20 mat ] Original commit   Revision:471273
471273 Mk/Scripts/smart_makepatch.sh
SC2155: Declare and assign separately to avoid masking return values.

In the original code, the return value of mycmd is ignored, and export
will instead always return true. This may prevent conditionals, set -e
and traps from working correctly.

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
Mon, 22 Jan 2018
[ 16:42 kevans ] Original commit   Revision:459675
459675 Mk/Scripts/smart_makepatch.sh
`make makepatch`: Don't replace patches with only metadata changes

Rather than replacing patches that are effectively the same but with
different timestamps, drop the new version and let the old version remain in
place. This yields a `make makepatch` that doesn't try and produce unwanted
churn.

Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D13960
Fri, 20 May 2016
[ 19:01 mat ] Original commit   Revision:415573
415573 Mk/Scripts/actual-package-depends.sh
415573 Mk/Scripts/check-stagedir.sh
415573 Mk/Scripts/check_leftovers.sh
415573 Mk/Scripts/depends-list.sh
415573 Mk/Scripts/dialog4ports.sh
415573 Mk/Scripts/do-depends.sh
415573 Mk/Scripts/do-users-groups.sh
415573 Mk/Scripts/find-lib.sh
415573 Mk/Scripts/qa.sh
415573 Mk/Scripts/smart_makepatch.sh
Ease debugging of Mk/Scripts scripts.

Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6474
Thu, 21 Jan 2016
[ 10:25 rakuco ] Original commit   Revision:406842
406842 Mk/Scripts/smart_makepatch.sh
smart_makepatch: Quote PATCH_WRKSRC when regenerating patches.

Put ${PATCH_WRSKRC} within quotes so that expanding it works properly when it
contains spaces. This is required for `make makepatch' to work with
audio/quimup or any other port that has WRKSRC with spaces. Before the patch:

  % make -dl makepatch
  cd: too many arguments
  cd: too many arguments

and the port would be left with an empty files/ directory.

Reviewed by:	marino
Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D5011
Sun, 22 Nov 2015
[ 09:18 marino ] Original commit   Revision:402220
402220 Mk/Scripts/smart_makepatch.sh
Mk/Scripts/smart_makepatch.sh: Fix multi-patch file and locals bug

There were two issues with the new smart_makepatch script.

1) use of "local" declaration

All function variables were declared "local" during the review.  This
caused the script to break, at least on FreeBSD 9.2.  Given that it's
not being seen on 9.3R or later, it might be a bug in Bourne shell that
has since been fixed.

e.g. This resulted in stderr error on second iteration:
  local contains=$(grep "^+++ " ${existing_patch} | awk '{x++; print x}')

however, this works fine:
(Only the first 15 lines of the commit message are shown above View all of this commit message)
Sun, 15 Nov 2015
[ 15:25 marino ] Original commit   Revision:401709
401709 Mk/Scripts/smart_makepatch.sh
401709 Mk/bsd.port.mk
Enhance "make makepatch" to address two major deficiencies

This update to the "makepatch" target adds the following enhancements:

1) Conserves comments
   If the existing patch has comments, they will be transferred to the
   regenerated patch.

2) Supports multiple patches per file
   If the patch file contains concatenated patches, the makepatch
   target will keep these patches together.  It may change the order
   of the patches the first time, but every time after the multi-patch
   will be assembled in the same order.

Behavioral changes:
(Only the first 15 lines of the commit message are shown above View all of this commit message)

Number of commits found: 9

Login
User Login
Create account

Servers and bandwidth provided by
New York Internet, iXsystems, and RootBSD

This site
What is FreshPorts?
About the authors
Issues
FAQ
How big is it?
The latest upgrade!
Privacy
Forums
Blog
Contact

Search
Enter Keywords:
 
more...

Latest Vulnerabilities
drupal7Apr 25
drupal8Apr 25
hostapdApr 23
hostapdApr 23
hostapdApr 23
hostapdApr 23
hostapdApr 23
py-yamlApr 23
wpa_supplicantApr 23
wpa_supplicantApr 23
wpa_supplicantApr 23
wpa_supplicantApr 23
wpa_supplicantApr 23
istioApr 22
ghostscript9-agpl-baseApr 21

16 vulnerabilities affecting 120 ports have been reported in the past 14 days

* - modified, not new

All vulnerabilities

Last updated:
2019-04-25 03:05:54


Ports
Home
Categories
Deleted ports
Sanity Test Failures
Newsfeeds

Statistics
Graphs
NEW Graphs (Javascript)
Traffic

Calculated hourly:
Port count 36799
Broken 124
Deprecated 658
Ignore 343
Forbidden 3
Restricted 164
No CDROM 74
Vulnerable 36
Expired 512
Set to expire 632
Interactive 0
new 24 hours 13
new 48 hours17
new 7 days59
new fortnight89
new month144

Servers and bandwidth provided by
New York Internet, iXsystems, and RootBSD
Valid HTML, CSS, and RSS.
Copyright © 2000-2019 Dan Langille. All rights reserved.