notbugAs an Amazon Associate I earn from qualifying purchases.
Want a good read? Try FreeBSD Mastery: Jails (IT Mastery Book 15)
Ukraine
Some details on the 2023-01-16 website outage.
We just rebooted with several updates: * new HMTLify code * no port maintainer is now highly visible (e.g. https://freshports.org/security/sssd/) * fixed search logic error when using plain/ text details at https://github.com/FreshPorts/freshports/releases/tag/2.2.34
non port: Mk/Scripts/smart_makepatch.sh
SVNWeb

Number of commits found: 17

Wed, 14 Jul 2021
[ 16:15 Po-Chuan Hsieh (sunpoet) search for other commits by this committer ]    commit hash:fcb34faf706733a667358b293970fac444251828  commit hash:fcb34faf706733a667358b293970fac444251828  commit hash:fcb34faf706733a667358b293970fac444251828  fcb34fa 
Mk/Scripts/smart_makepatch.sh: Force diff to produce the patch file instead of
"Binary files ... differ" message

It helps avoid generating wrong patches, e.g. patch-grpc.gemspec in r567838 [1].

from diff manpage:
    -a --text
        Treat all files as ASCII text.  Normally diff will simply print
	"Binary files ... differ" if files contain binary characters.
        Use of this option forces diff to produce a diff.

[1]
https://cgit.FreeBSD.org/ports/diff/net/rubygem-grpc130/files/patch-grpc.gemspec?id=073c1c710a0c7254820adab9920c1903ace83fae

PR:		257027
Approved by:	mat (portmgr)
Tue, 6 Apr 2021
[ 14:27 Mathieu Arnold (mat) search for other commits by this committer ]    commit hash:5d33e045968104ac678d8b4b4ec1e8956bbf68e0  commit hash:5d33e045968104ac678d8b4b4ec1e8956bbf68e0  commit hash:5d33e045968104ac678d8b4b4ec1e8956bbf68e0  5d33e04  (Only the first 10 of 224 ports in this commit are shown above. View all ports for this commit)
framework: Remove $FreeBSD$

Where appropriate fiddle with a few other things.
Wed, 11 Nov 2020
[ 13:29 mat search for other commits by this committer ] Original commit   Revision:554893 (Only the first 10 of 22 ports in this commit are shown above. View all ports for this commit)
Add set pipefail in most framework scripts.

set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline.  This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.

PR:		250723
Exp-run by:	antoine
Reviewed by:	bapt
Approved by:	bapt
Differential Revision:	https://reviews.freebsd.org/D27007
Thu, 5 Nov 2020
[ 16:51 mat search for other commits by this committer ] Original commit   Revision:554142 (Only the first 10 of 22 ports in this commit are shown above. View all ports for this commit)
Backout r554139.
[ 16:42 mat search for other commits by this committer ] Original commit   Revision:554139 (Only the first 10 of 22 ports in this commit are shown above. View all ports for this commit)
Add set pipefail in most framework scripts.

set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline.  This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.
Thu, 23 Jan 2020
[ 08:55 mat search for other commits by this committer ] Original commit   Revision:523912
Unbreak make makepatch.

The glob in `find ./*` is handled by the shell and actually sorts the
files, so one needs to to ask find to sort the result, using `find -s`.

`find ./* -maxdepth 0` is not equivalent to `find . -maxdepth 0`, the
depth increases by one as `./x` is on level deeper than `.`.

Pointy hat:	bdrewery
Tue, 21 Jan 2020
[ 20:36 bdrewery search for other commits by this committer ] Original commit   Revision:523738
find(1) doesn't need a glob to search for patches.

This change also avoids cmdline length errors and other subst
parsing issues that were previously targeted.

Sponsored by:	DellEMC
Mon, 20 May 2019
[ 13:04 mat search for other commits by this committer ] Original commit   Revision:502102
Have makepatch ignore "C function prototype".

This will reduce the churn when base system diff subtly changes what is
put in that field.
Fri, 8 Jun 2018
[ 09:26 mat search for other commits by this committer ] Original commit   Revision:471994
SC1004: This backslash+linefeed is literal. Break outside single quotes if you
just want to break the line.

You have a single quoted string containing a backslash followed by a
linefeed (newline). Unlike double quotes or unquoted strings, this has
no special meaning. The string will contain a literal backslash and a
linefeed.

If you wanted to break the line but not add a linefeed to the string,
stop the single quote, break the line, and reopen it.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
[ 09:26 mat search for other commits by this committer ] Original commit   Revision:471993
SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.

Since files and arguments are strings passed the same way, programs
can't properly determine which is which, and rely on dashes to determine
what's what.

A file named -f (touch -- -f) will not be deleted by the problematic
code. It will instead be interpreted as a command line option, and rm
will even report success.

Using ./* will instead cause the glob to be expanded into ./-f, which no
program will treat as an option.

It is not possible to use `-f *` because -f only forces the next
argument to be a directory, a later directory named -delete would mess
things up.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
[ 09:26 mat search for other commits by this committer ] Original commit   Revision:471988
SC2046: Quote this to prevent word splitting.

When command expansions are unquoted, word splitting and globbing will
occur. This often manifests itself by breaking when filenames contain
spaces.

Trying to fix it by adding quotes or escapes to the data will not work.
Instead, quote the command substitution itself.

If the command substitution outputs multiple pieces of data, use a loop
instead.

Add an exception when using set -- where splitting is intended.

PR:             227109
Submitted by:   mat
Exp-run by:	antoine
Sponsored by:   Absolight
Fri, 1 Jun 2018
[ 16:20 mat search for other commits by this committer ] Original commit   Revision:471273
SC2155: Declare and assign separately to avoid masking return values.

In the original code, the return value of mycmd is ignored, and export
will instead always return true. This may prevent conditionals, set -e
and traps from working correctly.

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
Mon, 22 Jan 2018
[ 16:42 kevans search for other commits by this committer ] Original commit   Revision:459675
`make makepatch`: Don't replace patches with only metadata changes

Rather than replacing patches that are effectively the same but with
different timestamps, drop the new version and let the old version remain in
place. This yields a `make makepatch` that doesn't try and produce unwanted
churn.

Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D13960
Fri, 20 May 2016
[ 19:01 mat search for other commits by this committer ] Original commit   Revision:415573
Ease debugging of Mk/Scripts scripts.

Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6474
Thu, 21 Jan 2016
[ 10:25 rakuco search for other commits by this committer ] Original commit   Revision:406842
smart_makepatch: Quote PATCH_WRKSRC when regenerating patches.

Put ${PATCH_WRSKRC} within quotes so that expanding it works properly when it
contains spaces. This is required for `make makepatch' to work with
audio/quimup or any other port that has WRKSRC with spaces. Before the patch:

  % make -dl makepatch
  cd: too many arguments
  cd: too many arguments

and the port would be left with an empty files/ directory.

Reviewed by:	marino
Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D5011
Sun, 22 Nov 2015
[ 09:18 marino search for other commits by this committer ] Original commit   Revision:402220
Mk/Scripts/smart_makepatch.sh: Fix multi-patch file and locals bug

There were two issues with the new smart_makepatch script.

1) use of "local" declaration

All function variables were declared "local" during the review.  This
caused the script to break, at least on FreeBSD 9.2.  Given that it's
not being seen on 9.3R or later, it might be a bug in Bourne shell that
has since been fixed.

e.g. This resulted in stderr error on second iteration:
  local contains=$(grep "^+++ " ${existing_patch} | awk '{x++; print x}')

however, this works fine:
(Only the first 15 lines of the commit message are shown above View all of this commit message)
Sun, 15 Nov 2015
[ 15:25 marino search for other commits by this committer ] Original commit   Revision:401709
Enhance "make makepatch" to address two major deficiencies

This update to the "makepatch" target adds the following enhancements:

1) Conserves comments
   If the existing patch has comments, they will be transferred to the
   regenerated patch.

2) Supports multiple patches per file
   If the patch file contains concatenated patches, the makepatch
   target will keep these patches together.  It may change the order
   of the patches the first time, but every time after the multi-patch
   will be assembled in the same order.

Behavioral changes:
(Only the first 15 lines of the commit message are shown above View all of this commit message)

Number of commits found: 17