Number of commits found XX: 25

Mk/Uses/go.mk: Explicitly set modules-aware mode depending on "modules" argument

Until now, go.mk relied on default Go behavior of switching to modules-aware
mode only in the presence of go.mod and building in legacy ("GOPATH") mode
otherwise. This changes with go1.16 [1] which flips defaults to always build in
modules-aware mode and needs an explicit GO111MODULE=off to turn modules off.

Stop relying on Go defaults and set build mode explicitly depending on
"modules" argument in USES=go.

[1] https://github.com/golang/go/issues/41330

Ensure go modules cannot fetch missing modules via network

Notes from go help modules:

If GOPROXY is set to the string "direct", downloads use a direct connection to
source control servers. Setting GOPROXY to "off" disallows downloading modules
from any source. Otherwise, GOPROXY is expected to be list of module proxy URLs
separated by either comma (,) or pipe (|) characters, which control error
fallback behavior. For each request, the go command tries each proxy in
sequence. If there is an error, the go command will try the next proxy in the
list if the error is a 404 or 410 HTTP response or if the current proxy is
followed by a pipe character, indicating it is safe to fall back on any error.

The GOPRIVATE and GONOPROXY environment variables allow bypassing
the proxy for selected modules. See 'go help module-private' for details.

(Only the first 15 lines of the commit message are shown above )

Mk/Uses/go.mk: Fix gomod-vendor-diff when there are 3 or fewer items in the
GH_TUPLE

'make gomod-vendor-diff' currently doesn't work properly when modules2tuple
doesn't return the first empty line, when 3 or fewer items are in the GH_TUPLE
list.

PR:		245617
Submitted by:	yuri

Mk/Uses/go.mk: Set GO_NO_VENDOR_CHECKS=1

Set GO_NO_VENDOR_CHECKS=1 to signal lang/go to relax vendor checks during ports
build.

PR:		244783
Reported by:	Christopher Hall <hsw@bitmark.com>
Reviewed by:	mikael swills yuri
MFH:		2020Q2
Differential Revision:	https://reviews.freebsd.org/D24122

Mk/Uses/go.mk: Add the gomod-vendor-diff target

Add the 'gomod-vendor-diff' target that tells the user what changes are needed
in GH_TUPLE. This is in addition to the existing 'gomod-vendor' target that
shows the user the whole new GH_TUPLE.

PR:		244660
Submitted by:	yuri

Mk/Uses/go.mk: Avoid pollution of Go module cache with modules downloaded by
gomod-vendor

Use module cache local to the WRKDIR and add the -modcacherw flag (available in
go1.14 [1, 2]) to instruct go mod vendor to leave directories in the module
cache read-write instead of making them unwritable.

[1] https://github.com/golang/go/issues/31481
[2] https://go-review.googlesource.com/c/go/+/202079/

Reviewed by:	swills
Differential Revision:	https://reviews.freebsd.org/D23063

Mk/Uses/go.mk: Revert r517706, switch GO_PORT to lang/go on aarch64

aarch64 support has landed in lang/go, switch default GO_PORT from
lang/go-devel to lang/go.

Mk/Uses/go.mk: Add GO_TESTTARGET and provide default do-test

Add GO_TESTTARGET defaulting to `./...` (the current package and all
subpackages) and create do-test target unless already provided by port's
Makefile.

Also, while here

- remove GO_WRKDIR_SRC - it is not used by any port anymore
- sync GO_PKGNAME and GO_TARGET descriptions with Porter's Handbook

Reviewed by:	tobik
Differential Revision:	https://reviews.freebsd.org/D22412

Mk/Uses/go.mk: Warn if Go is not installed for gomod-vendor

PR:		242872
Reviewed by:	yuri
Differential Revision:	https://reviews.freebsd.org/D22923

Revert r517831, FOO_TEST_TARGET is reserved for option helpers

With hat:	portmgr

Mk/Uses/go.mk: Add GO_TEST_TARGET and provide default do-test

Add GO_TEST_TARGET defaulting to `./...` (the current package and all
subpackages) and create do-test target unless already provided by port's
Makefile.

In many cases this would allow us to remove explicit do-test and rely on
defaults provided by ports framework for testing.

Also, while here

- remove GO_WRKDIR_SRC - it is not used anywhere anymore
- sync GO_PKGNAME and GO_TARGET descriptions with Porter's Handbook

Reviewed by:	tobik
Approved by:	tz (mentor, implicit)
Differential Revision:	https://reviews.freebsd.org/D22412

Mk/Uses/go.mk: Omit symbol table and debug information by default

PR:		233335
Reported by:	yuri
Reviewed by:	0mp, tobik
Approved by:	araujo (mentor)
Differential Revision:	https://reviews.freebsd.org/D21730

Mk/Uses/go.mk: Enable binary package building for Go ports on aarch64

Tentatively enable package building for Go ports on aarch64 to catch
regressions early.

Reviewed by:	tobik, Mikael Urankar <mikael.urankar@gmail.com>
Approved by:	tz (mentor, implicit)
Differential Revision:	https://reviews.freebsd.org/D22385

Change my maintainer email

Approved by:	tz (mentor), portmgr (adamw)
Differential Revision:	https://reviews.freebsd.org/D21677

Mk/Uses/go.mk: Allow naming output executable in GO_TARGET

- Allow GO_TARGET to be specified as a tuple in the form package:output
- Rework build/install targets

PR:		240535
Submitted by:	Dmitri Goutnik <dg@syrec.org>
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D21562

Mk/Uses/go.mk: Add gomod-vendor helper target

For USES=go:modules ports it simplifies generating GH_TUPLE by
calling modules2tuple in the right directory etc.

Submitted by:	Dmitri Goutnik <dg@syrec.org> (maintainer)
Differential Revision:	https://reviews.freebsd.org/D21246

Mk/Uses/go.mk: Drop PLIST_SUB for GO_PKGNAME

GO_PKGNAME defaults to ${PORTNAME}.  As a result it is often too
general and can produce bad results with make makeplist.  For
example, in mail/aerc it produces bogus entries like

man/man5/%%GO_PKGNAME%%-sendmail.5.gz

since GO_PKGNAME=aerc there.

Having it in PLIST_SUB was only useful for Go libraries which we
no longer support.  Only 2 ports use it currently but do not really
need to and are easily fixed.

Approved by:	dg@syrec.org (maintainer)
Differential Revision:	https://reviews.freebsd.org/D21114

Mk/Uses/go.mk: Default to "." instead of PORTNAME

If neither GO_PKGNAME or GO_TARGET are set explicitly, go install
tries to install a package named ${PORTNAME} which is almost always
wrong.  This forces Go ports to set GO_PKGNAME or GO_TARGET although
their value is often redundant.

Update do-build to default to the "." package instead ("the package
in the current directory") and teach do-install to install the "."
package.  In many cases, this removes the need to explicitly set
GO_PKGNAME and GO_TARGET making USES=go:modules alone sufficient
for simpler ports.

This is a backward compatible change.

- Assign maintainership to Dmitri

Submitted by:	Dmitri Goutnik <dg@syrec.org>
Approved by:	jlaffaye (maintainer timeout, ~3 weeks)
Differential Revision:	https://reviews.freebsd.org/D20813

Convert all Go ports to USES=go

This allows for port testing with lang/go-devel via GO_PORT, setting
up the Go build environment in a single place, and is step one in
simplifying Go ports that often define too complicated do-build
targets themselves.

USES=go gains new arguments 'run' to add lang/go to RUN_DEPENDS and
'no_targets' for ports with composite builds that call 'go' themselves
and do not need the do-build/do-install targets of USES=go.

PR:		238849
Submitted by:	dg@syrec.org (also D20745)
Reviewed by:	mat, tobik
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D20746

Mk/Uses/go.mk: Allow overriding the Go port

This is intended to be used for regression testing of USES=go ports
with lang/go-devel.

Submitted by:	dg@syrec.org
Differential Revision:	https://reviews.freebsd.org/D20570

Improve support for ARM in go.mk
- Set GOARM value according to current ARCH
- Set CGO_ENABLED

Submitted by:	Dmitri Goutnik <dg@syrec.org>
Differential Revision:	D19892

Mk/Uses/go.mk: Remove support for installing Go libs and sources

All ports that depend on it have been removed in r497504.

- Restrict build to only main packages by adding -buildmode=exe to
  GO_BUILDFLAGS
- Add initial support for building in module-aware mode

PR:		236509
Submitted by:	Dmitri Goutnik <dg@syrec.org>
Reviewed by:	0mp, jlaffaye, tobik
Approved by:	jlaffaye (maintainer)
Differential Revision:	https://reviews.freebsd.org/D19570

Add GO_BUILDFLAGS variable to Uses/go.mk

PR:		225812
Submitted by:	David O'Rourke <dor.bsd@xm0.uk>

Allow USES=go ports to override make targets & include <bsd.port.pre.mk>

Prior to this change, if a port had:
- USES=go.mk,
- .include <bsd.port.pre.mk>, and
- overrode a make target (e.g. post-extract:)

then the following warnings were produced when invoking make on the port:
  make: "/usr/local/poudriere/ports/default/CATEGORY/PORT/Makefile" line XX:
warning: duplicate script for target "post-extract" ignored
  make: "/usr/local/poudriere/ports/default/Mk/Uses/go.mk" line 68: warning:
using previous script for "post-extract" defined here

This change fixes this issue by wrapping the definition of make targets
in a separate once-only !defined wrapper which is blocked until post.mk.
This concept was copied from Mk/Uses/python.mk.

PR:		224948
Submitted by:	woodsb02
Approved by:	jlaffaye (maintainer)

Move lang/go/files/bsd.go.mk to USES=go.

Reviewed by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6057

Number of commits found XX: 25

9 vulnerabilities affecting 70 ports have been reported in the past 14 days

^* - modified, not new

All vulnerabilities

Last updated:
2021-01-26 20:33:26