13:13 Rene Ladan (rene) 

Mk/Uses: tag kmod.mk as PIE_UNSAFE

Kernel modules are not executables, so marking them safe for being a
position-indepentent executable does not make sense.
PR:		268922

    1e765fa

10:00 Tobias C. Berner (tcberner) 

framework: cleanup conditional-indentations in Mk/

Run Tools/scripts/indent_make_if.pl on all of Mk.

These white space changes contribute greatly to the readability of those files.
As we have a version control system, finding out the reasons for the changes
prior to these white space changes is still easily possible

Differential Revision:	https://reviews.freebsd.org/D35024
Reviewed by:		portmgr (rene, bapt)

    aa25396

03:33 Li-Wen Hsu (lwhsu) 

Uses/kmod: Only IGNORE when src is not available in build target

This enables to fetch and checksum on a host without src, for example, a
distfile mirroring service.

Reviewed by:	rene
Differential Revision:	https://reviews.freebsd.org/D30345

    939745d

14:27 Mathieu Arnold (mat) 

framework: Remove $FreeBSD$

Where appropriate fiddle with a few other things.

    5d33e04

19:46 emaste 

on error, remind user of variable used to set src tree location

trying to build kmod ports without a src tree in /usr/src results in a
failure reporitng that the build requires kernel source files in /usr/src.
Mention also the make variable (SRC_BASE) that sets the path as a hint to
users building against a src tree located elsewhere.

Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D22707

 

21:48 rene 

Automatically generate @dir entries for package list if :debug is used.

Tested with a modified sysutils/biosfont in which the :debug option was added,
a file was installed into ${KERN_DEBUGDIR}/${KMODDIR} and that file was added
to pkg-plist.

PR:		216879 (inspired by)
Submitted by:	Sergey Kozlov (kozlov.sergey.404@gmail.com)

 

21:53 rene 

Fix check-plist of USES=kmod

No longer depend on (KERN_)DEBUGDIR being non-empty to decide whether to
create the empty KERN_DEBUGDIR/KMODDIR directory, instead use a new
argument 'debug' to indicate this.

Add KERN_DEBUGDIR to PLIST_SUB and MAKE_ENV so that the including ports
can use them.

Ports using kmod:debug do need to add @dir entries to their pkg-plist for
now to prevent 'make check-plist' errors, for example for default KMODDDIR:

@dir /%%KERN_DEBUGDIR%%/%%KMODDIR%%
@dir /%%KERN_DEBUGDIR%%/boot
@dir /%%KERN_DEBUGDIR%%

It would indeed be nice to automate this.

PR:		216879
Submitted by:	Sergey Kozlov (kozlov.sergey.404@gmail.com)

 

20:53 rene 

If KERN_DEBUGDIR happens to be empty, the port would try to install
files twice to the same location leading to make(1) warnings.

Reported by:	marino
Pointy hat:	rene (r428333)

 

18:47 rene 

Uses/kmod.mk: add support for debug versions of kernel modules.

Submitted by:	glebius via private mail

 

13:31 mat 

Rewrite the target ordering code.

The targets now have priority assigned to them, and, when the dependency
ordering magic is done at the end of bsd.port.mk, they are sorted
according to their priority.

This allows USES to add targets easily and have them run whenever they
want without touching bsd.port.mk.

To add a target that runs just before post-configure run, do:

_USES_configure+=  695:my-post-configure
my-post-configure:
	do something

To fine tune when the target is ran, look at the values in the *_SEQ
variables at the end of bsd.port.mk, and the other USES.

Allow ports Makefiles to override the priority of targets with the
TARGET_ORDER_OVERRIDE variable.  For example, to get post-install
running earlier, (its default is 700) do:

TARGET_ORDER_OVERRIDE=	  650:post-install

While there, add options target helpers for the do-* targets when they
exist.

Reviewed by:	antoine, bapt
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3099

 

12:43 bapt 

Use a custom keyword for kldxref, that allows to control exactly when it is run
and work nicer with automatic directly support from pkg

Differential Revision:	https://reviews.freebsd.org/D1377
Reviewed by:	rene, antoine
Approved by:	rene

 

16:36 tijl 

Change the way USES is handled:
- Loop over USES twice, once to define all *_ARGS variables and once to
  include Uses/*.mk.  This allows all Uses/*.mk to examine arguments given
  to other USES entries.
- Always define *_ARGS (possibly empty) and replace commas with spaces.

Similar for _USES_POST.

Adjust all Uses/*.mk:
- defined(u_ARGS) becomes !empty(u_ARGS)
- Eliminate helper variables like _*_ARGS=${*_ARGS:C/,/ /g}
- Some Uses/*.mk used ":" as argument separator instead of ",", but no port
  used this form
- Uses/cran.mk: remove unused variable VALID_ARGS and USES+=fortran which
  has no effect
- Uses/twisted.mk: simplify handling of the case where neither "build" nor
  "run" arguments have been specified

PR:		193931
Exp-run by:	antoine
Approved by:	portmgr (antoine)

 

09:50 antoine 

Do not override _USES_POST

Reviewed by:	bapt
Phabric:	D560
With hat:	portmgr

 

21:01 rene 

Add --strip-debug to STRIP_CMD to avoid removing kernel symbols from the
installed kernel module.  This would otherwise break comms/uarduno on amd64
when converting this port to USES=kmod.

PR:		189621 (in private followup)
Submitted by:	Bob Frazier <bobf@mrp3.com>
MFH:		2014Q2

 

10:31 gerald 

Move MAINTAINER lines to the end of the initial comment block and
make things a bit more consistent.

Approved by:	portmgr (bapt)

 

18:00 rene 

Remove support for unstaged ports.

Approved by:	bapt

 

23:08 rene 

- kernel modules support SSP natively, so change the description
  of SSP_UNSAFE [1]
- take advantage of rmdir -p to remove nested instances of KMODDIR if
  empty.  Some ports have KMODDIR=dir1/dir2

Submitted by:	antoine [1]
Approved by:	portmgr (bapt)

 

00:26 bapt 

Properly add targets to the sequence they belong to, that now makes them
predictable

 

16:43 danfe 

Traditionally, most (if not all) tamperings with ${TMPPLIST} were done
silently within the ports (similar to extraction and patching phases).

Recently introduced Mk/Uses/kmod.mk does some grunt work for pkg-plist,
like @[un]exec /usr/sbin/kldxref ... stuff via ${ECHO_CMD}, which makes
build logs less neat.  Mute them and MKDIR, remove an extra whitespace,
and wrap one overly long line.

Approved by:	rene

 

12:43 bapt 

Define the target in post section.
Remove the PHONY kmod-pre-install target and replace it with a real file target
(well directory in this case)

Approved by:	rene

 

07:29 bapt 

Mark some targets .PHONY

 

19:44 rene 

Do not try to remove /boot/modules, it is part of BSD.root.dist [1]

While here unquote an instance of /boot/modules.
Submitted by:	antoine [1]

 

11:40 rene 

Fix with bmake which requires KMODDDIR to be defined before use.

Submitted by:	marino

 

09:44 rene 

Change KMODDDIR to /boot/modules if it is set to /boot/kernel

This allows upgrading a kernel without breaking any installed kernel ports
because during the upgrade /boot/kernel is renamed to /boot/kernel.old ,
resulting in moved files.

While /boot/modules is the default, it might be overridden by bsd.own.mk to
/boot/kernel before kmod is included, so setting MODULES_WITH_WORLD has no
effect.

 

09:30 rene 

Using stage does not magically enforce the use of sane package tools, so
always use the "@unexec rmdir" form in TMPPLIST.  @dirrmtry lines are
substituted with this in bsd.port.mk, but only when generating TMPPLIST.

While here update the description in the header.

Submitted by:	QAT for commit r332642 (8.4-QAT/i386)

 

22:51 rene 

Use @unexec rmdir instead of @dirrmtry in the NO_STAGE case.

Submitted by:	vsevolod via IRC

 

19:41 rene 

Make sure that kldxref(8) is not run when installing into the staging
directory to prevent orphaned linker.hints files.

Obtained from:	Porters Handbook section 6.1

 

11:34 rene 

Add a new USES for kernel module ports.

USES=kmod takes no arguments and:
- adds kld to CATEGORIES
- sets SSP_UNSAFE
- sets IGNORE if the kernel sources are not found
- defines KMODDIR to /boot/modules by default, add it to
  PLIST_SUB and MAKE_ENV, and create it upon installation
- handles cross-referencing kernel modules upon installation and
  deinstallation

Approved by:	bapt