07:08 Po-Chuan Hsieh (sunpoet) 

Mk/Uses/pathfix.mk: Add CMAKE_INSTALL_FULL_LIBDIR/pkgconfig pattern

It is used by devel/level-zero.

    2416ef0

10:00 Tobias C. Berner (tcberner) 

framework: cleanup conditional-indentations in Mk/

Run Tools/scripts/indent_make_if.pl on all of Mk.

These white space changes contribute greatly to the readability of those files.
As we have a version control system, finding out the reasons for the changes
prior to these white space changes is still easily possible

Differential Revision:	https://reviews.freebsd.org/D35024
Reviewed by:		portmgr (rene, bapt)

    aa25396

09:29 Rene Ladan (rene) 

Mk: release portmgr maintainership of most USES files

Differential Revision: https://reviews.freebsd.org/D34936

Reviewed by:	desktop (tcberner), portmgr (tcberner), ruby (yasu), tijl

    767d81e

17:20 Muhammad Moinur Rahman (bofh) 

Mk/Uses: Add new pathfix expression

While working on Apertium ecosystem it looks like their entire 500+
applications uses hardcoded pkgconfigdir with (prefix)/share/pkgconfig.
This patch adds that regex for easier porting for the huge pile of
ports.

Reviewed by:	tcberner
Approved by:	portmgr
Differential Revision:	https://reviews.freebsd.org/D34780

    5333878

13:45 Baptiste Daroussin (bapt) 

cleanup: remove unused letfovers from scrollkeeper

    13977a9

14:27 Mathieu Arnold (mat) 

framework: Remove $FreeBSD$

Where appropriate fiddle with a few other things.

    5d33e04

13:01 swills 

Add QA warning about useless REINPLACE_CMD

Reviewed by:	mat, bdrewery, tobik
Approved by:	mat
Differential Revision:	https://reviews.freebsd.org/D22174

 

09:08 gahr 

Fix pkgconfig path when used in CMAKE_INSTALL_DATAROOTDIR

 

15:19 mat 

Allow more than one filename to be pathfixed.

PR:		213195
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D8093

 

15:19 mat 

It feels safe to assume that if using autoreconf, you want to patch Makefile.am.

PR:		213195
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D8093

 

15:19 mat 

Add a few more paths to USES=pathfix.

PR:		213195
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D8093

 

06:18 tcberner 

Teach pathfix.mk about LIB_DESTINATION

Some cmake projects use LIB_DESTINATION/pkgconfig to install the pc-files.

For example:
* deskutils/libstreamanalyzer
* sysutils/polkit-qt{,5}
* x11-toolkits/attica

By adding this, we can convert these ports to use pathfix instead of an
uncessessary patch-foo or confusing sed call.

Reviewed by:	mat
Approved by:	portmgr (mat), mat (mentor)
Differential Revision:	https://reviews.freebsd.org/D8141

 

17:45 tcberner 

Teach pathfix about KDE_INSTALL_LIBDIR for pkgconfig files.

Reviewed by:	rakuco, mat
Approved by:	portmgr (mat), mat (mentor)
Differential Revision:	https://reviews.freebsd.org/D8029

 

14:54 jhale 

Add USES=pathfix support for CMake.  Some ports that use CMake to build
already had USES=pathfix, although it did nothing.  For those ports, I
either removed it as they were handling the pkgconfig files differently
or I removed patches and substitutions that accomplished the same thing
as pathfix.

Differential Revision:	https://reviews.freebsd.org/D850
Reviewed by:	antoine, bapt, tijl
Approved by:	portmgr (bapt)

 

12:35 mat 

Change the meaning of NO_WRKSUBDIR to force a WRKDIR != WRKSRC.

Right now, NO_WRKSUBDIR means that the extraction does not produce a
subdirectory, and that everything goes straight into WRKDIR.  It is
problematic, because during the build of a port, quite a few files are
created in there, and then, a stage directory, where everything is
installed, and then a pkg directory where the package is created, and
those often conflict, or get in the way, of the building process.

With this, NO_WRKSUBDIR will extract the distfiles directly into WRKSRC
instead of WRKDIR.  In this case, WRKSRC is artificial and is based on
PKGNAME and not DISTNAME, mitigate conflicts with rc files.

PR:		204056
Submitted by:	mat
Reviewed by:	bapt
Exp-run:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D2735

 

13:31 mat 

Rewrite the target ordering code.

The targets now have priority assigned to them, and, when the dependency
ordering magic is done at the end of bsd.port.mk, they are sorted
according to their priority.

This allows USES to add targets easily and have them run whenever they
want without touching bsd.port.mk.

To add a target that runs just before post-configure run, do:

_USES_configure+=  695:my-post-configure
my-post-configure:
	do something

To fine tune when the target is ran, look at the values in the *_SEQ
variables at the end of bsd.port.mk, and the other USES.

Allow ports Makefiles to override the priority of targets with the
TARGET_ORDER_OVERRIDE variable.  For example, to get post-install
running earlier, (its default is 700) do:

TARGET_ORDER_OVERRIDE=	  650:post-install

While there, add options target helpers for the do-* targets when they
exist.

Reviewed by:	antoine, bapt
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3099

 

16:36 tijl 

Change the way USES is handled:
- Loop over USES twice, once to define all *_ARGS variables and once to
  include Uses/*.mk.  This allows all Uses/*.mk to examine arguments given
  to other USES entries.
- Always define *_ARGS (possibly empty) and replace commas with spaces.

Similar for _USES_POST.

Adjust all Uses/*.mk:
- defined(u_ARGS) becomes !empty(u_ARGS)
- Eliminate helper variables like _*_ARGS=${*_ARGS:C/,/ /g}
- Some Uses/*.mk used ":" as argument separator instead of ",", but no port
  used this form
- Uses/cran.mk: remove unused variable VALID_ARGS and USES+=fortran which
  has no effect
- Uses/twisted.mk: simplify handling of the case where neither "build" nor
  "run" arguments have been specified

PR:		193931
Exp-run by:	antoine
Approved by:	portmgr (antoine)

 

15:18 tijl 

- Set CPPFLAGS and LIBS in a number of ports so configure can find libintl.h
  and libintl.so.  This fixes a problem where DATADIRNAME gets an incorrect
  value which causes locale files to be installed in the wrong place.
- The only configure checks that still need to be patched are related
  to intltool so move DATADIRNAME patching from USES=pathfix to
  USE_GNOME=intlhack.

- games/klavaro: remove excessive dependencies
- japanese/libskk: add INSTALL_TARGET=install-strip
- math/libqalculate: add INSTALL_TARGET=install-strip and remove pthread
  patching
- multimedia/freetuxtv: remove excessive dependencies
- science/gramps: fix shared-mime-info use

Exp-run by:	antoine
Approved by:	portmgr (antoine)

 

06:42 bapt 

Rename pathfix-pre-patch target into pathfix to be consistent

 

12:45 koobs 

Mk/pathfix.mk: Support more pkgconfig libdir matches

Add support for matching additional pkgconfig libdir entries
that were found in Python's Makefile.pre.in.

It can also be used by other ports [1] by setting PATHFIX_MAKEFILEIN to the
appropriate filename in ${WRKSRC}.

If this file grows support for other pathfix'es beyond Makefile's and
autoconf sources, it may be worth renaming PATHFIX_MAKEFILEIN in future
to suit the broader scope.

[1] Examples: devel/ptlib, graphics/zathura (thanks antoine)

Reviewed by:	antoine
Approved by:	antoine (exp-run)
MFH:		2014Q2

 

10:31 gerald 

Move MAINTAINER lines to the end of the initial comment block and
make things a bit more consistent.

Approved by:	portmgr (bapt)

 

00:02 bapt 

Mark all targets defines in _SEQ and .ORDER has .PHONY which they all should be
If one day we are no adding a target actually correspond to an actual file,
simply adding
the name of the target to the NOTPHONY will make it work as expected

 

23:43 bapt 

Add pathfix-pre-path to the _PATCH_SEQ and do not anymore make it a dependency
of pre-patch
That makes applying the pathfix target predictable

 

07:29 bapt 

Mark some targets .PHONY

 

15:45 kwm 

Add new replace line for pkg-config file location.

PR:		ports/177868
Submitted by:	myself
Approved by:	portmgr (bapt)
Feature safe:	yes

 

06:43 az 

- Change namespace for USES files
- Add missing colon

Approved by:	bapt@ (portmgr@)

 

15:04 bapt 

- Add a short usage description inside each Uses/*.mk
- Simplify logic for Uses/bison.mk and make error message more informative
- Add error handler for Uses/fuse.mk and Uses/pathfix.mk

Submitted by:	ak@, az@

 

15:12 bapt 

Add a newline to improve readability

 

14:28 bapt 

New USES macros that loads "features" on demand.

First feature implemented: pathfix which will lookup in WRKSRC for Makefile.in
and configure and fix common path that doesn't fit with FreeBSD hier(7)

This is an extract of bsd.gnome.mk's gnomehack to avoid porters to have to load
the full bsd.gnome.mk just for this feature

More features to come...