10:02 mat 

Keep --forward when using PATCH_DEBUG.

Otherwise, when used with BATCH defined so as to not be bothered by
config screen and all, it will almost silently reverse obsolete patches
and make you wonder why something is now broken.

Reviewed by:	sbruno
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D15804

 

17:39 tcberner 

Replace bsd.qt.mk by Uses/qt.mk and Uses/qt-dist.mk

From now on, ports that depend on Qt4 will have to set
	USES=		qt:4
	USE_QT=		foo bar
ports depending on Qt5 will use
	USES=		qt:5
	USE_QT=		foo bar

PR:		229225
Exp-run by:	antoine
Reviewed by:	mat
Approved by:	portmgr (antoine)
Differential Revision:	-https://reviews.freebsd.org/D15540

 

17:42 jhb 

Set OS versions to target system versions for CROSS_SYSROOT.

When cross-building a package via a CROSS_SYSROOT, set OSVERSION,
_OSRELEASE, and OSREL to the target OS version.  OSVERSION is derived
from the <sys/param.h> header in the sysroot.  _OSRELEASE cannot be
easily derived from a sysroot as it is a property of a kernel, so
instead generate a "fake" _OSRELEASE from the OSVERSION, but use a
"-CROSS" branch name that will hopefully fail in any places that make
assumptions about branch names.

Approved by:	portmgr (bapt)
Differential Revision:	https://reviews.freebsd.org/D15812

 

15:15 mat 

Sort ONLY_FOR_ARCHS and NOT_FOR_ARCHS on display.

This is so that all IGNORE message end up looking the same, and grep'ing
and sorting them is easier.

Reported by:	linimon
Sponsored by:	Absolight

 

19:15 tijl 

Run "/usr/sbin/service ldconfig restart" for USE_LDCONFIG instead of
"ldconfig -m <path>" so the order of ldconfig search directories after
package installation is the same as after a reboot.  The original command
simply appends the path to the list of directories while the ldconfig rc.d
script uses "sort -u".

Bump lang/gcc* which are known to install libraries with exactly the same
name so the library loaded at runtime depends on the order of the search
directories.

PR:		228046
Approved by:	portmgr (antoine)

 

19:06 bapt 

Remove LIBDIR from build env variable

This is leaking LIBDIR information (which is defined in base share/mk/*) to
the build environement with a value which is not really suitable for ports
(/usr/lib) which may have an impact on some build system forcing the maintainer
to override the value.

Revealed during the update of liblz4

PR:		228059
Submitted by:	bapt
Exp-run by:	antoine

 

15:18 jhb 

Add 32-bit mips support to base/binutils and base/gcc.

- When cross-building packages, set ARCH to the target arch instead of
  the arch of the build host.  This fixes bsd.ssp.mk on MIPS which was
  trying to enable SSP on MIPS cross-built packages because the host
  ARCH was amd64.  A new HOST_ARCH variable is added to set the
  --build triple for configure scripts, but I believe most other uses of
  ARCH in ports are really about the target, not the build host so this
  is the more correct general direction.
- Some updates to base/binutils and base/gcc to use ARCH as the target
  architecture.
- Drop the extra arguments to GCC to set include and library paths and
  only set --sysroot.
- Move the --sysroot flags into CC, CXX, CPP (which is now set to XCPP)
  and LD instead of passing it in CFLAGS, etc.  The base/gcc build uses
  ends up using the CFLAGS when building native binaries for the build
  host which fails when tripping over the --sysroot.  I think this might
  have accidentally worked before because the powerpc64 headers in
  /usr/include/machine were "close enough" to the amd64 headers, but with
  32-bit MIPS this failed hard.
- Add the GCC MIPS patch from devel/powerpc64-gcc to base/gcc to add
  MIPS support to base/gcc.
- Add a MIPS plist for base/binutils.
- Set helper variables for the base/gcc plist to tag architecture-specific
  headers (e.g. for intrinsincs) and use these to tag powerpc and MIPS
  specific headers.
- Drop the include-fixed headers from base/gcc.
- Strip /usr/local/include from the default list of include paths for
  base/gcc.
- Use libc++'s include path for C++ for base/gcc.

Reviewed by:	bapt
Approved by:	portmgr (bapt)
Differential Revision:	https://reviews.freebsd.org/D15267

 

22:29 jbeich 

Drop FreeBSD 10.3 support

Reviewed by:	yuri (SoPlex), sunpoet (nghttp2), cpm (chromium), brooks (llvm*)
Approved by:	portmgr (rene)
Differential Revision:	https://reviews.freebsd.org/D15238

 

09:16 mat 

Add a warning about setting DISTNAME and USE_GITHUB=yes

Sponsored by:	Absolight

 

15:00 mat 

Note that 10.3 is not supported any more.

Sponsored by:	Absolight

 

04:52 acm 

- Migrate Mk/bsd.fpc.mk to Mk/Uses/fpc.mk
- Convert all fpc-based ports to USES=fpc

PR:             227210
Reviewed by:    portmgr
Approved by:    portmgr
Exp-run by:     antoine
Differential Revision:  https://reviews.freebsd.org/D14617

 

15:02 emaste 

Use BINARY_ALIAS to make LLD_UNSAFE more widely applicable

Some ports do not honour $LD or -fuse-ld=bfd in $CFLAGS, but do invoke
ld via $PATH.   Automatically set BINARY_ALIAS+=ld=${LD} when LLD_UNSAFE
is active to use ld.bfd for these ports.

Approved by:	portmgr (antoine)
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D14876

 

14:51 bapt 

Remove last occurence of WANT_GNOME which was removed
monthes ago

 

21:39 bdrewery 

Fix some recursive targets using the wrong FLAVOR.

Reported by:	Andrzej Tobola <ato@iem.pw.edu.pl>, koobs
Approved by:	portmgr (implicit)

 

02:36 bdrewery 

Define CONFIG_SITE even without GNU_CONFIGURE as some ports still benefit from
it.

Approved by:	portmgr (implicit)

 

19:04 bdrewery 

FLAVORS: Reorder so the default is first.

It is documented that the first FLAVOR is the default.  Due to some use
of DEFAULT_VERSIONS and USES, the default FLAVOR may be determined
dynamically.  Poudriere in particular expects the default to be first
and does the wrong thing for emacs ports currently [1].  This resolves
that and avoids other tools making the same mistake.

PR:		225659 comment #14
Approved by:	portmgr (implicit)

 

18:19 bdrewery 

FLAVORS: Fix several 'make *recursive' targets not passing along FLAVOR
properly.

PR:		225659 comment #15
Approved by:	portmgr (implicit)

 

14:23 brnrd 

Mk/Uses/apache.mk: Migrate Mk/bsd.apache.mk to Uses

 - Chase required changes in framework (bsd.sanity.mk, bsd.port.mk)
 - Chase required changes in ports (version checks)
 - Chase required changes in PHP ports (include bsd.apache.mk)
 - exp-run by antoine, brnrd, joneum

PR:             223691 (exp-run)
Reviewed by:    joneum (hat apache), mat (portmgr), antoine (portmgr)
Approved by:    joneum (hat apache)
Approved by:	portmgr
With hat:       apache

 

06:50 ultima 

* Add USE_GITLAB for fetching from www.gitlab.com and GitLab deployed sites.

Reviewed by:	mat
Approved by:	portmgr (mat)
Relnotes:	yes
Differential Revision:	https://reviews.freebsd.org/D12162

 

18:38 bdrewery 

ports_env: Store list of variables to export in PORTS_ENV_VARS in mk files.

This will avoid renamed/removed variables being orphaned, and allows for
exporting variables in ports_env that are not wanted to be exported in
sub-makes via _EXPORTED_VARS.

Approved by:	portmgr (implicit)

 

22:58 bdrewery 

Fix RANDOMIZE_MASTER_SITES.

- /usr/games/random moved to /usr/bin/random in 11.0+
- Need to explicitly add in the pipe '|'

Approved by:	portmgr (implicit)

 

22:45 bdrewery 

Reduce fstat(2) calls for SCRIPTDIR/* scripts.

There's only about 10 ports that actually use this, so rather than
spamming a dozen fstat(2) calls for every port during INDEX reduce
it to 1 for now.

Also avoid the fstat(2) if the target already exists.

Approved by:	portmgr (implicit)

 

05:52 bdrewery 

Fix editors/vim-tiny hanging on reading stdin during generate-plist.

test -f "" is true so we need to only test if $PLIST is not empty.

Approved by:	portmgr (implicit)

 

14:32 swills 

Fix cross build of base/ ports

This is a follow up to r461057 and fixes base/binutils and base/gcc in my
testing.

PR:		224217
Submitted by:	nwhitehorn (partially, I made additional changes)
Reviewed by:	bapt

 

14:26 swills 

Changes from BZ PR 224217 plus minor changes to fix base/gcc fetch

 

18:03 jrm 

Flavorize and modernize Emacs ports

- Convert USE_EMACS to USES=emacs
- Remove editors/emacs-nox11 (refer to nox flavors of editors/emacs and
  editors/emacs-devel)
- Permit default Emacs flavor to be specified in make.conf
- Rename japanese/migemo-emacs23 to japanese/migemo-emacs
- Update and simplify audio/emms and fix build on FreeBSD 10 [1]
- Update databases/bbdd and fix build on FreeBSD 10 [1]
- Update editors/emacs-devel
- Ensure Makefile shell commands that change directory are executed in a
  subshell
- Silence some portlint warnings

[1] By not depending on base texinfo

PR:		225404
Reviewed by:	antoine
Approved by:	portmgr (mat) ashish (maintainer)
Differential Revision:	https://reviews.freebsd.org/D13506

 

08:31 mat 

Don't run create-manifest as root.

PR:		224992
Submitted by:	tobik
Reported by:	yuri
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D13798

 

08:25 mat 

Extract desktop-categories, check-desktop-entries, and install-desktop-entries
into scripts.

PR:		225301
Exp-run by:	antoine
Reviewed by:	jilles, kevans
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D11304

 

09:12 mat 

Add support to passing directories to EXTRA_PATCHES.

Instead of:

  EXTRA_PATCHES=	${PATCHDIR}/feat-foo-patch-file.c \
			${PATCHDIR}/feat-foo-patch-file.h \
			${PATCHDIR}/feat-foo-patch-file2.c

Move those files to ${PATCHDIR}/feat-foo/, name them patch-*, and set:

  EXTRA_PATCHES=	${PATCHDIR}/feat-foo

Approved by:	bdrewery
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D10855

 

18:54 bdrewery 

Allow passing -DDEPENDS_SHOW_FLAVOR to list flavors for dependency lists.

Submitted by:	se (based on D13535)
With hat:	portmgr

 

16:35 tz 

add new stage-qa target: gemfiledeps

This checks whether rubygem based ports have all of their dependencies
in Gemfile(s) satisfied by what's currently installed. Sample output:

====> Running Q/A tests (stage-qa)
Warning: Dependencies defined in
/usr/ports/www/gitlab/work/stage/usr/local/www/gitlab/Gemfile are not satisfied

These ports could (!) be broken at runtime. Be aware: some projects
defines multiple Gemfiles and not all are used at runtime. For example
www/gitlab has two Gemfiles, but only one is used for testing and warnings
about it can be ignored.

Approved by: portmgr (mat), lifanov
Differential Revision: https://reviews.freebsd.org/D11865

 

10:01 tijl 

Retire USE_AUTOTOOLS and bsd.autotools.mk.

PR:		225170
Approved by:	portmgr (antoine)

 

12:59 mat 

Add another solution to the WRKSRC+USE_GITHUB warning.

Sponsored by:	Absolight

 

07:40 mat 

Remove support for variables that have been deprecated for a while.

variables                  deprecation       revision
WITHOUT_NLS                2013-12-13        r336337
WITH_/WITHOUT_             2014-02-24        r345870
NOPORT(DOC|EXAMPLE)S       2014-04-19        r351587
WITH_BDB_VER               2016-05-02        r414444
OVERRIDE_LINUX_BASE_PORT   2016-09-05        r421387
WITH_OPENSSL_(BASE|PORT)   2016-06-16        r416965

While there, add an ERROR variable that works like DEV_ERROR, but for
user facing errors, and move NOPORTDOCS,
NOPORTEXAMPLES and WITHOUT_NLS to it.

Cleanup bsd.sanity.mk a bit.

Fix fallout.

PR:		224613
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D13490

 

00:24 bdrewery 

Fix flavor helpers when only bsd.port.pre.mk is not used and FLAVOR is not set.

The helpers were being evaluated before the default FLAVOR was set. The
helpers worked fine if the FLAVOR was specified by the user but not if
it was left to the default value. Resolve this by moving the helpers
right after the default FLAVOR is set.

PR:		224879
exp-run by:	antoine
Approved by:	portmgr (implicit)
MFH:		2018Q1
Differential Revision:	https://reviews.freebsd.org/D13756

 

20:17 bdrewery 

Disallow forced FLAVOR as make argument.

This otherwise prevents properly setting FLAVOR to the default internally
since it is in a separate namespace in bmake that is read-only.

Approved by:	portmgr (implicit)
MFH:		2018Q1

 

20:06 bdrewery 

Follow-up r458048: Properly trim FLAVOR from .MAKEOVERRIDES.

The code I removed was wrong but it still achieved the proper effect of
removing FLAVOR from .MAKEOVERRIDES.  This is still needed and now is
done properly without truncating away all of the other valuable variables.

Pointyhat to:	bdrewery
Approved by:	portmgr (implicit)
MFH:		2018Q1

 

19:37 bdrewery 

Pass FLAVOR in enviroment to avoid forcing an empty value in some cases.

Approved by:	portmgr (implicit)
MFH:		2018Q1

 

19:18 bdrewery 

Stop truncating .MAKEOVERRIDES after the FLAVORS work.

There is no such variable as ${MAKEOVERRIDES}, only ${.MAKEOVERRIDES}, so this
code was simply truncating .MAKEOVERRIDES entirely which could cause performance
and other odd issues with OSREL and make recursion.

We don't want to leak FLAVOR to child sub-makes but that can be fixed later;
this code was not doing what it intended.

Approved by:	portmgr (implicit)
MFH:		2018Q1

 

19:07 bdrewery 

Fix package-depends-list for FLAVORS.

Reported by:	dinoex
Approved by:	portmgr (implicit)
MFH:		2018Q1

 

20:16 jbeich 

bsd.port.mk: don't create a new variable just to check LLD

PR:		224760
Approved by:	portmgr (antoine)

 

01:51 bdrewery 

Fix 'make -j'.

- Pass MAKEFLAGS down into do-depends properly.
- Remove redundant dependencies, run-depends and lib-depends, from
  targets that already depend on earlier targets that depend on
  the needed targets.

Reported by:	emaste
With hat:	portmgr

 

11:55 mat 

Add a warning to try and prevent people from mis-using USE_GITHUB.

Sponsored by:	Absolight

 

12:11 mat 

Fix build-depends-list and run-depends-list.

Sponsored by:	Absolight

 

11:54 mat 

11.0 is no longer supported.

Sponsored by:	Absolight

 

15:33 mat 

Add various FLAVOR related helpers.

  To help with flavored ports, helpers are available.  In these, replace <*>
  with the flavor name.

  *_PKGNAMEPREFIX *_PKGNAMESUFFIX *_PLIST *_DESCR will overwrite the variable.

  *_CONFLICTS *_CONFLICTS_BUILD *_CONFLICTS_INSTALL *_PKG_DEPENDS
  *_EXTRACT_DEPENDS *_PATCH_DEPENDS *_FETCH_DEPENDS *_BUILD_DEPENDS
  *_LIB_DEPENDS *_RUN_DEPENDS *_TEST_DEPENDS will append to the variable.

Reviewed by:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D12483

 

15:33 mat 

Generic FLAVORS work.

- Enable FLAVORS.
- Make make describe flavors aware.
- Add a qa check for unique package names amongst flavors.
- Make MOVEDlint understand flavors.
- Add a bit of sanity check to make sure FLAVORS stay lowercase.
- Various fixes.

Reviewed by:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D12577

 

15:16 mat 

Add a check for options names.

They must be all uppercase, so that they do not conflict with flavors
that are lowercase.

Reviewed by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D12810

 

17:07 bdrewery 

FLAVORS: Fix 'make clean' not respecting passed in FLAVOR.

With hat:	portmgr

 

15:30 jilles 

Make COPYTREE_* work with POSIX-compliant sh -c

The COPYTREE_BIN and COPYTREE_SHARE macros use constructs like

sh -c 'command' -- arg0 arg1

and assume that $0 will expand to arg0 and $1 will expand to arg1.

Our current sh implements it that way. However, POSIX specifies that $0 will
expand to -- and $1 will expand to arg0, since the command string is an
operand and not an option-argument. Bug #220587 requests making sh
POSIX-compliant in this regard.

If the argument after the command string does not start with '-', the
current sh behaves as required by POSIX. Therefore, adjust the macros so
this is always the case.

PR:		222870
Approved by:	portmgr (antoine)

 

14:05 madpilot 

Retire WITHOUT_DEBUG flag.

The flag has partial support across the tree, and the same effect
can be obtained by using ".undef WITH_DEBUG".

Reviewed by:		mat, rene
Approved by:		portmgr (rene)
Differential Revision:	https://reviews.freebsd.org/D12548

 

19:03 bapt 

Introduce the new BINARY_ALIAS variable

When defined it will create symlinks of some given binaries in a directory which
will be prepended to the PATH.

The syntax is the following:
BINARY_ALIAS=   target1=source1  target2=source2

For example to have a "swig" binary in the path which will be pointing at
swig3.0 and a "sed" pointing at GNU sed: gsed

BINARY_ALIAS=  swig=swig3.0 sed=gsed

Reviewed by:	swills, adamw, mat
Approved by:	swills (portmgr)
Differential Revision:	https://reviews.freebsd.org/D12603

 

23:37 bdrewery 

Disable FLAVORS support for now until we have real FLAVORS-using ports.

Having this enabled breaks Poudriere's ability to build py2 and py3 ports
together which FLAVORS aims to resolve.  Once we have actual python
FLAVORS support ready to commit we can then enable this feature again.

With hat:	portmgr

 

20:28 mat 

Fix post-clean.

Submitted by:	antoine
Sponsored by:	Absolight

 

14:14 mat 

Implement basic flavors.

**Do not start migrating any ports, a hook will prevent it**

This has been a long awaiting feature, most of the work has been done by
bapt, bdrewery and antoine, I am just the one actually doing the commit.

All this informations, and more to come are in the first link to our wiki
in the bottom block. A roadmap is in the second link.

To define a different flavors in a port, before any include, set:

FLAVORS=  flavor1 flavor2 [...]

The first flavor in the list will be the default.

You can then check for flavors after includ'ing bsd.port.options.mk with:

.if ${FLAVOR} == flavor2
[some stuff]
.endif

To build flavor2, simply run:

make FLAVOR=flavor2

To depend on a specific flavor, write @<flavor> at the end of the depend
string, like:

RUN_DEPENDS=	something:origin@foo

Submitted by:	bapt, bdrewery, antoine
Reviewed by:	portmgr
More infos:	https://wiki.freebsd.org/Ports/FlavorsMigration
Todo List:	https://wiki.freebsd.org/Ports/FlavorsAndSubPackages
With hat:	portmgr
Differential Revision: https://reviews.freebsd.org/D10327

 

14:20 jrm 

Ensure .CURDIR contains an absolute path without a trailing slash.

Failed builds can occur when PORTSDIR is a symbolic link, or with

make -C /usr/ports/category/port/

PR:		221296
Reported by:	yasu@utahime.org, rum1cro@yandex.ru
Reviewed by:	bdrewery, sjg
Approved by:	portmgr (bdrewery)
Differential Revision:	https://reviews.freebsd.org/D11934

 

18:55 emaste 

Add LLD_UNSAFE to force use of ld.bfd when ld is lld

By default the compiler will find /usr/bin/ld for the linker.  If a port
sets LLD_UNSAFE and /usr/bin/ld is ld.lld, then add -fuse-ld=bfd to
force the use of the binutils BFD linker (from the base system, if
available, or by setting USE_BINUTILS).

This change is based on an earlier, similar patch from bapt, with the
addition of the -fuse-ld flag.

PR:		214864
Reviewed by:	bapt
Approved by:	portmgr (bapt)
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D12064

 

19:09 lifanov 

add new stage-qa target: gemdeps

This checks whether rubygem ports have all of their dependencies
in gemspec satisfied by what's currently installed. Sample output:

====> Running Q/A tests (stage-qa)
Error: RubyGem dependency archive-tar-minitar = 0.5.2 is not satisfied.
*** Error code 1

Stop.
make: stopped in
/usr/home/lifanov/src/svn/freebsd/ports/head/archivers/rubygem-fpm

These ports would be broken at runtime.

Big thanks to:
  swills - discussion
  mat - reviews
  antoine - exp runs
  sunpoet - fixing several dozens of ports :)

PR:		220605
Reviewed by:	mat, sunpoet
Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D11841

 

18:09 dbn 

qa: add check for NO_ARCH

If NO_ARCH is set then check that no FreeBSD elf(5) files are in $STAGEDIR.
If an elf(5) file is bundles as part of the package, but is not meant to be
run directly (i.e. the elf(5) file is a payload, and not compiled) then
those files can be added to NO_ARCH_IGNORE to avoid the check from failing,

Changes to ports:
 - Ports that have NO_ARCH set, but actually compile files have had NO_ARCH
   removed.
 - Ports that have elf(5) payloads have had those files added to
   NO_ARCH_IGNORE.
 - R-cran ports that do not set USES=cran:compiles have NO_ARCH set,

PR:		218976
Reviewed by:	antoine, mat
Approved by:	portmgr

 

20:18 tcberner 

Add note, that WRKDIRPREFIX must not end in '/'.

PR:		199297
Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D11032

 

16:38 mat 

Add a fixup-lib-pkgconfig target to move files in lib/pkgconfig into
libdata/pkgconfig.

Fix ports that where installing the file in the wrong place.

PR:		218067
Submitted by:	mat
Exp-run by:	antoine
Reviewed by:	rene, antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D10129

 

19:13 bapt 

Fix issues with PACKAGES is set by a user with a ':' in the path

Reported by:	dim
Approved by:	portmgr (adamw)
Differential Revision:	https://reviews.freebsd.org/D10847

 

18:46 rezny 

Consolidate the Mesa ports, update to 17.0.4, and add Wayland option

* libGL, libEGL, libglesv2, libglapi, and gbm have been moved into mesa-libs,
  graphics/dri has been renamed to mesa-dri, and USE_GL has been adjusted
* mesa-libs has a new WAYLAND option that enables platform support in libEGL
* mesa-dri now depends on graphics/s2tc for compressed texture support [1]
* re-remove obsolete dependency on makedepends [2]
* correct sed fix backported from 17.1 [3]

PR:		218799 (exp-run), 212762 [1], 218552 [2], 218562 [3]
Submitted by:	dbn [1], jbeich [2,3]
Reported by:	afiskon@devzen.ru [1]
Reviewed by:	kwm, johalun0@gmail.com
Approved by:	portmgr, swills (mentor)
Differential Revision:  https://reviews.freebsd.org/D10448

 

19:04 ak 

- Remove checks for .PARSEDIR and vestiges of pmake support

PR:	218832
Approved by:	portmgr (antoine)

 

19:36 antoine 

Use POSIX conformant expressions with grep(1)

PR:		218691
Submitted by:	Kyle Evans
With hat:	portmgr

 

18:32 bapt 

Refactor do-package aka subpackages step 2

Now each files generated are explicit targets depending on the files
This would allow to simply loop over a list of packages for subpackages to
create them.

Remove the code for transition from pkg_install to pkg packages

The latest symlink is now a specific target only defined when needed

Reviewed by:	swills
Approved by:	portmgr (swills)
Differential Revision:	https://reviews.freebsd.org/D10323

 

20:20 mat 

Remove something that I did not even know I had.

Sponsored by:	Absolight

 

20:16 mat 

Remove @comment $FreeBSD$ from plists.

Whatever you do, things always get to creep back in the ports tree.

Sponsored by:	Absolight

 

15:54 mat 

Mmm, some parts of the ports tree are doing strange things.

Pointy hat:	mat
Sponsored by:	Absolight

 

15:21 mat 

Make defining both PORTVERSION and DISTVERSION a DEV_ERROR.

There are two cases:

- The upstream versionning is compatible with our versionning, or using
  DISTVERSION's magic leads to a compatible PORTVERSION, use
  DISTVERSION.  If it is possible to use DISTVERSIONPREFIX and
  DISTVERSIONSUFFIX to make it compatible, use them.
- The upstream versionning is not compatible with our versionning, and
  DISTVERSION's magic does not lead to a correct PORTVERSION, then set
  PORTVERSION to the equivalent of our versionning, and set DISTNAME.
  It is possible to use a third variable where you store upstream's
  version and use it to compute PORTVERSION and/or DISTNAME, like the
  dns/bind9* ports do.

Sponsored by:	Absolight

 

14:22 amdmi3 

Use dedicated macro FMT_80 instead of ${FMT} 75 79 magical constants

Suggested by:	mat
Approved by:	portmgr (mat)
Differential Revision:	D10342

 

14:22 amdmi3 

- Make warning, dev warning, and dev error display consistent and more readable:
  - Split all messages with a newline
  - Run all messages through fmt to fit them into 80 columns

Approved by:	portmgr (mat)
Differential Revision:	D9216

 

15:35 bapt 

Stop creating stubs targets calling /usr/bin/true

It is not needed at all.

While here remove:
- the stub pre-everything:: declaration, let the framework define it if needed
- remove the stub describe target with NO_DESCRIBE is set. It is useless
- remove options-message it was only used by gnome and dropped a long time ago
- remove pre-distclean it was never used

Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D10326

 

10:58 bapt 

Readd still called by poudriere

Approved by:	portmgr (implicit)

 

10:52 bapt 

Gargabe collect install-mtree not used since pkg(8)

Approved by:	portmgr (mat)

 

10:26 bapt 

Garbage collect TMPPLIST_SORT which is not needed anymore since pkg(8)

Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D10324

 

18:17 bapt 

Use native make(1) mechanism to create the package repository directory

In order to have subpackages we need in the end do-package to depend on
a target per package that would be created per subpackages

For this we need to decouple the content of do-package so it becomes
a target that only creates the packages.

As a first step use natural make(1) mechanism for a target: if checks first
for the existence of a file and it it does not exists that execute the content
of the target, in that case it creates the PKGREPOSITORY
Bonus it simplifies a bit the code.

While here to avoid testing multiple time for the PACKAGES directory set a
variable after we tested it the first time

PR:		216877
Approved by:	portmgr (mat)
Reviewed by:	mat
exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D9466

 

15:17 mat 

Remove ALWAYS_KEEP_DISTFILES, it cannot find code where it was ever
used.

Sponsored by:	Absolight

 

13:11 mat 

Do not overwrite WRKSRC when USE_GITHUB=nodefault.

Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D10091

 

13:10 mat 

COPYTREE_SHARE should also be using _SHAREMODE and not SHAREMODE.

SHAREMODE defaults to 444, and gives us endless grief because one
cannot modify a file that is not writable.
So use _SHAREMODE that is 644, so that we can avoid all those CHMOD +w
in so many Makefiles.

Exp-run:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D7623

 

14:59 mat 

Remove the USE_OPENSSL compatibility shims.

Sponsored by:	Absolight

 

17:47 bdrewery 

GNU_CONFIGURE: Fix ax_am_jobserver usage to respect MAKE_JOBS_NUMBER.

PR:		217670 [exp-run]
With hat:	portmgr

 

17:44 mat 

USE_RCORDER has been deprecated and unused for a long time.

Sponsored by:	Absolight

 

13:25 tijl 

Enable https certificate verification during make makesum.

Discussion:	https://lists.freebsd.org/pipermail/freebsd-ports/2017-March/107694.html
Approved by:	portmgr (adamw)

 

16:28 mat 

Fix the error message when no option in a _SINGLE is used.

PR:		217273
Reported by:	Andreas Sommer
Sponsored by:	Absolight

 

21:20 tijl 

- Remove inclusion of bsd.default-versions.mk from ftp/curl/Makefile so
  bsd.default-versions.mk can rely on ARCH being defined.
- In bsd.port.mk move inclusion of bsd.default-versions.mk from the
  pre-makefile section to the options section so the variables can be used
  earlier.  Also put the bit of code sitting between the options section and
  the pre-makefile section into the options section.
- Remove last few cases where ports set WITH_OPENSSL_PORT.  This variable is
  handled in bsd.default-versions.mk and some ports were setting it after
  including bsd.port.options.mk.  After FreeBSD 9 EoL all but a few ports,
  and then only when setting non-default options, work without setting that
  variable.

PR:		215996
Exp-run by:	antoine
Approved by:	portmgr (antoine)

 

23:42 bapt 

Add wayland as a valid category (for virtual category usage for now)

Approved by:	portmgr (implicit)

 

14:07 mat 

Improve the error message when conflicting OPTIONS_RADIO or
OPTIONS_SINGLE are defined.

PR:		216150
Submitted by:	stb lassitu de
Sponsored by:	Absolight

 

12:42 tijl 

Wrap .export in .ifdef .PARSEDIR to support fmake for now.  FreeBSD 9 users
will still hit the error/warning that was added in r431746, but that's
clearer than the obscure error they see now.

Approved by:	portmgr (antoine)

 

13:20 tijl 

The output of tools like awk, date, sort, tr,... depends on the current
locale set by the user.  Add LANG=C and LC_ALL=C at the beginning of
bsd.port.mk and export them so all commands are executed with the C locale.
LC_ALL=C overrides all other LC_* variables.  LANG is used by setlocale(3)
as default value for LC_* variables, so normally it isn't used when LC_ALL
is set, but there's code out there that looks at LANG directly so it's safer
to set it as well.  The only commands not captured by this are !=
assignments before any inclusion of bsd.port.*mk.

Introduce USE_LOCALE=<locale> that adds LANG=<locale> and LC_ALL=<locale> to
CONFIGURE_ENV and MAKE_ENV so upstream build systems can be executed with a
different locale (e.g. USE_LOCALE=en_US.UTF-8).

PR:		215882
Exp-run by:	antoine
Approved by:	portmgr (antoine)

 

15:49 amdmi3 

- Refuse (overridable) to build ports on unsupported system version

Unfortunately, it's not uncommon for FreeBSD users to not update
their systems timely and thus end up using unsupported FreeBSD
release. These users continue to update ports tree as usual and
expect it to work, either unaware of the release EoL, or not clearly
understanding the consequences, which results in unexpected build
failures, bogus bug reports, attempts to bring back removed legacy
support bits and general discontent.

This change introduces system version check which makes ports refuse
to build anything on unsupported system. This makes users aware of
EoL of their system and makes it clear that no port is guaranteed to
build.

The error message tells how to override the check (by defining
ALLOW_UNSUPPORTED_SYSTEM, in which case it's turned into a simple
warning), additionally stressing that this configurartion is not
supported.

Currently outdated are OSVERSION < 1003000 (pre 10.3-RELEASE) and
1100000 <= OSVERSION < 1100122 (from 11-CURRENT'2013 to 11.0-PRERELEASE)

I expect these to be kept up to date with base system lifetimes,
be updated BEFORE removing any support for outdated release from
the tree and also serve as a reference of which OSVERSION checks
may be removed.

Approved by:	portmgr (swills, mat)
Differential Revision:	D9210

 

16:47 mat 

Implement EXTRA_PATCH_TREE.

PR:		215726
Reported by:	julian

 

16:47 mat 

Extract do-patch into a separate script.

PR:		215761
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D9029

 

07:24 rene 

Remove support for FreeBSD < 10.3 from Mk/*

This does not yet convert the files to bmake.

Reviewed by:	mat
Differential Revision:	https://reviews.freebsd.org/D9016

 

12:46 bapt 

Revert r429298 it has some unexpected side effects which I do not have time to
fix yet

Approved by:	portmgr (implicit)

 

00:30 bapt 

Make the ports infrastructure accept at least 3 level ports

Approved by:	portmgr (rene
Differential Revision:	https://reviews.freebsd.org/D8889

 

16:39 mat 

Add a warning about setting both PORTVERSION and DISTVERSION.

Sponsored by:	Absolight

 

21:29 swills 

Rename PKG_CMD to PKG_REGISTER

Submitted by:	bapt
Differential Revision:	https://reviews.freebsd.org/D8677

 

12:14 mat 

Optimize COPYTREE_* macros.

The main problem slowing down those macros was that it was ending up
calling chmod(1) once for each file and directory.
It was doing this because it was running find(1) in the source tree and
needed to chmod in the target tree, so it had to append the full path to
the chmod(1) calls, which made it impossible to use -exec +.

Rewrite the -exec calls to call sh and cd into it before running
chmod(1) and do so on as many files as we can using the -exec + construct.

While there, optimize a bit more after figuring out that it is possible
to only use one find(1) to run two -exec for different options.

Also switch to using the more powerfull modern regular expressions
instead of the usual basic regular expressions by using find -E.  This
will allow the use of | which as no basic regular expressions equivalent
(as in, for example, "*.(html|txt)") as well as the + and ? keywords,
and back references.

About the speed gain, I did a few tests, using time's builtin from csh (table
with all the data available in the review), comparing the home baked versions
of COPYTREE_SHARE found in ports, it boils down to:

|  version   |   www/sit (~2k)  | www/mathjax (~30k) |
+------------+------------------+--------------------+
| home baked | 0.032u 0.104s    | 0.946u 7.446s      |
| current    | 0.281u 0.649s    | 5.446u 18.626s     |
| new        | 0.024u 0.081s    | 0.770u 7.012s      |

PR:		213614
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D8283

 

22:52 bapt 

Add an annotation to packages that are marked as deprecated and the one having
an expiration date

Approved by:	portmgr (bdrewery)