12:56 mi 

Upgrade from 2.4.1 to 2.5.0. The change-log is here:

	http://download.sourceforge.net/project/scons/scons/2.5.0/CHANGES.txt

The compatibility wrapper for subprocess, in particular, has been removed as
unnecessary for Python above 2.7.

Notified by:	portscout

 

12:27 marino 

devel/scons: Upgrade 2.3.0 => 2.4.1 and reset maintainer

While the maintainer has mostly been responsive since July 2010, his
actions were limited to approving PRs (mainly to upgrade scons because
the maintainer wasn't doing it).  Not a single update originated from
the maintainer himself.  Since being a gatekeeper isn't the purpose of
a maintainer, I'm going to reset the port on this timeout so that future
upgrades can get applied faster than they have been.

PR:		206343
Submitted by:	myself
Approved by:	maintainer timeout

 

14:57 pgollucci 

Python's subprocess module has a race condition: Popen() constructor has a call
to global "_cleanup()" function on whenever a Popen object gets created, and
that call causes a check for all pending Popen objects whether their subprocess
has exited - i.e. the poll() method is called for every active Popen object.

See http://bugs.python.org/issue1731717 for addition details

SCon's compat/_scons_subprocess.py module is just a copy of a more recent
stock Python subprocess.py modified so it will work with older Python
versions.

The attached patch will add locks around calls to Popen and change
the compat module in a way that the subprocess module is always used, no matter
if Python already ships one.

The rationale behind this decision is that there are many Python versions in the
wild with different Popen() race condition problems.

PR:             ports/128845
Submitted by:   Steven Kreuzer <skreuzer@exit2shell.com>
Approved by:  araujo (mentor, implicit)