05:41 Alexey Dokuchaev (danfe) 

games/gtkradiant: try to fix the port's build against Clang 16

Ancient `register' keyword is gone with C++17, drop it from various
places.  Also, ISO C99 and later no longer tolerate implicit function
declarations, but the code in question is too convoluted and fragile
to fix properly, so just disable the warning for the time being.

While here, do not hardcode -O2 for release builds (system-provided
compilation flags being correctly upheld) and spell -Wextra correctly
(quoting the GCC docs*, this option used to be called -W; the older
name is still supported, but the newer name is more descriptive).

Reported by:	pkg-fallout

*) https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wextra

    b5772e3

09:54 danfe 

Convert to Python-threeish SCons.

 

18:32 sunpoet 

Fix build with scons 3.1.2

 

20:15 danfe 

Unbreak against Clang 10 and Python 3.

Reported by:	pkg-fallout

 

16:29 danfe 

- Fix the build against modern libpng (do not try to access private data)
- Clang insists that reference cannot be bound to dereferenced null pointer
  in well-defined C++ code (that is correct) and evaluates comparisons like
  &foo == 0 to false, which breaks GtkRadiant; "fix" this with a dirty hack
  by casting those "bad" references to a local volatile int variable
- Remove no longer required and no-op -lpthread vs. -pthread patch hunk
- Report operating system and correct compiler version in the About dialog
- When fixing annoying "GtkSpinButton: setting an adjustment with non-zero
  page size is deprecated" warnings, replace find(1) with grep(1) to narrow
  down initial search results and, subsequently, sed(1) furiousness
- Omit port revision bump as the port was BROKEN for quite some time

 

07:05 danfe 

- Unbreak linking with our new ld(1) by explicitly listing -lgobject-2.0 on
  the LINKFLAGS, otherwise we get this:

    /usr/bin/ld: invalid DSO for symbol `g_signal_connect_data' definition
    /usr/local/lib/libgobject-2.0.so.0: could not read symbols: Bad value
    c++: error: linker command failed with exit code 1 (...)
    scons: *** [build/release/radiant.cpu] Error 1

- Replace PTHREAD_LIBS variable with '-pthread' and tidy up some superfluous
  LOCALBASE-related assignments while here (leftovers from X11BASE era)

 

17:56 miwi 

- Remove unneeded dependency from gtk12/gtk20 [1]
- Remove USE_XLIB/USE_X_PREFIX/USE_XPM in favor of USE_XORG
- Remove X11BASE support in favor of LOCALBASE or PREFIX
- Use USE_LDCONFIG instead of INSTALLS_SHLIB
- Remove unneeded USE_GCC 3.4+

Thanks to all Helpers:
        Dmitry Marakasov, Chess Griffin, beech@, dinoex, rafan, gahr,
        ehaupt, nox, itetcu, flz, pav

PR:             116263
Tested on:      pointyhat
Approved by:    portmgr (pav)

01:51 alepulver 

- Fix building on non-i386 architectures.
- Avoid hacking the SConstruct file, pass information through the environment.

18:35 alepulver 

GtkRadiant is a level design program developed by id Software and Loki
Software. It is used to create maps for a number of computer games.

GtkRadiant originated as Q3Radiant, the Quake III Arena level design tool,
which was a Windows-only application. Two major things are different in
GtkRadiant: it is based on the GTK+ toolkit, so it also works in Linux and Mac
OS X, and it's also game engine-independent, with functionality for new games
added as game packs.

GtkRadiant is an Open Source application. Source code is publicly available
from id Software's Subversion repository and new additions to the code are
covered under open source licenses. The core Q3Radiant code, however, was
originally under id Software's proprietary license. The license for both the
editor and toolset (notably Q3Map2, the BSP compiler) was changed in February
2006, and publicly released under the GPL on February 17.

WWW: http://www.qeradiant.com/

PR:             ports/93668
Submitted by:   Alejandro Pulver <alejandro@varnet.biz>
Approved by:    garga (mentor)