05:04 lwhsu 

lang/python35: Update to 3.5.10

ChangeLog: https://docs.python.org/3.5/whatsnew/changelog.html#python-3-5-10

PR:		249187
MFH:		2020Q3

 

18:11 zeising 

Chanse update of devel/libffi

Chase the devel/libffi update
Bump portrevision of all dependent ports to chace shard library version bump
in libffi.
Update LIB_DEPENDS lines where needed to not require a specific version of
libffi.so.

PR:		247028 (for tracking)

 

14:21 dbaio 

lang/python35: Fix security issues

The patches for CVE-2019-18348 and CVE-2020-8492 are in the 3.5 branch
and will be present in a next release.

PR:		246984
Approved by:	python (with hat)
MFH:		2020Q2
Security:	ca595a25-91d8-11ea-b470-080027846a02 (CVE-2019-18348)
Security:	a27b0bb6-84fc-11ea-b5b4-641c67a117d8 (CVE-2020-8492)

 

17:03 antoine 

python 3.5 will reach End-of-life on 2020-09-13

 

22:19 tcberner 

Fix makefile ordering.

Reported by:	mat

 

19:11 tcberner 

Fix namespace pollution in python3.5 and python3.6 (upstreamed fix)

The standard math library (libm) may follow IEEE-754 recommendation to
include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x).
And this triggers a name clash, found by FreeBSD developer
Steve Kargl, who worked on putting sinpi into libm used on FreeBSD
(it has to be named "sinpi", not "sinPi", cf. e.g.
https://en.cppreference.com/w/c/experimental/fpext4).

- python2.7 and > 3.6 are already fixed

PR:		232792
Submitted by:	Steve Kargl <sgk@troutmask.apl.washington.edu>, Dima Pasechnik
<dimpase+freebsd@gmail.com>
Approved by:	python (maintainer timeout)
Obtained
from:	https://github.com/python/cpython/commit/b545ba0a508a5980ab147ed2641a42be3b31a2db

 

10:55 koobs 

lang/python{27,35,36,37,38}: Add closefrom(2) support

A single close(fd) syscall is cheap, but when MAXFDS (maximum file
descriptor number) is high, the loop calling close(fd) on each file
descriptor can take several milliseconds.

The default value of subprocess.Popen "close_fds" parameter changed to True
in Python 3. Compared to Python 2, close_fds=True can make Popen 10x
slower: see bpo-37790 [1]

The present workaround on FreeBSD to improve performance is to load and
mount the fdescfs kernel module, but this is not enabled by default.

This change adds minimum viable (and upstreamable) closefrom(2) syscall
support to Python's subprocess and posix modules, improving performance
significantly for loads that involve working with many processes, such as
diffoscope, ansible, and many others.

For additional optimizations, upstream recently (3.8) landed posix_spawn(2)
support [3] and has stated that they will adopt close_range(2) after Linux
merges it [4]. Linux/FreeBSD developers are already collaborating on
ensuring compatible implementations, with FreeBSD's implementation pending
in D21627. [5]

Thank you emaste, cem, kevans for providing analysis, input,
clarifications, comms/upstream support and patches.

[1] https://bugs.python.org/issue37790
[2] https://bugs.python.org/issue38061
[3] https://bugs.python.org/issue35537
[4] https://lwn.net/Articles/789023/
[5] https://reviews.freebsd.org/D21627

Additional References:

https://bugs.python.org/issue8052
https://bugs.python.org/issue11284
https://bugs.python.org/issue13788
https://bugs.python.org/issue1663329
https://www.python.org/dev/peps/pep-0446/

PR:		242274, 221700
Submitted by:	kevans (emaste, cem)
Approved by:	koobs (python (maintainer), santa)

 

11:53 bapt 

Drop the ipv6 virtual category for l* category as it is not relevant anymore

 

17:12 pkubaj 

lang/python35: Use -std=c99

Python 3.5 is currently failing to build the pickle module on GCC-based
architectures, with the following (several) errors:

  error: 'for' loop initial declaration used outside C99 mode

This causes packaging to fail, as the pickle module filename changes on
failure to build, so the plist ends up incorrect

Python 3.6+ switched to using -std=c99 [1][2], but the changes were not
backported to 3.5

[1] https://bugs.python.org/issue28017
[2] https://hg.python.org/cpython/rev/b5b2bb56d303
[3] https://hg.python.org/cpython/rev/91017e2202ae

PR: 238821
Reviewed by: koobs (python)
Approved by: koobs (python), mat (mentor)
MFH: 2019Q2 (blanket: build fix)
Differential Revision:  https://reviews.freebsd.org/D20778

 

14:04 sunpoet 

Update devel/readline to 8.0

- Bump PORTREVISION of dependent ports for shlib change

Changes:	https://tiswww.case.edu/php/chet/readline/CHANGES
PR:		236156
Exp-run by:	antoine

 

13:32 rene 

Remove compatibility code for FreeBSD < 11.2 from all ports.

Simplify some ports where DragonFlyBSD no longer needs to be special-cased.
Submitted by:	rene
Reviewed by:	bapt, jbeich
Differential Revision:	https://reviews.freebsd.org/D17724

 

06:23 koobs 

lang/python27,35+: Remove MAKE_JOBS_UNSAFE

ports r393217 via bug 200622 [1] originally set MAKE_JOBS_UNSAFE=yes due to
incorrect uses of recursive make [2], causing intermittent build failures when
run with multiple jobs (-jN).

Upstream committed a fix for the issue in default (3.6, at the time), 3.5 and
2.7 which are now contained in all released lang/python?? port versions. 3.4 did
not receieve a backport merge.

lang/python3.5+ ports inadvertently inherited MAKE_JOBS_UNSAFE=yes, via
repocopies from lang/python34 on their creation, when they were infact safe to
use with -j.

Remove MAKE_JOBS_UNSAFE in all lang/python?? ports except python34 accordingly.

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200622
[2] https://bugs.python.org/issue22359

PR:		232308
Reported by:	cem
Reviewed by:	cem
Approved by:	koobs (python)
MFH:		2018Q4
Differential Revision:	D17579

 

08:58 tobik 

lang/python3?: Fix python3.?-config behavior when symlinked

When python3.?-config is symlinked to another location it starts
outputting bogus paths.  For example

$ pwd
/home/tobias
$ python3.6-config --includes
-I/usr/local/include/python3.6m -I/usr/local/include/python3.6m
$ ln -s /usr/local/bin/python3.6-config python3-config
$ ./python3-config --includes
-I/home/include/python3.6m -I/home/include/python3.6m

This breaks ports trying to use BINARY_ALIAS together with
python3.?-config.  Apply a patch to resolve the symlink first before
trying to find the install prefix.

PR:		229749
Submitted by:	tobik
Reviewed by:	antoine, miwi
Approved by:	python (miwi)

 

12:48 sunpoet 

Fix build with OpenSSL 1.1.0 (security/openssl-devel)

- Remove BROKEN_SSL=openssl-devel

Reference:	https://bugs.python.org/issue30622
		https://github.com/python/cpython/commit/b2d096bd2a5ff86e53c25d00ee5fa097b36bf1d8
		https://github.com/python/cpython/commit/af64aff9f7de2ee60c20bfb331e8a00ea0521c1e
PR:		225870
Submitted by:	brnrd
MFH:		2018Q1

 

19:03 sunpoet 

Silence patch messages

 

16:52 sunpoet 

Update to 3.5.5

- Update Makefile and PLIST to be similar with python36
- Sort USES
- Remove CPE_*: all of them are default values
- Update PLIST_FILES: do not use %%
- Remove over-patched shebang fix of Lib/cgi.py
- Update http:// links in Makefile comments and patch files

Changes:	https://docs.python.org/3.5/whatsnew/changelog.html
Security:	0fe70bcd-2ce3-46c9-a64b-4a7da097db07
MFH:		2018Q1

 

18:19 amdmi3 

- Fix more shebangs

Approved by:	portmgr blanket

 

19:36 sunpoet 

Update to 3.5.4

- Sort PLIST

Changes:	https://docs.python.org/3.5/whatsnew/changelog.html
MFH:		2017Q3

 

01:39 sbruno 

Pointyhat to me.

A stray '.' somehow made it past my testing.

Do *not* bump portrevision as this only affects the packaging/stage
of these ports on mips/armv6 or other cross compiled targets.

PR:		221202
Reported by:	antoine

 

17:58 sbruno 

Add a code block for the qemu-user enabled cross build environment.  When using
this environment in poudriere, CC is not set to the default of /usr/bin/cc and
a cross-compile toolchain is used.  We need to hand edit this so that the run
time configuration for python matches what the FreeBSD base system provides.

PR:		208282
Submitted by:	manu
Approved by:	portmgr (mat)

 

02:37 dbaio 

lang/python{27,33,34,35,36}: Make Python curses module work with Unicode

Use readline from ports (USES= readline:port) and patch
setup.py to ignore readline from base. The patch is necessary for
FreeBSD < 1100000, as after this the readline library became an
INTERNALLIB, see base r268461 [1]

Link devel/readline against termcapw instead of termcap is part of
this change, see ports r444463 [2]

Note that this is the **ports** approach for getting Python curses
module working with Unicode. The other way is splitting libncurses
into separate libncurses and libtinfo in base, for which an open
issue exists [3].

Apart from Python language ports, at least www/rtv and
sysutils/py-ranger ports have been tested to work correctly
(display Unicode) after this change.

[1] https://svnweb.freebsd.org/changeset/base/268461
[2] https://svnweb.freebsd.org/changeset/ports/444463
[3] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197317

PR:		171246, 197317
Reported by:	Vitaly Magerya <vmagerya gmail com>
Reviewed by:	garga, koobs, miwi, sunpoet
Approved by:	garga (mentor), sunpoet (python, with hat)
Differential Revision:	https://reviews.freebsd.org/D11127

 

13:46 sunpoet 

Update devel/readline to 7.0 patch 3

- Bump PORTREVISION for shlib change

Changes:	https://cnswww.cns.cwru.edu/php/chet/readline/CHANGES
		https://lists.gnu.org/archive/html/bug-bash/2016-09/msg00107.html
		https://lists.gnu.org/archive/html/bug-readline/2017-01/msg00002.html
Differential Revision:	https://reviews.freebsd.org/D11172
PR:		219947
Exp-run by:	antoine

 

12:56 koobs 

lang/python{27,33,34,35,36}: Install GDB debugging script

Users with a GDB that supports [1] Python extensions will automatically
load the extra debugging extensions when debugging programs that are
linked with libpythonX.Y.so.foo.

This enables extensions like 'py-bt' and 'py-frame' as described in
the Fedora Wiki Article: Easier Python Debugging [2], which can be
useful for debugging Python program state from crashes in C extensions,
for example.

[1] PYTHON option enabled in devel/gdb
[2] https://fedoraproject.org/wiki/Features/EasierPythonDebugging

PR:		203021
Submitted by:	cem
Reviewed by:	mat, koobs (python)
Approved by:	koobs (python)
Differential Revision: D10398

 

11:08 sunpoet 

Modernize port

- Use PORTVERSION
- Use BROKEN_SSL
- Fix indent
- Update WWW

 

18:07 miwi 

- Fix shebang

Thanks to: amdmi3

 

18:46 mat 

Mark some ports as not openssl-devel ready.

Sponsored by:	Absolight

 

15:21 mat 

Use USES=pathfix where applicable.

PR:		213195
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D8093

 

19:07 brnrd 

lang/python3*: Backport upstream issue 24557

  - Add backport of patch for EGD issue [1]
  - Change USE_OPENSSL to USES= ssl
  - Don't set CPE_VERSION to the default PORTVERSION

PR:		205960 [1], 199050 [1]
Reviewed by:	koobs (python)
Approved by:	python (koobs)
Obtained from:	https://hg.python.org/cpython/rev/7c0432cf1f2e [1]
MFH:		2016Q3

 

00:56 wen 

- Update to 3.5.2

 

17:09 rm 

lang/python[xx]: backport upstream fix for CVE-2016-5636

Add patch for integer overflow in zipimport module to all our python ports.

While I'm here, get rid of -f flag in ${RM} invocation, because ${RM} already
expands to rm -f, so in result we are getting something like:

/bin/rm -f -f
/wrkdirs/usr/ports/lang/python35/work/stage/usr/local/lib/libpython3.so

PR:		210325
Submitted by:	 Vladimir Krstulja <vlad-fbsd@acheronmedia.com>
Security:	1d0f6852-33d8-11e6-a671-60a44ce6887b
With hat:	python

 

20:35 amdmi3 

Remove NLS, DOCS, EXAMPLES and IPV6 from OPTIONS_DEFAULT, they are enabled by
default anyway and don't need to be listed

Approved by:	portmgr blanket

 

20:22 dim 

For the various lang/python* ports, improve the __FreeBSD_version
check in pyport.h for working around a very old ctype issue.

If the workaround for this issue is enabled, pyport.h redefines
toupper() and some other ctype macros, and this wreaks havoc when
including newer libc++ headers (or any other system header which tries
to declare those functions).

Approved by:	portmgr (antoine)
PR:		208486
MFH:		2016Q2

 

14:08 mat 

Remove ${PORTSDIR}/ from dependencies, categories h, i, j, k, and l.

With hat:	portmgr
Sponsored by:	Absolight

 

16:45 koobs 

lang/python{27,3*}: Backport patch in upstream issue20397

In certain situations, file references (.py[co]) for Python files that
fail to compile with compileall() are still added to distutils --record
output.

This output is used for pkg-plist generation and must only contain
references to files that will be installed.

One example of a failure condition is when a Python 2/3 compatible
package containing a file containing Python 3.x only code is built with
Python 2.x, such as Gunicorn's _gaiohttp.py [1]

This change backports patches submitted against upstream issue 20397 [2]
that has not yet been committed.

 - For Python 2.7 and 3.5, backport both install_lib and test
 - For Python 3.2, 3.3 and 3.4, only backport install_lib

[1] https://svnweb.freebsd.org/changeset/ports/404558
[2] https://bugs.python.org/issue20397

Thank you to Brendan Molloy for producing and submitting the patches
against upstream sources.

Reviewed by:		sbz (python)
MFH:			2016Q1
Differential Revision:	D4832

 

12:03 marino 

lang/python27(3*), Mk/Uses/python.mk: remove make spawn

There are some inefficiencies in python.mk that significantly slow down
full tree scanning.  The use of bmake to obtain the current version of
a specific python is responsible for the majority of the slow done.

This commit splits out the PYTHON_PORTVERSION definition (which is the
same as the lang/python* PORTVERSION) into separate files.  With this
change, python.mk can simple include the makefile fragment instead of
spawning a new instance of make.

Different Revision:	https://reviews.freebsd.org/D4660
Approved by:		antoine (python), mva (python)

 

11:39 miwi 

- Switch regression-test to TEST_TARGED

Discussed in:   D4695
Reviewed by:	koobs

 

18:13 miwi 

- Update lang/python32 to 3.2.6 [1]
- Update lang/python35 to 3.5.1 [2]
- Update lang/python-doc-html for [1]
- Switch to do-test

Changelog:
[1] https://hg.python.org/cpython/file/v3.2.6/Misc/NEWS
[2] https://docs.python.org/3.5/whatsnew/changelog.html#python-3-5-1-final

Reviewed by:	koobs (python)
Approved by:	mat (mentor)
Differential Revision:	D4663

 

01:28 lwhsu 

Add version specified ports of separated standard Python modules for
non-default Python versions:

- Add pyXY-{sqlite3,gdbm,tkinter} ports for generating binary packages
- Improve/add pkg-message to point users to install respective packages of
  separated Python standard modules
- Add COMMENT to explicitly show the Python version that package should be
  used with
- Simplify version-related PYTHON_* for lang/python35

Reviewed by:	koobs
Differential Revision:	https://reviews.freebsd.org/D4170

 

12:36 koobs 

lang/python35: Update to 3.5.0 (release!)

- Update to 3.5.0
- Update pkg-plist

Release Announcement:

  https://www.python.org/downloads/release/python-350/

Complete Changelog:

  https://docs.python.org/3.5/whatsnew/changelog.html#python-3-5-0-final

 

16:08 koobs 

[NEW] lang/python35: Welcome Python 3.5.x! (Note: RC3)

FreeBSD welcomes Python 3.5 (early, pre-release) to the Ports tree,
with 3.5.0 release candidate 3!

Please test this port and Python 3.5 profusely. If you notice issues,
please report them upstream at: https://bugs.python.org to ensure a
robust upcoming 3.5.0 release.

Whats New in Python 3.5:

 * https://docs.python.org/3.5/whatsnew/3.5.html

Python 3.5 Release Schedule (PEP 478)

 * http://www.python.org/dev/peps/pep-0478

Note: This port retires an old fcntlmodule.c patch, possibly
temporarily. User impact *should* be zero. For more information
see: https://bugs.python.org/issue25026

Requested by:	Webair Inc :)