06:32 Fernando Apesteguía (fernape)  Author: Trond Endrestol

x11-wm/blackbox: switch from std::mem_fun to std::mem_fn

The former is deprecated.

PR:		272660
Reported by:	Trond.Endrestol@ximalas.info
Approved by:	A.J.Caines@halplant.com (maintainer)

    1bd91c3

06:42 koobs 

x11-wm/blackbox: Fix build with Clang 6, Fix TOOLS_ONLY option

Clang 6 (on 12-CURRENT) reports the following error during build:

EWMH.cc:250:7: error: non-constant-expression cannot be narrowed from type
'long' to 'unsigned long' in initializer list [-Wc++11-narrowing]
    { static_cast<long>(x), static_cast<long>(y) };
      ^~~~~~~~~~~~~~~~~~~~

There was also a bug introduced 4 years ago which removed the MAN1 variable a
later INSTALL_MAN macro relied on [1]. This caused a build/install failure
when the TOOLS_ONLY option was enabled.

This change fixes those two issues.

While I'm here level up port compliance:

  - Add LICENSE_FILE
  - Convert to OPTIONS helpers
  - Regenerate patches

[1] http://svnweb.freebsd.org/changeset/ports/346174
[2] https://lists.freebsd.org/pipermail/freebsd-ports/2018-August/114039.html

PR:		226708
Submitted by:	<Trond Endrestol ximalas info> (Clang 6 fix)
Approved by:	Andrew J. Caines <A J Caines halplant com> (technically)
Approved by:	portmgr (implicit, build fixes, framework compliance)
Reported by:	Erich Dollansky <freebsd ed lists sumeritec com> [2]
MFH:		2018Q3

 

10:00 danfe 

Add two patches to Blackbox:

Setting _NET_NUMBER_OF_DESKTOPS may cause Blackbox to explode.  The problem
is due to a bad loop condition in Screen.cc::clientMessageEvent().  If the
difference between the new number of desktops and initial workspaceCount()
is odd, the condition is always true, or at least until "number" underflows
or overflows.  BB will usually end up munching a lot of memory and dying
when it creates thousands of desktops first, though (tracker ID 2306646).

Blackbox does not handle transparency correctly in its slit, which causes
applications like x11/bbdock to display garbled graphics.  Patch suggested
by the author of BBDock.

Port revision will be bumped separately, as there are more changes coming.

Approved by:    maintainer