09:32 Mateusz Piotrowski (0mp) 

Mk/bsd.port.mk: Remove confusing double "/" from _DISTDIR

_DISTDIR is a variable which stores the distfiles directory of the port
that is currently being worked on. In practice, it is usually just
the DISTDIR, although some ports also define a subdirectory. Currently,
a slash separating DISTDIR from DIST_SUBDIR is added to _DISTDIR
no matter if DIST_SUBDIR is set or not. This may cause confusion to
ports users by looking like a bug while it is not.

In particular, this patch casuses diagnostic logs of failed archive
extraction to look like this:

    ===>  Failed to extract "/portdistfiles/ttf-iosevka-ss05-4.1.1.zip".

Instead of this:

    ===>  Failed to extract "/portdistfiles//ttf-iosevka-ss05-4.1.1.zip".

PR:		282291
Reviewed by:	pizzamig
Approved by:	pizzamig (portmgr)
Event:		Berlin Hackathon 202507
Differential Revision:	https://reviews.freebsd.org/D27722

    3fc4fad

07:56 Baptiste Daroussin (bapt) 

Mk/bsd.port.mk: Remove compatibility with pkg pre 1.17

in pkg 1.17 the extension was changed to always be .pkg, all supported
version of FreeBSD and bootstrap now support .pkg, it is time to remove
backware compatibility

Approved by:	mat (portmgr) on matrix
Differential Revision:	https://reviews.freebsd.org/D51142

    42de922

17:16 Rene Ladan (rene) 

Mk/bsd.port.mk: mark FreeBSD 13.4 as unsupported.

Drop support for FreeBSD 13.4 (and sometimes 12, 14.0, 14.1) from all
ports.

Reviewed by:	dch, @gor_clogic.com.ua
Approved by:	portmgr (implicit)
Differential Revision:	https://reviews.freebsd.org/D50769

    3be82964

11:26 Baptiste Daroussin (bapt) 

Mk/bsd.port.mk: Allow package not to expose some of their libraries

2 new KNOB: NO_SHLIB_PROVIDES_GLOB and NO_SHLIB_PROVIDES_REGEX which
allow to define glob and regex patterns of libraries which should not be
automatically exposed by packages via shlibs provides and requires

    454289d

11:17 Baptiste Daroussin (bapt) 

Mk/bsd.port.mk: fix typo

Be consistent between NO_SHLIB_REQUIRES_GLOB and NO_SHLIB_REQUIRES_REGEX
Syntax

    29d683c

18:21 Alexander Leidinger (netchild) 

Mk/Features: Add features for fortify, zeroregs and stack autoinit.

Those 3 features for ports go along with the cooresponding features from
the basesystem (some only availabe in -current).

The options you can put into make.conf for the ports collections are:

WITH_FORTIFY=yes
    This enables mitigations of common memory safety issues, such as buffer
    overflows, by adding checks to functions like memcpy, strcpy, sprintf,
    and others when the compiler can determine the size of the destination
    buffer at compile time.

WITH_STACK_AUTOINIT=yes
    This enables a compiler specific option to automatically initialize
    local (automatic) variables to prevent the use of uninitialized memory.

WITH_ZEROREGS=yes
    Zero call-used registers at function return to increase program
    security by either mitigating Return-Oriented Programming (ROP)
    attacks or preventing information leakage through registers.
    This depends upon support from the compiler for a given architecture.
    This is disabled for python ports, currently there are issues.

Approved by:	portmgr (mat)
PR:		284270

    7a489e9

06:27 Gleb Popov (arrowd) 

Mk/bsd.port.mk: Fix SHLIB_PROVIDE_PATHS_COMPAT_LINUX for i386

Approved by: bapt
Differential Revision: https://reviews.freebsd.org/D49888

    8a8e486

13:51 John Baldwin (jhb) 

Mk/bsd.port.mk: Pass CSTD/CXXSTD in MAKE_ENV

For ports which use bsd.*.mk in their build, the existing USE_CSTD
logic which patches CFLAGS and CXXFLAGS is insufficient since
bsd.sys.mk will add the default CSTD/CXXSTD later in CFLAGS/CXXFLAGS.
Presumably no ports are using USE_CSTD with bsd.*.mk, but at least one
does use USE_CXXSTD with bsd.*.mk which will break when src starts
defining a default CXXSTD.

PR:		285141
Reviewed by:	bapt
Differential Revision:	https://reviews.freebsd.org/D49597

    2be2295

10:51 Rene Ladan (rene) 

all: drop support for EOL FreeBSD 14.1

- Mk/bsd.port.mk: de-support FreeBSD 14.1
- devel/boost-libs: simplify a comment
- devel/libdispatch: remove a commented out and outdated code block
- editors/imhex: simplify some tautologies
- editors/libreoffice: remove an outdated BROKEN
- graphics/dspdfviewer: simplify OSVERSION logic

Approved by:	portmgr (implicit)
Differential Revision: https://reviews.freebsd.org/D49099

    2b343c2

18:55 Mathieu Arnold (mat) 

Mk: minor style fix bapt forgot to apply

    0700438

16:49 Baptiste Daroussin (bapt) 

Mk: add a new HAS_SYMBOL_VERSION

When a port is tagged with this (should contain the list of libraries
with SYMBOL version) the ports tree will add an extra check that
the built library actually have symbols versions.

    2ec0ea0

16:54 Baptiste Daroussin (bapt) 

Mk/bsd.port.mk: consider USE_LDCONFIG32 for provides/requires

With newer pkg we need to also take in account USE_LDCONFIG32
in the path where we do provide lib32 libraries

    a8a7c6f

19:24 Baptiste Daroussin (bapt) 

golang: do not collect data from wrong freebsd binary

Reviewed by:		bdrewery
Differential Revision:	https://reviews.freebsd.org/D49260

    a432716

11:08 Gleb Popov (arrowd) 

Mk/bsd.port.mk: Use PKG_VERSION instead of PKG_BIN

Sponsored by:	Future Crew, LLC

    18bf494

11:08 Gleb Popov (arrowd) 

Mk/bsd.port.mk: Setup SHLIB_PROVIDE_PATHS* vars for pkg

This changes picks a new pkg feature: https://github.com/freebsd/pkg/pull/2422

The idea behind the `.if ${LINUX_DEFAULT} ...` check comes from the Linux
ld.so(8) man page that says

> (5)  In the default path /lib, and then /usr/lib.  (On some 64-bit
>      architectures, the default paths for 64-bit shared objects
>      are /lib64, and then /usr/lib64.)

CentOS 7 and Rocky Linux 9 that we have in Ports install 32 bit libraries
into `/usr/lib` and 64 bit libraries into `/usr/lib64`. `/lib` and `/lib64` are
symlinks, so I omitted them.

Differential Revision: https://reviews.freebsd.org/D49136
Approved by:	bapt

    682808b

12:02 Gleb Popov (arrowd) 

Framework: Allow setting the 'vital' flag from a port

Approved by:	bapt
Differential Revision: https://reviews.freebsd.org/D48697
Sponsored by:	Future Crew, LLC

    b2f07f8

16:47 Rene Ladan (rene) 

Mk/bsd.port.mk: fix OSVERSION for 13.4

Reported by:	bofh
Approved by:	portmgr (implicit)
Fixes:		8777dde2465 "all: remove support for expired FreeBSD 13.3"

    65b88c2

16:09 Rene Ladan (rene) 

all: remove support for expired FreeBSD 13.3

Reviewed by:	bofh, brnrd, jbeich, nobutaka
Approved by:	portmgr (implicit)
Differential Revision: https://reviews.freebsd.org/D48247

    8777dde

15:56 Po-Chuan Hsieh (sunpoet) 

Mk/bsd.port.mk: Sort VALID_CATEGORIES

- Fix 6e2da9672f79f44048d597f0f61e4646cdeade9d

Approved by:	portmgr (blanket)

    982edc7

08:57 Muhammad Moinur Rahman (bofh) 

Mk/**java.mk: Convert bsd.java.mk to USES

The following features have been added or changed:
- Instead of USE_JAVA use USES=java. This defaults to
  USES=java:build,run if NO_BUILD is undefined. Else it defaults to
  USES=java:run
- Instead of USE_ANT=yes use USES=java:ant which also implies
  USES=java:build
- Instead of JAVA_BUILD=yes use USES=java:build. Does not imply run or
  extract
- Instead of JAVA_EXTRACT=yes use USES=java:extract does not imply
  build or run
- Instead of JAVA_RUN=yes use USES=java:run does not imply extract or
  build
- Instead of USE_JAVA=<version> use USES=java and JAVA_VERSION=<version>

Approved by: mat (portmgr), glewis
Differential Revision:  https://reviews.freebsd.org/D48201

    0835676

07:41 Muhammad Moinur Rahman (bofh) 

Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk

- Instead of USE_OCAML=yes use USES=ocaml. If empty USES=ocaml implies
  build and run
- Instead of USE_OCAMLFIND_PLIST use USES=ocaml:findplist which also
  implies USES=ocaml:findlib
- Instead of USE_OCAML_CAMLP4 use USES=ocaml:camlp4
- Instead of USE_OCAML_FINDLIB use USES=ocaml:findlib
- Instead of USE_OCAML_LDCONFIG use USES=ocaml:ldconfig
- Instead of USE_OCAML_WASH use USES=ocaml:wash
- Instead of NO_OCAML_BUILDDEPENDS use USES=ocaml:run
- Instead of NO_OCAML_RUNDDEPENDS use USES=ocaml:build
- Instead of USE_OCAML_TK use USES=ocaml:tk which actually implies
  USES=ocaml:tkbuild and USES=ocaml:tkrun
- Instead of NO_OCAMLTK_BUILDDEPENDS use USES=ocaml:tkrun
- Instead of NO_OCAMLTK_RUNDEPENDS use USES=ocaml:tkbuild
- USES=ocaml:dune remains unchanged
- Prepare to add/remove keywords easily

Approved by: mat (portmgr)
Reviewed by: freebsd@dev.thsi.be
Differential Revision: https://reviews.freebsd.org/D48227

    c79c880

16:29 Muhammad Moinur Rahman (bofh) 

Mk/bsd.port.mk: Remove obsolete descriptions

Both USE_TEX and USE_OPENLDAP has been converted to USES=tex and
USES=ldap respectively

Approved by:	portmgr (blanket)

    b5599c6

10:46 Robert Clausecker (fuz) 

Mk/bsd.port.mk: stop ports from finding the ports tree's git repository

When building from source, the ports tree is by default a parent
directory of WRKDIR.  When ports try to use git to find the git commit
they are built from, they'll some times find the port's git repository
and produce bogus metadata.  Set GIT_CEILING_DIRS in WRK_ENV to ensure
that git does not escape WRK_ENV trying to look for a git repository
that doesn't exist.

This doesn't affect Poudriere builds as for these, WRKDIR is by default
not a subdirectory of the ports tree, and neither is git installed in
builder jails unless explicitly needed.  As a result, bugs of this kind
tend to go unnoticed by maintainers, but do affect source builders.

Approved by:	portmgr (mat)
Exp-run by:	antoine
PR:		283098
Differential Revision: https://reviews.freebsd.org/D47850

    deb7978

08:17 Baptiste Daroussin (bapt) 

kmod: append osversion to the portversion

The version is now

kmodpackagename-<kmodpackageversion>.<osversion>_<revision>,<epoch>

This is necessary to make sure that the same packages built on a newer
version of FreeBSD on a given branch is considered as an upgrade of the
default provided one.

In the current model of support, all packages are built on the lowest
supported version of a given branch, which means right now all packages
are built on 14.1, this results as since 14.2 has been released and up
to the time 14.1 is EOLed we do not provide working binary packages for
kernel modules and related for 14.2.

With this we will be able to provide a dedicated repo built against 14.2
that will be usable by users and pkg upgrade will simply update to the
right version.

https://reviews.freebsd.org/D47997

    a5fc087

15:17 Robert Clausecker (fuz) 

filesystems: add new category for file systems and related utilities

The filesystems category houses file systems and file system utilities.
It is added mainly to turn the sysutils/fusefs-* pseudo-category into
a proper one, but is also useful for the sundry of other file systems
related ports found in the tree.

Ports that seem like they belong there are moved to the new category.
Two ports, sysutils/fusefs-funionfs and sysutils/fusefs-fusepak are
not moved as they currently don't fetch and don't have TIMESTAMP set
in their distinfo, but that is required to be able to push a rename
of the port by the pre-receive hook.

Approved by:	portmgr (rene)
Reviewed by:	mat
Pull Request:	https://github.com/freebsd/freebsd-ports/pull/302
PR:		281988

    6e2da96

09:04 Tijl Coosemans (tijl) 

Mk/bsd.port.mk: Add MACHINE_ARCH to WRK_ENV

make(1) has a built-in variable MACHINE_ARCH that defaults to the value
of sysctl hw.machine_arch.  This is not correct when building packages
under qemu.  In that case poudriere sets MACHINE_ARCH in its make.conf.
Since commit d7511b9d0074 make.conf is not picked up by make during
build so pass MACHINE_ARCH through the environment.

This affects building kmod ports under qemu.

This is a workaround for make not looking at UNAME_p when setting
MACHINE_ARCH.  It does look at UNAME_m when setting MACHINE.

PR:		281674
Reported by:	jrtc27
Exp-run by:	antoine
Approved by:	portmgr (antoine)

    3154506

18:56 Rene Ladan (rene) 

all: drop support for expired FreeBSD 14.0

Simplify expressions for FreeBSD 13.X

Reviewed by:	many

Differential Revision:	https://reviews.freebsd.org/D46601

    4485bd8

15:33 Ed Maste (emaste) 

bsd.port.mk: remove unused base system binutils support

GNU binutils 2.17.50 was removed from the base system (for all archs)
prior to FreeBSD 13.0.  Remove ports support for base system ld.bfd.

Reviewed by:	portmgr (mat)
Sponsored by:	The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D46015

    a015287

20:27 Rene Ladan (rene) 

all: drop support for FreeBSD 13.2 which reached EOL today

Thanks again to jbeich for noticing various things I overlooked.

Reviewed by:	acm, ashish, eduardo, ehaupt, eugen, jbeich, martymac, mat,
nobukata, sunpoet, tagattie, yuri, arrowd, kde
Differential Revision:	https://reviews.freebsd.org/D45141

    19d6872

04:59 Mathieu Arnold (mat) 

Revert "Framework: Introduce bsd.sponsor.mk"

This reverts commit 274cd4df4dcce0a9aa78da47bb6e35ab3dbcbf8c.

    0668752

18:37 Gleb Popov (arrowd) 

Framework: Introduce bsd.sponsor.mk

Differential Revision:	https://reviews.freebsd.org/D44487

    274cd4d

01:56 Joseph Mingrone (jrm) 

Mk/bsd.port.mk: Update comment about quoting do-fetch env vars

Reviewed by:	portmgr (mat)
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D45607

    ecef7ae

17:16 Mathieu Arnold (mat) 

Mk/bsd.port.mk: simplify WITH_<feat> code

Differential Revision:	https://reviews.freebsd.org/D44793

    0660628

07:53 Mathieu Arnold (mat) 

framework: reintroduce the feature enabling code

For each feature (see in Mk/Features) users can now set these variables
in their make.conf. Using LTO as an example.

To enable globally:

  WITH_LTO= yes

To disable globally (for example ssp is enabled by default):

  WITHOUT_LTO=	yes

To enable for a specific list of ports:

  WITH_LTO_PORTS= lang/perl5.36

To disable for a specific list of ports:

  WITHOUT_LTO_PORTS= lang/perl5.36

Differential Revision:	https://reviews.freebsd.org/D44750

    0660189

19:41 Mathieu Arnold (mat) 

Revert "Mk/bsd.port.mk: Allow WITHOUT_FEATURE_PORTS to cancel WITH_FEATURE"

This reverts commit d697653cffd19ddaf3cdee2589a830c72ab39777.

    0660147

18:51 Gleb Popov (arrowd)  Author: Muhammad Moinur Rahman

Framework: Finalize switch to share/man for manpages

PR:		277603
Approved by:	portmgr

    9fd7ee1

11:40 Gleb Popov (arrowd) 

Framework: Use WRK_ENV when handling USE_LOCALE

PR:		276478

    bf8e12d

15:00 Tijl Coosemans (tijl) 

*/*: Various Linux CentOS 7 updates

    6672772

11:19 Tijl Coosemans (tijl) 

Mk/bsd.port.mk: Add __MAKE_CONF=${NONEXISTENT} to WRK_ENV

And remove it from individual ports.  Use WRK_ENV in custom build
commands where necessary.

FreeBSD make(1) includes /usr/share/mk/sys.mk and that includes
/etc/make.conf if it exists.  This happens when you run make in a port
directory but it also happens when the upstream build system uses make.
This commit disables make.conf inclusion in the latter case because
users can define variables like CFLAGS in make.conf that override ports
framework variables and this can cause problems that are difficult to
diagnose.

If there are any build customisations made through make.conf that stop
working because of this commit then they should be made available by the
ports tree through some mechanism, e.g. an option in a port.

Some ports were picking up variables from Poudriere make.conf and
required fixes:

- astro/wmspaceweather x11-clocks/wmcalclock: Add OPSYS to MAKE_ENV.
- games/zhlt: Add ARCH to MAKE_ENV.
- graphics/tachyon: Upstream ARCH is not ports tree ARCH.
  Set ALL_TARGET=bsd so upstream ARCH is defined correctly.
  Enable multi-threading support while here.

PR:		277455
Exp-run by:	antoine

    d7511b9

13:56 Baptiste Daroussin (bapt) 

Mk/bsd.port.mk: remove LEGAL related variables

This is noop since the ports tree does nothing with the variables
anymore for a while

Reviewed by:	mat
Differential Revision:	https://reviews.freebsd.org/D44252

    4dea5ae

20:21 Tijl Coosemans (tijl) 

Mk/*: Build with a clean environment

Both our make and gmake use the MAKEFLAGS environment variable but the
values aren't compatible and the latest version of gmake complains about
that.  To rule out that any environment variable can cause problems like
this, add a new command SETENVI=/usr/bin/env -i that clears the
environment, and use it to run upstream build systems with a clean
environment.

Introduce a new variable WRK_ENV that contains the environment to use
with SETENVI in all targets that run upstream build commands.  Variables
that are common between CONFIGURE_ENV and MAKE_ENV could be moved to
WRK_ENV but for now it just contains a minimal environment:

HOME=${WRKDIR}: Fixes USES=elixir ports that were using the user's HOME.
OSVERSION: For cross building; determines the output of uname -K and
getosreldate(3); affects net/freebsd-telnetd for example.
PATH: Fixes USES=gem ports that were using the user's PATH.
PWD=$${PWD}: Preserve current working directory; affects USES=go ports.
TERM: To preserve colored output to terminals.
TMPDIR: For users who define that.
UNAME_*: For cross building; determines the output of uname(1); affects
lang/python* for example.

This commit deals with everything under Mk/.  Ports that have their own
targets running upstream build commands can switch to SETENVI later.

The ports tree adds its definition of ARCH to the MAKEFLAGS environment
variable, which is interpreted by sub-makes as command line arguments,
which means that any definition of ARCH in upstream makefiles was
overridden.  The following ports required fixes now that this is no
longer the case.

games/iortcw, games/q3cellshading, games/tremulous:
These use Quake 3 engine code.  Fix use of ARCH.  Reduce diff between
FreeBSD code and Linux code.

games/legesmotus:
Remove ARCH related patches.

lang/ocaml:
Patch configure script so it detects amd64 correctly.  Also make the
powerpc case consistent with the other architectures.  This also affects
other ocaml ports like devel/ocaml-ocamlbuild and math/ocaml-num that
include a Makefile.config installed by lang/ocaml.  While here, use
SETENVI in check-test target.

net/libnatpmp:
Use of upstream definition of ARCH triggers installation in PREFIX/lib64
on amd64.  Disable this.

PR:		276478
Approved by:	portmgr (antoine)
Exp-run by:	antoine

    572f236

06:07 Gleb Popov (arrowd) 

Mk/bsd.port.mk: Allow WITHOUT_FEATURE_PORTS to cancel WITH_FEATURE

Differential Revision: https://reviews.freebsd.org/D43949

Sponsored by:	Serenity Cybersecurity, LLC

    d697653

06:07 Gleb Popov (arrowd) 

Framework: Introduce testing feature

Setting WITH_TESTING=yes will cause running `make test` between `stage` and
`package` in the default pipeline.

This feature is off by default.

Sponsored by:	Serenity Cybersecurity, LLC

    d7700ff

13:24 Baptiste Daroussin (bapt) 

subpackages: fix minor regression

Before subpackages, when running package there where 2 cases:
case 1: ${PACKAGES} directory exist:
  packages are created in the work/pkg directory then copies into
  ${PACKAGES} directory
case 2: ${PACKAGES} does not exist:
  packages where only created in work/pkg

After subpackages in the case 2, the packages get copied into the
  directory actually running the make package comment.

This change makes the framework behave like before subpackages

Reported by:	Antonio Huete Jimenez (tuxilio from Dragonfly irc
		channel)

    e1584ae

16:26 Baptiste Daroussin (bapt) 

subpackages: fix make flavors-package-names

if the ports has flavors and subpackages then the list of names
are properly displayed 1 per line, but if the ports as no flavors
then it reported everything inline, breaking pkg version and
probably other tools

Reported by:	many

    2a58fba

06:31 Gleb Popov (arrowd) 

Features/debuginfo.mk: Automatically generate a subpackage with debugging info.

Differential Revision: https://reviews.freebsd.org/D43515

Tested by:	flo
Approved by:	portmgr, emaste

    2c24a73

22:25 Muhammad Moinur Rahman (bofh) 

Mk/bsd.port.mk: Sunset MANPREFIX

For historical reasons FreeBSD had been using PREFIX/man to install man
pages and a variable MANPREFIX was utilized to do this. While the rest
of the UNIX/Linux world had been mostly using PREFIX/share. As the
first step of moving to PREFIX/share/man this commit removes all the
references to the MANPREFIX variable. Apart from MAKE_ARGS this
variable no longer exists and should not be used to refer to PREFIX
anymore in the future.

The entire shift to PREFIX/share/man will take some more times as there
are around 4000 ports which installs man page to PREFIX/man.

PR:		276551
Approved by:	portmgr (exp-run)

    8f80d6d

20:13 Olivier Cochard (olivier) 

features: Add support to enable sanitizers

Can be activated/deactivated globally via
WITH_SANITIZE

Can be activated individualy via
WITH_SANITIZE_PORTS

Each port can individually mark itself as not supporting the feature
via SANITIZE_UNSAFE=

Approved by:	bapt, arrowd
Sponsored by:	Netflix
Differential Revision:	https://reviews.freebsd.org/D43497

    0592024

16:17 Christian Weisgerber (naddy) 

Mk/*: unconditionally use .MAKE.UID and .MAKE.GID

Since FreeBSD 12 has been EOLed, the built-in make(1) variables
.MAKE.UID and .MAKE.GID are always available.

PR:		276259
Approved by:	arrowd

    fe3392e

08:06 Gleb Popov (arrowd) 

Mk/bsd.port.mk: Introduce generic WITH_<FEATURE>_PORTS knob.

This allows enabling any feature supported by Ports Framework for a selected
ports. It was only possible to do WITH_DEBUG_PORTS before.

Differential Revision: https://reviews.freebsd.org/D43369

Approved by:	bapt

    263bffb

08:02 Baptiste Daroussin (bapt) 

MAN?PREFIX: undefine those variables

MAN?PREFIX where confusing (people kept messing around with them)
did not bring any real value or functionnality.

Reviewed by:		portmgr (mat)
Approved by:		portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D43392

    5c475f0

10:55 Baptiste Daroussin (bapt) 

subpackages: fix flavors-package-names

Before subpackages was introduced, flavors-package-names was printing
the full <name>-<version>, a regression was introduced with subpackages
which made it print <name>.

One of the side effect of this is pkg version -v -P was determining all
the ports as orphaned.

Reported by:	stephen@

    0823be4

21:58 Luca Pizzamiglio (pizzamig) 

component: add SUBPACKAGES

This commit add SUBPACKAGES support to the framework.

Fix users of _LICENSE_DIR
Fix multi/dual license
Add annotation to packages about being a subpkg
Make do-depends aware of the subpackages
Add PKGBASE.subpkg variable
Fix actual-package-depends target
Fix dependencies in sub-packages
Implement LICENSE support
Fix PLIST_FILES.subpkg
Make DESCR.subpkg warning message shorter
Add SUBPACKES to the list of OPTIONS_HELPERS
Fix _strip_perms
Simplify METADIR as in the original patch
Fix _PLIST
Fix the case when there are no subpackages
Fix typo
Fix _PKGDIR initialization
Fix PLIST
Fix typo in RE
Fix METADIR
Fix type in PKGFILE
Fix [build|run]-depends-list targets
Initial import of the subpackage framework
This import is based on https://reviews.freebsd.org/D16457

PR:		275735
Differential Revision:	https://reviews.freebsd.org/D40549

    4756476

00:37 Muhammad Moinur Rahman (bofh) 

*/*: Sunset 12.4-RELEASE/12-STABLE from ports tree

- Remove all references to defunct ARCH arm
- Remove all references to defunct ARCH sparc64
- Remove x11-drivers/xf86-video-sunffb which requires defunct sparc64
  ARCH
- Remove sysutils/afbinit requires defunct sparc64 ARCH
- Remove all references to bktr driver
- Remove all references to defunct FreeBSD_12
- Remove all references to OSVERSION/OSREL corresponding to 12
- Remove conditionals in Mk/Uses/cabal.mk
- Remove sparc reference from Mk/Uses/qt-dist.mk
- Remove BROKEN_sparc64/NOT_FOR_ARCH=sparc64
- Remove BROKEN_FreeBSD_12* from:
- Remove OpenSSL patches from:
- Remove conditional flags for OSVERSION >= 1300000 to fixed flags.
  Also move conditional flags for non sparc64/arm ARCH to fixed flags.

Reviewed by:	brooks, jbeich, rene, salvadore
Differential Revision: https://reviews.freebsd.org/D42068

    bbab7f5

16:39 Fernando Apesteguía (fernape) 

Mk/bsd.port.mk: Remove duplicate variable in JSON output

Remove duplicate pkg_depends when generating a JSON description of the three

Approved by:		delphij@
Fixes:			3d9f300e01f5ecdb140027096c603623264ecc07
Differential Revision: https://reviews.freebsd.org/D42373

    a270e74

06:34 Fernando Apesteguía (fernape) 

Mk/bsd.port.mk: add COMMENT to make describe-json

Follow up to 3d9f300e01f5ecdb140027096c603623264ecc07.

Approved by:	portmgr@ (bapt@ via mail)

    4ad6ea4

13:23 Alexey Dokuchaev (danfe) 

Mk/bsd.port.mk: fix indentation (per ts=4) and trim excessive linefeeds

While here, spell two common Latin contractions properly.

    8d4446d

11:16 Fernando Apesteguía (fernape) 

Mk/bsd.port.{subdir}.mk: create describe-json

Summary:
Create "describe-json" target to get a JSON-compliant representation of the
ports tree.

It can be invoked from a single port directory, a category directory or from the
ports tree top directory.

It supports FLAVORS. E.g. It is possible to execute the following:

cd math/qalculate-qt && make describe-json-qt6

Performance-wise it is equivalent to a simple "make describe" although it
offers a more complete vision of the port in an easily parseable format.

Times for describe:
     1345.39 real       933.06 user       403.01 sys
     1317.00 real       929.22 user       406.43 sys
     1316.83 real       930.82 user       404.70 sys
     1316.75 real       928.05 user       407.39 sys
     1316.58 real       930.69 user       404.59 sys
Times for describe-json:
     1320.38 real       924.80 user       414.48 sys
     1320.66 real       926.14 user       413.41 sys
     1320.41 real       924.08 user       415.30 sys
     1320.37 real       922.96 user       416.35 sys
     1320.25 real       924.25 user       414.95 sys

Some examples assuming the output is saved in the `describe.json` file.

Show all ports in the "accessibility" category:

jq '.accessibility' describe.json

Show ports in the "accessibility" category with a USES=iconv dependency:

jq '.accessibility.[] | select(.uses | index("iconv")) | .pkgorigin'
describe.json

Show ports in the tree that Uses=kmod:

jq '.[].[] | select(.uses | index("kmod")) | .pkgorigin' describe.json

Show ports having a LIB_DEPENDS on devel/binutils:

jq '.[].[] | select(.lib_depends | map(test("devel/binutils")) | any) |
.pkgorigin' describe.json

Show ports in the "database" category which have no maintainer and are marked as
deprecated:

jq '.databases.[] | select(.maintainer=="ports@FreeBSD.org" and .deprecated!="
") | .pkgorigin, .deprecated' describe.json

Approved by:		portmgr (bapt@)
Differential Revision:	https://reviews.freebsd.org/D42131

    3d9f300

18:27 Tobias C. Berner (tcberner) 

sanity: warn about unnused LIB_DEPENDS entries

`stage-qa` already warns about missing dependencies. However, it does not warn
about possibly unneeded ones.

This change tries to address this, by simply walking the list of linked against
shared libraries and then matching the entries of LIB_DEPENDS against them.

Note: this may lead to false positives -- as always, user your brain,
and don't rely on output of static tools alone.

Possible output might look like:

[...]
====> Running Q/A tests (stage-qa)
Warning: you might not need LIB_DEPENDS on libqgpgme.so
Warning: you might not need LIB_DEPENDS on libintl.so
Warning: you might not need LIB_DEPENDS on libKF5IconThemes.so
Warning: you might not need LIB_DEPENDS on libqca-qt5.so
Warning: you might not need LIB_DEPENDS on libQt5Test.so
[...]

Note, that in this case all are false positives.

Differential Revision: https://reviews.freebsd.org/D27304

    f3790c0

11:27 Rene Ladan (rene) 

all: remove support for expired FreeBSD 13.1

Approved by:	portmgr (implicit), salvadore (gcc ports)
Reviewed by:	jbeich

Differential Revision: https://reviews.freebsd.org/D40845

    5981a24

18:55 Felix Palmen (zirias) 

bsd.sites.mk: Support tag names with USE_GITLAB

Since quite some time, it's possible to download generated tarballs from
gitlab for a tag name without knowing the corresponding git hash. This
is preferable because you have a single source of truth about the
software version.

Support this by replacing GL_COMMIT with GL_TAGNAME which also accepts a
commit hash, similar to USE_GITHUB. Unfortunately, there's a catch, the
DISTFILE must be named exactly: ${GL_PROJECT}-${GL_TAGNAME}.tar.bz2,
otherwise it extracts in a directory that contains the commit hash. So,
we can't add the gitlab account or the revision suffix to make it work.

Therefore, detect whether GL_TAGNAME contains a commit hash, and if it
does, use the old behavior of deriving DISTNAME and DISTFILES.

Document in CHANGES, also add a DEV_WARNING similar to USE_GITHUB when
there's an URL in MASTER_SITES that looks like a gitlab URL. With
support for tags, there shouldn't be any reason left to hardcode such an
URL in MASTER_SITES.

PR:			248967
Approved by:		portmgr (tcberner, mentor)
Differential Revision:	https://reviews.freebsd.org/D37077

    16bde07

14:19 Mateusz Piotrowski (0mp) 

framework: Implement fetch-url-recursive-list and fetch-urlall-recursive-list

The recursive variants of fetch-url-list and fetch-urlall-list provide
a stable interface to a list of all the to-be-accessed URLs. That is
quite handy, e.g., when a list like that is necessary to implement
security policies.

Reviewed by:	pizzamig
Approved by:	portmgr (pizzamig)
Sponsored by:	Klara Inc.
Differential Revision: https://reviews.freebsd.org/D40810

    349b11c

22:04 Robert Clausecker (fuz)  Author: Andrew Gierth

Mk/bsd.port.mk: Allow category_port_VARS= in make.conf for arbitrary per-port
overrides.

Currently the only way to specify make.conf variables (other than port
options which have their own mechanism) in a per-port fashion is to use
conditionals on .CURDIR, which is fragile since it tends to involve
assumptions about where the ports tree is mounted.

Instead, allow category_portname_VARS= to be set in make.conf to provide
arbitrary assignments when building a specified port. For example one
might use

    devel_llvm10_VARS= MAKE_JOBS_NUMBER=2

or

    converters_lua-iconv_VARS= TRYBROKEN=yes

This is intended to be consistent with the existing
category_portname_SET= variables for port options, and uses the same
syntax for values as option_VARS= in port makefiles, but without the
case-folding behavior since that makes it impossible to handle
mixed-case or lowercase variable names.

Reviewed by:	koobs, mat, adamw, mandree, 0mp
Approved by:	portmgr (bapt)
Differential Revision:	https://reviews.freebsd.org/D24324
VAR+=val can be used to append to a variable, and VAR@ to unset one entirely.

    f685268

05:47 Daniel Engberg (diizzy) 

Mk/bsd.port.mk: Enable verbose output when pkgconfig file(s) ends up in wrong
path

To avoid confusion and silently fix issues that occurs

Reviewed by:	mat
Approved by:	portmgr (bofh)

    af209ce

23:59 Muhammad Moinur Rahman (bofh) 

*/*: Sunset 12.3-RELEASE from ports tree

- Mk/bsd.port.mk: mark FreeBSD 12.3 as unsupported.
- Mk/Uses/cabal.mk: Remove the text-2 workaround for 12.3-RELEASE
- biology/wfa2-lib: remove obsolete patch
- databases/mongodb60: remove IGNORE for EOL FreeBSD 12.3
- devel/concurrencpp: remove workaround for EOL FreeBSD 12.3
- devel/electron22: remove IGNORE for EOL FreeBSD 12.3
- devel/malloy: this should build fine on 12.4-RELEASE
- devel/qcoro: remove BROKEN for EOL FreeBSD 12.3
- devel/root: remove workaround for EOL FreeBSD 12.3
- editors/imhex: remove IGNORE for EOL FreeBSD 12.3
- emulators/ppsspp: remove workaround for EOL FreeBSD 12.3
- emulators/rpcs3: remove workaround for EOL FreeBSD 12.3
- emulators/yuzu: remove workaround for EOL 12.3-RELEASE
- games/aquaria: remove support for EOL FreeBSD 12.3
- games/punchy: remove workaround for EOL FreeBSD 12.3
- graphics/cxxplot: remove support for EOL FreeBSD 12.3
- lang/gcc11*: bump a __FreeBSD_version in libphobos to 1204000
- lang/rust: untangle OSVERSION logic a bit
- misc/mbuffer: remove workaround for EOL FreeBSD 12.3 for aarch64
- sysutils/libdisplay-info: remove workaround for EOL FreeBSD 12.3
- www/*chromium: remove IGNORE for EOL FreeBSD 12.3
- x11/hyprpaper: remove workaround for expired FreeBSD 12.3
- x11-wm/labwc: remove workaround for EOL FreeBSD 12.3
- x11-wm/kwinft: remove workaround for EOL FreeBSD 12.3
- www/iridium: remove IGNORE for EOL FreeBSD 12.3

Differential Revision: https://reviews.freebsd.org/D38664

    5693229

18:18 Gleb Popov (arrowd)  Author: Olivier Duchateau

x11/budgie: + Budgie desktop environment.

This is import of complete Budgie desktop, it contains:

  - Uses 'budgie.mk' framework
  - Add virtual category (budgie) in `Mk/bsd.port.mk`
  - Meta-port `x11-wm/budgie`
  - New icon theme `x11-themes/tela-icon-theme`

Reviewed by: rene, tcberner, lbartoletti, arrowd

Differential Revision: https://reviews.freebsd.org/D37224

    1ccad74

15:51 Baptiste Daroussin (bapt)  Author: Mateusz Guzik

SMP: Use nproc(1) instead of sysctl kern.smp.cpus

The former respects cpuset, while the latter does not.

$ cpuset -l 1 -- make -V MAKE_JOBS_NUMBER
1

As nproc is newly introduced, keep the previous variant as a fallback
for the time being.

Differential Revision:	https://reviews.freebsd.org/D38457

    e3a17d6

10:53 Muhammad Moinur Rahman (bofh) 

Mk/**ldap.mk: Convert USE_LDAP to USES=ldap

Convert the USE_LDAP=yes to USES=ldap and adds the following features:

- Adds the argument USES=ldap:server to add openldap2{4|5|6}-server as
  RUN_DEPENDS
- Adds the argument USES=ldap<version> and replaces WANT_OPENLDAP_VER
- Adds OPENLDAP versions in bsd.default-versions.mk
- Adds USE_OPENLDAP/WANT_OPENLDAP_VER in Mk/bsd.sanity.mk
- Changes consumers to use the features

Reviewed by:	delphij
Approved by:	portmgr
Differential Revision: https://reviews.freebsd.org/D38233

    6e1233b

23:08 Muhammad Moinur Rahman (bofh) 

Mk/**ruby.mk: Switch from USE_RUBY=yes to USES=ruby

Switch from Mk/bsd.ruby.mk to Mk/Uses/ruby.mk

Notable changes are.

- Mk/bsd.ruby.mk is moved to Mk/Uses/ruby.mk.
- USE_RUBY=yes is replaced with USES=ruby.
- USE_RUBY_EXTCONF is replaced with USES=ruby:extconf.
- USE_RUBY_RDOC is replaced with USES=ruby:rdoc.
- USE_RUBY_SETUP is replaces with USES=ruby:setup.
- RUBY_NO_BUILD_DEPENDS and RUBY_NO_RUN_DEPENDS are replaced with
  USES=ruby:{build,none,run}.
- RUBY_REQUIRE isn't used anywhere, so removed.
- USES=gem now implies USES=ruby.

This is mainly the work of yasu@ at https://reviews.freebsd.org/D27863

I have just made some cosmetic changes and ran exp-run to test that the
tree is not in a BROKEN state.

Approved by:	portmgr
Differential Revision:	https://reviews.freebsd.org/D37925

    18c6e18

22:41 Luca Pizzamiglio (pizzamig) 

component: Mk framework

Add check to detect colon in .CURDIR, because it's not supported
this patch detects the colon and shows a proper error message

Reviewed By: #portmgr, tcberner
Differential Revision: https://reviews.freebsd.org/D37500

    93a8625

22:05 Tijl Coosemans (tijl) 

Mk/bsd.port.mk: Pass MASTER_SITE_SUBDIR to submake of makesum target

This fixes make makesum in Linux ports.  Uses/linux.mk only defines
MASTER_SITE_SUBDIR if MASTER_SITES is undefined so it was empty in the
submake.

    5ebd817

16:34 Bryan Drewery (bdrewery) 

Mk/bsd.sanity.mk: Reduce parsing during package builds

This disables bsd.sanity.mk when PACKAGE_BUILDING is set such that it
only is loaded during 'make [all]' or 'make check-sanity'.  It is assumed the
package tool will manually call the target if it wants the check.  Otherwise
we get redundant logic and filesystem lookups from this file for every other
build target.

Prodded by:	mjg

    4ca11c4

14:44 Muhammad Moinur Rahman (bofh) 

Mk/**tex.mk: Convert bsd.tex.mk to USES=tex

- Update all the consumers to use USES=tex
- USE_TEX=yes is the old way of writing USES=tex which has been removed
  and replaced in all ports
- Almost all of the USE_TEX features remains unchanged
- Some consumers had the same variables defined both in the mk
  infrastructure and also in the ports which have been removed from the
  ports as those are redundant.

In case any of the consumers are failing to build please make sure that
the nexessary USES=tex is there. Unlike previous USE_TEX=yes will no
longer load the required VARS for tex and related dependencies.

Reviewed by:	portmgr
Approved by:	portmgr (blanket)

    721e577

08:34 Baptiste Daroussin (bapt) 

hardening: add relro and bind_now features

As usual with features, this can be activated/deactivated via
WITH/WITHOUT_<feature>

Each port can individually mark itself as not supporting the feature
via <feature>_UNSAFE=

    cc0e861

08:22 Baptiste Daroussin (bapt)  Author: Jatin Kataria

features: Add support to build ports as PIE executables.

This will allow utilization of ASLR provided by the kernel.

Sponsored by:	Netflix

    c6e7c89

13:36 Christian Weisgerber (naddy) 

Mk/bsd.port.mk: Use .MAKE.UID instead of calling id(1)

Save an invocation of id(1) by using the built-in .MAKE.UID variable
instead.  Check availability of .MAKE.UID first, since older versions
of bmake (12.x) don't have it yet.

PR:		266942
Approved by:	bapt

    d8c8948

07:48 Rene Ladan (rene) 

Mk: remove ancient 'make update-patches' target.

People should use 'make makepatch' instead which creates patches
with the expected filename and header.

Differential Revision: https://reviews.freebsd.org/D36767

    b74ed0f

11:23 Stefan Eßer (se) 

Mk/bsd.port.mk: support multiple URLs in WWW

The WWW macro was supposewd to hold only one URL pointing to the most
useful starting point for a user searching for additional information,
configuration examples, etc.

Some port maintainers have set the WWW macro to a list of URLs,
breaking assumptions by scripts and tools in the ports system and of
external users of the ports system.

This change allows WWW to hold a list of URLs by only considering the
first list element in places where only a single URL is supported.

This mirrors the previous behavior of only using the first line tagged
with "WWW: " in the pkg-descr file.

Approved by:	portmgr (tcberner)
Differential Revision:	https://reviews.freebsd.org/D36558

    4553009

16:54 Stefan Eßer (se) 

Mk/bsd.port.mk: do not use master site as default for WWW

Maintainers should set WWW to a website with useful information for
users of the package.

The first MASTER_SITE of the port had been considered to be a useful
default value for the WWW variable.

It has been found not to be a generally useful URL though, therefore
stop providing a default value for WWW.

Approved by:	portmgr (tcberner)

    1c4cfbf

14:03 Stefan Eßer (se) 

Mk/bsd.port.mk: Fix quoting of ${COMMENT:Q} in the describe target

The contents of COMMENT will be adequately protected against
interpretation by the shell due to the :Q modifier.

This access to the COMMENT variable should therefore not be enclosed
in double quotes.

Approved by:	portmgr (implicit)

    136a6b0

19:32 Stefan Eßer (se) 

Mk/bsd.ports.mk: Add suppport for WWW in Makefiles

Expect the project website or other relevant URL of a port to be
specified in a WWW macro in its Makefile.

This information used to be available in WWW: lines at the end of
each port's pkg-descr file. By moving it into the Makefile, this
value is easier to access, verify, and maintain.

A WWW: line is added to the "desc" element of package manifests
based on the WWW macro value by the create-manifest.sh script.
This restores the previous contents of this line in the manifest
(as e.g. expected by the Freshports website).

The ports-mgmt/portlint port has been updated in commit 9800743f0
(version 2.19.13) to support the planned introduction of WWW in
port Makefiles.

Approved by:		portmgr (tcberner)
Differential Revision:	https://reviews.freebsd.org/D36434

    ddd0e82

13:52 Rene Ladan (rene) 

cleanup: remove support for FreeBSD 13.0 which expired today.

- Mk/bsd.port.mk: mark 13.0 as unsupported
- Tools/scripts/portsearch: Drop support for FreeBSD <= 4
- archivers/zstd: revert "Fix build on FreeBSD 13.0"
- deskutils/xdg-desktop-portal: remove check for 13.0
- devel/libpeas: remove outdated comment
- editors/imhex: remove compatibility for 13.0
- editors/libreoffice: remove compatibility for 13.0
- editors/openoffice-4: remove compatibility for 13.0
- editors/openoffice-devel: remove compatibility for 13.0
- emulators/linux_base-c7: remove compatiblity for 13.0
- graphics/drm-kmod: remove detection for 13.0
- graphics/gpu-firmware-amd-kmod: do not check 13.0 anymore
- graphics/linux-c7-libdrm: remove support for 13.0
- math/igraph: remove support for 13.0
- net/asterisk16: drop support for ancient FreeBSD versions
- net/asterisk18: drop support for ancient FreeBSD versions
- security/openssl*: drop now obsolete patches
- sysutils/bhyve+: drop support for FreeBSD 13.0
- sysutils/ebsnvme-id: drop support for FreeBSD 13.0
- sysutils/openzfs: remove detection of FreeBSD 13.0
- sysutils/openzfs-kmod: drop detection of FreeBSD 13.0
- www/firefox: generalize pkg-message a bit regarding hgame(4)
- x11/xorg-cf-files: remove support for FreeBSD < 6 (yes, pre-2008)

While here, regenerate patches for:
- x11/xorg-cf-files
- net/asterisk16
- net/asterisk18

While here, remove a stale $Id$ from Tools/scripts/portsearch

Differential Revision: https://reviews.freebsd.org/D36233

Reviewed by:	office (fluffy), x11 (manu), arrowd, brnrd, cperciva, freqlabs,
imp, jbeich, madpilot, nobutaka

    2a09e5b

09:03 Baptiste Daroussin (bapt) 

CONFLICTS_INSTALL: check later for conflicts

Until now, the check of the CONFLICTS_INSTALL was done during the sanity
check, meaning very early in the package building process.

this makes it painful in 2 cases:
1. a port depend at build time on the extraction of this port, it will print
   its warning message along with the default timer, while we will never reach
   the said conflict at all.
2. since the ports tree has been staged, one can even go up to create a valid
   package even if a locally conflicting package is locally installed.

This change make the check and print of the conflicts only happen during the
install phase, the same way the ports tree checks if a previous version is
already installed.

PR:	213890
Discussed with:	tcberner
Reviewed by:	tcberner
Differential Revision:	https://reviews.freebsd.org/D36355

    acf5d27

08:17 Tobias C. Berner (tcberner) 

Mk/bsd.port.mk: add ${LOCALBASE}/share/pkgconfig support

In d48fab59daa56e0b3b6ffecef57a69c32ae9c0a7 ${LOCALBASE}/share/pkgconfig
was added as a valid location for pc files. Chase this change when using
base-pkgconfig files.

    de99fa0

23:05 Adam Weinberger (adamw) 

Framework: Fix typo

    b13c98f

13:21 Baptiste Daroussin (bapt) 

framework: generalize WITH_ code

Make the definition of WITH_ variable (end user actionable) a define
via a generic code
Move the WITH_DEBUG code into its own file Features/debug.mk
Replace USE_LTO into WITH_LTO and move it into Features/lto.mk
Move WITH_SSP into its own Features/ssp.mk

Add a variable to defined which one are activated by default (here SSP)

Reviewed by:	portmgr (tcberner)
Differential Revision:	https://reviews.freebsd.org/D35873

    b26839a

19:14 Tobias C. Berner (tcberner) 

framework: add new variable PKGCONFIG_BASE

The base system started to provide certain pkgconfig files for
components it provides. This new variable allows ports to prefer base
components explicitly using for example

	PKGCONFIG_BASE=foo

This will create a symlink of /usr/libdata/pkgconfig/foo.pc to
${WKRDIR}/.pkgconfig and adding said path to pkgconfigs search path.

This allows us to switch easily between base and port implementation
of different components (say openssl) by simply defining the appropriate
variable in (say ssl.mk).

Reviewed by:		bapt
Differential Revision:	https://reviews.freebsd.org/D35494

    882f167

21:33 Tobias C. Berner (tcberner) 

Mk/bsd.port.mk: fix indentations

Reminder: please use the provdied hooks when working in Mk.

    5b1a3b2

12:52 Baptiste Daroussin (bapt) 

bsd.port.mk: remove FORCE_POST

FORCE_POST was a temporary solution when migrating from pkg_tools to
pkg now that everything can directly enforce when it is executed, it is
not needed anymore (and actually pkg is not looking for it anymore)

    e64dd94

15:30 Bryan Drewery (bdrewery) 

Mk/bsd.port.mk: Fix unchanged options overwriting dialog4ports bg

This was already handled for the changed options case.

    9f1366d

08:54 Emmanuel Vadot (manu) 

flavors: Allow ignoring for specific OSREL

This change allow a ports to have
<flavor>_IGNORE_<OPSYS>_{OSREL,OSREL:R} in their makefile so we
can ignore on specific FreeBSD version.

Approved by:	bapt
Reviewed by:	bapt
Sponsored by:	Beckhoff Automation GmbH & Co. KG

    10034f0

07:23 Baptiste Daroussin (bapt) 

package: fix inverted logic

    b0421f6

07:21 Baptiste Daroussin (bapt) 

package: stop creating the backward compatibility symlinks

Stop creating the "transitionning" backward compatibility symlink
for packages, 9 month passed since we switched to .pkg

Only create the backward compatible symlinks for the bootstrap and
its signature when the compression format is txz. The old bootstrap may
only be looking for those. This should be removed once 13.0-RELEASE is EOLed

    13efc89

12:04 Baptiste Daroussin (bapt) 

bsd.port.mk: Use zstandard as default compression for FreeBSD 14+

The packages are switched from XZ to ZSTD compression, the compression level
is set at the maximum possible because it creates packages which are closed
in size between XZ and ZSTD, the compression time is close as well,
but decompression time is way bigger.

Exp-run:	antoine
Differential revision:	https://reviews.freebsd.org/D35095

    dfae67d

08:03 Tobias C. Berner (tcberner) 

framework: convert bsd.gstreamer.mk to Uses/gstreamer.mk

- convert bsd.gstreamer.mk to Uses/gstreamer.mk
- convert ports tree to make use of USES=gstreamer
- remove duplicate dependency lines from the tree

Differential Revision: https://reviews.freebsd.org/D35097

    ca3f925

11:40 Stefan Eßer (se) 

Mk/bsd.port.mk: simplify conflicts checks logic

I had added support for the specification of a condition and package
name patterns to Version 1.17.2 of the pkg command. This change allows
to simplify the conflicts checks: instead of listing all packages that
match a name pattern and then apply a filter to select the relevant
values, the filter condition is now passed to the pkg command.

This update includes a change to the semantics of the conflicts check
which aligns the output with current package naming practices:

After the introduction of flavors a "same origin exclusion" was
introduced, which removed packages from the conflicts list when
they shared the same origin (without considering the flavor).
This was required to allow the installation of e.g. python modules
for different interpreter versions (which typically use interpreter
version specific sub-directories to store their files), at a time
when there was no strict requirement to have non-colliding package
base names.

The "same origin exclusion" is wrong for ports with conflicting
flavors, e.g. devel/git where only one flavor may be installed at
any time - but the conflict is ignored due to the same origin of
all the different git packages.

Since all packages are now required to have a distinct base name
(e.g. by using a prefix like "py38-" instead of the prior "py-"),
a "same package base name exclusion" can be used to make the
conflicts check stricter and to correctly report the conflict if
for example some git flavor is installed and the installation of
another one is attempted.

An update of the documentation of the CONFLICTS* variables that
describes the "same package base name exclusion" has been committed to
the porter's handbook.

The Makefiles of many flavored ports could be simplified as described
in review D31303 (https://reviews.freebsd.org/D31303), since the
complexity of those definitions results from the exclusion of the
currently built package base name from the CONFLICTS definition,
which was unneeded before (due to the "same origin exclusion",
which made all these CONFLICTS definitions void, anyway) and is now
correctly dealt with after this commit (due to the "same package
base name exclusion").

This patch has been first put up for review in October of 2021, with
a comment that it should not be applied before pkg-1.17.2 (or newer)
can be assumed to be generally used.

Bapt@ accepted the change but later requested the MINIMAL_PKG_VERSION
to be adjusted to require pkg-1.17.2 (as included in this commit).

Due to recent white-space changes in bsd.port.mk the latest patch
uploaded for review does no longer cleanly apply. This commit contains
an updated version that matches the white-space changes (indentation
of .if / .else / .endif and other elements).

[This change had previously been applied as commit e03f85dbc9c, but
during a last minute white space adjustment 1 line had been lost.
This commit applies the change as has been accepted in the review,
updated to match the recent white-space changes.]

Approved by:    portmgr (bapt)
Differential Revision:  https://reviews.freebsd.org/D32694

    d21825d

11:34 Stefan Eßer (se) 

Mk/bsd.port.mk: revert commit e03f85dbc9cc

While adjusting for white-space changes one .if conditon has been
lost.

Revert and re-apply in a follow-up commit with the missing line
restored.
Approved by:	portmgr (implicit)

    5614638

11:18 Stefan Eßer (se) 

Mk/bsd.port.mk: simplify conflicts checks logic

I had added support for the specification of a condition and package
name patterns to Version 1.17.2 of the pkg command. This change allows
to simplify the conflicts checks: instead of listing all packages that
match a name pattern and then apply a filter to select the relevant
values, the filter condition is now passed to the pkg command.

This update includes a change to the semantics of the conflicts check
which aligns the output with current package naming practices:

After the introduction of flavors a "same origin exclusion" was
introduced, which removed packages from the conflicts list when
they shared the same origin (without considering the flavor).
This was required to allow the installation of e.g. python modules
for different interpreter versions (which typically use interpreter
version specific sub-directories to store their files), at a time
when there was no strict requirement to have non-colliding package
base names.

The "same origin exclusion" is wrong for ports with conflicting
flavors, e.g. devel/git where only one flavor may be installed at
any time - but the conflict is ignored due to the same origin of
all the different git packages.

Since all packages are now required to have a distinct base name
(e.g. by using a prefix like "py38-" instead of the prior "py-"),
a "same package base name exclusion" can be used to make the
conflicts check stricter and to correctly report the conflict if
for example some git flavor is installed and the installation of
another one is attempted.

An update of the documentation of the CONFLICTS* variables that
describes the "same package base name exclusion" has been committed to
the porter's handbook.

The Makefiles of many flavored ports could be simplified as described
in review D31303 (https://reviews.freebsd.org/D31303), since the
complexity of those definitions results from the exclusion of the
currently built package base name from the CONFLICTS definition,
which was unneeded before (due to the "same origin exclusion",
which made all these CONFLICTS definitions void, anyway) and is now
correctly dealt with after this commit (due to the "same package
base name exclusion").

This patch has been first put up for review in October of 2021, with
a comment that it should not be applied before pkg-1.17.2 (or newer)
can be assumed to be generally used.

Bapt@ accepted the change but later requested the MINIMAL_PKG_VERSION
to be adjusted to require pkg-1.17.2 (as included in this commit).

Due to recent white-space changes in bsd.port.mk the latest patch
uploaded for review does no longer cleanly apply. This commit contains
an updated version that matches the white-space changes (indentation
of .if / .else / .endif and other elements).

Approved by:	portmgr (bapt)
Differential Revision:	https://reviews.freebsd.org/D32694

    e03f85d

10:00 Tobias C. Berner (tcberner) 

framework: cleanup conditional-indentations in Mk/

Run Tools/scripts/indent_make_if.pl on all of Mk.

These white space changes contribute greatly to the readability of those files.
As we have a version control system, finding out the reasons for the changes
prior to these white space changes is still easily possible

Differential Revision:	https://reviews.freebsd.org/D35024
Reviewed by:		portmgr (rene, bapt)

    aa25396

15:53 Rene Ladan (rene) 

all: drop support for EOL FreeBSD 12.2

- Mk/bsd.port.mk: bump minimal FreeBSD version to 12.3,
  update an example
- sysutils/lsof: drop support for ancient FreeBSD releases.
- multimedia/ustreamer: remove inline patch for 12.2
- x11/wayland-logout: remove support for FreeBSD < 12.3
- sysutils/bhyve+: remove support for FreeBSD 12.2
- databases/clickhouse: remove support for FreeBSD 12.2
- databases/mariadb106-server: remove support for FreeBSD 12.2
- devel/cvsd: no need to test for FreeBSD >=5 anymore
- devel/imake: no need to support a.out anymore
- japanese/kterm: no need to support FreeBSD <= 9
- math/igraph: remove support for FreeBSD 12.2
- net/onedrive: remove support for FreeBSD 12.2
- security/ipsec-tools: no need to test for FreeBSD >= 11
- emulators/rpcs3: Revert "emulators/rpcs3: unbreak on FreeBSD 12.2 after
49f593b2f77f"

Reviewed by:	brnrd, fluffy, jbeich, ler, yuri, x11 (zeising)
Approved by:	portmgr (implicit)
Differential Revision:	https://reviews.freebsd.org/D34523

    74c02f1