15:22 tobik 

lang/rust: Update to 1.41.1

- Force rebuild all consumers to fix potential miscompilations with
  1.41.0
- Enable SOURCES by default.  The sources are indexed by RLS and
  required for it to function properly, so they should be available
  by default.  This also makes sure we test the option properly.
- Remove implied --config=config.toml from x.py args
- Switch to the upstreamed backtrace crate patches like rust-nightly
- Enable WASM by default [0]
- Strip libraries (D23650) [1]
- Simplify plist generation (D23735) [2]

Changes:	https://blog.rust-lang.org/2020/02/27/Rust-1.41.1.html
Submitted by:	mikael [0,1,2]
With hat:	rust
Differential Revision:	https://reviews.freebsd.org/D23835

 

20:00 tobik 

lang/rust: Update to 1.41.0

- Force rebuild all consumers to catch regressions early
- Switch to cross-compiled (from amd64) bootstraps for all
  architectures generated with the incoming lang/rust-bootstrap
- Update cargo-c to 0.5.2 to unbreak librav1e build
- Make use of regular MAKE_ENV/TEST_ENV in lang/rust
- Turn on RUST_BACKTRACE in lang/rust and USES=cargo to hopefully
  produce more useful failure logs when something panics during
  builds

Changes:	https://blog.rust-lang.org/2020/01/30/Rust-1.41.0.html
Tested by:	mikael, tobik
With hat:	rust
Differential Revision:	https://reviews.freebsd.org/D23385

 

09:08 tobik 

Mk/Uses/cargo.mk: Unbreak install with rust-nightly

Remove yet another install metadata file.  This should all be
replaced with --no-track once it is part of lang/rust.

https://github.com/rust-lang/cargo/pull/7560

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: .crates2.json

 

18:36 tobik 

lang/rust: Add COMPAT_FREEBSD11 canary

This attempts to provide a nicer error message for the subset of
users who build their own kernels without COMPAT_FREEBSD11 and then
attempt to build lang/rust.  The Rust ecosystem currently uses
pre-ino64 syscalls, so building lang/rust without COMPAT_FREEBSD11
is not going to work.

The error message for this is non-obvious and there is a new bug
for this at least every 1-2 months.  Hopefully this will improve
the situation a little.

Cargo and Gecko ports are similarly affected, so add the pre-build
check to them too.

Reviewed by:	jbeich, mikael.urankar@gmail.com
Tested by:	madpilot (negative case)
Approved by:	gecko (jbeich)
Differential Revision:	https://reviews.freebsd.org/D23100

 

16:14 tobik 

lang/rust: Update to 1.40.0

- Force rebuild all consumers to catch regressions early

Thanks to Mikael Urankar for providing updated bootstraps for
aarch64, armv6, armv7, powerpc64.

Changes:	https://blog.rust-lang.org/2019/12/19/Rust-1.40.0.html
Tested by:	mikael.urankar@gmail.com, tobik
With hat:	rust
Differential Revision:	https://reviews.freebsd.org/D22843

 

08:43 tobik 

Mk/Uses/cargo.mk: Do not override do-configure

Cargo vendoring can be useful even for ports that use other build
systems like Meson to call Cargo for the actual build.  Often they
use the framework's default do-configure which USES=cargo should
not overwrite.

Remove hacks from games/jaggedalliance2 and x11/squeekboard.

Reviewed by:	jbeich
Differential Revision:	https://reviews.freebsd.org/D22619

 

22:12 tobik 

lang/rust, Mk/Uses/cargo.mk: Drop gmake build dependency for backtrace-sys

The backtrace-sys crate no longer needs gmake since 0.1.20.
sysutils/flowgger still uses backtrace-sys-0.1.14.  Since it is the
only USES=cargo port left that needs it, move the gmake dependency
directly to it instead.

lang/rust currently has backtrace-sys-0.1.30.  It also vendors
jemalloc-sys (which also needs gmake to build) but it is hidden
behind rustc's jemalloc feature which we do not currently activate.
It should be safe to remove gmake in lang/rust too.

PR:		242267
Reported by:	mikael.urankar@gmail.com

 

15:02 pkubaj 

Mk/bsd.port.mk: detect powerpc64 abi

We'll have a new abi on ppc64 soon (ELFv2) which is incompatible with the ELFv1
abi. We need to detect the abi on which we build stuff.

Submitted by:	mikael_urankar@gmail.com
Approved by:	portmgr (earlier version)
Differential Revision:	https://reviews.freebsd.org/D22039

 

21:08 tobik 

Mk/Uses/cargo.mk: Add CARGO_GIT_SUBDIR hook to provide hints for CARGO_USE_GIT*

This is a workaround to add some manual "support" for Cargo projects
that use workspaces where the current method of patching is not
good enough as it causes the various Cargo.toml to point to the
wrong directory.  With CARGO_GIT_SUBDIR maintainers can control the
patching process a little and point things to the correct subdirectories.

CARGO_GIT_SUBDIR=	<group>:<crate name>:<subdir under ${WRKSRC_group}>

This is needed for alacritty 0.4.0-rc2 where the glutin sources are
under ${WRKSRC_glutin}/glutin and not just ${WRKSRC_glutin}.  This
causes the following issue:

error: failed to load source for a dependency on `glutin`

Caused by:
  Unable to update .../x11/alacritty/work/glutin-7e479d

Caused by:
  found a virtual manifest at `.../x11/alacritty/work/glutin-7e479d/Cargo.toml`
instead of a package manifest

For glutin we would set CARGO_GIT_SUBDIR=glutin:glutin:glutin to
work around this problem and point the build to
.../x11/alacritty/work/glutin-7e479d/glutin instead.

 

18:07 tobik 

lang/rust: Update to 1.39.0

- Force rebuild all consumers to catch regressions early
- Partially apply D20792 in preparation for PPC_ABI support
- Add LibreSSL 3.0.x support [1]

Thanks to Mikael Urankar for providing updated bootstraps for
aarch64, armv6, armv7, powerpc64.

Changes:	https://blog.rust-lang.org/2019/11/07/Rust-1.39.0.html
PR:		241411 [1]
Tested by:	mikael.urankar@gmail.com, tobik
With hat:	rust
Differential Revision:	https://reviews.freebsd.org/D22240

 

12:51 tobik 

Mk/Uses/cargo.mk: Handle git URLs that end with /

Fix CARGO_USE_GIT{HU,LA}B when Cargo.toml has URLs that end with
/.  This is needed for audio/spotifyd 0.2.16 which has an entry
like

structopt = { git = "https://github.com/TeXitoi/structopt/", rev = "..." }

 

09:35 tobik 

lang/rust: Update to 1.38.0

- Force rebuild all consumers to catch regressions early

Thanks to Mikael Urankar for providing updated bootstraps for
aarch64, armv6, armv7, powerpc64.

Changes:	https://blog.rust-lang.org/2019/09/26/Rust-1.38.0.html
Tested by:	jbeich, mikael.urankar@gmail.com, tobik
With hat:	rust
Differential Revision:	https://reviews.freebsd.org/D21778

 

12:39 tobik 

Mk/Uses/cargo.mk: Add gmake build dependency for jemalloc-sys

 

14:30 tobik 

lang/rust: Update to 1.37.0

- Force rebuild all consumers to catch regressions early

Thanks to Mikael Urankar for providing updated bootstraps for
aarch64, armv6, armv7, powerpc64.

Changes:	https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html
Tested by:	jbeich, tobik, greg@unrelenting.technology (aarch64)
With hat:	rust
Differential Revision:	https://reviews.freebsd.org/D21247

 

08:12 tobik 

Mk/Uses/cargo.mk: Add support for CARGO_USE_GITLAB/GL_TUPLE to cargo-crates

 

08:18 tobik 

www/geckodriver: Bump libc crate version again

$ make check-sanity
/!\ geckodriver-0.24.0: Makefile warnings, please consider fixing /!\

CARGO_CRATES=libc-0.2.43 may be unstable on aarch64 or not build on armv6,
armv7, powerpc64. Consider updating to the latest version (higher than 0.2.49).

This will give it at least a chance to build on tier 2 archs.  We
bumped libc earlier but this was regressed on in r506813.

The libc warnings in USES=cargo do not seem to be enough.  Make
them errors instead.

With hat:	rust

 

08:46 tobik 

Mk/Uses/cargo.mk: Handle distfile group names properly

Crates like openssl-src-111.3.0+1.1.1c have characters not in
[a-zA-Z0-9].  Use the complement of [a-zA-Z0-9] instead of adding
+ to the list of chars [-.] we currently handle.

 

14:41 tobik 

lang/rust: Update to 1.36.0

- Force rebuild all consumers to catch regressions early

Thanks to Mikael Urankar for providing updated bootstraps for
aarch64, armv6, armv7, powerpc64.

Changes:	https://blog.rust-lang.org/2019/07/04/Rust-1.36.0.html
Tested by:	jbeich, mikael.urankar@gmail.com
With hat:	rust
Differential Revision:	https://reviews.freebsd.org/D20810

 

10:56 tobik 

Mk/Uses/cargo.mk: Add CARGO_INSTALL_PATH knob

It can be used to overwrite the --path argument when calling `cargo
install` to point cargo to different local crates to install.  This
might be necessary when ${WRKSRC}/Cargo.toml is only a virtual
manifest.

 

07:57 tobik 

Mk/Uses/cargo.mk: QoL improvement during makepatch

Cargo normalizes Cargo.toml when crates are published.  It creates
a Cargo.toml.orig to preserve the original.  Rename them to not
interfere with makepatch and avoid creating a bunch of useless
and wrong files/patch-*Cargo.toml.

Suggested by:	mat

 

03:25 tobik 

lang/rust: Update to 1.35.0

- Force rebuild all consumers to catch regressions early

Thanks to Mikael Urankar for providing updated bootstraps for
aarch64, armv6, armv7, powerpc64.

Changes:	https://blog.rust-lang.org/2019/05/23/Rust-1.35.0.html
Reviewed by:	jbeich
Tested by:	pkubaj (powerpc64), mikael.urankar@gmail.com (aarch64)
With hat:	rust
Differential Revision:	https://reviews.freebsd.org/D20332

 

03:12 tobik 

lang/rust: Update to 1.34.2

- While here add patches from [1] for LibreSSL 2.9.1 support

[1] https://github.com/sfackler/rust-openssl/pull/1097

Changes:	https://blog.rust-lang.org/2019/05/13/Security-advisory.html
Changes:	https://blog.rust-lang.org/2019/05/14/Rust-1.34.2.html
PR:		237495 [1]
Security:	37528379-76a8-11e9-a4fd-00012e582166

 

07:33 tobik 

Mk/Uses/cargo.mk: Push lib dependencies back down into ports

Some crates are optional via Cargo features or are only used during
tests, however the framework has no way to discriminate between
test or run dependencies using just CARGO_CRATES leading to more
run dependencies than necessary for some packages.  With more ported
Rust applications it's time to let individual ports make that
decision now.

The environmental setup to use dependencies from ports instead of
bundled ones and implied build dependencies (cmake, gmake, pkgconf)
are left in place for now.

Assign cargo.mk to rust@ while here.

 

19:39 tobik 

lang/rust: Update to 1.34.0

- Update devel/racer to latest version that can build with 1.34.0
- Drop no longer needed patch from textproc/ripgrep
- Force rebuild all consumers to catch regressions early

Thanks to Mikael Urankar for providing updated bootstraps for
aarch64, armv6, armv7, powerpc64.

Changes:	https://blog.rust-lang.org/2019/04/11/Rust-1.34.0.html
Reviewed by:	jbeich
With hat:	rust
Differential Revision:	https://reviews.freebsd.org/D19850

 

06:28 tobik 

Mk/Uses/cargo.mk: Add GitLab support and drop CARGO_GH_CARGOTOML

- Add a CARGO_USE_GITHUB equivalent for GitLab instances,
  CARGO_USE_GITLAB
- Replace CARGO_GH_CARGOTOML with a ${FIND} and just patch
  all Cargo.toml under ${WRKDIR}.  It is too tedious to find all
  the Cargo.toml that need patching manually due to transitive
  dependencies.

 

17:31 jbeich 

USES=cargo to omit -C link-arg if LDFLAGS is empty

DPorts overrides USE_GCC logic and doesn't opt in into SSP_CFLAGS, so
its LDFLAGS are empty by default.

PR:		236529
Reported by:	Antonio Huete Jimenez

 

00:35 tobik 

Mk/Uses/cargo.mk: Require ports gcc on powerpc64 same as lang/rust

PR:		235063

 

18:51 jbeich 

lang/rust: update to 1.33.0

- www/firefox temporarily loses SIMD in charset conversion, see
  https://bugzilla.mozilla.org/show_bug.cgi?id=1521249
- Force rebuild all consumers to catch regressions early

Changes:	https://blog.rust-lang.org/2019/02/28/Rust-1.33.0.html
Tested by:	Mikael Urankar (aarch64, armv6, armv7, powerpc64), Piotr Kubaj
(powerpc64)
Approved by:	rust (tobik)
Differential Revision:	https://reviews.freebsd.org/D19354

 

18:47 jbeich 

USES=cargo to update libc to 0.2.49 for Tier2

PR:		235063
Differential Revision:	https://reviews.freebsd.org/D19309

 

12:04 tobik 

Add a CRATESIO entry for crates.io to bsd.sites.mk

Switch cargo.mk over to it.

Differential Revision:	https://reviews.freebsd.org/D19133

 

09:33 ale 

Don't break when there are multiple libc versions in crates.

 

12:19 tobik 

Mk/Uses/cargo.mk: Silence "you need USES=ssl" QA warning

We already have it via CARGO_CRATES=openssl-sys-*.

Differential Revision:	https://reviews.freebsd.org/D19044

 

19:50 jbeich 

lang/rust: update to 1.32.0

- devel/racer no longer needs to dowgrade rustc-ap-syntax
- Force rebuild all consumers to catch regressions early

Changes:	https://blog.rust-lang.org/2019/01/17/Rust-1.32.0.html
Approved by:	rust (tobik)
Differential Revision:	https://reviews.freebsd.org/D18858

 

04:00 jbeich 

Allow overriding rust dependency

Add DEFAULT_VERSIONS+=rust=rust-nightly to make.conf(5) if you want to
build consumers using lang/rust-nightly.

Approved by:	rust (tobik)
MFH:		2019Q1 (avoid merge conflicts during www/firefox updates)
Differential Revision:	https://reviews.freebsd.org/D18634

 

12:08 tobik 

Mk/Uses/cargo.mk: Fix install for Rust 2018 edition applications

`cargo install` currently fails with:

error: Using `cargo install` to install the binaries for the package
in current working directory is no longer supported, use `cargo
install --path .` instead.

Also see https://github.com/rust-lang/cargo/issues/5327

 

18:20 jbeich 

USES=cargo to respect CC for linking

Reported by:	tijl
Approved by:	rust (tobik)
Differential Revision:	https://reviews.freebsd.org/D18528

 

17:11 jbeich 

lang/rust: update to 1.31.0

- devel/racer no longer needs to dowgrade rustc-ap-syntax
- Force rebuild all consumers to catch regressions early

Changes:	https://blog.rust-lang.org/2018/12/06/Rust-1.31.0.html
Approved by:	rust (tobik)
Differential Revision:	https://reviews.freebsd.org/D18427

 

17:07 jbeich 

USES=cargo to convert LDFLAGS into RUSTFLAGS

Approved by:	rust (tobik)
Differential Revision:	https://reviews.freebsd.org/D18039

 

11:05 tobik 

Warn maintainers when OpenSSL 1.1.1 support is missing when using
an outdated openssl < 0.10.4 crate.

Submitted by:	jbeich
Differential Revision:	https://reviews.freebsd.org/D18292

 

16:18 tobik 

Bump minimum Rust version after rP482993

 

18:47 tobik 

Bump minimum Rust version in Mk/Uses/cargo.mk

Given that at least ripgrep will soon require Rust >= 1.28.0 [1]
and given the recently discovered buffer overflow vulnerability in
the standard library of Rust < 1.29.1 [2] bump it to 1.29.1 to avoid
surprises.

[1] https://github.com/BurntSushi/ripgrep/issues/1019
[2]
https://groups.google.com/forum/#!topic/rustlang-security-announcements/CmSuTm-SaU0

 

11:16 jbeich 

lang/rust: unbundle libgit2/libssh2

- libgit2 in ports is nowadays newer than bundled version
- libssh2 was already unbundled until 1.29.0 update
- Unbundle libssh2 for USES=cargo (unused atm)

PR:		231411
Approved by:	rust (dumbbell, tobik)

 

07:26 tobik 

Mk/Uses/cargo.mk: Let 'cargo-crates' generate Cargo.lock if it does not exist

This will make maintaining ports easier when upstream does not
provide a Cargo.lock on its own.

It uses the crate registry and will output the newest crate versions
available based on the restrictions in Cargo.toml.  As such subsequent
runs of `make cargo-crates` might not generate the same output.
Upstream should still be encouraged to provide Cargo.lock if possible.

Requested by:	mat
Differential Revision:	https://reviews.freebsd.org/D17003

 

19:55 tobik 

Mk/Uses/cargo.mk: Fix crate name and version split (take 2)

cargo.mk is still too eager in splitting a crate's name and version
in two when the name contains a dash followed by a number.  For
example with utf-8-0.7.4 the wrong URL ends up being used in
MASTER_SITES

  .../utf/8-0.7.4/download/...

instead of

  .../utf-8/0.7.4/download/...

PR:		230413
Reported by:	Thomas Hurst <tom@hur.st>

 

09:56 tobik 

Mk/Uses/cargo.mk: Encode more crate build dependencies

- Add build/lib dependencies, environment variables to ports using
  the backtrace-sys, freetype-sys, gettext-sys, onig_sys,
  thrussh-libsodium crates instead of doing this individually for
  every port.

- Add a DEV_WARNING when using libc versions < 0.2.37 to prevent
  instability of Rust applications on 12.0-CURRENT [1]

- Sort cargo-crates-licenses output

Reviewed by:	pizzamig, jbeich [1]
Differential Revision:	https://reviews.freebsd.org/D15463

 

11:06 tobik 

Mk/Uses/cargo.mk: Respect CPUTYPE

C and C++ code can be built targeting newer CPUs if user defined
CPUTYPE in make.conf.  Let's opt-in for Rust as well.

PR:		223939
Submitted by:	jbeich

 

14:05 madpilot 

Retire WITHOUT_DEBUG flag.

The flag has partial support across the tree, and the same effect
can be obtained by using ".undef WITH_DEBUG".

Reviewed by:		mat, rene
Approved by:		portmgr (rene)
Differential Revision:	https://reviews.freebsd.org/D12548

 

10:51 tobik 

Mk/Uses/cargo.mk: Fix crate name and version split

cargo.mk is a little too eager in splitting a crate's name and version
in two when the version contains a dash (e.g. csv-1.0.0-beta.4) and
the wrong URL ends up being used in MASTER_SITES e.g.

.../csv-1.0.0/beta.4/download/...

instead of the correct one

.../csv/1.0.0-beta.4/download/...

Reviewed by:	dumbbell
Differential Revision:	https://reviews.freebsd.org/D12628

 

13:57 dumbbell 

Mk/Uses/cargo.mk: Fix version of Rust which started to ship Cargo

Cargo started to ship with Rust in 1.19.0_2. I forgot to indicate the
port revision in the 1.19.0_2 commit.

Reported by:	jbeich@
Differential Revision:	https://reviews.freebsd.org/D12460

 

18:01 dumbbell 

lang/rust: Install Cargo + use bundled crates

This port now provides Cargo. This is the recommended now because Cargo
won't be provided separately in the future.

To build Cargo, we set `extended = true` in `config.toml`. As a side
effect, this flag also installs Rust source code. The port has a new
`SOURCES` option (disabled by default) to keep those sources.

As a consequence of this, `devel/cargo` is removed. Several ports
and Makefiles in Mk were updated to depend on `lang/rust` instead of
`devel/cargo`.

The other big change in this patch is the use of the bundled crates,
instead of relying on Cargo's registry (which was part of the distfiles,
in order to allow offline builds). So now, we don't need to prepare the
registry when updating this port.

This has several other benefits:
    * It fixes the build with sudo(8).
    * It fixes the use of the ino-64 patch (it was not applied to the
      registry, thus not used).

Compilation errors were fixed in the ino-64 patch.

Various `.cargo-checksum.json` files are updated after the sources are
patched (FBSD10_FIX, ino-64, and so on). This fixes builds which were
failing with errors such as:

    error: the listed checksum of
`.../rustc-1.19.0-src/src/vendor/lzma-sys/xz-5.2.3/build-aux/config.rpath` has
changed:
    expected: c8b4c017079da9dfb3086a0583e60ffe736184d89005dc5973f0bb0fd17c04bb
    actual:   561b00eb30ecaef2c9da17bc195e7d2a7ea63facea38ea9849fbb0ed340bebba

PR:		221088
Reported by:	joneum@, nwhitehorn@, romain@,
		Ekaterina Vaartis <vaartis@cock.li>,
		david@catwhisker.org,
		fullermd@over-yonder.net,
		rum1cro@yandex.ru,
		w.schwarzenfeld@utanet.at
Differential Revision:	https://reviews.freebsd.org/D11783

 

16:22 tobik 

Add USES=cargo to make creating ports of Rust applications easier

Approved by:	mat (mentor)
Reviewed by:	dumbbell, mat
Differential Revision:	https://reviews.freebsd.org/D11162