08:35 Baptiste Daroussin (bapt) 

mail/mlmmj: reduce the number of dependencies necessary to build

Use the "testing" Feature" to activate testing

PR:	278665

    2612aa2

18:43 Vladimir Druzenko (vvd) 

Mk/bsd.options.mk: add possibility set default options for other (not defined in
port) arches

New port option OPTIONS_DEFAULT_OTHER_ARCHS.
Examples are at review.

Approved by:		arrowd (portmgr, mentor)
Differential Revision:	https://reviews.freebsd.org/D44228

    cab93d2

12:11 Mathieu Arnold (mat) 

Mk/bsd.options.mk: fix typo

    0649234

21:58 Luca Pizzamiglio (pizzamig) 

component: add SUBPACKAGES

This commit add SUBPACKAGES support to the framework.

Fix users of _LICENSE_DIR
Fix multi/dual license
Add annotation to packages about being a subpkg
Make do-depends aware of the subpackages
Add PKGBASE.subpkg variable
Fix actual-package-depends target
Fix dependencies in sub-packages
Implement LICENSE support
Fix PLIST_FILES.subpkg
Make DESCR.subpkg warning message shorter
Add SUBPACKES to the list of OPTIONS_HELPERS
Fix _strip_perms
Simplify METADIR as in the original patch
Fix _PLIST
Fix the case when there are no subpackages
Fix typo
Fix _PKGDIR initialization
Fix PLIST
Fix typo in RE
Fix METADIR
Fix type in PKGFILE
Fix [build|run]-depends-list targets
Initial import of the subpackage framework
This import is based on https://reviews.freebsd.org/D16457

PR:		275735
Differential Revision:	https://reviews.freebsd.org/D40549

    4756476

18:55 Felix Palmen (zirias) 

bsd.sites.mk: Support tag names with USE_GITLAB

Since quite some time, it's possible to download generated tarballs from
gitlab for a tag name without knowing the corresponding git hash. This
is preferable because you have a single source of truth about the
software version.

Support this by replacing GL_COMMIT with GL_TAGNAME which also accepts a
commit hash, similar to USE_GITHUB. Unfortunately, there's a catch, the
DISTFILE must be named exactly: ${GL_PROJECT}-${GL_TAGNAME}.tar.bz2,
otherwise it extracts in a directory that contains the commit hash. So,
we can't add the gitlab account or the revision suffix to make it work.

Therefore, detect whether GL_TAGNAME contains a commit hash, and if it
does, use the old behavior of deriving DISTNAME and DISTFILES.

Document in CHANGES, also add a DEV_WARNING similar to USE_GITHUB when
there's an URL in MASTER_SITES that looks like a gitlab URL. With
support for tags, there shouldn't be any reason left to hardcode such an
URL in MASTER_SITES.

PR:			248967
Approved by:		portmgr (tcberner, mentor)
Differential Revision:	https://reviews.freebsd.org/D37077

    16bde07

09:16 Gleb Popov (arrowd) 

Uses/cabal.mk: Rename `EXECUTABLES` to `CABAL_EXECUTABLES`.

Approved by: tcberner

Differential Revision: https://reviews.freebsd.org/D36079

    505ecf2

10:00 Tobias C. Berner (tcberner) 

framework: cleanup conditional-indentations in Mk/

Run Tools/scripts/indent_make_if.pl on all of Mk.

These white space changes contribute greatly to the readability of those files.
As we have a version control system, finding out the reasons for the changes
prior to these white space changes is still easily possible

Differential Revision:	https://reviews.freebsd.org/D35024
Reviewed by:		portmgr (rene, bapt)

    aa25396

10:57 Tobias Kortkamp (tobik) 

Mk/bsd.options.mk: Fix typos in comment

    bdc3d57

14:27 Mathieu Arnold (mat) 

framework: Remove $FreeBSD$

Where appropriate fiddle with a few other things.

    5d33e04

16:30 rene 

Clean up support for FreeBSD 11.2.

While here, modernize some comments in Mk/bsd.*.mk.

Note that graphics/drm-fbsd11.2-kmod is not renamed yet, this was somewhat
under discussion.

Submitted by:	rene
Reviewed by:	antoine, jbeich, mat, zeising
Differential Revision:	https://reviews.freebsd.org/D21974

 

14:39 arrowd 

Introduce USES=cabal and use it to build Haskell applications.

PR:		230186
Reviewed by:	mat, tcberner
Approved by:	tcberner (mentor)
Differential Revision:	https://reviews.freebsd.org/D19730

 

14:28 tobik 

Flag nop options helpers that appear after bsd.port.options.mk as DEV_ERRORs

Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D19553

 

22:07 jbeich 

Add option helper for MESON_ARGS = -Dfoo=enabled

feature options define combo like auto/yes/no in a standand way.
In other words, upstream projects of ports that use _MESON_YES are
supposed to migrate to _MESON_ENABLED.

https://mesonbuild.com/Build-options.html#features

Reviewed by:	tobik (implicit)
Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D19127

 

20:33 sunpoet 

Add TEST_DEPENDS support

Differential Revision:	https://reviews.freebsd.org/D18398
Approved by:	portmgr (mat)

 

14:40 mat 

Do not enable options that do not exist.

Differential Revision:	https://reviews.freebsd.org/D13953

 

13:16 mat 

Only set %%PORTDOCS%%/%%PORTEXAMPLES%% if a DOCS/EXAMPLES option is defined.

PR:		230864
Submitted by:	mat
exp-runs by:	antoine
Differential Revision:	https://reviews.freebsd.org/D13651

 

12:22 mat 

Remove automagic WITH_DEBUG activation with the DEBUG option.

- People keep adding options named DEBUG to enable verbose things in
  their ports and have no idea it also enables WITH_DEBUG.
- We already have WITH_DEBUG_PORTS that can enable WITH_DEBUG on a per
  port basis.

Differential Revision:	https://reviews.freebsd.org/D16829

 

06:50 ultima 

* Add USE_GITLAB for fetching from www.gitlab.com and GitLab deployed sites.

Reviewed by:	mat
Approved by:	portmgr (mat)
Relnotes:	yes
Differential Revision:	https://reviews.freebsd.org/D12162

 

07:40 mat 

Remove support for variables that have been deprecated for a while.

variables                  deprecation       revision
WITHOUT_NLS                2013-12-13        r336337
WITH_/WITHOUT_             2014-02-24        r345870
NOPORT(DOC|EXAMPLE)S       2014-04-19        r351587
WITH_BDB_VER               2016-05-02        r414444
OVERRIDE_LINUX_BASE_PORT   2016-09-05        r421387
WITH_OPENSSL_(BASE|PORT)   2016-06-16        r416965

While there, add an ERROR variable that works like DEV_ERROR, but for
user facing errors, and move NOPORTDOCS,
NOPORTEXAMPLES and WITHOUT_NLS to it.

Cleanup bsd.sanity.mk a bit.

Fix fallout.

PR:		224613
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D13490

 

14:19 bapt 

Add an option helper for BINARY_ALIAS

 

19:41 bdrewery 

Follow-up r454266: Sort and remove duplicates for [DE]SELECTED_OPTIONS.

Some ports like graphics/povray-meta do funky things like add the same
option into PORT_OPTIONS twice.  This also avoids a new leading blank
space in some cases.

With hat:	portmgr

 

19:13 bdrewery 

Fix [DE]SELECTED_OPTIONS to lazily evaluate as late as possible.

If a port modifies OPTIONS_UNSET after including bsd.port.options.mk
then these values were wrong even though all of 'showconfig',
'pretty-print-config', and the package generated all had the expected
options.

Only Poudriere and synth use these variables for incremental build checks.

Reviewed by:	sjg, bapt
Approved by:	portmgr (bapt)
Differential Revision:	https://reviews.freebsd.org/D13092

 

18:12 kwm 

Meson is picky about the arguments of build options.

For example a option of the "boolean" type only accepts true/false this
 option is covered by ${opt}_MESON_TRUE/_FALSE.

Add option helpers ${opt}_MESON_YES/_NO for the "combo" type which
 accepts yes and no.

Approved by:		portmgr@ (mat@)
Differential Revision:	https://reviews.freebsd.org/D11078

 

20:24 kwm 

* Fix MESON_TRUE/MESON_FALSE comment, to mention the actualy meson argument.
* Rework option hanlding to be more clear and to avoid double negative.

Submitted by:	antoine@
Approved by:	antoine@

 

18:55 kwm 

Introduce new "meson" USES.

This uses will handling building software that uses the meson
build system. Expand the option framework to handle MESON options.

Approved by:	portmgr (swills@)

Differential Revision:	https://reviews.freebsd.org/D104091

 

09:01 antoine 

Revert r398829: do not change OPTIONS when DEVELOPER=yes
Having a TEST option is usually a bad idea

With hat:	portmgr

 

12:46 bapt 

Revert r429298 it has some unexpected side effects which I do not have time to
fix yet

Approved by:	portmgr (implicit)

 

00:30 bapt 

Make the ports infrastructure accept at least 3 level ports

Approved by:	portmgr (rene
Differential Revision:	https://reviews.freebsd.org/D8889

 

14:45 mat 

Add an OPTIONS_EXCLUDE_opsys_osrel.

Sponsored by:	Absolight

 

12:19 mat 

Change the way opt_USE is parsed.

This makes it possible to have:
opt_USE=  ldconfig=${PREFIX}/lib/foo/bar

Before this, it would have ended up doing USE_LDCONFIG=/lib/foo/bar,
without ${PREFIX}.

Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D8169

 

13:28 mat 

Don't duplicate the list of options helpers.

People who come here can read the code, they will be able to understand
the variable definition.

Sponsored by:	Absolight

 

12:50 mat 

Add GH_SUBDIR to option helpers.

Submitted by:	lightside gmx com
Sponsored by:	Absolight

 

12:16 mat 

Move USE_BDB and PLIST_DIRSTRY to the unsupported section, all the ports
have been converted.

Sponsored by:	Absolight

 

16:23 mat 

Add opt_CMAKE_BOOL_OFF, oposite of opt_CMAKE_BOOL.

PR:		210576
Sponsored by:	Absolight

 

22:23 adamw 

Add an opt_CMAKE_BOOL options helper.

  SOMEOPT_CMAKE_BOOL=	WITH_FOO BAR

expands to:

  -DWITH_FOO:BOOL=true -DBAR:BOOL=true
or
  -DWITH_FOO:BOOL=false -DBAR:BOOL=false

PR:		210576
Approved by:	portmgr (mat)

 

18:36 bdrewery 

Fix excluding implied options.

This fixes the devel/git-lite port to not get PERL despite being excluded.

PR:		207460
PR:		202701
With hat:	portmgr
Differential Revision:	https://reviews.freebsd.org/D5538

 

15:28 mat 

Add MASTER_SITES to options helpers.

Sponsored by:	Absolight

 

11:08 mat 

Add GH_TUPLE to the options flags too.

Sponsored by:	Absolight

 

17:01 mat 

Be consistent.

Noticed by:	amdmi3
Sponsored by:	Absolight

 

16:19 mat 

Remove unneeded .for loops.

Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D4484

 

22:44 marino 

Mk/bsd.options.mk: Introduce SELECTED_OPTIONS, DESELECTED_OPTIONS

Until now, the only way to obtain information on the valid port options
and the current selection states is by using the pretty-print-config
target.  It would look something like this:

  > make -C /usr/ports/lang/gcc5-aux print-print-config
  Standard[ +FORT +OBJC +NLS -TESTSUITE -ALLSTAGES -STATIC ] \
  Bootstrap[ -BOOTSTRAP ]

To process the total options and the selection state of each option
requires additional processing, e.g. with awk and/or sed.  Moreover, if
other information is needed about the port it question, it would require
a second execution of "make" to reveal variable values. There simply is
no other way to obtain the option selection information in a single pass
(this limitation came when options framework was brought in).

This enhancement allows the option selection information to revealed with
make -V so that all port information can be acquired in a single pass.
Moreover, they won't require piping through sed or awk.  Two read-only
variables are introduced:

  SELECTED_OPTIONS   (list of all "on" options)
  DESELECTED_OPTIONS (liss of all "off" options)

Here's an example of a single pass acquisition:

  > make -C /usr/dports/lang/gcc5-aux -V PKGNAME -V SELECTED_OPTIONS \
    -V DESELECTED_OPTIONS
  gcc5-aux-20150716
  NLS OBJC FORT
  BOOTSTRAP STATIC ALLSTAGES TESTSUITE

Obviously the grouping information seen in pretty-print-config is lost,
so these new variables will not help if option group information is
required.

Approved by:	portmgr (bapt)

 

13:50 mat 

Refactor the list of all excluded options so that the second place it is
needed is not forgotten any more.

PR:		204510
With hat:	portmgr
Sponsored by:	Absolight

 

14:21 amdmi3 

Enable TEST option if DEVELOPER is set

TEST option is used when a port needs extra depends or flags for
build phase to enable tests (so TEST_DEPENDS don't work). Enable
it by default for DEVELOPER builds, so interested parties and Q/A
can have all tests available.

Approved by:	portmgr (bapt)
Differential Revision:	D3844

 

12:45 amdmi3 

Add support for opt_TEST_TARGET consistent with opt_{ALL,INSTALL}_TARGET

Approved by:	portmgr (mat)
Differential Revision:	D3788

 

07:56 mat 

Fix opt_VARS premature expansion.

Due to the way .for loop work, opt_VARS was being expanded too early
evaluation, which made it impossible to use vars that are set/modifies
afterwards (such as PREFIX or PKGDIR)

Fix this by changing opt_VARS handling logic so that the right side is
not prematurely expanded:

- Loop not by words (each word here is single VAR=val / VAR+=val tuple)
  but by unique left sides of assignments (VAR, VAR+ here)
- Using the left side, extract all corresponding right sides and
  append/assign them to a variable

This changes the way this opt_VARS line work, which behavior is between
invalid and undefined:

opt_VARS= FOO=bar FOO=baz

Before it would end up with "FOO=baz", now it ends up with "FOO=bar baz"

Submitted by:	amdmi3
Reviewed by:	antoine, mat
Approved by:	my portmgr hat
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3729

 

17:20 amdmi3 

Implemented complete support for test target.

You can now `make test' on any port to run test sequence, no-op by default.
If a port defines TEST_TARGET, it'll run sub-make with specified target,
usually `check' or `test', useful if upstream supports that. The port may
instead define custom do-test target, as well as usual satellite targets:

  {pre,do,post}-test, {pre,do,post}-test-OPT, {pre,do,post}-test-OPT-off

`make test' builds and stages port first, so test may use both WRKDIR and
STAGEDIR, and both BUILD and RUN depends are available for test target.
Additionally, TEST_DEPENDS is now properly supported and may be used to
define additional depends specifically for testing.

Framework may define default tests for specific cases. For instance,
perl5.mk and cran.mk already provide default test target on their own.

This commit also converts my ports which have tests to this new framework.

Approved by:	portmgr (bapt)
Differential Revision:	D3680

 

14:04 mat 

Add PORTEXAMPLES to the options helpers.

Sponsored by:	Absolight

 

16:35 mat 

Add DESKTOP_ENTRIES to the options flags.

Sponsored by:	Absolight

 

16:18 adamw 

Use more precise wording, i.e. "set" and "append" instead of "run."

Approved by:	portmgr (mat)

 

12:28 mat 

Add generic opt_VARS/opt_VARS_OFF.

OPT1_VARS=  foo=bar baz+=bam

will set FOO to bar and append bam to BAZ if OPT1 is enabled.  <opt>_VARS_OFF
works the same way, if the option is disabled.

Reviewed by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3410

 

13:07 mat 

Add an optional error message for opt_PREVENTS, opt_PREVENTS_MSG.

Reviewed by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3469

 

13:05 mat 

Fix with fmake.

Noticed by:	marck
Sponsored by:	Absolight

 

12:02 mat 

Optimize opt_IMPLIES.

PR:		191144
Submitted by:	hrs
Sponsored by:	Absolight

 

09:28 mat 

Add EXTRACT_ONLY to the options flags.

Sponsored by:	Absolight

 

11:00 mat 

Introduce <opt>_IMPLIES and <opt>_PREVENTS to register dependencies, or
conflicts, between options.

PR:		191144
Submitted by:	adamw
Sponsored by:	Absolight

 

10:39 mat 

Add BROKEN and IGNORE to the options flags.

Sponsored by:	Absolight

 

14:20 mat 

Remove UNIQUENAME and LATEST_LINK.

UNIQUENAME was never unique, it was only used by USE_LDCONFIG and now,
we won't have conflicts there.

Use PKGBASE instead of LATEST_LINK in PKGLATESTFILE, the *only* consumer
is pkg-devel, and it works just fine without LATEST_LINK as pkg-devel
has the correct PKGNAME anyway.

Now that UNIQUENAME is gone, OPTIONSFILE is too. (it's been called
OPTIONS_FILE now.)

Reviewed by:	antoine, bapt
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3336

 

13:31 mat 

Rewrite the target ordering code.

The targets now have priority assigned to them, and, when the dependency
ordering magic is done at the end of bsd.port.mk, they are sorted
according to their priority.

This allows USES to add targets easily and have them run whenever they
want without touching bsd.port.mk.

To add a target that runs just before post-configure run, do:

_USES_configure+=  695:my-post-configure
my-post-configure:
	do something

To fine tune when the target is ran, look at the values in the *_SEQ
variables at the end of bsd.port.mk, and the other USES.

Allow ports Makefiles to override the priority of targets with the
TARGET_ORDER_OVERRIDE variable.  For example, to get post-install
running earlier, (its default is 700) do:

TARGET_ORDER_OVERRIDE=	  650:post-install

While there, add options target helpers for the do-* targets when they
exist.

Reviewed by:	antoine, bapt
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3099

 

08:51 mat 

White space fix.

With hat:	portmgr
Sponsored by:	Absolight

 

08:51 mat 

Add GH_* and PORTDOCS top the make variables helpers.

With hat:	portmgr
Sponsored by:	Absolight

 

12:11 mat 

Introduce target option helpers.

With hat:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D2944

 

09:38 mat 

Add SUB_LIST and SUB_FILES to the helper flags.  (and sort the flags)

With hat:	portmgr
Sponsored by:	Absolight

 

17:31 marino 

Mk/bsd.options.mk: Add OPTIONS_EXCLUDE_${OPSYS}

This simple addition greatly simplifies the removal of options as a
function of operating system, e.g. OPTIONS_EXCLUDE_DragonFly.

Approved by:	portmgr (bdrewery)

 

12:18 antoine 

Add a ${opt}_USE_OFF option helper

PR:		195817
Differential Revision:	https://reviews.freebsd.org/D1581
Reviewed by:	bapt, mat, jbeich
With hat:	portmgr

 

14:14 mat 

Allow the use of opt_ENABLE= foo=/bar to work like opt_WITH.

Sponsored by:	Absolight

 

12:09 bapt 

Spelling

Submitted by:	xmj

 

18:06 antoine 

Add an option helper for PLIST_SUB
Rename a few variables to avoid confusion with this new helper

Requested by:	koobs
Reviewed by:	mat
With hat:	portmgr
Differential revision: https://reviews.freebsd.org/D665

 

22:28 bapt 

Add INFO macro to the helpers

 

13:29 ohauer 

- strip optional WITH parameter from argument if OPTION is set to off

  FOO_WITH=	foo=bar

  CONFIGURE_ARGS will become now
  ON:	--with-foo=bar
  OFF:	--without-foo

PR:		191085
Submitted by:	ohauer
Approved by:	portmgr (antoine)

 

07:13 bapt 

Switch back to default tabspace: 8

 

14:50 tijl 

Support LIBS like LDFLAGS.

- Add LIBS="${LIBS}" to MAKE_ENV and CONFIGURE_ENV.
- Add an option helper for LIBS.
- Adjust all ports that already use LIBS.  Also remove references to
  PTHREAD_CFLAGS and PTHREAD_LIBS while here.
- Some ports did not support having a LIBS environment variable and
  required additional patches.

Somewhat simplified a linker command line looks like:

${CC} ${src_LDFLAGS} ${LDFLAGS} ${src_LIBS} ${LIBS}

where src_LDFLAGS and src_LIBS are controlled by upstream and LDFLAGS and
LIBS can be controlled by us.  If possible -L and -l flags need to be
added to LIBS to make sure they appear after any -L and -l flags set by
upstream.  Many ports currently add -L${LOCALBASE}/lib to LDFLAGS but this
may appear too early on the command line causing installed libraries to
be linked in instead of freshly built ones.

Additional changes:
benchmarks/netio: Replace WITH_IPV6 with an IPV6 option.
comms/gnokii: Replace some patches with USES=pathfix.  Also remove -fPIC.
graphics/gimageview: USES=libtool and install desktop file in DESKTOPDIR.
graphics/visionworkbench: Remove FreeBSD 7 support.
multimedia/libmovtar: New LIB_DEPENDS syntax.
multimedia/opencinematools: Use standard do-build.
net/siproxd: USES=libtool:keepla (port actually needs .la files for plugins)
net-mgmt/nagios: Remove -fPIC.
net-mgmt/nagios4: Remove -fPIC.
print/cups-base: Only add -lssp_nonshared on i386 and OSVERSION < 1000036.
security/p11-kit: Replace PTHREAD_LIBS in CONFIGURE_ENV with
ac_cv_func_pthread_mutexattr_init=no in CONFIGURE_ARGS.  This skips a test
in configure that falsely detects pthread_mutexattr_init in our libc.
sysutils/dar: Fix iconv detection.
x11/rxvt-unicode: Remove -lstdc++ and patch configure to remove a FreeBSD
hack and use $CXX as linker as on other platforms.

PR:		190592
Exp-run by:	antoine
Approved by:	portmgr (antoine)

 

09:45 bapt 

Convert all :U to :tu and :L to :tl

Since FreeBSD 8.4 and FreeBSD 9.1 make(1) do support :tu and :tl as a
replacement for :U and :L (which has been marked as deprecated)

bmake which is the default on FreeBSD 10+ only support by default
:tu/:tl a hack has been added at the time to support :U and :L to ease
migration. This hack is now not necessary anymore

Note that this makes the ports tree incompatible with make(1) from
FreeBSD 8.3 or earlier

With hat:	portmgr

 

06:44 bdrewery 

- Rename check-orphans to check-plist. Keep the old for backwards-compat.
- Bug fixes:
  makeplist/check-plist:
   - Fix showing directories owned by RUN_DEPENDS/LIB_DEPENDS [1]
   - Use proper "rmdir PATH" syntax, not "rmdir >/dev/null... PATH" which
     pkg will not recognize.
   - Never consider base /etc/mtree/BSD.usr.dist or LOCLABASE
     Templates/BSD.local.dist as needing @dirrm handling.
  check-plist:
   - Fix showing PORTDOCS/PORTEXAMPLES files when the OPTIONS are not set.
     makeplist will still suggest them.
   - Fix showing files installed through unselected OPTIONS as orphans,
     by considering "@comment file" to be ignored. [2]
   - Fix @sample, @fc, @fcfontsdir, @fontsdir support
   - Fix return status when orphans are found to be non-zero
   - Add note when PREFIX=!LOCALBASE
   - Be more clear when orphans/no orphans are found.
   - Add a whitelist mechanism for globally approved ignores.
   - Add *.bak/*.orig to orphan whitelist for now.
   - Fix false-positive with dirs installed to /, such as with
     archivers/dpkg creating /var/db/dpkg
   - Fix false-positive with @dirrm ending in /, such as with
     ports-mgmt/poudriere with a @dirrmtry share/zsh/
   - There are likely still some false-positives. I fixed as many as I could
     find. Please let me know of others.
    * One in particular that is not easily fixable is installing a file into
      a directory owned by another port where that other port is not a run-time
      dependency. So the leaf port may create all of the parent dirs and never
      clean them up. Cleaning them up is not proper unless no other package is
      depending on them. This will be addressed by pkg(8) once pkg_install is
      EOL, or sooner.
   - Consider @dirrm of directories owned by run-time dependencies, or
     /etc/mtree/* or Templates/BSD.local.dist (at LOCALBASE) as fatal errors.
     These should not be removed in the plist. @comment lines are not
     considered for this; they will not ignore an error.
        ===> Checking for directories owned by dependencies or MTREEs
        Error: Owned by dependency: @dirrmtry share/locale/af/LC_MESSAGES
        Error: Owned by dependency: @dirrmtry share/locale/af
        Error: Owned by dependency: @dirrmtry %%PERL5_MAN3%%
   - Detect files in plist that do not exist in the stagedir. Pkgng already did
     this, but now we have it unified with this check. @comment lines are
     not considered for this; they will not ignore an error.
        ===> Checking for items in pkg-plist which are not in STAGEDIR
        Error: Missing: foo
        Error: Missing: @dirrmtry bar
   - Change orphaned output due to several new errors introduced:
        ===> Checking for items in STAGEDIR missing from pkg-plist
        Error: Orphaned: foo
   - Send errors to stderr
  check_leftovers.sh:
   - Prefer longer values for PLIST_SUB.
  bsd.options.mk:
   - Fix NOPORTDOCS/WITHOUT_NLS/NOPORTEXAMPLES not unsetting their respective
     OPTIONS.
   - Mark NOPORTDOCS/NOPORTEXAMPLES deprecated and hook them into the
     OPTIONS_WARNING to tell users the new format.
- check-stagedir.sh refactoring:
  - Switch to using new PLIST_SUB_SED
  - Use ! instead of , in sed(1) regex to allow files/dirs with ','
  - Rework PORTEXAMPLES/PORTDOCS handling so it acts on PLIST_SUB_SED'd
    value and not absolutes. Also simplify the regex for these a bit to
    allow reuse.
  - No longer need DOCSDIRS/EXAMPLESDIR in env
  - Wrap long lines
  - Unset some vars in env when they are done being used to free space for
    larger sed vars
  - Cleanup redundant sed regexes
- Add a Scripts/plist_sub_sed_sort.sh to prefer longer values when substituting
  over shorter values.

- To make check-plist ignore a file *as an orphan* do one of the following:
  1. Install it
  2. post-install: ${RM} ${STAGEDIR}file
  3. Put the file behind an OPTION with a PLIST_SUB: %%OPTION%%file
  4. Add to plist as a @comment [2]:
     @comment file
     @comment @dirrmtry dir

Reviewed by:	mat (much earlier version)
Discussed with:	mat, antoine, bapt, swills (various bits)
With hat:	portmgr
PR:		ports/185561 [1]
Reported By:	Alexander Yerenkow <yerenkow@gmail.com> [1]
Tested with:	pkg and pkg_install
Reported by:	many (false-positives)

[2] This is a partial solution, we may still need a plist.ignore too. It
    doesn't make much sense to add files in main pkg-plist we don't care about,
    but maybe it does since you'll see and reconsider them being ignored
    someday. @comment is used as all the OPTION PLIST_SUB deactivations use
    @comment instead of something like @ignore.

 

11:04 bapt 

Make option DEBUG work like WITH_DEBUG

 

18:19 mat 

Have OPTIONS_SUB also fill in SUB_LIST.

Fix two ports that would have been broken with this change.

With hat:	portmgr

 

18:56 mat 

Correctly sort the DEPENDS targets.

Sponsored by:	Absolight

 

18:47 mat 

Add CONFLICT{,_BUILD,_INSTALL} to the options helpers.

PR:		187226 (based on)
Submitted by:	adamw
Sponsored by:	Absolight

 

15:12 mat 

Don't output warnings about WITH_DEBUG being on.

Requested by:	eadler
Sponsored by:	Absolight

 

16:39 mat 

Add %%NO_OPT1%% to PLIST_SUB that is enabled when %%OPT1%% is not.

Sponsored by:	Absolight

 

15:40 mat 

Really tell our users that using WITH_/WITHOUT_ to set/unset options is
deprecated.

Sponsored by:	Absolight

 

14:33 antoine 

Use OPTIONS helpers from excluded options too

Reviewed by:	bapt
With hat:	portmgr

 

22:53 mat 

Add two new options helpers:

${OPT}_${TYPE}_DEPENDS_OFF=<something> will automatically add:
${TYPE_DEPENDS}+=<something> in case OPT is 'off'

${OPT}_${FLAG}_OFF=<something> will automatically add:
${FLAG}+=<something> in case OPT is 'off'

With hat:	portmgr
Sponsored by:	Absolight

 

23:44 bapt 

fmake doesn't like previous commit (which breaks index) [1]

Given we do not support for long enough old OPTIONS framework just get
rid of this compat block that doesn't bring anything anymore

Kick by:	cperciva [1]

 

23:31 bapt 

Do not set again WITHOUT_NLS in old backward compatibility if NLS is in
OPTIONS_UNSET

Reported by:	eadler

 

11:28 bapt 

Stop defining WITHOUT_NLS it not used anymore in the ports tree

 

10:59 makc 

Add support for ${opt}_QMAKE_ON/${opt}_QMAKE_OFF

Approved by:	portmgr (bapt)

 

13:23 mat 

Allow multiple value in ${opt}_USE= FOO=bar,baz.

Which is nice in case you end up with something like :
X11_USE=	xorg=x11 xorg=ice xorg=sm xorg=xext xorg=xineramaproto
		xorg=xinerama xorg=xrandr xorg=xrender xorg=xtst

now you can do :
X11_USE=	xorg=x11,ice,sm,xext,xineramaproto,xinerama,xrandr,xrender,xtst

PR:		ports/183892
Approved by:	bapt

 

16:54 ak 

- Remove gratuitous whitespaces
- Use sinclude when possible
- Rewrap overly long list

Approved by:	portmgr (bapt)

 

11:58 wg 

Allow multiple values for configure ENABLE and WITH options helpers

${opt}_CONFIGURE_ENABLE and ${opt}_CONFIGURE_WITH now accept multiple arguments
and will be expanded accordingly, e.g.:

OPT_CONFIGURE_ENABLE= feature1 feature2  --  will add to CONFIGURE_ARGS:
	OPT enabled: --enable-feature1 --enable-feature2
	OPT disabled: --disable-feature1 --disable-feature2

Approved by:	portmgr (bapt)

 

11:42 bdrewery 

- Fix OPTIONS_SUB not including OPTIONS_SLAVE options in PLIST_SUB

With hat:	portmgr

 

11:38 bdrewery 

- Add option helper opt_USE= FOO=bar -> USE_FOO=bar

Discussed with:	bapt
With hat:	portmgr

 

10:03 sunpoet 

- Add more helpers: ALL_TARGET, INSTALL_TARGET and CATEGORIES
- Remove duplicate EXTRA_PATCHES comment
- Minor comment rewording: change "add it to" to "add its content to"
  just like how we describe ${opt}_CMAKE_*

PR:		ports/182626
Submitted by:	sunpoet (myself)
Approved by:	bapt (portmgr)

 

01:52 bdrewery 

- Add support for PATCHFILES and PATCH_SITES
- While here, cleanup r329186 and move EXTRA_PATCHES to common
  section

With hat:	portmgr

 

13:32 bdrewery 

- Support {opt}_EXTRA_PATCHES

Reviewed by:	bapt
With hat:	portmgr

 

16:27 sunpoet 

- Add more OPTIONS helpers: MAKE_ARGS, PLIST_FILES, PLIST_DIRS and PLIST_DIRSTRY
- Fix typo

PR:		ports/182514
Submitted by:	sunpoet (myself)
Approved by:	bdrewery (portmgr)

 

21:01 naddy 

If ${opt}_CPPFLAGS is defined, its value will be appended to CPPFLAGS
depending on the status of option ${opt}.

Approved by:	bapt

 

12:32 mat 

Document the new bsd.options.mk knobs.

PR:		ports/180949
Submitted by:	mat
Approved by:	bapt

 

07:01 bapt 

Add new ${OPT}_CONFIGURE_WITH option help
it will handle the --with/--without configure argument dancing based on the
value of the OPTION ${OPT}

Requested by:	mandree

 

11:47 tijl 

- Document the use of ${OPTIONS_NAME}_(UN)SET(_FORCE).
- Remove options in ${OPTIONS_NAME}_(UN)SET from NEW_OPTIONS list.
- Remove an intermediate sort.
- Add support for ${OPTIONS_NAME}_(UN)SET_FORCE.

Approved by:	bapt

 

07:22 bapt 

Replace OPTIONSFILE by OPTIONS_FILE which is a more robust variable with unicity
insurance in its path to avoid collision.

A compatibility layer is available to automatically load and migration from
OPTIONSFILE to OPTIONS_FILE (this is all transparent for users.)

It is recommanded that ports that used to overwrite OPTIONSFILE to prevent the
known bugs should keep the OPTIONSFILE overwrite for a while (6 month) to allow
the migration to happen automatically and users to not lose their old save
options.

New options file is now based on the PKGORIGIN therefor the definition of the
PKGORIGIN has been moved ealier in bsd.port.mk to allow it's usage from withing
bsd.options.mk

PR:		ports/148637
Reviewed by:	bdrewery