mail/dspam: fix configure with modern MariaDB

1) Configure fails with error message:
checking for MySQL client version >= 5.0.0... no
configure: error: Required version of libmysqlclient not found

It check "mysql_get_client_info() > 5", but modern MariaDB return
Connector/C's version 3.x instead of MariaDB version.
How to get the correct version found here:
https://github.com/pali/DBD-MariaDB/commit/9743bec52db5e8f1beb2b31e4a55d6ea1a4edcdd

While here:
2) remove GNU_CONFIGURE_MANPREFIX
3) fix make check-plist if build with MYSQL option ON only:
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: @dir lib/%%DSPAM_OWNER%%

PR:		279253
Approved by:	danny@dannywarren.com (maintainer, timeout 17 days)

mail/dspam: Moved man to share/man

Approved by:    portmgr (blanket)

*/*: Refactor with IGNORE_WITH_MYSQL

- There are multiple ports which has MYSQL options and are non-DEFAULT.
  Most of the time committers actually forget to check with the OPTION
  enabled and in some cases they are BROKEN with newr versions of mysql.
  So test with different versions of mysql and mark IGNOPRE_WITH_MYSQL
  appropriately. Due to the EOL of 5.7 this has not been checked.
- Unbreak sysutils/cfengine* with MySQL 8.0 and later
- The primary purpose of running this check is having statistics of the
  MySQL usability over MariaDB to explore the future possibility of
  shifting to MariaDB as the default as major ports upstream have moved
  their codebase to support MariaDB over MySQL.
- The following actions will also be taken after the sunset of MySQL 5.7
  If a port is broken on all instances of MySQL/MariaDB:
  - If a port has the option of multiple DB backends and MySQL is the
    default then the DEFAULT will be changed to PGSQL/SQLITE before
    2024Q1. And the OPTION will be removed before 2024Q2. If a
    MAINTAINER is aware about such cases and want to prefer PGSQL over
    SQLITE or vice versa please do so at your own accord. Otherwise
    PGSQL will be preferred over SQLITE.
  - If a port has the option of multiple DB backends and MySQL is not
    the default then the the OPTION will be removed before 2024Q1.

Approved by:	portmgr (blanket)

*/*: Update WWW to use HTTPS for sourceforge.net projects

Homepage link is permanent redirected to its HTTPS counterpart
Issue reported by repology : https://repology.org/repository/freebsd/problems

Approved by:	portmgr (blanket)
PR:		274888

mail/dspam: adjust SHEBANG_FILES masks to cover *.pl.in template

Bump PORTREVISION to force reroll with correct configure script

Reported by:	poudriere bulk -t
Approved by:	portmgr blanket
Sponsored by:	Serenity Cybersecurity, LLC

Mk/**ldap.mk: Convert USE_LDAP to USES=ldap

Convert the USE_LDAP=yes to USES=ldap and adds the following features:

- Adds the argument USES=ldap:server to add openldap2{4|5|6}-server as
  RUN_DEPENDS
- Adds the argument USES=ldap<version> and replaces WANT_OPENLDAP_VER
- Adds OPENLDAP versions in bsd.default-versions.mk
- Adds USE_OPENLDAP/WANT_OPENLDAP_VER in Mk/bsd.sanity.mk
- Changes consumers to use the features

Reviewed by:	delphij
Approved by:	portmgr
Differential Revision: https://reviews.freebsd.org/D38233

Mk/Uses/apache.mk: Refactor after removal of older versions

apache22 and apache25 had been removed a long time ago however the
apache.mk file has never been refactored and is out of sync from the
file Mk/bsd.default-versions.mk. These changes refactors the removals of
the older versions. In addition:

- Move some keywords like USE_APACHE, USE_APACHE_BUILD, USE_APACHE_RUN
  from SANITY_DEPRECATED to SANITY_UNSUPPORTED
- Remove apache versions from ports Makefiles as currently there is only
  one available version in the tree. However the version checks are
  still valid and should work flawlessly whenever a new version is
  added. For example USES=apache:2.2+ are simply replaced with
  USES=apache. As currently there are no other versions available for
  test this could not be checked on it's own ground.
- Update FOO_USE=APACHE=yes to FOO_USES=apache
- Remove trailing whitespaces

Approved by:    portmgr
Differential Revision: https://reviews.freebsd.org/D38113

security/clamav: Update to 1.0.0

* Switch to use bundled TomsFastMath library. Upstream made
  incompatible change to bundled copy and this makes it impossible to
  use external one. They also dropped option to use it.
* Bump PORTREVISION of consumers as shlib version is changed.
* Note that though this is new LTS feature release security/clamav-lts
  stays in 0.103.x until either next regular feature release (probably
  1.1.0) is released or 0.103.x reaches its EoL.

ReleaseNotes:	https://blog.clamav.net/2022/11/clamav-100-lts-released.html

mail/dspam: convert UPDATING file to UTF-8 and trim EOL whitespace.

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

mail: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  <ashish@FreeBSD.org>
  *  Aaron Dalton <aaron@FreeBSD.org>
  *  Adam David <adam@FreeBSD.org>
  *  Adam McDougall <mcdouga9@egr.msu.edu>
  *  Adam Weinberger <adamw@FreeBSD.org>
  *  Ade Lovett <ade@FreeBSD.org>
  *  Akinori MUSHA aka knu <knu@idaemons.org>
  *  Alex Deiter <tiamat@komi.mts.ru>
  *  Alex Dupre <ale@FreeBSD.org>
  *  Alex Dupre <sysadmin@alexdupre.com>
  *  Alex Perel <veers@disturbed.net>

*/*: Remove redundant '-[0-9]*' from CONFLICTS

The conflict checks compare the patterns first against the package
names without version (as reported by "pkg query "%n"), then - if
there was no match - agsinst the full package names including the
version (as reported by "pkg query "%n-%v").

Many CONFLICTS definitions used patterns like "bash-[0-9]*" to filter
for the bash package in any version. But that pattern is functionally
identical with just "bash".

Approved by:	portmgr (blanket)

*: apply refactor.remove-consecutive-empty-lines

Submitted by:	portedit

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

mail/dspam: fix  build on recent current

- this seems to be abandonware, and should likely be removed.

Unbreak the build against MariaDB and MySQL 8.0 (the latter replaced
my_bool with C99 bool, while earlier versions used typedef to char).

PR:	243035

- update libgd to 2.3.0
- new option RAQM
- resurrect deprecated gdlib-config
- bump dependend ports

onvert to UCL & cleanup pkg-message (categories l-m)

Bump PORTREVISION for ports depending on the canonical version of GCC
as defined in Mk/bsd.default-versions.mk which has moved from GCC 8.3
to GCC 9.1 under most circumstances now after revision 507371.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, everything INDEX-11 shows with a dependency on lang/gcc9 now.

PR:		238330

Fix more daemon typos

Bump PORTREVISION for ports depending on the canonical version of GCC
defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t
GCC 8.2 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.

PR:		231590

Migrate USE_APACHE to USES= apache

 - Following migration of Mk/bsd.apache.mk to Mk/Uses/apache.mk

With hat:	apache

Rename dovecot2/dovecot2-pigeonhole to dovecot/dovecot-pigeonhole.

It might be necessary to manually remove and reinstall the package under
the new name.

Discussed with:	ler

Remove optional dependencies on mail/dovecot.

Change the default for sysutils/froxlor to mail/dovecot2.

Use USES=pathfix where applicable.

PR:		213195
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D8093

- update libgd to 2.2.2
- new MASTER_SITES
- add security patch
PR:		210913
Submitted by:	Piotr Kubaj
MFH:		2016Q3
Security: CVE-2015-8874
Security: CVE-2016-3074
Security: http://www.openwall.com/lists/oss-security/2016/07/12/4

mail/dspam: fix build; remove duplicate patch hunks in to files

PR:		209184
Submitted by:	Danny Warren <danny@dannywarren.com> (maintainer)
Pointy hat to:	junovitch

mail/dspam: implement privilege separation (resolves bug running with suexec)

- Runs as dspam:dspam instead of root:mail. The dspam UID/GID were created
  in r168311 when the UIDs/GIDs files were added but the port had always
  used root:mail. This had prevented running the dspam webUI under Apache
  with suexec due to a minimal requirement of UID/GID of 100. The original
  unsecure behavior is available with the SETUID option.
- Default run directory is now /var/run/dspam. This follows the default
  upstream behavior and removes the patch to dspam.c as a result. Use
  RUN_DIR and correct the dspam.conf.sample file accordingly.
- Default daemon/client communication port is now 2424.
- Regen patches while here (portlint)

UPDATING: Document privilege separated dspam

PR:		115957
Reported by:	tedm@ipinc.net, support@ipinc.net
Submitted by:	Danny Warren <danny@dannywarren.com> (maintainer)

Remove USE_SQLITE from bsd.databases.mk, replaced by USES=sqlite.

While there replace USE_SQLITE=x by USES=sqlite:x.

PR:		208971
Submitted by:	mat
Exp-run by:	antoine
With hat:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D5951

Remove ${PORTSDIR}/ from dependencies, categories m, n, o, and p.

With hat:	portmgr
Sponsored by:	Absolight

- Clean up plist user/group/mode handling [1]
- Add DSPAM_SAMPLE_MODE variable

PR:		203200
Submitted by:	amdmi3 [1]
Approved by:	danny@dannywarren.com (maintainer)

MASTER_SITES cleanup.

- Replace ${MASTER_SITE_FOO} with FOO.
- Merge MASTER_SITE_SUBDIR into MASTER_SITES when possible. (This means 99.9%
  of the time.)
- Remove occurrences of MASTER_SITE_LOCAL when no subdirectory was present and
  no hint of what it should be was present.
- Fix some logic.
- And generally, make things more simple and easy to understand.

While there, add magic values to the FESTIVAL, GENTOO, GIMP, GNUPG, QT and
SAMBA macros.

Also, replace some EXTRACT_SUFX occurences with USES=tar:*.

Checked by:	make fetch-urlall-list
With hat:	portmgr
Sponsored by:	Absolight

Fix some USE_PGSQL that were missed before

Submitted by:	antoine

mail/dspam: 3.9.0 -> 3.10.2

Upstream Changes:
- Support for Postgresql 9.1 added
- Support for Postgresql <8.1 dropped (EOL)
- Support for MySQL 5.5 added
- Support for MySQL <5.0 dropped
- Updated license from GPLv2 to AGPLv3
- Bug in RSET handling during LHLO phase
- Location of configuration files in dspam home (/var/dspam) can be changed
  through dspam.conf
- Various fixes to the webui templates
- Various small bugs and memleaks
- Missing documentation added to tarball
- Many bugfixes

Danny takes maintainership

databases/sqlite2:
- Convert to USES=libtool and bump dependent ports

Change the words NOPORTDOCS and NOPORTEXAMPLES in a couple comments so that
future updates won't trigger the NOPORT* commit hook checks.

In some straightforward situations, protect examples behind PORTEXAMPLES,
adding EXAMPLES to OPTIONS_DEFINE where necessary. In a couple instances,
correct examples being controlled by the DOCS option.

net/openldap24-*:
- Convert to USES=libtool and bump dependent ports
- Avoid USE_AUTOTOOLS
- Don't use PTHREAD_LIBS
- Use MAKE_CMD

databases/glom:
- Drop :keepla
- Add INSTALL_TARGET=install-strip

databases/libgda4* databases/libgda5*:
- Convert to USES=libtool and bump dependent ports
- USES=tar:xz
- Use INSTALL_TARGET=install-strip
- Use @sample

Fix some non default LIB_DEPENDS

With hat:	portmgr

Add DOCS to OPTIONS_DEFINE to ports that check for PORT_OPTIONS:MDOCS.

Fix installation with the WEBUI option enabled.

PR:		191610
Submitted by:	mtomasek4@gmail.com
MFH:		2014Q3

Bump PORTREVISION on all ports with USE_SQLITE=yes or USE_SQLITE=3 that
have not been bumped yet after the latest libsqlite3.so library version
change.

Approved by:	portmgr (implicit)

Reset due to multiple maintainer timeouts.

Approved by:	portmgr (bapt)

mail/dspam: remove support for expired cyrus 2.1 / 2.2

Approved by:	bapt

Support LIBS like LDFLAGS.

- Add LIBS="${LIBS}" to MAKE_ENV and CONFIGURE_ENV.
- Add an option helper for LIBS.
- Adjust all ports that already use LIBS.  Also remove references to
  PTHREAD_CFLAGS and PTHREAD_LIBS while here.
- Some ports did not support having a LIBS environment variable and
  required additional patches.

Somewhat simplified a linker command line looks like:

${CC} ${src_LDFLAGS} ${LDFLAGS} ${src_LIBS} ${LIBS}

where src_LDFLAGS and src_LIBS are controlled by upstream and LDFLAGS and
LIBS can be controlled by us.  If possible -L and -l flags need to be

Retire security/clamav-devel, clamav is not being updated that much nowadays,
so a -devel version is not required anymore. Also removed OPTIONS on other
ports that pointed to clamav-devel as a dependency.

Approved by:	portmgr (implict)

Add patch forgotten on last commit

Approved by:	portmgr (blanket)

. Move USE_AUTOTOOLS=libtool to USES=libtool
. Drop .la files
. Use shebangfix for necessary files
. Use @sample, @owner, @group and @mode to modernize plist
. Try to remove LOG_DIR on pkg-plist

Approved by:	portmgr (blanket)

Fix properties on pkg-plist

Clean up the Makefile and OPTIONS.

Remove multiple MySQL version selection and leave it to the global
system settings. This implicitly enables support for MariaDB and
Percona in addition to all the versions of MySQL while simplifying
the Makefile at the same time.

Add Cyrus24 and Dovecot LDA options.

Regroup OPTIONS so all the DB related choices appear together.

Otherwise the resulting build should remain the same as before.

PR:		ports/180704
Submitted by:	Yarema <yds@CoolRat.org>
Submitted by:	Radim Kolar <hsn@sendmail.cz>

While here, stage

Approved by:	maintainer timeout (itetcu, 6 months)

Add NO_STAGE all over the place in preparation for the staging support (cat:
mail)

- convert to the new perl5 framework
- remove redundant perl usage, since we use it already in global context

Approved by:	portmgr (bapt@, blanket)

- update libdg to 2.1.0

Mark as job unsafe

- fix PORT_OPTIONS s/)/}/

Fix options conversion with bmake

- adoption of optionsNG

Approved by:	portmgr (bapt)

Remove MySQL 5.0, it has been unsupported upstream for about 1.5 years

Approved by:    ale (maintainer)

Remove MySQL 4.1, it has been unsupported upstream for almost 3.5 years.

Approved by:	ale

- remove www/apache20 and devel/apr0
- s/USE_APACHE= 20+/USE_APACHE= 22+/
- unify s/YES/yes/
- cleanup APACHE_VERSION <= 22 usage
- add entry to MOVED

with hat apache@

- Remove SITE_PERL from *_DEPENDS

Approved by: portmgr@ (bapt@)

In the rc.d scripts, change assignments to rcvar to use the
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().

In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.

- change required APACHE version from 13+ to 20+
  (prepare to remove www/apache13)

- no PORTREVISION bump since apache22 is the default

with hat apache@

- Add LDFLAGS to CONFIGURE_ENV and MAKE_ENV (as it was done with LDFLAGS)
- Fix all ports that add {CPP,LD}FLAGS to *_ENV to modify flags instead

PR:             157936
Submitted by:   myself
Exp-runs by:    pav
Approved by:    pav

 - bump PORTREVISION from ports if USE_APACHE=13+ or 20+ is defined

- remove MD5

Sync to new bsd.autotools.mk

Chase clamav's lib bump

Shorten an OPTION description.

PR:             145090
Submitted by:   olli hauer <ohauer@gmx.de>

Begin the process of deprecating sysutils/rc_subr by
s#. %%RC_SUBR%%#. /etc/rc.subr#

- Add support for MySQL 5.5 (default: off)

PR:             143730
Submitted by:   Joe Horn
Feature safe:   yes

Update to 3.9.0.
Yes, after a long hiatus and a year of development and testing, bug fixes and
improvements bu the new devel team, a new version is ready for use.

There are too many change to mention here, please see: files/UPDATING.
You will need to modify your dspam.conf and database structure, as described in
the UPGRADING from the tarball (installed in share/doc/dspam).

Tested by:      supsonic#dspam on irc.freenode.net

-Repocopy devel/libtool15 -> libtool22 and libltdl15 -> libltdl22.
-Update libtool and libltdl to 2.2.6a.
-Remove devel/libtool15 and devel/libltdl15.
-Fix ports build with libtool22/libltdl22.
-Bump ports that depend on libltdl22 due to shared library version change.
-Explain what to do update in the UPDATING.

It has been tested with GNOME2, XFCE4, KDE3, KDE4 and other many wm/desktop
and applications in the runtime.

With help:      marcus and kwm
Pointyhat-exp:  a few times by pav
Tested by:      pgollucci, "Romain Tartière" <romain@blogreen.org>, and
                a few MarcusCom CVS users. Also, I might have missed a few.
Repocopy by:    marcus
Approved by:    portmgr

- Bump necessary PORTREVISIONS and fix some ports to new clamav API

- Update security/clamav to 0.94 [1] and fix a remote DoS [2]
- Chase libclamav version bump on all dependant ports
- Bump necessary PORTREVISIONS
- Fix some BROKEN messages from ports that were already broken with clamav-0.93
- Mark security/klamav as BROKEN since it doesn't build with clamav-0.94

PR:             ports/127122 [1], ports/127310 [2]
Submitted by:   Gary Palmer <freebsd-gnats@in-addr.com> [1], delphij [2]
Approved by:    portmgr (pav)

Update CONFIGURE_ARGS for how we pass CONFIGURE_TARGET to configure script.
Specifically, newer autoconf (> 2.13) has different semantic of the
configure target. In short, one should use --build=CONFIGURE_TARGET
instead of CONFIGURE_TARGET directly. Otherwise, you will get a warning
and the old semantic may be removed in later autoconf releases.

To workaround this issue, many ports hack the CONFIGURE_TARGET variable
so that it contains the ``--build='' prefix.

To solve this issue, under the fact that some ports still have
configure script generated by the old autoconf, we use runtime detection
in the do-configure target so that the proper argument can be used.

Changes to Mk/*:
 - Add runtime detection magic in bsd.port.mk

Unbreak, testing is finished.

test again

Break it again

Unbreak it.

Break this port for a few minutes to test some QA Tindy changes.

Bump portrevision due to upgrade of devel/gettext.

The affected ports are the ones with gettext as a run-dependency
according to ports/INDEX-7 (5007 of them) and the ones with USE_GETTEXT
in Makefile (29 of them).

PR:             ports/124340
Submitted by:   edwin@
Approved by:    portmgr (pav)

Remove extra '\'

Adjust MASTER_SITES to an other server of mine

- Update clamav to 0.90.1
- Use -lthr to build clamav since it has problems with libpthread
- Bump PORTREVISION of dependant ports, libclamav version was bumped
- Fix clamcour to build with clamav-0.90.x using patch sent by maintainer

Fix an other typo

- add SAFECAT_LDA OPTION
- fix a typo

- added safecat as LDA [1]
- give user the possibility to configure where dspam.conf is [1]
- bump PORTVERSION for OPTIONS chage for [1]
- display UPDATING entry smarter [2]

Submitted by:   Emil Isberg <emil@pyttemjuk.se> [1]
                Phil Pennock <pdp@spodhuis.demon.nl> [2] (suggestion by vd@)

Fix some typos.

Added CYRUS23_LDA "Use Cyrus's 2.3 deliver as LDA", defaults to off

PR:             ports/103910
Submitted by:   Steffen Rick <srick@srick.org>

Fix typos.

Submitted by:   brueffer

Fix CLAMAV[_DEVEL][_LOCAL] logic so one can use clamav w/o CLAMAV_LOCAL.

PR:             ports/98709
Submitted by:   Artis Caune <Artis.Caune@latnet.lv>

Fix plist; I commited the right file to my cvs, but forgot to commit it here
also :(

Submitted by:   krismail
Pointyhat:      me
Approved by:    lawrance (mentor, implicit)

Bugfixes:
- PostgreSQL fails to connect (always)
- LDAP client will not build due to header missing from makefile

Approved by:    lawrance (mentor, implicit)

Fix typo and unbreak.

Submited by:    FreshPorts Daemon.
Approved by:    lawrance (mentor, implicit)

Update to 3.6.7, a bugfix release; see files/UPDATING for details.

Drop old sql migration scripts.

Approved by:    lawrance (mentor, implicit)

Update to dspam-3.6.6 release:

Removed feature:
- Phased out deprecated Berkeley DB drivers
- Phased out legacy tools (dspam_corpus, dspam_genaliases)
Bugfixes:
- trainPristine preference turned "off" now overrides config turned "on"
- segfault fix for when correcting messages using UIDInSignature with MySQL
- when using logfile, write errors result in segfault

Approved by:    lawrance (mentor)