16:56 vd 

net-p2p/bitcoin*: remove db48 dependency

In r465909 [1], 2 years ago, we added the option to link
net-p2p/bitcoin* against db 5 or 6, still allowing to link against db
4.8 which is long time EOL and has been deprecated and marked for
deletion in 2014 [2].

Now remove the option to link net-p2p/bitcoin* against db48, so the
former does not depend on the latter anymore and db48 can be eventually
removed from the ports tree.

[1]
https://svnweb.freebsd.org/ports?view=revision&revision=465909
https://github.com/freebsd/freebsd-ports/commit/68892c74876772806eaca3a9ecc1308e9459acea

[2]
https://github.com/freebsd/freebsd-ports/commit/b0113421712e3e2543fa9e1e0726502ef475e372#diff-9385162ec22da88a3a66c47891cbde67R19

PR:		245220
Submitted by:	vd
Approved by:	kbowling (maintainer timeout)

 

17:52 vd 

net-p2p/bitcoin: Add an option to use newer BDB

Make the new option the default, so that when the port is recompiled it
will link against BDB 5.x or 6.x (whichever is the default in the system).
This will keep old wallet files readable and will not automatically
convert them in an incompatible with BDB 4.8 way. Newly created wallet
files will not be readable by Bitcoin Core versions linked with BDB 4.8.

Next thing to consider is to remove the option to link against BDB 4.8 as
this will remove the net-p2p/bitcoin -> databases/db48 dependency and will
make it possible to ditch the latter, which is scheduled for removal from
the ports collection on Apr 30 2018.

PR:		226527
Approved by:	kbowling (maintainer), antoine

 

20:58 antoine 

Revert r465619 and r465623,  the use of PORT_OPTIONS and option helpers is
incorrect

With hat:	portmgr

 

17:33 vd 

net-p2p/bitcoin: Add an option to use newer BDB

Make the new option the default, so that when the port is recompiled it
will link against BDB 5.x or 6.x (whichever is the default in the system).
This will keep old wallet files readable and will not automatically
convert them in an incompatible with BDB 4.8 way. Newly created wallet
files will not be readable by Bitcoin Core versions linked with BDB 4.8.

Next thing to consider is to remove the option to link against BDB 4.8 as
this will remove the net-p2p/bitcoin -> databases/db48 dependency and will
make it possible to ditch the latter, which is scheduled for removal from
the ports collection on Apr 30 2018.

PR:		226527
Approved by:	kbowling (maintainer)