shells/zsh: Fix build with DOCS option off and base system WITHOUT_DOCS

PR:		274713
Reviewed by:	garga
Approved by:	maintainer timeout
Sponsored by:	Rubicon Communications, LLC ("Netgate")

shells/zsh: cache the utx.active location

On fresh jails or chroot the /var/run/utx.active might not exist (like
in poudriere for example) but configure script is looking for its
existance to determine its existance and activate the build of the
utmx logging feature internally.

Caching it makes the configure script always build the logging features.

While here, make ZSH_VER use the distversion, which fixes the usecase of
building snapshots of zsh via the port.

PR:	268714
Reported by:	okiddle@yahoo.co.uk

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

shells/zsh: remove the MEM option

Remove the option allowing to use zsh memory allocator, it is only
useful for zsh developers who won't use the port anyway.

PR:	259997

shells/zsh: remove the modification of the configure script

We used to modify the configure script to avoid zsh to link against
librt because clock_gettime on FreeBSD is in libc not librt.

It's been a while that we are configuring zsh with the --as-needed
linker flag which means now even if -lrt is passed we will not end
up linked to it librt anymore.

besides, modifying the configure script at the patch phase makes it
newer than stamp.h.in which results in the build system triggering a
regeneration of itself (hence the USES= autoreconf we had), not
touching anymore that script can remove the need for USES=autoreconf
and the load if build dependencies it drags in

Removing the USES=autoreconf highlights also the lack of build
dependency on perl which is needed to be able to the help files for
 run-help to work on builtins. this is fixed now

shells: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  Adam Weinberger <adamw@FreeBSD.org>
  *  Andreas Kohn <andreas@syndrom23.de>
  *  Carlos Jacobo Puga Medina <cpm@FreeBSD.org>
  *  Cyrille.Lefevre@laposte.net
  *  Danijel Tasov <danielt@pilgerer.org>
  *  David O'Brien <obrien@NUXI.com>
  *  Emanuel Haupt <ehaupt@FreeBSD.org>
  *  Hajimu UMEMOTO <ume@FreeBSD.org>
  *  Igor Pokrovsky <ip@unixway.org>
  *  Jean-Yves Lefort <jylefort@brutele.be>
  *  Kai Wang <kaiw27@gmail.com>

shell/zsh: remove unnneeded patch

files/extra-patch-Src_Modules_curses__keys.awk is no longer needed
and broke patch phase if ports ncurses is installed.

The patch is already incorporated upstream, so doesn't apply.

shell/zsh: update to 5.9

Stop supporting case with both utmp.h and utmpx.h the changed happened
more than 10 years ago

shells/zsh: update to 5.8.1

MFH:            2022Q1
Security:       CVE-2021-45444

shells/zsh: Revert "shells/zsh: Add BASE_ZSH option"

This reverts commit ae1787aab23e44e369dbb0cc814e8318c6f86e0d.

Requested by:	maintainer

shells/zsh: Add BASE_ZSH option

Add new option BASE_ZSH that makes zsh and rzsh also available as
/bin/zsh and /bin/rzsh.

Under ports flamework everything is installed under /usr/local unless
custom prefix is used. And according to it zsh is installed as
/usr/local/bin/zsh. But on most Linux based OSes zsh is installed as
/bin/zsh. And it causes problem if user's account information is
shared between FreeBSD and Linux by using such tools as LDAP or NIS as
account information also includes absolute path of user's login shell.
To work around it I have created /bin/zsh as symbolic link referencing
/usr/local/bin/zsh and also edited /etc/shells to add /bin/zsh to it
every time I set up new FreeBSD system. But it's quite bothersome and
that is why I add new BASE_ZSH option.

While I'm here,

* Pet portclippy
* Re-format Makefile with portfmt

PR:		259109
Proposed by:	Chris Hutchinson (more intuitive option name)
Approved by:	maintainer timeout (> 2 weeks)

shells/zsh: Add CPE information

Approved by:	portmgr (blanket)

Remove # $FreeBSD$ from Makefiles.

Switch to USES=localbase:ldflags

Approved by:	portmgr blanket

shells/zsh: Fix build with devel/ncurses 6.2

When devel/ncurses is installed in the system, the Zsh configure script
detects and uses ${LOCALBASE}/include/ncurses/ncurses.h instead.

The patch is obtained from this commit:
https://sourceforge.net/p/zsh/code/ci/c6a85163619ed1cee89ab047a0d98108ed46828d/

cc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I. -I/usr/local/include
-DBOOL_DEFINED -DLIBICONV_PLUG -DHAVE_CONFIG_H -DMODULE -O2 -pipe 
-DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -fPIC -o curses..o
curses.c
In file included from curses.c:210:
./curses_keys.h:93:15: error: use of undeclared identifier 'KEY_EVENT'
    {"EVENT", KEY_EVENT},
              ^
1 error generated.
*** Error code 1

Reviewed by:	koobs
Approved by:	koobs (ports, mentor)
Differential Revision:	https://reviews.freebsd.org/D26355
MFH:		2020Q3 (build fix)

Update to 5.8

Fix sites-functions not respecting PREFIX != LOCALBASE
Don't document the security issue CVE-2019-20044 as it does not
impact FreeBSD

shells/zsh: Spell PORTREVISION correctly

Only show the pkg-message on installation, never do it on upgrades

Update to 5.7.1

Update MASTER_SITES and WWW

Approved by:	portmgr (blanket)

Add a patch to fix an infinite recursion when using VCS_info

Reported by:	ume

Commit forgotten patch:

Mandoc was not able to find zshbuiltin.1 in the path

Update to 5.7

Update `databases/gdbm' to version 1.18.1, an important bugfix release
which restores compatibility with old databases (version 1.8) and some
later versions which were built without mmap(2) support.  Due to shlib
version change, bump port revisions of the consumer ports.

PR:		233059
Exp-run by:	antoine
Approved by:	maintainer (johans, numerous timeouts)

Update to 5.6.2

update to 5.6.1

Update to 5.6

Security:	CVE-2018-0502, CVE-2018-13259

Update to 5.5.1

Update to zsh 5.5

Patch broken linux completion so that zcompile can actually compile it
Remove now useless patch for libarchive

Fix diff -u completion

PR:		222420
Submitted by:	cy

Update to 5.4.2

Due to some timestamp issue zsh may need autoheader at build time
Let's renegerate the autotools part to be safe

Reported by:	jrm

Update to 5.4.1

Fix bug in kldload completion (also reported upstream).

Approved by:	bapt@

Update to 5.3.1

Fix typo in chflags completion

Reported by:	adamw

Update ZSH to 5.3

Among the usual bugs fixes and completion updates, FreeBSD users will now
benefit new completion functions for:
- cu
- gstat
- jot
- rcctl
- sysrc

Fix make and gmake completion

Submitted by:	Daniel Shahaf (on zsh mailing list)
Reported by:	Guilherme Salazar (on zsh mailing list)

Grab back maintainership on zsh

Approved by:	adamw

Sort a few OPTIONS helpers

Reorganize, simplify, and improve the Makefile.

A couple options changes:
The MAILDIR and SECURE_FREE knobs were both removed and switched to
always-on. Having maildir support does not preclude mbox support, so
there's no reason not to include it for everybody. The secure-free
run-time free() safety check is good practice and is a mandatory default
on a number of other OS's, so now it's enabled for all zsh here as well.

PORTREVISION bump for the above changes.

The rest of the changes are simplifications, and reorganizing things to
be more legible. An EXTRA_PATCHES that was being applied unconditionally
was converted to a normal files/patch-, and I added in some comments
on things I got confused by.

While here, I also rewrote the descr to better describe what Zsh is
in relation to other shells. I also removed

	"See also zshcompsys(1) manpage. :)"

Not even a smiley face can undo the pain of trying to read zshcompsys(1).

Change the ETCDIR description to say "${PREFIX}" instead of
showing the actual prefix. Otherwise poudriere says it will
read from /nonexistent/etc.

Switch zsh back to looking for system-wide files under ${PREFIX}/etc,
rather than /etc. Add an option, ETCDIR, to switch it back to /etc.
Also includes a couple whitespace cleanups. PORTREVISION bump, and a
note in UPDATING.

PR:		201866

- No need to specify master site subdirectory when it's the same as default

Approved by:	portmgr blanket

Clean up Makefile and regenerate patches.

Reorganize Makefile for clarity, and add a few comments.
While here, regenerate the patches with makepatch.

No functional changes.

Remove ${PORTSDIR}/ from dependencies, categories r, s, t, and u.

With hat:	portmgr
Sponsored by:	Absolight

Fix ncurses detection properly. Now zsh builds and packages properly with
base and ports ncurses, static or non-static.

Many thanks to bapt for showing me the magic trick here!

Partially revert r403755. It can't build the curses module against ncurses from
ports. It probably can, but configure is too smart to figure that out.

I have no confidence that linking against curses from ports results in a
properly
working zshell. So, for now, back out the change. It will build a shared lib zsh
against ncurses from ports, but breaks statically-linked zsh's. Mark the port
as IGNORE if we're using ncurses from ports and building a static zsh.

Also, remove a regression-test target that isn't useful anymore (thanks to bapt
for the reminder about this).

I am not enthused about this change. It doesn't really "fix" the below PR, so
much as shoot ourselves in the other foot instead.

PR:	205500

Fix static build against devel/ncurses by correcting how zsh tries to link
against the terminal libraries. No PORTREVISION bump as this shouldn't really
change the generated packages.

PR:		181720
Submitted by:	wulf@mail.mipt.ru

While here, fix a spacing nit and wrap compound commands in parens.

I'll take this port.

Make zsh read again conf in /etc
Drop maintainership

We do not have yet the need for that new timestamp :)

Update to zsh 5.2
While here:
- ensure zsh looks ${PREFIX}/etc for zshrc [1]
- hook the testsuite to our test framework

PR:		201866
Submitted by:	Georgy <delycid@gmail.com>

- Switch to options helpers

Approved by:	portmgr blanket

Update to 5.1.1

Update to 5.1
Switch the default mirror to zsh.org until the distfiles appears on sourceforge

- Fix shebangs

Approved by:	portmgr blanket
MFH:		2015Q3 (blanket)

Move the SF mirrors first again

Fix du(1) completion

PR:		200768
Obtained from:	ZSH upstream

Really fix the plist

Pointyhat to:	bapt
Reported by:	many

Forgot about the plist

Update to 5.0.8

Among the usual updates, users will be happy to discover plenty of new FreeBSD
related completion as well as zpty working out of box (which wasn't the case
anymore for a while)

shells/zsh: Fix runtime error when built by gcc-5 with upstream patch

The previous approved fix for building with gcc5 still didn't work right.
Sure enough, upstream updated their patch.  When we take that update,
zshell finally behaves.  Piggybacking on previous approval.

shells/zsh: Fix runtime error when built by gcc-5 with upstream patch

ZSH was misbuilt on gcc-5 due to an intentional change in behavior of
gcc5's cpp.  This patch to execute cpp with the -P switch comes from
upstream.  No revbump necessary as GCC5 isn't used by default on FreeBSD.

Reported by:	DragonFly ZSH users
Approved by:	maintainer (bapt, IRC)

Stop installing info files, the manpages already covers the full documentation
Add --as-needed to LDFLAGS to avoid overlinking with some options

Correct time report after r367805

PR:		367805
Submitted by:	peterj

Add a patch the kld* completion to find modules in /boot/modules [1]
While here, fix manpages so they render correctly with mandoc

PR:		194621 [1]
Submitted by:	clutton@zoho.com [1]

Update to 5.0.7

Note from upstream release note:

Note in particular there is a security fix to disallow evaluation of the
initial values of integer variables imported from the environment (they
are instead treated as literal numbers).  That could allow local
privilege escalation, under some specific and atypical conditions where
zsh is being invoked in privilege elevation contexts when the
environment has not been properly sanitized, such as when zsh is invoked
by sudo on systems where "env_reset" has been disabled.

Make zsh look at its config files in localbase in priority
Cleanup a bit more the plist

Submitted by:	Rolf Nielsen <rmg1970swe@gmail.com>

Fix stage violation/allow staging as a regular user

Clean up directory handling

Regenerate the patch that corrects memory report for builtin time command

Update to 5.0.6
Only build with multibyte (disabling leads to weird bugs) [1]

Reported by:	adamw [1]

Fix build with texinfo from ports

Fix building zsh on a FreeBSD which is a NIS client [1]
Fix hangs upon '>(command)' redirections (enforce always using pipes) [2]

PR:		183253 [1], 180178 [2]
Submitted by:	Yasuhiro KIMURA <yasu@utahime.org> [1], danielsh@apache.org [2]
With help of:	jilles [2]

Test ICONV_LIB instead of being dependant on an OSVERSION

Submitted by:	tijl

Only pickup iconv from base even if libiconv is installed [1]
While here do not leak stage path info zwc bytecode

Reported & tested by:	dim [1]

Add an @shell keyword to handle adding and remove a shell path in /etc/shell
Bump port revision of all ports that were doing it wrong prior to the keyword

CR:		D208
Reviewed by:	antoine
With hat:	portmgr

Update my ports to the latest infrastructure changes

Fix properties on pkg-plist

Update to 5.0.5

Update to 5.0.4

Convert to stage, while here, cleanup a bit

Add NO_STAGE all over the place in preparation for the staging support (cat:
shells)

- Fix a typo in configure arguments
- Bump port revision as it concerns a default option

Submitted by:	Paul Mulders <justinkb@gmail.com> (by private mail)

Fix a confusion

Reported by:	wg

Use new helpers

Adopt USES=ncurses

- Convert USE_ICONV=yes to USES=iconv
- Change USE_GNOME=pkgconfig|gnomehack to USES=pathfix|pkgconfig and
  USE_GETTEXT=yes to USES=gettext while here

Variable that start with _ are considered private to the defining
makefile and may not be used by ports makefiles.
In addition, avoid problems should the defaults ever change.

Approved by:	portmgr (tabthorpe)

- update to 5.0.2

- update to 5.0.1

Update PCRE to 8.32
Introduces the UTF-32 library pcre32
Bump PORTREVISION in dependent ports

- Add the documentation to distinfo [1]
- Fix plist

Reported by:	zi [1]

- update to 5.0.0
no much changes for us (we where following the 4.3.x dev branch for a while)
except we are back on an official stable branch

Note that this version offers completion for dtrace, beadm (not tested with
FreeBSD versions) and improved completion for zfs.

Double quotes not needed anymore for options description

Show up debug flags
Add shared DEBUG description

Fix descriptions with "()"

Reported by:    freshports sanity check

Convert to new option framework