notbugIf you buy from Amazon USA, please support us by using this link.
non port: Mk/Scripts/qa.sh
SVNWeb

Number of commits found: 104 (showing only 100 on this page)

1 | 2  »  

Sat, 22 Sep 2018
[ 16:45 sunpoet ] Original commit   Revision:480421
480421 Mk/Scripts/qa.sh
Fix typo

Differential Revision:	https://reviews.freebsd.org/D17263
Approved by:	bapt (portmgr)
Thu, 26 Jul 2018
[ 10:37 mat ] Original commit   Revision:475360
475360 Mk/Scripts/qa.sh
475360 Mk/bsd.port.mk
Tell people who disabled LICENSE processing that it then cannot be
checked.

Reported by:	mfechner
Approved by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D16450
Wed, 18 Jul 2018
[ 11:33 mat ] Original commit   Revision:474853
474853 Mk/Scripts/qa.sh
Have the license qa check actually work.

Pointy hat:	mat
Sponsored by:	Absolight
[ 11:13 mat ] Original commit   Revision:474850
474850 Mk/Scripts/qa.sh
474850 Mk/bsd.port.mk
Add a license qa check to tell porters when their ports will be mostly
useless.

Reviewed by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D16103
Thu, 28 Jun 2018
[ 17:39 tcberner ] Original commit   Revision:473503
473503 CHANGES
473503 Mk/Scripts/qa.sh
473503 Mk/Uses/qmake.mk
473503 Mk/Uses/qt-dist.mk
473503 Mk/Uses/qt.mk
473503 Mk/bsd.port.mk
473503 Mk/bsd.qt.mk
473503 Mk/bsd.sanity.mk
473503 accessibility/jovie-kde4/Makefile
473503 accessibility/kaccessible-kde4/Makefile

(Only the first 10 of 1416 ports in this commit are shown above. View all ports for this commit)
Replace bsd.qt.mk by Uses/qt.mk and Uses/qt-dist.mk

From now on, ports that depend on Qt4 will have to set
	USES=		qt:4
	USE_QT=		foo bar
ports depending on Qt5 will use
	USES=		qt:5
	USE_QT=		foo bar

PR:		229225
Exp-run by:	antoine
Reviewed by:	mat
Approved by:	portmgr (antoine)
Differential Revision:	-https://reviews.freebsd.org/D15540
Fri, 8 Jun 2018
[ 09:26 mat ] Original commit   Revision:471994
471994 Mk/Scripts/qa.sh
471994 Mk/Scripts/smart_makepatch.sh
SC1004: This backslash+linefeed is literal. Break outside single quotes if you
just want to break the line.

You have a single quoted string containing a backslash followed by a
linefeed (newline). Unlike double quotes or unquoted strings, this has
no special meaning. The string will contain a literal backslash and a
linefeed.

If you wanted to break the line but not add a linefeed to the string,
stop the single quote, break the line, and reopen it.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
[ 09:26 mat ] Original commit   Revision:471992
471992 Mk/Scripts/check-stagedir.sh
471992 Mk/Scripts/check_leftovers.sh
471992 Mk/Scripts/generate-symbols.sh
471992 Mk/Scripts/qa.sh
SC2162: read without -r will mangle backslashes.

By default, read will interpret backslashes before spaces and line
feeds, and otherwise strip them. This is rarely expected or desired.

Normally you just want to read data, which is what read -r does. You
should always use -r unless you have a good reason not to.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
[ 09:26 mat ] Original commit   Revision:471991
471991 Mk/Scripts/qa.sh
SC2015: Note that A && B || C is not if-then-else. C may run when A is true.

It's common to use A && B to run B when A is true, and A || C to run C
when A is false.

However, combining them into A && B || C is not the same as if A then B
else C.

In this case, if A is true but B is false, C will run.

If an if clause is used instead, this problem is avoided.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
Fri, 1 Jun 2018
[ 16:20 mat ] Original commit   Revision:471274
471274 Mk/Scripts/actual-package-depends.sh
471274 Mk/Scripts/create-manifest.sh
471274 Mk/Scripts/find-lib.sh
471274 Mk/Scripts/qa.sh
SC2006: Use $(..) instead of legacy `..`.

Backtick command substitution `STATEMENT` is legacy syntax with several
issues.

 - It has a series of undefined behaviors related to quoting in POSIX.
 - It imposes a custom escaping mode with surprising results.
 - It's exceptionally hard to nest.

$(STATEMENT) command substitution has none of these problems, and is
therefore strongly encouraged.

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
[ 16:20 mat ] Original commit   Revision:471272
471272 Mk/Scripts/qa.sh
SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

cd can fail for a variety of reasons: misspelled paths, missing
directories, missing permissions, broken symlinks and more.

If/when it does, the script will keep going and do all its operations in
the wrong directory. This can be messy, especially if the operations
involve creating or deleting a lot of files.

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
[ 16:20 mat ] Original commit   Revision:471271
471271 Mk/Scripts/qa.sh
SC2153: Possible misspelling: PORTNAME may not be assigned, but portname is.

ShellCheck has noticed that you reference a variable that is not
assigned in the script, which has a name remarkably similar to one that
is explicitly assigned. You should verify that the variable name is
spelled correctly.

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
[ 16:20 mat ] Original commit   Revision:471270
471270 Mk/Scripts/qa.sh
SC2091: Remove surrounding $() to avoid executing output.

ShellCheck has detected that you have a command that just consists of a
command substitution.

This is typically done in order to try to get the shell to execute a
command, because $(..) does indeed execute commands. However, it's also
replaced by the output of that command.

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
[ 16:20 mat ] Original commit   Revision:471264
471264 Mk/Scripts/functions.sh
471264 Mk/Scripts/generate-symbols.sh
471264 Mk/Scripts/qa.sh
SC2145: Argument mixes string and array. Use * or separate argument.

The behavior when concatenating a string and array is rarely intended.
The preceeding string is prefixed to the first array element, while the
succeeding string is appended to the last one. The middle array elements
are unaffected.

For example, with the parameters foo,bar,baz, "--flag=$@" is equivalent
to the three arguments "--flag=foo" "bar" "baz".

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
Thu, 10 May 2018
[ 23:00 bdrewery ] Original commit   Revision:469589
469589 Mk/Scripts/qa.sh
stage-qa: Change stripped check to only look for .debug_info.

'strip -x', and splitting out debug symbols with objcopy, will leave
a .symtab section but will still remove the .debug_info section.  file(1)
shows this distinction as well after the use of 'strip -x':

    work/tcl8.7a1/unix/libtcl8.7.so:       ELF 64-bit LSB shared object, x86-64,
version 1 (FreeBSD), dynamically linked, with debug_info, not stripped
    work/stage/usr/local/lib/libtcl8.7.so: ELF 64-bit LSB shared object, x86-64,
version 1 (FreeBSD), dynamically linked, not stripped

This fixes false-positives when using install-strip and symbol splitting.

With hat:	portmgr
Wed, 7 Mar 2018
[ 09:17 mat ] Original commit   Revision:463782
463782 Mk/Scripts/qa.sh
Handle flavors in the proxydeps qa check.

Reviewed by:	bdrewery
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D14595
Tue, 6 Mar 2018
[ 16:25 mat ] Original commit   Revision:463734
463734 Mk/Scripts/qa.sh
Add a hint about devel/boost-python-libs.

Sponsored by:	Absolight
Mon, 22 Jan 2018
[ 16:35 tz ] Original commit   Revision:459673
459673 Mk/Scripts/qa.sh
459673 Mk/bsd.port.mk
add new stage-qa target: gemfiledeps

This checks whether rubygem based ports have all of their dependencies
in Gemfile(s) satisfied by what's currently installed. Sample output:

====> Running Q/A tests (stage-qa)
Warning: Dependencies defined in
/usr/ports/www/gitlab/work/stage/usr/local/www/gitlab/Gemfile are not satisfied

These ports could (!) be broken at runtime. Be aware: some projects
defines multiple Gemfiles and not all are used at runtime. For example
www/gitlab has two Gemfiles, but only one is used for testing and warnings
about it can be ignored.

Approved by: portmgr (mat), lifanov
Differential Revision: https://reviews.freebsd.org/D11865
Thu, 21 Dec 2017
[ 13:27 amdmi3 ] Original commit   Revision:456908
456908 Mk/Scripts/qa.sh
456908 Mk/Uses/shebangfix.mk
Report (in q/a) and fix (in shebangfix) python[23] shebangs

Currently, only python shebangs (e.g. /bin/python, /usr/local/bin/python,
/usr/bin/env python etc.) are reported by stage Q/A and fixed by
USES=shebangfix. We need to do the same for python[23] as well.

Before the problem was not noticeable since many ports had e.g.
USES=python:2, which added a dependency on python2 metaport, however
that's going to switch to USES=python:2.7, and neither it, nor more
widely used USES=python adds a dependency on metaports, so there's
very high probability that python[23] links are not available.

Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D13571
Fri, 15 Dec 2017
[ 15:56 mat ] Original commit   Revision:456405
456405 Mk/Scripts/qa.sh
Fix qa lib dependency checks when using libmap.conf.

This happens, for instance, if x11/nvidia-driver is installed.

PR:		221406
Submitted by:	tobik
Approved by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D11977
Thu, 30 Nov 2017
[ 15:33 mat ] Original commit   Revision:455205
455205 CHANGES
455205 Mk/Scripts/qa.sh
455205 Mk/bsd.port.mk
455205 Tools/scripts/MOVEDlint.awk
Generic FLAVORS work.

- Enable FLAVORS.
- Make make describe flavors aware.
- Add a qa check for unique package names amongst flavors.
- Make MOVEDlint understand flavors.
- Add a bit of sanity check to make sure FLAVORS stay lowercase.
- Various fixes.

Reviewed by:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D12577
Wed, 4 Oct 2017
[ 21:01 adridg ] Original commit   Revision:451250
451250 Mk/Scripts/qa.sh
Take out the check that suggests that all <foo>-qt5 ports should be
part of USE_QT5, since all of those suggestions are wrong.

Approved by:	rakuco (mentor), tcberner (mentor), portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D12526
Mon, 25 Sep 2017
[ 22:45 mat ] Original commit   Revision:450638
450638 Mk/Scripts/qa.sh
Remove a useless block in the shebang checks.

* Once upon a time, we checked all of STAGEDIR/PREFIX's executable
  files.
* We then decided too many false positives were found, so we switched to
  only checking executable files in bin/sbin/libexec/www, and also
  symlinks that were in there.
* And then, we decided to go back to check all of STAGEDIR/PREFIX's
  executable files, but forgot to remove the checks for symlinks (which
  are now useless because we already check all the executable files.)

Reported by:	lifanov
Sponsored by:	Absolight
Fri, 22 Sep 2017
[ 10:48 mat ] Original commit   Revision:450351
450351 Mk/Scripts/qa.sh
450351 Mk/Uses/execinfo.mk
450351 astro/opencpn/Makefile
450351 audio/clementine-player/Makefile
450351 audio/deadbeef/Makefile
450351 audio/pulseaudio/Makefile
450351 audio/sayonara/Makefile
450351 biology/seqtools/Makefile
450351 biology/ugene/Makefile
450351 cad/klayout/Makefile

(Only the first 10 of 175 ports in this commit are shown above. View all ports for this commit)
Remove USES=execinfo.

PR:		220271
Submitted by:	mat (review), Yasuhiro KIMURA (PR)
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D11488
Mon, 7 Aug 2017
[ 19:09 lifanov ] Original commit   Revision:447515
447515 Mk/Scripts/qa.sh
447515 Mk/bsd.port.mk
add new stage-qa target: gemdeps

This checks whether rubygem ports have all of their dependencies
in gemspec satisfied by what's currently installed. Sample output:

====> Running Q/A tests (stage-qa)
Error: RubyGem dependency archive-tar-minitar = 0.5.2 is not satisfied.
*** Error code 1

Stop.
make: stopped in
/usr/home/lifanov/src/svn/freebsd/ports/head/archivers/rubygem-fpm

These ports would be broken at runtime.

Big thanks to:
  swills - discussion
  mat - reviews
  antoine - exp runs
  sunpoet - fixing several dozens of ports :)

PR:		220605
Reviewed by:	mat, sunpoet
Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D11841
Sat, 5 Aug 2017
[ 22:07 kwm ] Original commit   Revision:447413
447413 Mk/Scripts/qa.sh
Add gstreamer 0.10 and 1.0 hints to the qa script.

Approved by:	portmgr (bapt@)
Differential Revision:	https://reviews.freebsd.org/D11610
Sun, 18 Jun 2017
[ 18:09 dbn ] Original commit   Revision:443845
443845 Mk/Scripts/qa.sh
443845 Mk/Uses/cran.mk
443845 Mk/bsd.port.mk
443845 archivers/py-rcssmin/Makefile
443845 archivers/py-rjsmin/Makefile
443845 converters/R-cran-RJSONIO/Makefile
443845 converters/R-cran-rjson/Makefile
443845 databases/R-cran-RSQLite.extfuns/Makefile
443845 databases/R-cran-RSQLite/Makefile
443845 databases/p5-CDB_File/Makefile

(Only the first 10 of 79 ports in this commit are shown above. View all ports for this commit)
qa: add check for NO_ARCH

If NO_ARCH is set then check that no FreeBSD elf(5) files are in $STAGEDIR.
If an elf(5) file is bundles as part of the package, but is not meant to be
run directly (i.e. the elf(5) file is a payload, and not compiled) then
those files can be added to NO_ARCH_IGNORE to avoid the check from failing,

Changes to ports:
 - Ports that have NO_ARCH set, but actually compile files have had NO_ARCH
   removed.
 - Ports that have elf(5) payloads have had those files added to
   NO_ARCH_IGNORE.
 - R-cran ports that do not set USES=cran:compiles have NO_ARCH set,

PR:		218976
Reviewed by:	antoine, mat
Approved by:	portmgr
Fri, 12 May 2017
[ 18:46 rezny ] Original commit   Revision:440699
440699 MOVED
440699 Mk/Scripts/qa.sh
440699 Mk/bsd.port.mk
440699 Mk/bsd.xorg.mk
440699 emulators/i386-wine-devel/Makefile.i386
440699 emulators/i386-wine/Makefile.i386
440699 graphics/Makefile
440699 graphics/copperspice/Makefile
440699 graphics/dri
440699 graphics/gbm

(Only the first 10 of 52 ports in this commit are shown above. View all ports for this commit)
Consolidate the Mesa ports, update to 17.0.4, and add Wayland option

* libGL, libEGL, libglesv2, libglapi, and gbm have been moved into mesa-libs,
  graphics/dri has been renamed to mesa-dri, and USE_GL has been adjusted
* mesa-libs has a new WAYLAND option that enables platform support in libEGL
* mesa-dri now depends on graphics/s2tc for compressed texture support [1]
* re-remove obsolete dependency on makedepends [2]
* correct sed fix backported from 17.1 [3]

PR:		218799 (exp-run), 212762 [1], 218552 [2], 218562 [3]
Submitted by:	dbn [1], jbeich [2,3]
Reported by:	afiskon@devzen.ru [1]
Reviewed by:	kwm, johalun0@gmail.com
Approved by:	portmgr, swills (mentor)
Differential Revision:  https://reviews.freebsd.org/D10448
Wed, 10 May 2017
[ 13:03 mat ] Original commit   Revision:440560
440560 Mk/Scripts/qa.sh
Sometime, USES=iconv does not bring in the required dependency.

Reported by:	kwm
Sponsored by:	Absolight
Fri, 21 Apr 2017
[ 08:56 amdmi3 ] Original commit   Revision:439032
439032 Mk/Scripts/qa.sh
- Add /bin/rc to blacklist for qa.sh, since it's not available on FreeBSD

Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D10426
Mon, 10 Apr 2017
[ 15:21 amdmi3 ] Original commit   Revision:438176
438176 Mk/Scripts/qa.sh
Treat python shebangs without version specified (e.g. `/usr/local/bin/python'
and `/usr/bin/env python') as invalid, because ports always depend on specific
version of python (e.g. python2 or python3), and generic `python'
which is link to either of them may point to incorrect version or
be not available at all (since it's installed by separate optional
python metaport)

Approved by:	portmgr (mat), python (sunpoet)
Differential Revision:	D9332
[ 14:19 amdmi3 ] Original commit   Revision:438168
438168 Mk/Scripts/qa.sh
Don't limit Q/A check for bad shebangs with just bin, sbin, libexec
and www. Scripts (with possibly incorrect shebangs) may be located
anywhere in ${PREFIX}, including, for instance, lib/ (multimedia/lives):

Error: '/usr/bin/perl' is an invalid shebang you need USES=shebangfix for
'lib/lives/plugins/effects/rendered/colour_replace'

and ${DATADIR}/ (databases/cego):

Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for
'share/cego/cgbackup'

There may be some more false positives, but broken scripts are much
more severe problem. There's also whitelist mechanism which lets
you ignore shebangs for certain kinds of files (like .pm) which may
be extended to fix FPs

Approved by:	portmgr (swills)
Differential Revision:	D8923
Tue, 4 Apr 2017
[ 14:06 mat ] Original commit   Revision:437734
437734 Mk/Scripts/qa.sh
The lang/perl5* ports are allowed to have their shebangs pointing to the
versionned binaries.

Sponsored by:	Absolight
Sat, 1 Apr 2017
[ 22:21 bapt ] Original commit   Revision:437499
437499 Mk/Scripts/qa.sh
437499 Mk/Uses/gnome.mk
Finish removal of gal2
[ 22:05 bapt ] Original commit   Revision:437494
437494 MOVED
437494 Mk/Scripts/qa.sh
437494 Mk/Uses/gnome.mk
437494 databases/Makefile
437494 databases/libgda4
437494 databases/libgda4-bdb
437494 databases/libgda4-jdbc
437494 databases/libgda4-ldap
437494 databases/libgda4-mdb
437494 databases/libgda4-mysql

(Only the first 10 of 13 ports in this commit are shown above. View all ports for this commit)
Remove more obsolete gnome2 components
[ 20:15 bapt ] Original commit   Revision:437469
437469 Mk/Scripts/qa.sh
Catchup with recent removals
Sat, 11 Feb 2017
[ 16:43 kwm ] Original commit   Revision:433892
433892 Mk/Scripts/qa.sh
433892 graphics/libEGL/Makefile
433892 graphics/libEGL/pkg-deinstall
433892 graphics/libEGL/pkg-install
433892 graphics/libEGL/pkg-plist
433892 graphics/libGL/Makefile
433892 graphics/libGL/pkg-deinstall
433892 graphics/libGL/pkg-install
433892 graphics/libGL/pkg-plist
433892 graphics/libglesv2/Makefile

(Only the first 10 of 20 ports in this commit are shown above. View all ports for this commit)
Now that all supported FreeBSD versions support libmap.conf files installed
from ports, remove the symlink dance with libGL/libEGL/libgles and the
nvidia-driver ports.

* Revert libGL/libEGL/libglesv2 ports to normal.
* Rename the conflicting libraries from the nvidia-driver ports with a
  -NVIDIA prefix and install a libmap.conf file to map to these versions.
* Remove the special case from Mk/Scripts/qa.sh for libGL and libEGL.
* Sadly the symlink dance between nvidia-driver and xorg-server for glx.so
  need to stay, due to xorg-server opening that file with dlopen(3).

Approved by:	portmgr@ (mat@ (prio version))
Differential Revision:	https://reviews.freebsd.org/D7848
Tue, 31 Jan 2017
[ 16:21 mat ] Original commit   Revision:432931
432931 Mk/Scripts/qa.sh
432931 Mk/Uses/perl5.mk
Tell Module::Build to use LOCALBASE/bin/perl and not
LOCALBASE/bin/perl5.xx.y.

Add a QA check to test for it.

Sponsored by:	Absolight
Thu, 19 Jan 2017
[ 15:06 mat ] Original commit   Revision:431881
431881 Mk/Scripts/qa.sh
Provide a port/perl module mapping utility.

Sometime, Perl ports names do not map to the modules they provide
easily, and it makes it impossible to check for the existence of those
modules in Perl core.

Sponsored by:	Absolight
Fri, 9 Dec 2016
[ 14:24 mat ] Original commit   Revision:428207
428207 Mk/Scripts/qa.sh
Report the binary with bad linking.

Sponsored by:	Absolight
Sat, 3 Dec 2016
[ 21:30 sunpoet ] Original commit   Revision:427742
427742 Mk/Scripts/qa.sh
- Skip soname check if ${STAGEDIR}${PREFIX}/lib directory does not exist

Differential Revision:	https://reviews.FreeBSD.org/D8697
Approved by:	mat (portmgr)
Mon, 14 Nov 2016
[ 16:12 tcberner ] Original commit   Revision:426118
426118 MOVED
426118 Mk/Scripts/qa.sh
426118 Mk/Uses/kde.mk
426118 archivers/Makefile
426118 archivers/kf5-karchive
426118 archivers/kf5-karchive/Makefile
426118 archivers/kf5-karchive/distinfo
426118 archivers/kf5-karchive/pkg-descr
426118 archivers/kf5-karchive/pkg-plist
426118 chinese/fcitx/Makefile

(Only the first 10 of 383 ports in this commit are shown above. View all ports for this commit)
Importing KDE Frameworks into the ports tree (required for newer KDE Desktop and
Applications)

KDE Frameworks is a collection of libraries and software frameworks by KDE
that serve as technological foundation for KDE Plasma 5 and KDE Applications
distributed under the GNU Lesser General Public License (LGPL) [1].

The work is based on what we have in the KDE testing repo [2].

This is the next big step in updating the KDE Desktop and its Applications
to anything less dusty.

With this change, `USES=kde:5` is now a valid option. Ports that need to depend
on KDE Framework can now set:
	USES=kde:5
	USE_KDE=<framework1> <framework2> ... <frameworkX>
(Only the first 15 lines of the commit message are shown above View all of this commit message)
Sat, 29 Oct 2016
[ 10:10 mat ] Original commit   Revision:424899
424899 Mk/Scripts/qa.sh
424899 Mk/bsd.port.mk
Add a Perl CORE QA check.

This will use Module::CoreList to tell you if a dependency you added can
be removed, or only conditionally added.

Approved by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D7832
Tue, 25 Oct 2016
[ 11:44 mat ] Original commit   Revision:424616
424616 Mk/Scripts/qa.sh
Do not force a lookup in LOCALBASE/lib for shared libraries.

ldd should work correctly if rpath is set, and this adds false
positives.

PR:		213547
Submitted by:	John Hein
Sponsored by:	Absolight
Thu, 20 Oct 2016
[ 13:19 mat ] Original commit   Revision:424326
424326 Mk/Scripts/qa.sh
424326 net/foreman-proxy/Makefile
Replace non breaking space \xa0 with a normal space.

Sponsored by:	Absolight
Tue, 13 Sep 2016
[ 20:35 kwm ] Original commit   Revision:422084
422084 Mk/Scripts/qa.sh
Add ncurses suggestion to qa.sh.

Approved by:	portmgr (mat@)
Differential Revision:	https://reviews.freebsd.org/D7885
Thu, 8 Sep 2016
[ 14:12 mat ] Original commit   Revision:421555
421555 Mk/Scripts/qa.sh
Provide a standard way to look up for executables and shared libraries.

PR:		211146
Submitted by:	yuri rawbw com
Sponsored by:	Absolight
[ 14:12 mat ] Original commit   Revision:421553
421553 Mk/Scripts/qa.sh
Disable some checks for linux ports.

- shebang check: skip scripts in LINUXBASE.  Things like /bin/bash are
  valid in a Linux context.  Also, these scripts usually only work with
  a Linux shell so it doesn't make sense to try to make them work from a
  FreeBSD shell.
- prefixvar check: allow LINUXBASE/var.
- proxydeps check: only test FreeBSD ELF files because ldd(1) doesn't
  work with other ELF files.

PR:		212419
Submitted by:	tijl
Sponsored by:	Absolight
Mon, 29 Aug 2016
[ 15:23 mat ] Original commit   Revision:421068
421068 Mk/Scripts/qa.sh
421068 Mk/bsd.port.mk
Add a stage-qa check to check for the existence of SONAME in .so's.

If a port provides .so.X files, they have to have a SONAME for them to
work correctly.

While there, incorporate a reverse soname checks in proxydeps.
A port that needs a .so.X from another port which does not have a
SONAME.

Reviewed by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D7454
Fri, 26 Aug 2016
[ 12:43 mat ] Original commit   Revision:420914
420914 Mk/Scripts/qa.sh
420914 Mk/Uses/kde.mk
Use LIB_DEPENDS when appropriate in KDE components.

Lots of KDE components are providing libraries, and they were,
strangely, written as BUILD_ or RUN_DEPENDS, with a full path to the
library.  Change this so that if a component is needed at both build,
and, run-time, then it gets a LIB_DEPENDS.

Reviewed by:	rakuco, tcberner
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D7625
Fri, 5 Aug 2016
[ 18:29 mat ] Original commit   Revision:419700
419700 Mk/Scripts/qa.sh
Tell people to add USES=gettext-runtime, not USES=gettext.

This is done after the port has been built, so it is already building,
so it does not need to be added a BUILD_DEPENDS on gettext-tools.

Discussed with:	dumbbell
Sponsored by:	Absolight
Thu, 30 Jun 2016
[ 09:59 mat ] Original commit   Revision:417821
417821 Mk/Scripts/qa.sh
Only warn about symlinks that exist in the stage directory, or that
exist nowhere.

Sponsored by:	Absolight
Tue, 28 Jun 2016
[ 07:58 amdmi3 ] Original commit   Revision:417699
417699 Mk/Scripts/qa.sh
- Fix typo: "you need USES=nssl" -> "you need USES=ssl"

Approved by:	mat
Differential Revision:	D6997
Mon, 27 Jun 2016
[ 13:26 mat ] Original commit   Revision:417658
417658 Mk/Scripts/qa.sh
417658 Mk/bsd.port.mk
Catch up two instances of USE_OPENSSL.

Sponsored by:	Absolight
[ 11:31 mat ] Original commit   Revision:417651
417651 CHANGES
417651 Mk/Scripts/qa.sh
417651 Mk/Uses/ssl.mk
417651 Mk/bsd.openssl.mk
417651 Mk/bsd.port.mk
417651 Mk/bsd.sanity.mk
417651 devel/libopkele/Makefile
417651 devel/p5-Event-RPC/Makefile
417651 dns/opendd/Makefile
417651 ftp/vsftpd-ext/Makefile

(Only the first 10 of 14 ports in this commit are shown above. View all ports for this commit)
Replace bsd.openssl.mk with USES=ssl

Add a qa hint about needing, or not, USES=ssl.

Fix ports doing silly things, like including bsd.openssl.mk directly.

PR:		210322
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6866
Thu, 23 Jun 2016
[ 11:31 mat ] Original commit   Revision:417364
417364 Mk/Scripts/qa.sh
Extend the symlink checks to warn on absolute targets.

Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6930
Thu, 16 Jun 2016
[ 14:32 mat ] Original commit   Revision:416970
416970 Mk/Scripts/qa.sh
Add USE_OPENSSL to the proxy libs thing.

Sponsored by:	Absolight
Sat, 28 May 2016
[ 17:16 amdmi3 ] Original commit   Revision:416052
416052 Mk/Scripts/qa.sh
Fix sed command in proxydeps_suggest_uses qa.sh check

It led to incorrect "you need USE_XORG+" suggestion

Submitted by:	amdmi3
Approved by:	portmgr (bapt)
Differential Revision:	D6618
Wed, 25 May 2016
[ 11:59 mat ] Original commit   Revision:415827
415827 CHANGES
415827 Mk/Scripts/qa.sh
415827 Mk/bsd.port.mk
A new stage-qa test has been added, it reports all shared libraries
dependencies that are not part of the port list of dependencies.  It help
finds what is called proxy dependencies.

A is needed by B, and B is needed by C.  If C also needs A, then it needs to
be registered, and this check will tell you to do so.

Right now, it is only reporting the problems, but if you add
PROXYDEPS_FATAL=yes to your environment, it will give an error and will force
you to fix the dependencies.

PR:		195203
Submitted by:	yuri rawbw com (earlier version)
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6531
Fri, 20 May 2016
[ 19:01 mat ] Original commit   Revision:415573
415573 Mk/Scripts/actual-package-depends.sh
415573 Mk/Scripts/check-stagedir.sh
415573 Mk/Scripts/check_leftovers.sh
415573 Mk/Scripts/depends-list.sh
415573 Mk/Scripts/dialog4ports.sh
415573 Mk/Scripts/do-depends.sh
415573 Mk/Scripts/do-users-groups.sh
415573 Mk/Scripts/find-lib.sh
415573 Mk/Scripts/qa.sh
415573 Mk/Scripts/smart_makepatch.sh
Ease debugging of Mk/Scripts scripts.

Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6474
Mon, 9 May 2016
[ 10:12 mat ] Original commit   Revision:414832
414832 Mk/Scripts/qa.sh
414832 Mk/bsd.port.mk
414832 lang/perl5-devel/Makefile
414832 lang/perl5.18/Makefile
414832 lang/perl5.20/Makefile
414832 lang/perl5.22/Makefile
Try to simplify how libperl.so is looked for.

PR:		209123
Submitted by:	mat
Exp-run by:	antoine
With hat:	perl@
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6107
Thu, 21 Jan 2016
[ 16:18 swills ] Original commit   Revision:406868
406868 Mk/Scripts/qa.sh
exclude all gem stuff from path check
Mon, 18 Jan 2016
[ 16:16 mat ] Original commit   Revision:406594
406594 Mk/Scripts/qa.sh
Be consistent and always enclose shell variables inside braces.

Sponsored by:	Absolight
[ 16:16 mat ] Original commit   Revision:406593
406593 Mk/Scripts/qa.sh
Rework the logic of the libperl detection, making it a bit more simple,
and also a bit more verbose.

With hat:	perl
Sponsored by:	Absolight
Fri, 25 Dec 2015
[ 23:22 antoine ] Original commit   Revision:404488
404488 Mk/Scripts/qa.sh
Do not advise to strip object files, it can be harmful

Reported by:	koobs
With hat:	portmgr
Mon, 19 Oct 2015
[ 16:59 bdrewery ] Original commit   Revision:399699
399699 Mk/Scripts/qa.sh
Switch strip test to using readelf(1) instead of file(1) to identify symbols.

This has been slightly faster in my tests since readelf(1) will fail on the
file much quicker if it doesn't find the ELF headers.  This also more directly
finds the symbol table.

With hat:	portmgr
Thu, 8 Oct 2015
[ 14:12 amdmi3 ] Original commit   Revision:398827
398827 Keywords/terminfo.ucl
398827 Mk/Scripts/qa.sh
398827 Mk/Uses/terminfo.mk
398827 Mk/bsd.port.mk
398827 devel/ncurses/Makefile
398827 devel/ncurses/pkg-plist
398827 sysutils/jfbterm/Makefile
398827 sysutils/jfbterm/pkg-plist
398827 x11/rxvt-unicode/Makefile
398827 x11/rxvt-unicode/files/patch-doc_Makefile.in

(Only the first 10 of 11 ports in this commit are shown above. View all ports for this commit)
Add a way to cleanly handle terminfo.db file used by devel/ncurses

This database contains compiled terminfo entries and is merged from
a large part which comes with ncurses themselves and compiled
.terminfo files installed by other ports (currently only rxvt-unicode
and jfbterm)

- Now the database is always kept up to date, regardless of port
  installation order (both ncurses installed before .terminfo files
  and the other way around work as expected)
- All affected ports now support clean deinstallation and do not
  produce stage-qa errors
- Affected ports are simplified, as they now only need to define
  USES=terminfo
- rxvt-unicode no longer pulls in ncurses: the dependency is not
  really needed for anything beside updating it's own database
- The patch contains Q/A test to check whether a port needs, or
  needs not USES=terminfo

Approved by:	portmgr (mat, bapt)
Differential Revision:	D3747
Mon, 10 Aug 2015
[ 17:06 antoine ] Original commit   Revision:393878
393878 Mk/Scripts/qa.sh
Make baselibs QA check non recursive and activate it again

Reviewed by:	bapt
Differential Revision:	https://reviews.freebsd.org/D3352
Sun, 9 Aug 2015
[ 11:41 bapt ] Original commit   Revision:393778
393778 Mk/Scripts/qa.sh
Disable baselibs check until it is made saner (aka non recursive)
[ 10:10 antoine ] Original commit   Revision:393773
393773 Mk/Scripts/qa.sh
Fix a typo that made baselibs QA check run twice on some files

With hat:	portmgr
Sun, 19 Jul 2015
[ 22:19 bapt ] Original commit   Revision:392541
392541 Mk/Scripts/qa.sh
Fix path of libedit
[ 22:07 bapt ] Original commit   Revision:392538
392538 Mk/Scripts/qa.sh
Add a QA check on some base libraries (for now only libedit and libarchive)
Tue, 14 Jul 2015
[ 20:36 amdmi3 ] Original commit   Revision:392087
392087 Mk/Scripts/qa.sh
- Add /usr/sbin/dtrace to the list of allowed shebangs

Submitted by:	amdmi3
Approved by:	portmgr (bapt)
Differential Revision:	D3070
Thu, 4 Jun 2015
[ 11:37 amdmi3 ] Original commit   Revision:388526
388526 Mk/Scripts/qa.sh
- Add blacklist of files which are not intended to be executed to shebang test
- Sort shebang list

Differential Revision:	D2670
Submitted by:	amdmi3
Approved by:	portmgr (bapt)
Wed, 20 May 2015
[ 19:47 amdmi3 ] Original commit   Revision:386884
386884 Mk/Scripts/qa.sh
- Add ${PREFIX}/www to shebang check. We have many shebang problems which need
to be discovered and fixed in www category.

Differential Revision:	D2580
Approved by:	portmgr (bapt)
Thu, 30 Apr 2015
[ 02:44 bdrewery ] Original commit   Revision:385021
385021 Mk/Scripts/qa.sh
Fix strip check to consider setuid binaries.

file(1) returns 'setuid' before the rest of the ELF output.

With hat:	portmgr
Sponsored by:	EMC / Isilon Storage Division
Mon, 20 Apr 2015
[ 19:06 tijl ] Original commit   Revision:384380
384380 Mk/Scripts/qa.sh
384380 Mk/bsd.port.mk
384380 audio/ample/Makefile
384380 databases/monetdb/Makefile
384380 devel/global/Makefile
384380 dns/opendnssec/Makefile
384380 dns/opendnssec13/Makefile
384380 games/acm/Makefile
384380 games/acm/files/patch-dis-disgen-configure
384380 games/wolfpack/Makefile

(Only the first 10 of 32 ports in this commit are shown above. View all ports for this commit)
- Display a stage-qa warning when ports use PREFIX/var instead of /var
- Add --localstatedir=/var to _LATE_CONFIGURE_ARGS (like --mandir) but not
  when CONFIGURE_ARGS already sets it.  (GNU configure scripts set it to
  PREFIX/var when PREFIX != /usr.)
- Add --localstatedir="${PREFIX}/var" to CONFIGURE_ARGS in some ports so
  they aren't affected by this change (for now at least).  This commit is
  meant to ensure that new ports don't make the same mistake.

- games/acm: the configure script in this port is very old; instead of
  patching it more, just replace GNU_CONFIGURE with HAS_CONFIGURE.
- irc/charybdis: it already used /var but adding --localstatedir=/var
  changed the behaviour of the configure script; adjust the port to this.

PR:		199506
Exp-run by:	antoine
Approved by:	portmgr (antoine)
Mon, 23 Mar 2015
[ 20:41 feld ] Original commit   Revision:382038
382038 Mk/Scripts/qa.sh
Speed up checking for stripped binaries

Skip ascii files. This significantly speeds up stage-qa on ports with a
considerable amount of text files being installed.

Differential Revision:	https://reviews.freebsd.org/D2121
Approved by:	bdrewery
Tue, 23 Dec 2014
[ 00:27 mat ] Original commit   Revision:375297
375297 Mk/Scripts/qa.sh
Don't output a warning if PERL_ARCH does not exist.

With hat:	portmgr
Sponsored by:	Absolight
Wed, 17 Dec 2014
[ 13:21 mat ] Original commit   Revision:374847
374847 CHANGES
374847 Mk/Scripts/qa.sh
374847 Mk/Uses/perl5.mk
374847 UPDATING
374847 lang/perl5.14/Makefile
374847 lang/perl5.14/files/patch-Makefile.SH
374847 lang/perl5.16/Makefile
374847 lang/perl5.16/files/patch-Makefile.SH
374847 lang/perl5.18/Makefile
374847 lang/perl5.18/files/patch-Makefile.SH

(Only the first 10 of 12 ports in this commit are shown above. View all ports for this commit)
Make Perl link all .so it builds with libperl.so.

It makes upgrading from one Perl major version to another way easier.  For
binary package users, it means pkg upgrade will detect the libperl.so.x.yy
change, and reinstall the affected packages.  For users using ports, it will
save rebuild time as it's easier to detect what ports really need to be
rebuilt.

PR:		195821
Differential Revision: https://reviews.freebsd.org/D1241
Submitted by:	mat
Reviewed by:	antoine, bdrewery
Exp-run by:	antoine
With hat:	perl
Sponsored by:	Absolight
Fri, 3 Oct 2014
[ 18:47 bdrewery ] Original commit   Revision:369928
369928 Mk/Scripts/qa.sh
- Allow LINUXBASE for shebangs.

PR:		193878
Submitted by:	Jan Beich <jbeich@vfemail.net>
With hat:	portmgr
Mon, 15 Sep 2014
[ 18:23 tijl ] Original commit   Revision:368281
368281 Mk/Scripts/qa.sh
368281 Mk/Uses/libtool.mk
Turn the installation of *.la files, without some form of USES=libtool in
the port Makefile, into a stage-qa error.  All ports that would trigger
this error have been converted.  Many thanks to all people involved in
this, especially Dmitry Marakasov (amdmi3) who handled most ports.

At this moment over 2200 ports have USES=libtool and over 20000 library
dependencies between packages have been removed.

This also marks the point where :keepla is no longer special.  It is now
only needed if a port uses *.la files at run-time.

QA-run by:	antoine
Approved by:	portmgr (antoine)
Sat, 30 Aug 2014
[ 08:55 antoine ] Original commit   Revision:366597
366597 Mk/Scripts/qa.sh
Ignore references to stagedir in .fmt and .log files generated for tex formats
Those are harmless (records from which file they were generated from) and
removing them would require ugly hacks according to hrs@

PR:		ports/192933
Differential Revision:	https://reviews.freebsd.org/D684
Reviewed by:	bapt, hrs
With hat:	portmgr
Mon, 25 Aug 2014
[ 22:10 antoine ] Original commit   Revision:366159
366159 Mk/Scripts/qa.sh
366159 Mk/bsd.stage.mk
Check that the plist doesn't reference the stage dir during stage-qa

====> Running Q/A tests (stage-qa)
Error: '/usr/ports/www/claroline/work/.PLIST.mktmp' is referring to
/usr/ports/www/claroline/work/stage
*** Error code 1

Differential Revision: https://reviews.freebsd.org/D685
Reviewed by:	bdrewery
With hat:	portmgr
Sun, 17 Aug 2014
[ 17:48 antoine ] Original commit   Revision:365214
365214 Mk/Scripts/qa.sh
Advise trying INSTALL_TARGET=install-strip before ${STRIP_CMD}

Phabric:	D477
Reviewed by:	bdrewery
With hat:	portmgr
Tue, 17 Jun 2014
[ 14:33 rene ] Original commit   Revision:358122
358122 Mk/Scripts/qa.sh
Mk/Scripts/qa.sh: add /bin/tcsh as a valid shebang.

Phabric:	D231
Approved by:	portmgr (antoine)
Fri, 9 May 2014
[ 22:29 bdrewery ] Original commit   Revision:353532
353532 Mk/Scripts/qa.sh
- Fix regression handling files with spaces from r350006.
  Separate file(1) and stat(1) output by a newline and read each line
  individually to avoid losing spaces.
- Use <<-EOF with heredocs to avoid bad indent
- Add some more comments
- Quote filenames in output so it is less unclear

Spotted by:	mandree
Reviewed by:	antoine
With hat:	portmgr
Tue, 6 May 2014
[ 11:57 tijl ] Original commit   Revision:353084
353084 Mk/Scripts/qa.sh
353084 Mk/bsd.stage.mk
Let stage-qa detect .la libraries and warn that a port needs USES=libtool.

PR:		ports/189255
Approved by:	portmgr (antoine)
Mon, 21 Apr 2014
[ 20:17 antoine ] Original commit   Revision:351707
351707 Mk/Scripts/qa.sh
- Do not advise to strip non FreeBSD binaries [1]
- Shorten messages

Requested and tested by:	xmj [1]
With hat:	portmgr
Sat, 12 Apr 2014
[ 20:49 antoine ] Original commit   Revision:351133
351133 Mk/Scripts/qa.sh
Do not advise to strip ELF relocatables, usually it is harmful

With hat:	portmgr
[ 20:48 antoine ] Original commit   Revision:351132
351132 Mk/Scripts/qa.sh
Reduce the number of false positives reported by the shebang qa check
by looking only at files and symlinks in bin, sbin and libexec

Reviewed by:	bdrewery
With hat:	portmgr
Fri, 11 Apr 2014
[ 14:15 bdrewery ] Original commit   Revision:350959
350959 Mk/Scripts/qa.sh
- Make shebang a warning for now, too many false-positives in files we
  do not care about.

  antoine@ is working on a better solution for this.

With hat:	portmgr
Tue, 8 Apr 2014
[ 16:50 antoine ] Original commit   Revision:350634
350634 Mk/Scripts/qa.sh
Rewrite the sharedmimeinfo qa check so that it doesn't produce a false
positive on misc/shared-mime-info

With help from:	bdrewery
With hat:	portmgr
Thu, 3 Apr 2014
[ 14:09 bdrewery ] Original commit   Revision:350013
350013 Mk/Scripts/qa.sh
- stage-qa: Fix absolute symlink check to look at target not fully resolved
  path. Now tested on both good and bad symlinks.

Reported by:	antoine
Pointyhat to:	bdrewery
With hat:	portmgr
[ 13:00 bdrewery ] Original commit   Revision:350006
350006 Mk/Scripts/qa.sh
- Fix fatal checks not exiting with non-zero [1]
  This means that files referrencing stagedir or linked to stagedir will
  now be fatal errors as intended.
- Stop polluting global namespace with IFS changes
- Speedup find(1) -exec usage by execing far less
- Ignore known false-positive/harmless stagedir files in paths() [2]

Reported by:	eadler [1]
Discussed with:	antoine [2]
With hat:	portmgr
Tue, 28 Jan 2014
[ 22:19 antoine ] Original commit   Revision:341664
341664 Mk/Scripts/qa.sh
341664 Mk/bsd.stage.mk
- Do not check for ${WRKDIR} in staged files, there are lots of false
  positives as some .o files may embed the source path [1]
- Only check shebang of files with executable bit set

Requested by:	bapt [1]
With hat:	portmgr
Thu, 9 Jan 2014
[ 18:43 antoine ] Original commit   Revision:339268
339268 Mk/Scripts/qa.sh
Fix paths check from qa.sh
IFS is set to newline so dirs was not correctly splitted

Approved by:	portmgr (bapt)
Fri, 6 Dec 2013
[ 23:12 bapt ] Original commit   Revision:335787
335787 Mk/Scripts/qa.sh
/usr/bin/nawk and /bin/csh are valid shebangs
Sat, 23 Nov 2013
[ 12:23 mandree ] Original commit   Revision:334663
334663 Mk/Scripts/check-stagedir.sh
334663 Mk/Scripts/qa.sh
- in qa.sh, properly work with filenames containing blank or tab,
  by setting IFS to just LF

- in check-stagedir.sh, properly detect unset environmental variables,
  and list them all

- in check-stagedir.sh, also list the full prefix as known, not just
  its parents

PR:		184039
Approved by:	portmgr (bapt)
Thu, 31 Oct 2013
[ 19:07 mandree ] Original commit   Revision:332275
332275 Mk/Scripts/check-stagedir.sh
332275 Mk/Scripts/qa.sh
332275 Mk/bsd.stage.mk
bsd.stage.mk: Fewer false positives, much faster, easier maintenance.

Bugfixes:

* @cmd in pkg-plist is now properly handled.
  - It was previously treated the same as though there was a directory
    following it, missing the prefix. (ordering matters in case...esac)

  - Due to the cwd=${PREFIX} inside the while read line loop, state
    tracking was broken and every new line assumed that cwd were the
    prefix.

* stage-qa no longer complains about unstripped binaries if debugging is
  active (WITH_DEBUG set && WITHOUT_DEBUG unset).
(Only the first 15 lines of the commit message are shown above View all of this commit message)
Sun, 20 Oct 2013
[ 18:12 ak ] Original commit   Revision:331046
331046 Mk/Scripts/qa.sh
- Add check for suid files and directories

Approved by:	portmgr (bapt)

Number of commits found: 104 (showing only 100 on this page)

1 | 2  »  

Login
User Login
Create account

Servers and bandwidth provided by
New York Internet, SuperNews, and RootBSD

This site
What is FreshPorts?
About the authors
Issues
FAQ
How big is it?
The latest upgrade!
Privacy
Forums
Blog
Contact

Search
Enter Keywords:
 
more...

Latest Vulnerabilities
phpmyadminDec 12
firefoxDec 11
firefox-esrDec 11
libxulDec 11
linux-firefoxDec 11
linux-seamonkeyDec 11
linux-thunderbirdDec 11
seamonkeyDec 11
thunderbirdDec 11
waterfoxDec 11
nodeDec 10
node10Dec 10
node6Dec 10
node8Dec 10
powerdns-recursorDec 09

13 vulnerabilities affecting 158 ports have been reported in the past 14 days

* - modified, not new

All vulnerabilities

Last updated:
2018-12-12 10:25:27


Ports
Home
Categories
Deleted ports
Sanity Test Failures
Newsfeeds

Statistics
Graphs
NEW Graphs (Javascript)
Traffic

Calculated hourly:
Port count 36108
Broken 120
Deprecated 1119
Ignore 379
Forbidden 3
Restricted 162
No CDROM 74
Vulnerable 38
Expired 4
Set to expire 1092
Interactive 0
new 24 hours 0
new 48 hours5
new 7 days42
new fortnight72
new month145

Servers and bandwidth provided by
New York Internet, SuperNews, and RootBSD
Valid HTML, CSS, and RSS.
Copyright © 2000-2018 Dan Langille. All rights reserved.