mail/vpopmail: Resurrect MYSQL option

- Pet portclippy/portfmt
- For now I have just added MySQL 8.0 in the supported variant. If other
  variant for MySQL works please reopen this ticket.

This reverts commit e3586087ed3ae4cbb51ff4efb881a7af4fa27791.

PR:		257672
Reported by:	tobias.niethammer@projektb.net

mail/vpopmail: Fix build

- While I removed the MYSQL option there was a file in the pkg-plist
  which caused build failures. [1]
- Also refactor @exec/@unexec

Reported by:	antoine [1]

mail/vpopmail: Remove non default option MYSQL

- When enabled with MYSQL option this port is BROKEN on all available
  versions of mysql in the tree.

*/*: Refactor with IGNORE_WITH_MYSQL

- There are multiple ports which has MYSQL options and are non-DEFAULT.
  Most of the time committers actually forget to check with the OPTION
  enabled and in some cases they are BROKEN with newr versions of mysql.
  So test with different versions of mysql and mark IGNOPRE_WITH_MYSQL
  appropriately. Due to the EOL of 5.7 this has not been checked.
- Unbreak sysutils/cfengine* with MySQL 8.0 and later
- The primary purpose of running this check is having statistics of the
  MySQL usability over MariaDB to explore the future possibility of
  shifting to MariaDB as the default as major ports upstream have moved
  their codebase to support MariaDB over MySQL.
- The following actions will also be taken after the sunset of MySQL 5.7
  If a port is broken on all instances of MySQL/MariaDB:
  - If a port has the option of multiple DB backends and MySQL is the
    default then the DEFAULT will be changed to PGSQL/SQLITE before
    2024Q1. And the OPTION will be removed before 2024Q2. If a
    MAINTAINER is aware about such cases and want to prefer PGSQL over
    SQLITE or vice versa please do so at your own accord. Otherwise
    PGSQL will be preferred over SQLITE.
  - If a port has the option of multiple DB backends and MySQL is not
    the default then the the OPTION will be removed before 2024Q1.

Approved by:	portmgr (blanket)

Mk/**ldap.mk: Convert USE_LDAP to USES=ldap

Convert the USE_LDAP=yes to USES=ldap and adds the following features:

- Adds the argument USES=ldap:server to add openldap2{4|5|6}-server as
  RUN_DEPENDS
- Adds the argument USES=ldap<version> and replaces WANT_OPENLDAP_VER
- Adds OPENLDAP versions in bsd.default-versions.mk
- Adds USE_OPENLDAP/WANT_OPENLDAP_VER in Mk/bsd.sanity.mk
- Changes consumers to use the features

Reviewed by:	delphij
Approved by:	portmgr
Differential Revision: https://reviews.freebsd.org/D38233

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

mail: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  <ashish@FreeBSD.org>
  *  Aaron Dalton <aaron@FreeBSD.org>
  *  Adam David <adam@FreeBSD.org>
  *  Adam McDougall <mcdouga9@egr.msu.edu>
  *  Adam Weinberger <adamw@FreeBSD.org>
  *  Ade Lovett <ade@FreeBSD.org>
  *  Akinori MUSHA aka knu <knu@idaemons.org>
  *  Alex Deiter <tiamat@komi.mts.ru>
  *  Alex Dupre <ale@FreeBSD.org>
  *  Alex Dupre <sysadmin@alexdupre.com>
  *  Alex Perel <veers@disturbed.net>

net/openldap24-server: Make SASL permanent for OpenLDAP port.

PR:		ports/257374
Reviewed by:	obrien
Approved by:	portmgr (exp-run by antoine)
Differential Revision: https://reviews.freebsd.org/D31301

Remove # $FreeBSD$ from Makefiles.

mail/vpopmail: Unbreak build with PGSQL=on

Move remaining USE_MYSQL, WANT_MYSQL_VER to USES=mysql

Fix whitespace issues (mixed tab/spaces, alignment) in a few ports.

Don't patch away upstream -fPIC so dependent ports can link libvpopmail.a
into shared libraries.

With the power of USES=dos2unix, get rid of most patches and files
with CRLF.

While there, run make makepatch, rename patches to use the new scheme,
and various fixes.

With hat:	portmgr
Sponsored by:	Absolight

Conver to @sample keyword

Remove ${PORTSDIR}/ from dependencies, categories m, n, o, and p.

With hat:	portmgr
Sponsored by:	Absolight

Fix build as non root.

Sponsored by:	Absolight

Farewell qmail. You were good but the lack of an upstream maintainer or
ecosystem maintainers makes this not a viable mail system today. Personally
I am moving to postfix and have so far found it incredibly easy to setup and
already prefer it over qmail.

- Update plist for new format

Reviewed by:	bapt

Fix ownership of home directory

Convert to USES=pgsql

Stop looking at devel versions

net/openldap24-*:
- Convert to USES=libtool and bump dependent ports
- Avoid USE_AUTOTOOLS
- Don't use PTHREAD_LIBS
- Use MAKE_CMD

databases/glom:
- Drop :keepla
- Add INSTALL_TARGET=install-strip

databases/libgda4* databases/libgda5*:
- Convert to USES=libtool and bump dependent ports
- USES=tar:xz
- Use INSTALL_TARGET=install-strip
- Use @sample

- Update to 5.4.33
- Move auth options into its own single group
- Clarify PASSWD and VALIAS options

Changes: (* was already applied in our 5.4.32)
    Matt Brookings
  * - Defaulted to Server::Disable=True in vusagec.conf
  * - Fixed bug that didn't install vusagec.conf
    - Changed relevant quota code to use storage_t 64bit type
    - Fixed bug where backfill code wouldn't compile when FILE_LOCKING was
      enabled
    - Updated MySQL module to support larger quota sizes
    - Fixed typo
    - Added disable_maildrop flag to MySQL limits feature
    - More changes to allow for larger quota sizes in MySQL module

- Convert to stagedir

Move {mail,japanese}/p5-Mail-SpamAssassin to &/spamassassin, in the name of
improving accessibility.

I think people who want to just find the port/package and install it are
more likely to look for "spamassassin the program" than "spamassassin the
perl module collection."

- Add NO_STAGE until validated to be safe for upcoming staging support

- Add support to have vdelivermail send to stdout by defining
  DELIVER_TO_STDOUT in the environment. This is useful when
  using dovecot as an LDA. See more discussion at:
  http://www.mail-archive.com/vchkpw@inter7.com/msg26694.html

Convert from USE_GMAKE to USES=gmake

- Fix ROAMING after option helpers conversion

PR:		ports/179978
Reported by:	Claudiu Bosioc <claudiu@casi.ro>

- Use new options helpers
- Remove bsd.port.pre.mk usage

- Fix leftover /var/qmail/control/locals

  qmail-send.c:getcontrols() refuses to startup or to process
  the virtualdomains file if locals is missing. However,
  vpopmail's vadddomain is already creating the locals file
  when adding new domains. So creating it when installing is
  not needed.

  At the time that this change was added to the port, in
  vpopmail-5.4.13, vadddomain did not automatically create
  the locals file. The current version does in
  vpopmail.c:remove_line()

  This reverts the change done in r167787 for ports/99914

PR:		ports/99914 (reverts)

- Use VPOPMAIL_DIR as install target since that is
  user-changeable and this port does not really respect
  PREFIX at the moment
- Change tab to space for WWW

- Convert USE_QMAIL_RUN, USE_QMAIL_BUILD and WANT_QMAIL into USES feature
  bapt contributed to the qmail.mk as well
- Trim headers

USES= qmail:run will add qmail into RUN_DEPENDS
USES= qmail:build will add qmail into BUILD_DEPENDS
USES= qmail[:both] will add qmail into both RUN and BUILD DEPENDS
USES= qmail:vars will set QMAIL_PREFIX

With hat:	portmgr

- Convert from KNOBS to Options
- Trim header

- Update to my new maintainer address

Approved by:	eadler (mentor)

- Fix some portlint warnings
- Pass maintainership to submitter

PR:             ports/196359
Submitted by:   Bryan Drewery <bryan@shatow.net>

- Use USERS/GROUPS
- Remove perl dependency

PR:             ports/157206
Submitted by:   bapt

- Reassign to the heap

Requested by:   roam (on ports-developers@)

The upstream distfile was rerolled with some fixes:
- update the patches
- remove the MD5 checksum
- bump PORTREVISION

Reported by:    "Alexander B. Zubkov" <info@zubkov.info>

Update to vpopmail-5.4.32 and declare a GPL-2+ license.

Fix the installation when built with LDAP support.

PR:             144752
Submitted by:   Satoru Suzuki <xsuzu@yokohama.riken.jp>

Arrrrrgh.  Really copy the vusagec.conf-dist file to vusagec.conf
if the latter does not exist.  The pkg-plist @exec commands are not,
repeat not, executed at *port* install time!

PR:             141251 (for REAL this time, honest!)
Reported by:    Cristiano Deana <cris@gufi.org>
Feature safe:   yes

Another attempt at fixing the vpopmail-5.4.30 local delivery problem:
fix the upstream Makefile's logic and actually install vusage.conf, while
disabling the vusagec/vusaged check since we don't even install vusaged
on FreeBSD.

Pointed out by: garga
PR:             141251 (hopefully for real this time!)

Add an upstream patch as another attempt to fix the vdelivermail
segfault.

Submitted by:   ale

Update to vpopmail-5.4.30 which should fix the segfaults that some
users have been experiencing with 5.4.28.

Fix the master sites so that vpopmail is actually fetchable even with
-A present in FETCH_ARGS, as it is on most systems.
Fix the maildir++ file size calculations in the SpamAssassin code as
per the PR.

PR:             139962 (the maildir++ fix)
Submitted by:   Alex Dupre <ale@freebsd.org>

Update to vpopmail-5.4.28.
From the PR - fix the creation of new domains through LDAP.

PR:             131274
Submitted by:   Suzuki <xsuzu@yokohama.riken.jp>

- Fix configure when WITH_MAILDROP is set

PR:             ports/138363
Submitted by:   Alexey V.Degtyarev <alexey@renatasystems.org>
Approved by:    maintainer timeout (roam; 18 days)
Feature safe:   yes

- Switch SourceForge ports to the new File Release System: categories starting
with M

Update to vpopmail-5.4.27.
Internally, use quilt for patch management.
Add two Makefile knobs for the locations of the Courier IMAP server's
imaplogin and imapd binaries, just in case anyone would want to test
the new authvchkpw utility :)

Update CONFIGURE_ARGS for how we pass CONFIGURE_TARGET to configure script.
Specifically, newer autoconf (> 2.13) has different semantic of the
configure target. In short, one should use --build=CONFIGURE_TARGET
instead of CONFIGURE_TARGET directly. Otherwise, you will get a warning
and the old semantic may be removed in later autoconf releases.

To workaround this issue, many ports hack the CONFIGURE_TARGET variable
so that it contains the ``--build='' prefix.

To solve this issue, under the fact that some ports still have
configure script generated by the old autoconf, we use runtime detection
in the do-configure target so that the proper argument can be used.

Changes to Mk/*:
 - Add runtime detection magic in bsd.port.mk

Reinitialize the internal DeleteMail variable for each dot-qmail line
so that all delivery instructions are indeed executed and no messages are
(partially) lost.
Bump PORTREVISION.

Submitted by:   Michal Sviba <michal@myserver.cz> in
                e-mail message <47DBD588.4000906@myserver.cz>

Update the vpopmail port to version 5.4.26 with a lot of changes and fixes:
- add the WITH_SPAMFOLDER knob from Alex Dupre's PR;
- fix lots of bugs in the new vlist code;
- fix a couple of bugs in MySQL's "valias -n" implementation;
- actually implement "valias -n" for PostgreSQL;
- fix a couple of directory descriptor leaks and other buglets.

PR:             117321 (the WITH_SPAMFOLDER knob)
Submitted by:   ale

- Conditionalize vpopmail/etc/vpopmail.mysql-dist in plist, it's installed only
  when WITH_MYSQL is defined

Reported by:    pointyhat

Update vpopmail to 5.4.20 after a long delay, mostly due to wondering
how to handle the database upgrade and the SpamAssassin patch partial
integration.

There are several important changes that may affect your vpopmail
installation and may need you to handle manually:

- THE MYSQL CONNECTION INFORMATION IS NO LONGER DEFINED AT COMPILE-TIME!
  The WITH_MYSQL_{USER,PASSWD,SERVER,DB} variables should NOT be defined
  when you build the port; place that information in the vpopmail.mysql
  file after vpopmail has been installed!
- the default domain is also no longer defined at compile time - you need
  to place it in the defaultdomain file after the installation.
- the defaultdomain and vpopmail.mysql files are no longer blindly removed
  on deinstallation, they are only removed if they have not been modified

Build the vpopmail library with position-independent code on ia64 too,
not just amd64.

Reported by:    kris
Submitted by:   oliver

Make the PostgreSQL backend actually compile with the new
WITH_SQL_LOG_REMOVE_DELETED knob - fix the name of a variable and
a standard PostgreSQL routine.

Pointy hat to:  roam (myself), in addition to the upstream developers

Update to vpopmail-5.4.17.  In the process:
- add a new knob, WITH_SQL_REMOVE_DELETED, for explicitly activating
  the new code for removing entries from the SQL log file when a user or
  domain is deleted;
- add real NOPORTDOCS support and install the README.* files in addition
  to the doc_html/ and man_html/ directories if NOPORTDOCS is not set;
- fix a couple of spelling and grammar errors in the new README.vpopmaild;
- add several sanity checks;
- remove the last traces of the ActiveDirectory backend;
- various other minor changes.

Fix package installation - in most cases, the vpopmail package (if built)
would be installed with the wrong home directory for the vpopmail user.

PR:             103177
Submitted by:   oliver

I've updated the SpamAssassin patch, so re-enable it in the port.

Create the qmail control/locals file if it does not exist.
Silence a couple of portlint warnings.

PR:             99914
Submitted by:   garga

Update to the last stable release, 5.4.13.  In the process:
- temporarily disable the SpamAssassin patch, since vdelivermail was
  reorganized a bit;
- fix a couple of potential buffer bound problems;
- remove the unconditional -fPIC; we handle this ourselves for amd64.

Remove USE_REINPLACE from ports starting with M

Set the setgid bit on vchkpw, too - it simply will not work without it :)

PR:             85788
Submitted by:   Renato Botelho <garga@freebsd.org>

SHA256ify

Approved by: krion@

Replace ugly "@unexec rmdir %D... 2>/dev/null || true" with @dirrmtry

Approved by:    krion@
PR:             ports/88711 (related)

- Fix 'all-depends-list' target in cases if dependencies list is
  very long and if some dependencies can't be added into the list.
  [1]

- Fix FAM support.  Make gamin the default FAM system. [2]

- Introduce new 'quicksearch' target to show only port, path and
  info section of the matching ports. [3]

- Introduce new category - rubygems. [4]

- Fix stale dependencies while installing qmail slaveport and
  another port that depends on qmail. [5]

- Add commentary for describes target in bsd.port.mk. [6]

Only use -fPIC on amd64 - none of the other arches seem to need it.
Unfortunately, the only way to avoid adding -fPIC to the files that
go into libvpopmail.a would be to actually make the vpopmail port
build a real shared library, which might be a bit more difficult and
should probably be coordinated with the upstream.

Pointy hat to:  roam (myself)
Pointy hat handed by:   kris

Unless WITHOUT_FPIC is defined, add -fPIC to the C compiler flags.
This fixes the build of ports that use libvpopmail, at least on amd64,
and does not hurt on other platforms.

PR:             88402
Submitted by:   Matteo Baldi <egon@egonflower.com> among others

Errr... actually add the patch needed for the WITH_SMTP_AUTH_PATCH option
introduced in ports/mail/vpopmail/Makefile rev. 1.57.

Submitted by:   Nikolay Georgiev <niki@techlab.office1.bg>

Add the WITH_SMTP_AUTH_PATCH knob to fix the SMTP authentication, at least
when invoked via the elysium implementation of SMTP auth from
http://members.elysium.pl/brush/qmail-smtpd-auth/dist/

Submitted by:   Nikolay Georgiev <niki@techlab.office1.bg>

Complement pav's handling of tcp.smtp and tcp.smtp-dist: actually install
the sample tcp.smtp file as tcp.smtp-dist.
Add the WITH_SUID_VCHKPW knob for setting the setuid bit on bin/vchkpw. [1]
Bump PORTREVISION.

PR:             85124 [1]
Submitted by:   garga [1]

Set the SHELL environment variable to "/bin/sh" in vdelivermail before
executing external programs.

PR:             69969
Submitted by:   Claudiu Bosioc <claudiu@casi.ro>

Use --enable-sql-logging instead of the deprecated --enable-mysql-logging
and --enable-pgsql-logging.  Correspondingly, deprecate WITH_MYSQL_LOG and
WITH_PGSQL_LOG in favor of WITH_SQL_LOG.

Reported by:    Alexander B. Zubkov <sasha@sekrett.ru>,
                Martin Tsachev <mtsachev@gmail.com>

- Require perl in runtime too, pkg-install script is written in it.
  Up until now, it was impossible to install from package.

- Update to 5.4.10
- Add support for LDAP
- Handle tcp.smtp configuration file nicely

PR:             ports/80412
Submitted by:   Renato Botelho <freebsd@galle.com.br>
Approved by:    maintainer timeout (2 weeks)

Split the postgresql ports into a server and a client part.

All ports depending on postgresql shall use the USE_PGSQL=yes knob
defined in Mk/bsd.ports.mk. Bumping portrevisions where needed.

PR:             75344
Approved by:    portmgr@ (kris), ade & sean (mentors)

Merge several security and reliability fixes from the vpopmail 5.4
CVS branch.

Prompted by:    eik (for the vsybase.c advisory and CVS fix)
Approved by:    portmgr (marcus)

Update to vpopmail-5.4.6, which contains IMPORTANT security fixes for
people using vpopmail with SQL backends!

Remove databases/postgresql-client because there can't be a -server, and having
it installed prevents databases/postgresql7 from being installed, leading to
some dependencies problems

Fix a file descriptor leak in opensmtp().

Obtained from:  vpopmail CVS via oliver and
                Michael Bowe <mbowe@pipeline.com.au>

Update vpopmail to 5.4.3.

Fix dependency on SpamAssassin.

Noticed by:     Cristiano Deana <cris@gufi.org>

Add CONFLICTS.

- Fix new installations (patch disappeared in my last commit) [1]
- Remove now useless post-patch target

Noticed by:     Cristiano Deana <cris@gufi.org> [1]
Approved by:    nork (mentor/implicitly)

Update to 5.4.0 stable release.

Approved by:    roam, nork (mentor/implicitly)

Bump PORTREVISION on all ports that depend on gettext to aid with upgrading.

(Part 1)

A first shot at enabling the PostgreSQL authentication features, only
loosely based on the PR mentioned (the original patch in the PR does not
handle either library dependencies nor changing the default credentials).
PORTREVISION *not* bumped, this can wait until I implement WITH_PGSQL_PASS
and WITH_PGSQL_SERVER in the near future.

PR:             61998
Submitted by:   Sascha Luck <sascha@c4inet.net>

Looks like I seriously botched the last commit; somehow four lines from
the original Makefile.in got duplicated in the 'patched' one, leading
to a malformed sh(1) construct that would inevitably break the installation.
Thanks to Ronald Sebastian and Alex Dupre for pointing this out.

Noticed by:     Ronald Sebastian <mailsagan@yahoo.com> and
                Alex Dupre <sysadmin@alexdupre.com>, among others

While I'm here, remove the autoconf part of the Makefile.in patch, which
actually duplicates what I've been doing in the port's Makefile for
some time now :)

Update to vpopmail-5.3.30, fixing a critical update_rules bug.
Revamp a bit the creation of the MySQL credentials file.

PR:             59605
Submitted by:   Alex Dupre <sysadmin@alexdupre.com> (mostly)
Approved by:    portmgr (will)

Create an empty default limits file if none exists, bump PORTREVISION.
Change a -f check to an -e one to also catch symlinks and such.

Update to 5.3.29 and add the new SpamAssassion patch from Alex Dupre,
with a configurable spam threshold value set by the SPAM_THRESHOLD knob.

PR:             58306, 58805
Submitted by:   Alex Dupre <sysadmin@alexdupre.com>

Add Alex Dupre's patch for SpamAssassin integration, conditional
on the WITH_SPAMASSASSIN knob.

PR:             58503
Submitted by:   Alex Dupre <sysadmin@alexdupre.com>

Update to vpopmail 5.3.28.  Only set vpopmail:vchkpw ownership on
the bin/ and etc/ directories.

PR:             57551
Submitted by:   Alex Dupre <sysadmin@alexdupre.com>

Manually do the recursive chown of the vpopmail directory that was
removed from the 5.3.27 source for some reason.

PR:             56916
Submitted by:   guilherme@vianavirtual.com

Update to 5.3.27, USE_MYSQL, de-quote COMMENT, update the knobs info,
and other assorted fixes, mostly from Alex's PR.

PR:             56462
Submitted by:   Alex Dupre <sysadmin@alexdupre.com>
Ob-woohoo:      run-time configuration of default-domain and MySQL info;
                at last it is possible to build a single package for
                deploying on multiple servers!

Update to vpopmail-5.3.20.
Add the WITH_VPOPMAIL_SQWEBMAIL_CREATION knob to make vadduser
(well, make_user_dir(), actually) create an sqwebmail-config file
specifying the outgoing messages' sender address.

Remove pkg-comment files in my ports.

Update to vpopmail-5.3.16:
- WITH_MYSQL_LIMITS works now, move it where users can actually see it
  and remove the BROKEN mark;
- remove the vmysql.h patch that defined the 'limits' table creation -
  it was fixed in the meantime;
- remove the annoying configure script check for id == 0.