net-p2p/mldonkey: switch to clang and bfd on powerpc64*

OCaml: transient update of the stack to version 4.07.1

This is the first step in modernizing our OCaml ports infrastructure,
as we had accumulated substantial technical debt over the years when
many of its consumer ports had not received proper care and updates.

It is currently considered as the lowest supported version (baseline)
in majority of open-source OCaml projects, which would help to pull
up other ports, e.g. `devel/ocaml-dune' in smaller, manageable pieces.

For conservative hackers among us and for compatibility with RHEL 8
which is also on it, having 4.07 in the tree would allow users stick
to that package (pkg lock it) if needed.

PR:		250408, 262781
Exp-run by:	antoine

net-p2p/mldonkey: force unsafe strings to unbreak against modern OCaml.

*/*: Remove redundant '-[0-9]*' from CONFLICTS

The conflict checks compare the patterns first against the package
names without version (as reported by "pkg query "%n"), then - if
there was no match - agsinst the full package names including the
version (as reported by "pkg query "%n-%v").

Many CONFLICTS definitions used patterns like "bash-[0-9]*" to filter
for the bash package in any version. But that pattern is functionally
identical with just "bash".

Approved by:	portmgr (blanket)

net-p2p/mldonkey: builds fine with clang on powerpc

net-p2p/mldonkey: Add CPE information

Approved by:	portmgr (blanket)

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

Prefer graphics/ligvrsvg2-rust over graphics/librsvg2

- switch to the more modern version of librsvg2 on architectures
  supporting rust
- this will fix some graphical issues on these architectures

PR:		250276
Exp-run by:	antoine
Submitted by:	tobik
Differential Revision:	https://reviews.freebsd.org/D18878

Canonicalize use of GCC on all powerpc variants.

Approved by:	portmgr (tier-2 blanket)

- update libgd to 2.3.0
- new option RAQM
- resurrect deprecated gdlib-config
- bump dependend ports

net-p2p/mldonkey: fix build on powerpc64 elfv2

Clang can't build this port on powerpc64:
ld: error: build/client.a(commonShared.o):(function camlCommonShared__ni_2211:
.text+0xCE): relocation R_PPC64_TOC16_DS out of range: 121936 is not in [-32768,
32767]
ld: error: build/core.a(donkeyOptions.o):(function
camlDonkeyOptions__max_allowed_connected_servers_1641: .text+0x1A): relocation
R_PPC64_TOC16_DS out of range: 69120 is not in [-32768, 32767]
ld: error: build/cdk.a(http_lexer.o):(function camlHttp_lexer__get_args_1205:
.text+0x12): relocation R_PPC64_TOC16_DS out of range: 203032 is not in [-32768,
32767]

PR:		243221
Approved by:	danfe (maintainer)

Canonicalize librsvg dependency

- Use USE_GNOME=librsvg2 where possible
- Reduce scope of D18878

Convert to UCL & cleanup pkg-message (categories n)

(and missed 3 missed files from previous categories.)

Fix build on GCC-based architectures by adding c++11-lang to USES:

  /usr/local/lib/libgraphite2.so.3: undefined reference to
`__cxa_throw_bad_array_new_length@CXXABI_1.3.8'

Approved by:	portmgr (tier-2 blanket)

Update OCaml to version 4.05.0 (this is the last version where strings
are unsafe by default, which is the main motivation why it was picked,
but not the very latest one) and synchronize the rest of the stack and
dependent ports with it, particularly:

  - Update `devel/ocaml-ocamlbuild' to version 0.14.0 and unbreak,
    register build dependency on all ports that require it (should
    be part of USE_OCAML, but we do not want to make any Mk-related
    changes the for time being)
  - Update `devel/ocaml-camlp4' to version 4.05+2
  - Update `devel/ocaml-camlp5' to version 7.07 (the project had
    moved to GitHub)
  - Mark `devel/ocaml-deriving-ocsigen' as BROKEN for now, it is
    very outdated and requires quite a lot of work
  - Update `x11-toolkits/ocaml-labltk' to version 8.06.3

PR:		218333
Exp-run by:	antoine

- Add upstream patch to unbreak the build against OCaml 4.03.0+
- When possible, use modern spelling of native types to make the
  diff for upcoming OCaml update less noisy
- While here, rephrase the COMMENT and assume maintainership

net-p2p/mldonkey*: Fix build with Clang 6

src/utils/lib/CryptoPP.h:3941:26: error: ISO C++11 does not allow access
declarations; use using declarations instead
        BufferedTransformation::Get;
                                ^

http://beefy11.nyi.freebsd.org/data/head-i386-default/p477696_s338122/logs/errors/mldonkey-3.1.5_2.log
http://beefy11.nyi.freebsd.org/data/head-i386-default/p477696_s338122/logs/errors/mldonkey-core-3.1.5_2.log
http://beefy11.nyi.freebsd.org/data/head-i386-default/p477696_s338122/logs/errors/mldonkey-gui-3.1.5_2.log

PR:		229691
Submitted by:	mickey242@gmx.net

Add explicit build dependency on pkgconf

Reported by:	pkg-fallout

- Patch configure instead of configure.in so we can avoid USES=autoreconf.
  An obscure macro is used in configure.in that autoreconf cannot find
  anywhere (ACX_CHECK_CXX_FLAGS).
- Disable a test for libcharset from converters/libiconv, so the code will
  use nl_langinfo from libc instead.
- Remove unneeded CONFIGURE_ENV, CPPFLAGS and LDFLAGS.

Reported by:	antoine

Add build dependency on ax_pthread.m4 from autoconf-archive.  It is used
in configure.in.

Reported by:	antoine

Convert to USES=autoreconf.

The output of tools like awk, date, sort, tr,... depends on the current
locale set by the user.  Add LANG=C and LC_ALL=C at the beginning of
bsd.port.mk and export them so all commands are executed with the C locale.
LC_ALL=C overrides all other LC_* variables.  LANG is used by setlocale(3)
as default value for LC_* variables, so normally it isn't used when LC_ALL
is set, but there's code out there that looks at LANG directly so it's safer
to set it as well.  The only commands not captured by this are !=
assignments before any inclusion of bsd.port.*mk.

Introduce USE_LOCALE=<locale> that adds LANG=<locale> and LC_ALL=<locale> to
CONFIGURE_ENV and MAKE_ENV so upstream build systems can be executed with a
different locale (e.g. USE_LOCALE=en_US.UTF-8).

PR:		215882
Exp-run by:	antoine
Approved by:	portmgr (antoine)

Most commonly used build systems support silent builds, when they
hide actual commands executed and only show short summary line (like
"CC foo.c"). CMake and ninja enable this by default, some autotools
using ports do as well. This is unacceptable because we need complete
build logs at any time, so we now switch to verbose build logs
unconditionally. Note that this change deliberately affects ALL
builds and not only package builds on cluster, because we need to
be sure that user experiencing failure can always provide informative
build log regardless of settings and without rerunning the build.

Change summary:

- Always do verbose builds for cmake, ninja and GNU configure (the
  latter includes check if --disable-silent-rules is actually supported
  by the configure script; there are isolated cases when it's not true)

- Disable strict configure options checking in preparation for portswide
--disable-silent-rules

PR:		212075
Approved by:	portmgr blanket

- update libgd to 2.2.2
- new MASTER_SITES
- add security patch
PR:		210913
Submitted by:	Piotr Kubaj
MFH:		2016Q3
Security: CVE-2015-8874
Security: CVE-2016-3074
Security: http://www.openwall.com/lists/oss-security/2016/07/12/4

Remove ${PORTSDIR}/ from dependencies, categories m, n, o, and p.

With hat:	portmgr
Sponsored by:	Absolight

- Fix build by removing part of comment which contains broken ocaml code. Since
ocaml parses commented code, it breaks on this line

- Add USE_OCAML_CAMLP4 and USE_OCAML_TK to bsd.ocaml.mk which add
  depends on the camlp4 language and labltk ocaml modules, which are
  now in separate ports.
- Update x11-toolkits/ocaml-lablgtk2 to 2.18.3
- Update graphics/ocaml-lablgl to 1.05
- Make unison ports use USE_OCAML
- Convert ports to the new flags where needed
- Bump PORTREVISION on ports depending on ocaml-lablgtk2, those need to be
rebuilt

PR:			199845
Submitted by:		jbeich@
Differential Revision:	https://reviews.freebsd.org/D2434
Approved by:		portmgr (mat)

2 ports categories: Remove $PTHREAD_LIBS

Categories: net-p2p, comms

Note that qrq was not properly staged, it failed stage-QA.
aprsd failed check-plist; it had a plist orphan.  Now it fails stage-QA
with a fs violation, but it may be acceptable.  Fixes added to both.

approved by:	PTHREAD blanket

Cleanup plist

- Remove leading indefinite article from COMMENT
- Remove NO_LATEST_LINK

Remove a very strange series of ^H's from the pkg-message, and remove the
${CAT} ${PKGMESSAGE} from post-install.

- update to 3.1.5
- support stage and options

Modernize LIB_DEPENDS

With hat:	portmgr

- Convert USE_GMAKE/BZIP2 to USES

Fix build with clang on i386 by disabling inline asm that uses
intel syntax.

PR:		ports/180595

Add NO_STAGE all over the place in preparation for the staging support (cat:
net-p2p)

Introduce ICONV_CONFIGURE_ARG variable defined at Uses/iconv.mk.
It's value is "--with-libiconv-prefix=/usr/local" for systems
before 100043 with ports libiconv and to use at systems post
100043 with base iconv it's value is "" (NULL).

Co-authors:	bapt, madpilot and bsam (me)

Fix typo, and thereby fix INDEX.

- update libdg to 2.1.0

- Convert USE_ICONV=yes to USES=iconv
- Change USE_GNOME=pkgconfig|gnomehack to USES=pathfix|pkgconfig while here

Reviewed by:	zeising

update to 3.1.3

update x11-toolkits/ocaml-lablgtk2 to 2.16.0+bugfixes, and adjust
dependent ports

PR:		144982, 149958
Reviewed by:	johans (earlier version of the patch)

- Update to 3.1.2
- Pet portlint: remove ABI version number from LIB_DEPENDS

Changes:       
http://cvs.savannah.gnu.org/viewvc/mldonkey/mldonkey/distrib/ChangeLog?view=markup

- update png to 1.5.10

- Update to 3.1.1

PR:             166891
Submitted by:   Ports Fury

In the rc.d scripts, change assignments to rcvar to use the
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().

In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.

- Add LDFLAGS to CONFIGURE_ENV and MAKE_ENV (as it was done with LDFLAGS)
- Fix all ports that add {CPP,LD}FLAGS to *_ENV to modify flags instead

PR:             157936
Submitted by:   myself
Exp-runs by:    pav
Approved by:    pav

- Update to 3.1.0 [1]
- Garbage collect old threading options [1]
- Fix build with clang [2]

PR:             ports/160502 [1,2]
                ports/160498 [2]
Submitted by:   "h h" (aakuusta gmail.com) [1,2]
Obtained from:  upstream [2]

Drop maintainership

Update to 3.0.7

PR:             ports/154908
Submitted by:   soulcatcher <soulcatcher13@gmail.com>

Remove painful examples of foo="", with particular prejudice against
constructions that parse out to [ -z "$foo" ] && foo=""

These are bad examples that get copied and pasted into new code, so the
hope is that with less bad examples there will be less need for me to
bring this up in review.

In a few of these files all that were changed were comments so that next
time I search for these patterns I won't trip on the file for no reason.

In a few places, add $FreeBSD$

No functional changes, so no PORTREVISION bumps

Sync to new bsd.autotools.mk

Update to 3.0.6

Update to 3.0.5

PR:             152037
Submitted by:   sunpoet

Punt autoconf267->autoconf268

- Remove BROKEN: fix build

Obtained from:  mldonkey issue tracker
(https://savannah.nongnu.org/patch/?7267#comment2)

- Remove BROKEN: fix build

Obtained from: mldonkey issue tracker
(https://savannah.nongnu.org/patch/?7267#comment2)

- Mark BROKEN: does not build

Reported by:    pointyhat

Autotools update.   Read ports/UPDATING 20100915 for details.

Approved by:    portmgr (for Mk/bsd.port.mk part)
Tested by:      Multiple -exp runs

Update to 3.0.4

Update to 3.0.3

o Update to 3.0.2
o Add LICENSE* information

- update to 1.4.1
Reviewed by:    exp8 run on pointyhat
Supported by:   miwi

Begin the process of deprecating sysutils/rc_subr by
s#. %%RC_SUBR%%#. /etc/rc.subr#

- update to jpeg-8

o Revert previous commit since the specific LDFLAGS is not needed
o Bump PORTREVISION to insure that no one will have that LDFLAGS

- Fix build on systems where GCC stack protection (aka Propolice)
  was enabled for userland on src/share/mk/bsd.sys.mk
  (SVN rev 180012 on 2008-06-25 21:33:28Z by ru)
- For OSVERSION >= 800040, add -fstack-protector to LDFLAGS

Update to 3.0.1

- Fix rc.d startup script:
  1) Check if daemon is already running before start
  2) Add verbose start message
- Bump PORTREVISION

PR:             ports/129790
Submitted by:   Ulrich Spoerlein <uspoerlein@gmail.com>

- Retire MASTER_SITE_SOURCEFORGE_EXTENDED, it's no longer needed - all mirrors
actually have all distfiles
- Merge all SF mirrors to MASTER_SITE_SOURCEFORGE, resort according to quick
download speed survey
- Fix MASTER_SITES for all port that have used SOURCEFORGE_EXTENTED

Approved by:    portmgr (pav)

- bump all port that indirectly depends on libjpeg and have not yet been bumped
or updated
Requested by:   edwin

- Not MAKE_JOBS_SAFE

Reported by:    pointyhat

Fix a few "bad example" problems in the rc.d scripts that have been
propogated by copy and paste.

1. Primarily the "empty variable" default assignment, which is mostly
${name}_flags="", but fix a few others as well.
2. Where they are not already documented, add the existence of the _flags
(or other deleted empties) option to the comments, and in some cases add
comments from scratch.
3. Replace things that look like:
prefix=%%PREFIX%%
command=${prefix}/sbin/foo
to just use %%PREFIX%%. In many cases the $prefix variable is only used
once, and in some cases it is not used at all.
4. In a few cases remove ${name}_flags from command_args
5. Remove a long-stale comment about putting the port's rc.d script in
/etc/rc.d (which is no longer necessary).

No PORTREVISION bumps because all of these changes are noops.

Mark MAKE_JOBS_SAFE for SMP compilation

Update to 3.0.0

Update to 2.9.7

- Remove conditional checks for FreeBSD 5.x and older

Conversion from (now defunct) autoconf-2.61 to autoconf-2.62

Tested by:      exp build run (erwin)

Update to 2.9.6

Update to 2.9.5

Update to 2.9.4

Update to 2.9.3

Update to 2.9.2

Remove always-false/true conditions based on OSVERSION 500000

Switch autoconf dependencies from 2.53 or 2.59 to 2.61.

PR:             ports/116639
Submitted by:   aDe

Update to 2.9.1

Update to 2.9.0

o Fix RC script. Make sure the shell is sh(1) when starting mlnet.
o Bump PORTREVISION

PR:             112253
Submitted by:   Marcin Wisnicki <mwisnicki+freebsd@gmail.com>

Update to 2.8.7

- Welcome X.org 7.2 \o/.
- Set X11BASE to ${LOCALBASE} for recent ${OSVERSION}.
- Bump PORTREVISION for ports intalling files in ${X11BASE}.

Update to 2.8.5 since it is a bugfix to 2.8.4

Update to 2.8.4

o Update to 2.8.3
o Simplify Makefile's port logic
o Do not install rc(8) script if only the graphical user interface
  is being installed [1]

PR:             104029 [1]
Submitted by:   Marcin Wisnicki <mwisnicki+freebsd@gmail.com> [1]

o Fix: "Namely, eMule (and compatible) clients use 'rotational
  chunkrequest' scheme, where each REQCHUNKS packet contains one
  new chunk and two older chunks. This can lead to duplicate data
  being sent by mldonkeys, if a rotational chunkrequest scheme is
  used when communicating with them." [1]
  http://hydranode.com/docs/ed2k/ed2kproto.php#upload
o Bump PORTREVISION

Submitted by:   spiral voice <spiralvoice@hotmail.com> (MLDonkey developer) [1]

Fix install target: do not install files that do not exist

Fix patch target

o Update to 2.8.2
o Log to mlnet_logfile rc script variable instead of stdout/stderr [1]

PR:             104159 [1]
Submitted by:   hq [1]

/tmp/msg