*/*: convert Makefile patches to MAKE_ARGS after "Move man pages to share/man"

Replaced patches for Makefiles with "MAKE_ARGS+=MANDIR=${PREFIX}/share/man"

Reported by:	danfe, mat
Approved by:	portmgr (blanket)

net/mpd5: Move man pages to share/man

Approved by:	portmgr (blanket)

net/mpd5: minor improvements

(1) Import r2512 and r2529 from upstream:

* optimize CCP logging a bit: no string copying for known CCP names;
* use right name for HP-PPC.

Bump PORTREVISION.

(2) Also, this commit fixes upgrade problem for package users
introduced with previous commit that removed USES=ssl
not bumping PORTREVISION and following rename of openssl package
to openssl111. For details, refer to:

https://github.com/opnsense/core/issues/6959

PR:		274748 (2)
Reported by:	Franco Fichtner (2)
Fixes:		87e2681289fc1eb5fda22e4072aca1e7943af25e

net/mpd5: remove USES=ssl

mpd5 forces usage of base system crypto libraries
despite of presence of other *SSL libraries, so USES=ssl is wrong here.
The change does not affect build, so PORTREVISION not bumped.

PR:		273970

net/mpd5: unbreak build with OpenSSL 3.0

This fixes build, so PORTREVISION not bumped.

net/mpd5: new small feature and bugfix

- Import r2539 from upstream: introduce new interface description conversion
  specification %s for last description change time, in unixtime (seconds).
- Unbreak SIGUSR1/SIGUSR2 mechanics to open/close first link broken
  in mpd5-5.9_10 (*)

PR:		271508 (*)

net/mpd5: undo regression for specific PPPoE peers

mpd5-5.9_14 introduced regression for specific case
when no mtu configured for PPPoE peer that does not advertize any MTU itself.
mpd5 should default to 1492 then but revision 14 defaults to 1500.

The problem may be worked around specifying 1492 for link or interface MTU
until upgrade to this revision that restores compatibility.

PR:	270687

net/mpd5: minor improvements

Import several improvement from upstream:

* r2408,2409 - use SOCK_CLOEXEC for all sockets including PPtP,
  web and telnet consoles, so that subprocesses like ip-up/down scripts
  do not inherit such sockets;
* r2415 - avoid inadequate MTU undervalueing when bundle compression
  and/or encryption configured but not negotiated;
  f.e. PPPoE interface MTU could be set to 1490 instead of 1492 previously;
* r2482,2483 - improve client-side implementation of PPP-Max-Payload (RFC4638)
  and do not limit "set pppoe max-payload {size}" to 1510
  but use MTU of parent interface minus 8, as per RFC;
  also, relax sanity check for "set link mtu/mru" in case of PPPoE,
  so that it is possible to configure values like 1500 and over, if needed.

net/mpd5: eliminate some build time warnings

Import a couple of patches from upstream to eliminate some Clang warnings.
PORTREVISION not changed intentionally as changes are cosmetic.

net/mpd5: Fix incoming connections for static links (site-to-site VPN)

The change in 5.9_11 was incomplete as it did not fix
broken handling of incoming connections for static links,
f.e. site-to-site VPN.

Import r2474 from upstream to fix it, too.

net/mpd5: do not use negative value for socket backlog

Import r2463 from upstream.
As per POSIX, supply INT_MAX for listen(2) to use system default.
This changed in preparation for FreeBSD 14.

See also:	https://reviews.freebsd.org/D31821

net/mpd5: unbreak incoming L2TP connections

The revision mpd5-5.9_10 broke incoming L2TP connections. Fix it.

PR:	266838

net/mpd5: bump PORTREVISION after previous change

net/mpd5: fix some LCP negotiation problems

* Import upstream r2453: prevent endless LCP restarts in case of broken
peer or heavy packet drops. Allow 3 restarts then terminate LCP.
Let link redial restart it from the beginning, if configured.

* Import upstream r2454: fixes long-standing bug
known as "LCP: not converging" problem leaving link closed
with erroneously disabled redial.

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

net: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  <ports@c0decafe.net>
  *  Aaron Dalton <aaron@FreeBSD.org>
  *  Aaron Straup Cope <ascope@cpan.org>
  *  Aaron Zauner <az_mail@gmx.at>
  *  Adam Jette <jettea46@yahoo.com>
  *  Adam Weinberger <adamw@FreeBSD.org>
  *  Alan Eldridge <alane@geeksrus.net>
  *  Alex Bakhtin <Alex.Bakhtin@gmail.com>
  *  Alex Deiter <Alex.Deiter@Gmail.COM>
  *  Alex Dupre <ale@FreeBSD.org>
  *  Alex Dupre <sysadmin@alexdupre.com>

net/mpd5: install dictionary.mpd and add fix r2441 from upstream

* Add dictionary.mpd to default package build and install it
to /usr/local/share/mpd/dictionary.mpd.

Thanks Dmitry Luhtionov who noted this omission.

* If parent interface of PPPoE link (vlan, detachable USB ethernet etc.)
got destroyed and re-added, detect that and continue automatically;
manual interference was required before this import of upstream r2441.

net/mpd5: Use @sample for sample configuration files

The port installs some ".sample" configuration files into etc. Let's use
the @sample keyword to manage them correctly during upgrades and
deinstallations.

Approved by:	portmgr blanket

net/mpd5: let "red-port" accept zero remote port value

Import upstream r2446: allow to configre "any" remote port
for port redirection rule as supported by libalias(3).

PR:		261802
Reported by:	Martin Birgmeier

net/mpd5: Re-implement improvement for multi-homed L2TP server

Import upstream r2437-r2440:

Use IP_RECVDSTADDR socket option for IPv4 L2TP server
with unspecified self address (0.0.0.0) to determine destination
IP address of incoming request and bind new tunnel to right address.
This unbreaks multihomed L2TP server setup.

net/mpd5: undo recent change for L2TP server.

Temporary remove a change to L2TP server introduced after mpd5-5.9_2
(an attempt to improve multi-homed server behavior)
because of discovered bug that can result in a hang of the process.

Fixed version will be added later after more testing.

Reported by:	Eugene Selin at SourceForge

net/mpd5: Add CPE information

Approved by:    portmgr (blanket)

net/mpd5: add missing change after previous revision

Add r2420 from upstream to speedup multihomed L2TP server a bit.

net/mpd5: unbreak multihomed L2TP server setup and add WITHOUT_RADIUS

This change adds two improvements from upstream:

* Use IP_RECVDSTADDR socket option for IPv4 L2TP server
  with unspecified self address (0.0.0.0) to determine destination
  IP address of incoming request and bind new tunnel to right address.
  This unbreaks multihomed L2TP server setup. (r2419)

* Add support for base system built without libradius
  (WITHOUT_RADIUS_SUPPORT): this includes auto-detecting
  libradius presence and force building without RADIUS support.
  Default build is not affected and enables RADIUS support. (r2424)

net/mpd5: fix PPPoE Server remotely exploitable crash

This is security fix for PPPoE servers.

Insufficient validation of incoming PPPoE Discovery request
specially crafted by unauthenticated user might lead to unexpected
termination of the process. The problem affects mpd versions since 5.0.
Installations not using PPPoE server configuration were not affected.

Reported by:	paul & Yannick C at SourceForge
Tested by:	paul & Yannick C at SourceForge
Security:	f55921aa-10c9-11ec-8647-00e0670f2660

net/mpd5: unbreak build for GCC (powerpc64)

Unbreak package build for GCC-based arches
adding r2412 and r2414 from upstream.
No PORTREVISION bump.

net/mpd5: add L2TP fix from upstream (r2410, r2411).

This change should fix the problem reported in bugs #38 #47 #74.
It is L2TP interoperability issue with some Juniper, Cisco and
YAMAHA RTX routers having strict protocol checks.

Move USES to pet portlint.

Reported by: Kikuchan at SourceForge (based on)

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

net/mpd5: update to version 5.9

This version contains security fix for L2TP clients and servers.
Insufficient validation of incoming L2TP control packet
specially crafted by unauthenticated user might lead to unexpected
termination of the process. The problem affects mpd versions
since 4.0 that brought in initial support for L2TP.

Other changes from upstream were already present in the port
in form of pathes that were removed with this update.

Reported by:	chennan at SourceForge
Reviewed by:	mav

net/mpd5: remove required_files from startup script

Name and/or location of the configuration file may be changed
with mpd_flags, in which case required_files prevents starting service.

It is no big deal if mpd5 started with missing configuration file
because it just prints a warning to the log and exits in that case.

PR:		248993

net/mpd5: improve logging in rare case of libpdel failure.

Import upstream r2329 and r2373 to direct assertion message to the log.
See also: https://sourceforge.net/p/mpd/bugs/68/

net/mpd5: import r2272 from upstream

This fixes build with -fno-common (clang 11 and gcc 10).
PORTREVISION not bumped as it fixes build for FreeBSD 13.

PR:		248741
Reported by:	dim

Fix build with src r354909 applied.

The referenced change made NO_INSTALLLIB, NO_MAN, and NO_PROFILE into
errors causing these ports that declare them and use the FreeBSD make
infrastructure as part of their build to fail.

When the offending variables occur in a BSD Makefile, NO_MAN becomes
MAN= and NO_INSTALLLIB and NO_PROFILE become MK_INSTALLLIB=no and
MK_PROFILE=no respectively.  When declared in the environment they
become WITHOUT_<FOO>.

Clean up support for FreeBSD 11.2.

While here, modernize some comments in Mk/bsd.*.mk.

Note that graphics/drm-fbsd11.2-kmod is not renamed yet, this was somewhat
under discussion.

Submitted by:	rene
Reviewed by:	antoine, jbeich, mat, zeising
Differential Revision:	https://reviews.freebsd.org/D21974

net/mpd5: remove BROKEN_SSL*

For now, BROKERNL_SSL* is designed for port that defines GNU_CONFIGURE
and USES=pkgconfig to get libssl's include and library paths by means
of pkg-config --cflags/--libs or just use CFLAGS etc. including ${LOCALBASE}

net/mpd5 does not use pkgconfig nor GNU configure and since last update
it forces usage of system libssl despite of presence of other *SSL packages,
so BROKEN_SSL* is unneeded and does only harm here.

net/mpd5: fix build for systems having libressl installed

Import upstream revisions r2258-r2260: do not use -I${LOCALBASE}/include
by default when option NG_IPACCT is off. If NG_IPACCT is on,
use -nostdinc to force needed header inclusion order to force
usage of base system libssl.

Bump PORTREVISION as package can change if built with default options
when net-mgmt/ng_ipacct is installed.

PR:	233471

net/mpd5: fix after incorrect change r484599

openssl-1.1.1 is in FreeBSD12 base system and that was already
resolved in r482627.

While here, explicitly mark the port incompatible with alternative SSL
libraries such as LibreSSL due to dependency of base system libfetch
that links with base system libssl.

PR:		233471

security/openssl-devel was removed, but there is a security/openssl111 now.

net/mpd5: make it possible to build with ssl=openssl111

Now as FreeBSD 12 got openssl-1.1.1 in base system and
/usr/include/openssl/ssl.h and /usr/local/include/openssl/ssl.h
are indentical, it is safe to allow building net/mpd5
with DEFAULT_VERSIONS having ssl=openssl111 and no reasons to break
the build.

However, resulting binary still links with base system /usr/lib/libssl.so
because of libfetch(3) needs it and mpd5 links with libfetch too.

net/mpd5: start service earlier

mpd5 daemon can be used as replacement for stock ppp(8) daemon
to provide global connectivity (PPPoE, mobile networks etc.)

Follow ppp(8) behavior and run startup script early before
NETWORKING (and netwait), so other services that require
working networking to be operational before starting won't fail.

Bump PORTREVISION.

net/mpd5: import latest fix for "set iface mtu X override" from upstream

net/mpd5: mark broken with openssl111 for a moment

mpd5 successfully compiles with openssl-devel or openssl111
but cannot be linked because it links with base system libfetch(3)
that currently links with /usr/lib/libssl.so.8 (openssl 1.0.2p-freebsd).

So, one should not attempt to build mpd5 with newer openssl version
until it's imported to base system so mpd5 won't link with two distinct
openssl versions.

PR:		231599

Add DOCS options to ports that should have one.

Also various fixes related to said option.

PR:		230864
Submitted by:	mat
exp-runs by:	antoine

net/mpd5: revert previous LCP MRU negotiation change
and add new way to deal with same problem
following upstream changes r22478, r2249:

- reverse r2246 as it used wrong way to deal with the problem;
- make it possible to override results of LCP negotiation
  and set interface MTU to specified value with a command:

set iface mtu NNN override

New option "override" is not documented yet.
This is dangerous option as it can violate RFC 1661
and should be used with caution and at your own risk.
It is useful when you deal with broken PPP peer
negotiating too low value while higher MTU is known to work.

net/mpd5: add a fix from upstream r2247

Prevent reporting wrong traffic accounting data in very rare case
of failure of netgraph statistical socket data flow.

net/mpd5: really add the patch file after r473194

Minor change for net/mpd5: improve LCP MRU negotiation.

Add a fix from upstream r2246:

	Fix bug #62: improve LCP MRU negotiation in some unusual cases
	sometimes happening while using Orange S.A. services.
	This allow us to setup PPPoE client connection interface using mtu=1492
	instead of 1456.

Reported by:	Xavier Lemaire
Tested by:	Xavier Lemaire

Fix support of PPPoE over VLAN and add basic parsing of PADM messages.

Submitted by:	ale
Reviewed by:	mav julian
Differential Revision:	https://reviews.freebsd.org/D9848

Use BROKEN_SSL

Approved by:	portmgr (blanket)

Elaborate license information by changing it to right "BSD3CLAUSE"
instead of generic (and not entirely correct in this case) "BSD".

PR:		222545
Reported by:	Yasuhiro KIMURA <yasu@utahime.org>

- Update WWW

Approved by:	portmgr blanket

Add a patch from upstream: switch from NO_MAN and COPTS to MK_MAN and CFLAGS
for modern FreeBSD versions. PORTREVISION unchanged.

Approved by: az (mentor).

- add new patch from upstream to fix buffer overflow and improve compatibility
  with FreeBSD 11.
- bump PORTREVISION.

Reviewed by: mav
Approved by: vsevolod (mentor)

- Add new patch from upstream to improve stability of the daemon;
- simplify PORTDOCS and avoid usage of != in port's Makefile;
- add LICENSE;
- take maintainership;
- bump PORTREVISION.

Remove all USE_OPENSSL occurrences.

Sponsored by:	Absolight

Mark some ports as not openssl-devel ready.

Sponsored by:	Absolight

- Fix trailing whitespace in pkg-descrs, categories [g-n]*

Approved by:	portmgr blanket

Remove ${PORTSDIR}/ from dependencies, categories m, n, o, and p.

With hat:	portmgr
Sponsored by:	Absolight

Update to 5.8.

- Backport mpd5 fix (rev. 1224):

Do not print warning, when we a renaming interface to existing name
https://forum.pfsense.org/index.php?topic=41061.msg476926

- Bump PORTREVISION

PR:		200722
Approved by:	maintainer timeout (> 2 months)
Sponsored by:	Netgate

Need to bump revision for r382043 as well since it will change runtime behavior
for all releases.

With hat:	portmgr

Fix build of net/mpd5, after SSLv2 was disabled in base.

Approved by:	portmgr (bdrewery)
PR:		198791

Fix build with LibreSSL

PR:		196800
Approved by:	maintainer timeout

cleanup plist

Retire MANCOMPRESSED.

Also the compat NO_INSTALL_MANPAGES shim.

Differential Revision:	https://reviews.freebsd.org/D730
Reviewed by:	antoine
With hat:	portmgr
Sponsored by:	Absolight

Tiny fixes for the mpd5 package.

- Use PLIST_DIRSTRY to avoid warnings when deinstalling.

- Set PROVIDE to mpd5 in startup script (it currently confuses
  bsdadminscripts' commands)

PR:		186531
Submitted by:	olgeni
Approved by:	maintainer timeout (120 days)

Fix build when WITHOUT_MAN is defined

PR:		ports/189008
Submitted by:	Lev Serebryakov <lev@FreeBSD.org>

Support STAGE

Approved by:	portmgr (blanket)

Fix package name collision with lang/mpd

Add NO_STAGE all over the place in preparation for the staging support (cat:
net)

Update to 5.7.

Convert to new options framework
While here trim parts related to unsupported FreeBSD versions

Move the rc.d scripts of the form *.sh.in to *.in

Where necessary add $FreeBSD$ to the file

No PORTREVISION bump necessary because this is a no-op

In the rc.d scripts, change assignments to rcvar to use the
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().

In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.

- Update to 5.6

Submitted by:   maintainer

- Get Rid MD5 support

Begin the process of deprecating sysutils/rc_subr by
s#. %%RC_SUBR%%#. /etc/rc.subr#

- Update to 5.5
     * New features:
          * Added `set link redial-delay ...` command.
          * Print global filters on `show iface|customer` commands.
          * Added protocol/port forwarding support for NAT.
          * Added utmpx support on 9-CURRENT.
     * Bugfixes:
          * Fix memory leaks on pptp and radius on some reason.
          * Really make RESULT a mandatory option in ext-auth.

Submitted by:   maintainer
Feature safe:   yes

- Update to 5.4
  New features:
    * Added built-in RADIUS server, supporting RFC 3576: Dynamic
      Authorization Extensions to RADIUS.
    * Added support for DSL Forum vendor-specific Circuit-ID/Remote-ID
      PPPoE tags and respective RFC 4679 RADIUS VSA.

Submitted by:   maintainer

- Switch SourceForge ports to the new File Release System: categories starting
with N

- Update to 5.3

Submitted by:   maintainer

- Update 5.2

Submitted by:   mav (maintainer)

- Remove mtree(8) files. It prevents creating doc directories
  when NOPORTDOCS defined.

Submitted by:   mav (maintainer)

- Update to 5.1
  Next major stable release of mpd5 branch presents improved performance,
  scalability, additional features and bugfixes.

Submitted by:   maintainer

- Update to 5.0 release

Changes since 5.0rc2:
New features:
 * Sending LCP Time-Remaining packet implemented.
Bugfixes:
 * Fixed MPPC options loss on link disconnect.
 * Fixed crash on PPTP CDN sending error.
 * Fixed incorrect IPCP options reject processing.
 * Fixed MP SHORTSEQ option.
 * Fixed packet order on accepting outgoing PPTP call.

Submitted by:   mav (maintainer)

- Update to RC2. It fixes build on 5.5 and a few bugs.

Submitted by:   maintainer

- Update to 5.0 RC1

Submitted by:   maintainer

First public release of the mpd-5.x branch.
The main goal of this branch is to implement new
operation principles based on dynamic on-demand
links/bundles creation.

Repocopied from:        net/mpd4
Repocopied by:          marcus
Submitted by:           maintainer