sysutils/cdrdao: Fix zero length DMA with ata(4)

Fix zero length DMA transfer attempted failures with the ata(4) driver.
This does not seem to affect users of the ahci(4) driver.

While here, convert bzero/bcopy to memset/memmove, respectively.

PR:		277115
Reported by:	Benjamin Jacobs <freebsd@dev.thsi.be>

audio/libmad: Fix build with libmad 0.16.4

sysutils/cdrdao: Moved man to share/man

Approved by:    portmgr (blanket)

*/*: Update WWW to use HTTPS for sourceforge.net projects

Homepage link is permanent redirected to its HTTPS counterpart
Issue reported by repology : https://repology.org/repository/freebsd/problems

Approved by:	portmgr (blanket)
PR:		274888

sysutils/cdrdao: Update to 1.2.5

Convert to options helpers and clean up.
Take maintainership.

https://github.com/cdrdao/cdrdao/releases/tag/rel_1_2_5

*: reset marius@ ports after safekeeping his commit bit.

With hat:	portmgr-secretary

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

sysutils: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  <jsmith@resonatingmedia.com>
  *  Aaron Dalton <aaron@FreeBSD.org>
  *  Aaron Landwehr <aaron@snaphat.com>
  *  Adam Weinberger <adamw@FreeBSD.org>
  *  Adrian Chadd
  *  Adrian Chadd <adrian@FreeBSD.org>
  *  Akinori MUSHA aka knu <knu@idaemons.org>
  *  Alan Eldridge <alane@FreeBSD.org>
  *  Alan Eldridge <alane@geeksrus.net>
  *  Aldis Berjoza <aldis@bsdroot.lv>
  *  Alex Deiter <alex.deiter@gmail.com>

audio/libmad: Set SONAME to libmad.so.0 instead of libmad.so.0.16.2

- Bump PORTREVISION of dependent ports for shlib change
- Bump PORTREVISION for package change

audio/cdrdao: Fix pkg-config detection of libmad 0.16

Filename for libmad's pc file is now libmad.pc, this broke pkg-config
check however fallback detection code still worked.

Approved by:	portmgr (blanket)

sysutils/cdrdao: stab at fixing on riscv

sysutils/cdrdao: whitespace fixes

sysutils/cdrdao: drop use of lorder(1)

While at it, switch pkg-plist to @postunexec and remove remnants of the
gcdmaster slave missed in db5b4a8694f902fef50919c2744ee2ee31fcd89b.

PR:	259254

Remove # $FreeBSD$ from Makefiles.

Does not build on riscv64.  Kind of irrelevant, since there are no riscv64
desktops yet.

Approved by:	portmgr (tier-2 blanket)

the gcdmaster port has been removed in 2018, remove some of its definition that
has been left in the cdrdao port

Bump PORTREVISION for ports depending on the canonical version of GCC
as defined in Mk/bsd.default-versions.mk which has moved from GCC 8.3
to GCC 9.1 under most circumstances now after revision 507371.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, everything INDEX-11 shows with a dependency on lang/gcc9 now.

PR:		238330

Only append to MAKE_ENV after bsd.port.pre.mk

Bump PORTREVISION for ports depending on the canonical version of GCC
defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t
GCC 8.2 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.

PR:		231590

Bump PORTREVISION for ports depending on the canonical version of GCC
in the ports tree (via Mk/bsd.default-versions.mk and lang/gcc) which
has now moved from GCC 6 to GCC 7 by default.

This includes ports
 - featuring USE_GCC=yes or USE_GCC=any,
 - featuring USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and those
 - with USES=compiler specifying one of openmp, nestedfct, c11, c++0x,
   c++11-lib, c++11-lang, c++14-lang, c++17-lang, or gcc-c++11-lib.

PR:		222542

Update to 1.2.4, which is mostly a maintainance release and allows to get
rid of some local patches:

o Fixed autocon warnings (Denis Leroy)
o Ported to lame 3.100 (from Fedora)
o G++ compile fixes (Nick Bailey)
o Renamed xdao folder to gcdmaster (Denis Leroy)
o pccts format security patch (from Fedora)
o Fixed compile issues with glibc >= 2.12
o Gcdmaster segfault fix (Adrian Knoth)
o Prevent a FTBFS on kfreebsd (Christoph Egger)
o Fix printf format security issues (Frantisek Kluknavsky Fedora)
o Add missing options to man page (Honza Horak)
o CD_TEXT fix for HL-DT-ST (Kees Cook)
o Man page hyphen fixes (Markus Koschany)
o Some updates to the old scsilib smake files (Ubuntu patches)

While at it, pet portlint.

Security:	yes

Fix port builds for architectures which remain on gcc as the default compiler.
This will primarily help powerpc64.

For archs where clang is the default compiler, these changes will have no
effect, as the base compiler already has these capabilities (primarily, but
not exclusively, c++-11).

Tested for no-harm on amd64.

While here, pet portlint.

Approved by:	portmgr (tier-2 blanket)

Fix build of toc2mp3 after update of audio/lame to version 3.100.

PR:	225038

Remove WANT_GNOME and HAVE_GNOME.

Approved by:	bapt kwm
Sponsored by:	Absolight
Differential Revision:	  https://reviews.freebsd.org/D12643

- Unsilence installation commands
- Switch to options helpers

Approved by:	portmgr blanket

Mark some ports failing on power64.  In cases where the error message
was a stub, provide a real one.

While here, pet portlint.

Approved by:	portmgr (tier-2 blanket)
Reported by:	swills

Fix build with TOC2MP3 set after the switch to USE_CXXSTD=c++11 in r439255.

PR:		219064

Refine r439912 and properly deal with the devel/glibmm API breakage
introduced with r437481.

Catch up with a devel/glibmm API breakage introduced with r437481.

Fix another piece of code to build with -std=c++11.

Catch up with a devel/libsigc++20 API breakage introduced with r437480.

- Move the inclusion of bsd.port.pre.mk up slightly so ${UNAME} is also
  available in the gcdmaster slave port at the required point in time
  (it's unclear why this was no problem with the cdrdao port before). [1]
- Copy over the cdrtools patches from r427613 in order to fix the build
  with clang 3.9.0.

Reported by:	Jonathan Chen [1]

- Fix build on armv6 and mips and most likely also on aarc64 and mips64. [1]
- Let's see whether specifying USE_CXXSTD=c++11 stops the flood of pkg-fallout
  SPAM regarding gcdmaster caused by the update of devel/libsigc++20 to 2.10.0
  in r437480.

PR:		217074 [1]
Submitted by:	mmel (partially) [1]

The output of tools like awk, date, sort, tr,... depends on the current
locale set by the user.  Add LANG=C and LC_ALL=C at the beginning of
bsd.port.mk and export them so all commands are executed with the C locale.
LC_ALL=C overrides all other LC_* variables.  LANG is used by setlocale(3)
as default value for LC_* variables, so normally it isn't used when LC_ALL
is set, but there's code out there that looks at LANG directly so it's safer
to set it as well.  The only commands not captured by this are !=
assignments before any inclusion of bsd.port.*mk.

Introduce USE_LOCALE=<locale> that adds LANG=<locale> and LC_ALL=<locale> to
CONFIGURE_ENV and MAKE_ENV so upstream build systems can be executed with a
different locale (e.g. USE_LOCALE=en_US.UTF-8).

PR:		215882
Exp-run by:	antoine
Approved by:	portmgr (antoine)

Mark as broken on various tier-2 archs.

While here, pet portlint.

Approved by:	portmgr (tier-2 blanket)

Prevent collision with getline(3)

Remove ${PORTSDIR}/ from dependencies, categories r, s, t, and u.

With hat:	portmgr
Sponsored by:	Absolight

Fix sysutils/gcdmaster

Sponsored by:	Absolight

MASTER_SITES cleanup.

- Replace ${MASTER_SITE_FOO} with FOO.
- Merge MASTER_SITE_SUBDIR into MASTER_SITES when possible. (This means 99.9%
  of the time.)
- Remove occurrences of MASTER_SITE_LOCAL when no subdirectory was present and
  no hint of what it should be was present.
- Fix some logic.
- And generally, make things more simple and easy to understand.

While there, add magic values to the FESTIVAL, GENTOO, GIMP, GNUPG, QT and
SAMBA macros.

Also, replace some EXTRACT_SUFX occurences with USES=tar:*.

Checked by:	make fetch-urlall-list
With hat:	portmgr
Sponsored by:	Absolight

Get rid of gnomehier

Replace USES=libtool:oldver with USES=libtool or USES=libtool:keepla in
the 32 ports that still use it.  Bump PORTREVISION on their dependent
ports except the ones that depend on these:

audio/libogg
audio/libvorbis
devel/pcre
ftp/curl
graphics/jpeg
graphics/libart_lgpl
graphics/tiff
textproc/expat2
textproc/libxslt

In these cases the same trick as in the recent gettext update is used.

- Fix half-assed, broken attempt of r361978 to convert sysutils/cdrdao to
  OPTIONS and of r358245 to staging.
- Add LICENSE.

sysutils/cdrdao: USES+= alias plus no-op fix for DragonFly

The USES=alias fix is covered by a portmgr blanket.  While here,
duplicate a rules file to eliminate a local makefile in dports.  This
has no effect on FreeBSD.

- Convert USE_BZIP2 to USES
- Drop @dirrmtry from plist

Approved by:	portmgr blanket

Rename all patches that contain '::' as a path separator, and use
'__' instead.

Add DOCS to OPTIONS_DEFINE to ports that check for PORT_OPTIONS:MDOCS.

Modernize LIB_DEPENDS

With hat:	portmgr

Remove NOPORTDOCS and NOPORTEXAMPLES.

support stage for gcdmaster

support stage.

Add NO_STAGE all over the place in preparation for the staging support (cat:
sysutils)

Eradicate USE_GNOME=pkgconfig
While here:
- Trim headers
- Convert USE_GMAKE to USES=gmake
- Convert USE_GNOME=gnomehack to USES=pathfix
- Convert USE_PERL5 to USES=perl5

libogg.so.8: Bump PORTREVISION for ports that depend on libogg,
directly or indirectly (via libvorbis, libtheora).

- update png to 1.5.10

Update lame to 3.99.3.
Bump portrevision of all ports which depend upon it.

Allow to build on powerpc64.

Approved by:    netchild

- Get Rid MD5 support

Bump PORTREVISION after libao update and handle API incompatibility.

Build and use the internal pccts in order avoid the conflict between
devel/antlr and devel/pccts. Generally this doesn't fix anything of
course, given that there's only one other port which still requires
devel/pccts instead of its successor it makes sense to avoid that
dependency.

Approved by:    netchild
PR:             145615

Ressurect MASTER_SITE_SUBDIR which erroneously got nuked in rev. 1.57
but actually is needed for the gcdmaster slave-port.

Approved by:    netchild

Update to 1.2.3.

Approved by:    netchild

Hardcode a compiler specification file so CC can also be set to something
containing spaces.

Approved by:    netchild

- Retire MASTER_SITE_SOURCEFORGE_EXTENDED, it's no longer needed - all mirrors
actually have all distfiles
- Merge all SF mirrors to MASTER_SITE_SOURCEFORGE, resort according to quick
download speed survey
- Fix MASTER_SITES for all port that have used SOURCEFORGE_EXTENTED

Approved by:    portmgr (pav)

Bump PORTREVISION after libogg and libvorbisfile major version increment.

Update CONFIGURE_ARGS for how we pass CONFIGURE_TARGET to configure script.
Specifically, newer autoconf (> 2.13) has different semantic of the
configure target. In short, one should use --build=CONFIGURE_TARGET
instead of CONFIGURE_TARGET directly. Otherwise, you will get a warning
and the old semantic may be removed in later autoconf releases.

To workaround this issue, many ports hack the CONFIGURE_TARGET variable
so that it contains the ``--build='' prefix.

To solve this issue, under the fact that some ports still have
configure script generated by the old autoconf, we use runtime detection
in the do-configure target so that the proper argument can be used.

Changes to Mk/*:
 - Add runtime detection magic in bsd.port.mk

Rename fexecve() to js_fexecve() so it doesn't clash with the recently
added libc one.

Reported by:    marcus
Approved by:    netchild

Fix the build with new libsigc++20 2.2.2. I have tested these ports in runtime
and these seem work fine in normal use. I don't test every functions, so let
me know if you have any problem with it.

Reported by:    pointyhat via pav

Presenting GNOME 2.20.1 and all related works for FreeBSD.  The official
GNOME 2.20 release notes can be found at
http://www.gnome.org/start/2.20/notes/en/ .  Beyond that, this update
includes the new GIMP 2.4 (courtesy of ahze).

The GNOME 2.20 update also includes a huge change in the FreeBSD GNOME
hierarchy.  We are now using the more standard DATADIR of ${PREFIX}/share
rather than ${PREFIX}/share/gnome. The result is that fewer patches and
hacks are needed to port GNOME components to FreeBSD.  This will mean some
user changes may be required, so be sure to read /usr/ports/UPDATING for
more details.

This release and the things we accomplished in it would not have been
possible without mezz's crazy idea to collapse DATADIR, and his persistence
to make it happen successfully.  Ahze and pav also deserve thanks for

Fix build on FreeBSD 8 and beyond, dropping support for FreeBSD 3 and
earlier.

PR:             117361
Approved by:    netchild

- Update to 1.2.2. Relevant parts from the release notes:
  Cdrdao changes:
  o Man page cleanup (Andrew Suffield)
  GCDMaster changes:

  o Fixed GCC 4.1 compilation issues
  o Fixed hang when inserting WAV file

- Ensure that the libraries built by the port are linked in and not
  already installed ones. For example in case of libcdda_paranoia
  installed by audio/cdparanoia can't be used to build cddao. Such
  problems only happen when using non-standard compiler and/or linker
  flags are used but it doesn't hurt to add some anti-footshooting
  measurements to the port. [1]

PR:             115616 [1]
Approved by:    netchild

- Chase increase of audio/libvorbis shlib version.
- Bump PORTREVISION

Chase the GNOME X11BASE to LOCALBASE move, and fix the build with the
new freetype2 where needed.

Submitted by:   mezz, ahze, pav, and many others
Approved by:    portmgr (implicit, kris)

Fix build on 7.0-CURRENT sparc64 by ignoring the result of executing
avoffset. What happens is that on sparc64 when avoffset is compiled
with optimizations, it dumps core due to a SIGILL instead of failing
gracefully. If this happens during the build of a Schily tool like
cdrtools etc, it doesn't cause any further problems as all build
errors are ignored in the Schily build system. When built as part of
cdrdao, build errors in the Schily libs are reported upwards though,
albeit with an illegal exit status of -1, which was ignored until a
change in sh(1) earlier this year.

Reported by:    kris/pointyhat
Approved by:    netchild

- Allow this port to be compiled with CC set to something containing a
  path component.
- Remove obsolete USE_REINPLACE.

Approved by:    netchild

- Update to 1.2.1. Relevant parts from the release notes:
  <snip>
  Cdrdao changes:
   o  Fixed bad bug with missing return statemements in recomputeLength
      and format conversion.
   o  Fixed broken '-' STDIN input feature.
   o  Fixed various gcc4-related compile problems.
   o  Fixed copy problem with single device when read_device is specified.
   o  Minor fixes to driver table.

   GCDMaster changes:
   o  The crash when creating a new "Create Audio CD" view seemed to be
      related to gtkmm and libsigc++ and went away with newer releases of
      those packages.

   toc2cue changes:
   o  Fixed bug that was causing empty output files.
   o  Added conversion of COPY to DCP flags. (Julio Sanchez Fernandez)
  <snip>

- In gcdmaster.keys use the correct path to the installed gcdmaster-doc.png.

Approved by:    netchild

- Update to 1.2.0. [1]
  <snip>
  Cdrdao changes:
   o  SECURITY FIX: cdrdao now gives up its root privileges after setting
      up real-time scheduling, as well as before saving settings through
      the --save option. This fixes a potential local root exploit when
      cdrdao is installed with the +s chmod flag. Using --save now also
      forces an early exit after the settings are saved.
   o  Added MP3 and Ogg Vorbis file support (through respectively the
      libmad and libvorbis libraries). cdrdao will decode the MP3 and
      Ogg files into temporary WAV files that will be deleted upon exit
      (unless the new option --keep is used). The directory used to
      store those temporary WAV files can be specified with the --tmpdir
      option (default is /tmp).
   o  Improved native CUE file support: replaced old incomplete existing

Fix compilation of gcdmaster slave-port with GCC 3.4.2.

Approved by:    netchild
Obtained from:  cdrdao CVS repository

- Update to 1.1.9. Relevant parts from the release notes:
  <snip>
  Cdrdao changes:
  - MMC-driver auto-detection. If no --driver option is specified,
    cdrdao will try to autodetect an MMC-compliant device and use the
    generic-mmc driver by default. (Denis Leroy)
  - Included scsilib upgraded from cdrtools 2.01a31 (Denis Leroy)
  - Added --eject option to the unlock command to eject the cd after
    unlocking. (Eric Benson)
  - New 'discid' command to display CDDB information. (Eric Benson,
    Denis Leroy).
  - Added --full-burn and --capacity options to extend lead-out to entire
    disc, beyond 80 mins limit. (Vladimir Petrov)
  GCDMaster changes (Denis Leroy) :
  - Some bug fixes (manual driver configurations were not being saved

Use the @FreeBSD.org address of the maintainer.

Approved by:    marius

Trim whitespace.

Change the progress meter back to not print newlines on update, this
annoying behaviour unintentionally got introduced shortly before 1.1.8
was released. This patch also went into the cdrdao repository.

Submitted by:   maintainer

In case the distfile of cdrdao is not available locally, the slave port
gcdmaster was not able to fetch it.

Submitted by:   maintainer

- Update to 1.1.8. Relevant parts from the release notes:
  <snip>
  - Improved performance of the new L-EC code by up to a factor 2 depending
    on the hardware.
  - 'read-test' runs L-EC encoder over mode 1 or mode 2 form 1 sectors to
    allow performance testing in conjunction with option --speed.
  new:
  - toc2cddb: translates a TOC file into a cddb file. (Giuseppe Corbelli)
  new:
  - cue2toc: convert CUE to TOC format for audio CDs. (Matthias Czapla)
  <snip>

  Note: The 1.1.8 tarball was re-rolled twice because of missing files and
        a show-stopper in gcdmaster and some SourceForge mirrors still might
        need to catch up on it. If you have problems with differing checksums

Bump PORTREVISION on all ports that depend on gettext to aid with upgrading.

(Part 1)

Temporarily disable compilation of gcdmaster until problems with broken
dependencies when gnomelibs are installed after cdrdao can be resolved.

PR:             61840
Submitted by:   maintainer

- Fix yet another bug that might be used for a root exploit. As with the last
  bug you are only vulnerable if you locally set the cdrdao binary suid root.
- Respect CC already at the configure-stage of scsilib else we end up running
  configure with GCC and compiling with whatever CC was set to.

Submitted by:   maintainer

Fix potential root exploit.

THE FREEBSD PORT IS NOT VULNERABLE AS IT DOES NOT SET THE SUID BIT, YOU
ARE ONLY VULNERABLE, IF YOU SET IT ON YOUR OWN!

Submitted by:   maintainer

Remove USE_GNOMENG.

Use pre-everything:: instead of pre-everything: to avoid conflict with
targets in bsd.port.mk

De-pkg-comment.

Chase the gnomemm shared lib version.

From the submitter:
- Don't default to '-O2' when compiling the cdparanoia-lib but respect CFLAGS,
  this should work around the generation of broken code with GCC and an
  optimazation-level greater than 1.
- Fix a bug in the cdparanoia-lib that can cause problems on some !386.
- Remove the unneeded usage of what seems to be an extension of G++, i.e.
  arguments to the constructor when allocating an array of objects with new,
  fixes compilation with compilers stricter obeying the standards.
- Always symlink ${MACHINE_ARCH}-freebsd-cc.rul to the i386-version on !i386 in 
 the RULES-directory of scglib to be consistent with sysutils/cdrtools, cdrdao
  also should compile and work on any platform with the fixes above.
- hier(7) the location of the global cdrdao.etc to LOCALBASE/etc/cdrdao.conf.
- Make the gcdmaster gnome-frontend compile with GCC3, use HAVE_GOME-magic to
  build it.
- Clean up some stuff.