textproc/aspell: fix build with clang 19

With clang 19 and gcc 15, textproc/aspell fails to compile, with errors
similar to:

    In file included from modules/speller/default/readonly_ws.cpp:51:
    modules/speller/default/vector_hash-t.hpp:186:43: error: no member named 'e'
in 'VectorHashTable<Parms>'
      186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
          |                                     ~~~~  ^
    modules/speller/default/vector_hash-t.hpp:186:59: error: no member named
'_size' in 'VectorHashTable<Parms>'; did you mean 'size_'?
      186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
          |                                                           ^~~~~
          |                                                           size_
    modules/speller/default/vector_hash.hpp:182:17: note: 'size_' declared here
      182 |     size_type   size_;
          |                 ^

Upstream commit <https://github.com/GNUAspell/aspell/commit/ee6cbb1>
fixes this this, so add it as a PATCHFILES entry in the Makefile, until
the next version of aspell is released.

PR:		280675
Approved by:	fluffy (maintainer)
MFH:		2024Q3

textproc/aspell: Remove GNU_CONFIGURE_MANPREFIX

- Simplify Makefile
- Cosmetic change

textproc/aspell: garbage-collect DOCS option (now useless)

As of r332672, manpages are always installed and condition
.if ${PORT_OPTIONS:MDOCS} had been removed; since the port
does not install any other documentation, drop it from the
option list as well.  While here, sort INFO alphabetically
and GC the linking gimmick added for version 0.50.4.1 back
in 2003 (r94146, now commit ed1d8c2ac3336): these days, it
builds and links fine regardless of the optimization level.

PR:	252357
Fixes:	f027257d68fb6

textproc/aspell: Impelled to share/man

Approved by:    portmgr (blanket)

textproc/aspell: upgrade to 0.60.8.1

Changelog at <http://aspell.net/man-html/ChangeLog.html>.

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

textproc: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  "Choe, Cheng-Dae" whitekid
  *  -
  *  <glewis@FreeBSD.org>
  *  <koshy@india.hp.com>
  *  Aaron Dalton <aaron@FreeBSD.org>
  *  Aaron Dalton <aaron@daltons.ca>
  *  Aaron Straup Cope
  *  Aaron Straup Cope <ascope@cpan.org>
  *  Ache
  *  Adam Herzog <adam@herzogdesigns.com>
  *  Adam Weinberger <adamw@FreeBSD.org>

ncurses: fix build with futur base and ports ncurses

in preparation for the split in base of libtinfo and libncurses, clearly
specify when the packages should link against.

Note this also fixes the build with ports ncurses

textproc/aspell: fix a bad regexp after location specifier

PR:		253774

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

Provide a new macro NCURSES_IMPL

This is necessary to deal with the reduction of the ncurses library from
2 implementation on one single implementation which would be only the widechar.

Reviewed by:	mat
Differential Revision:	https://reviews.freebsd.org/D22794

Upgrade to 0.60.8 final.

Do not use MASTER_SITE_SUBDIR.

Suggested by:	mat

Upgrade to 0.60.8 (pre-release snapshot).

Changelog at <http://aspell.net/man-html/ChangeLog.html>.

Note: it includes a fix for a potently unbounded buffer over-read in GNU Aspell
0.60.*, but unfortunately, the fix will break applications that use null-
terminated UCS-2 or UCS-4 strings with the C API.

See details at
<https://lists.gnu.org/archive/html/aspell-announce/2019-08/msg00000.html>.

Security:	Potently unbounded buffer over-read in GNU Aspell 0.60.*

Upgrade to 0.60.7.

Changelog at <http://aspell.net/man-html/ChangeLog.html>.

Install texinfo files (GNU info) into ${PREFIX}/share/info

After a discussion on the mailing list on moving manpages to
${PREFIX}/share/man for consistency with base where it is
installed in usr/share/man, it appeared the same should happen
to GNU info files which were installed under share in base and
not in ports.

Now texinfo is not in base on any of the supported version of FreeBSD
it is possible to proceed to this move and it is easier to do than
the manpage change.

Other benefit than consistency are less patching: all build tools but
cmake are expecting info files to be under share/info and cmake (patched here)
was having an exception for BSD so the patch makes FreeBSD case less
specific for them

Bump revision of all impacted ports

PR:		232907
exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D17816

textproc/aspell: unbreak build with Clang 6 / GCC 7

modules/filter/tex.cpp:177:69: error: comparison between pointer and integer
('const char *' and 'int')
      if (top.in_what == Parm || top.in_what == Opt || top.do_check == '\0')
                                                       ~~~~~~~~~~~~ ^  ~~~~

Reported by:	antoine (via bug 224669)
Obtained from:	upstream (Apsell 0.60.7)

Rename the magic DISTVERSION into SPELLVERSION for the aspell ports.

Sponsored by:	Absolight

Remove libiconv.so.3 compatibility link that was added in r374303 to
prevent massive PORTREVISION bumps.  Bump dependent ports that have not
been bumped since.

Remove ${PORTSDIR}/ from dependencies, categories r, s, t, and u.

With hat:	portmgr
Sponsored by:	Absolight

textproc/aspell: document ncurses requirement (USES+=ncurses)

approved by:	infrastructure blanket

MASTER_SITES cleanup.

- Replace ${MASTER_SITE_FOO} with FOO.
- Merge MASTER_SITE_SUBDIR into MASTER_SITES when possible. (This means 99.9%
  of the time.)
- Remove occurrences of MASTER_SITE_LOCAL when no subdirectory was present and
  no hint of what it should be was present.
- Fix some logic.
- And generally, make things more simple and easy to understand.

While there, add magic values to the FESTIVAL, GENTOO, GIMP, GNUPG, QT and
SAMBA macros.

Also, replace some EXTRACT_SUFX occurences with USES=tar:*.

Checked by:	make fetch-urlall-list
With hat:	portmgr
Sponsored by:	Absolight

textproc/aspell: add CPE information

PR:		198187
Submitted by:	Shun <shun.fbsd.pr@dropcut.net>
Approved by:	bapt (blanket)

Trim @dirrm*

Rename all patches that contain '::' as a path separator, and use
'__' instead.

- Don't try to remove directories created by mtree

Convert textproc/aspell to "USES=libtool tar:bzip2" and bump dependent ports

Approved by:	portmgr (implicit, PORTREVISION bump on unstaged port)

Convert all :U to :tu and :L to :tl

Since FreeBSD 8.4 and FreeBSD 9.1 make(1) do support :tu and :tl as a
replacement for :U and :L (which has been marked as deprecated)

bmake which is the default on FreeBSD 10+ only support by default
:tu/:tl a hack has been added at the time to support :U and :L to ease
migration. This hack is now not necessary anymore

Note that this makes the ports tree incompatible with make(1) from
FreeBSD 8.3 or earlier

With hat:	portmgr

Fix build with clang 3.4

Submitted by:	dim

Extract the ispell wrapper out of aspell into a dedicated port
Cleanup up the aspell port
Propertly strip aspell libraries
Use short form of MASTER_SITES

- Convert to new options helper
- Pet portlint: use a tab (not space) after a variable name

Fix staging with ispell option on

Reported by:	Ajtim <lumiwa@gmail.com>

Stagify
Fix shebang for aspell itself, make perl also a run dependency for aspell
(needed for a couple of scripts)
Always install manpages for aspell.

Add NO_STAGE all over the place in preparation for the staging support (cat:
textproc)

- Convert to new perl framework

Approved by:	bapt@ (office@)

- Convert USE_ICONV=yes to USES=iconv
- Change USE_GNOME=pkgconfig|gnomehack to USES=pathfix|pkgconfig and
  USE_GETTEXT=yes to USES=gettext while here

- Convert USE_GETTEXT to USES (part 3)

Approved by:	portmgr (bapt)

Do not depend on gettext if NLS is off

PR:		ports/172149
Submitted by:	Gennady Proskurin <gpr@mail.ru>

- Fix ispell issue: CONFLICTS and SCRIPTS settings are optional (ISPELL)

No longer install the english dictionary (please use textproc/en-aspell if you
want the english dictionary)
Optionify
Remove the now useless textproc/aspell-with-dicten port
textproc/en-aspell now depends on textproc/aspell
clean up the Makefile

Fix with 0 lentgh words

Submitted by:   avg (office@ mailing list)

Drop maintainership to office.

Feature safe:   yes
Seen with:      bapt

- Remove WITH_FBSD10_FIX, is no longer needed

- Fix build FreeBSD 10

- Add LDFLAGS to CONFIGURE_ENV and MAKE_ENV (as it was done with LDFLAGS)
- Fix all ports that add {CPP,LD}FLAGS to *_ENV to modify flags instead

PR:             157936
Submitted by:   myself
Exp-runs by:    pav
Approved by:    pav

Upgrade to 0.60.6.1.

Remark: this release includes a patch provided by rdivacky to build with
clang.

Fix compilation with Clang (patch submitted by rdivacky).

Since I'm there, pet portlint.

Upgrade English dictionaries to SCOWL 7.1 which corrected several errors
and also added several now common proper names and some other words now
in common use.

Upgrade english dictionaries. This adds several variants.

Bounce PORTREVISION for gettext-related ports.  Have fun, ya'll.

Update CONFIGURE_ARGS for how we pass CONFIGURE_TARGET to configure script.
Specifically, newer autoconf (> 2.13) has different semantic of the
configure target. In short, one should use --build=CONFIGURE_TARGET
instead of CONFIGURE_TARGET directly. Otherwise, you will get a warning
and the old semantic may be removed in later autoconf releases.

To workaround this issue, many ports hack the CONFIGURE_TARGET variable
so that it contains the ``--build='' prefix.

To solve this issue, under the fact that some ports still have
configure script generated by the old autoconf, we use runtime detection
in the do-configure target so that the proper argument can be used.

Changes to Mk/*:
 - Add runtime detection magic in bsd.port.mk

Bump portrevision due to upgrade of devel/gettext.

The affected ports are the ones with gettext as a run-dependency
according to ports/INDEX-7 (5007 of them) and the ones with USE_GETTEXT
in Makefile (29 of them).

PR:             ports/124340
Submitted by:   edwin@
Approved by:    portmgr (pav)

- Disable wide char utf8 cursor control for $OSVERSION < 602107; (1)

- Fix segfault when checking TeX files. (2)

Reported by:    Pav (1)
PR:             ports/122873 (2)
Submitted by:   Roland Smith <rsmith (at) xs4all.nl> (2)
Patch from:     Kevin Atkinson <kevina (at) gnu.org> (author) (2)

Upgrade to 0.60.6.

List of changes from 0.60.5:

   * Compile fixes for Gcc 4.3.

   * Minor tweak to suggestion code which improved suggestion results in
     certain cases.

   * Always line buffer stdout and stderr in the Aspell utility when
     there is the potential for it to be used interactively through a
     pipe.

   * Removed debug output in `aspell munch-list'.

   * Other minor updates and bug fixes.

   * Enable Unicode support.

Don't depend on gettext if WITHOUT_NLS is defined.

Submitted by:   dougb

- Set --mandir and --infodir in CONFIGURE_ARGS if the configure script
  supports them.  This is determined by running ``configure --help'' in
  do-configure target and set the shell variable _LATE_CONFIGURE_ARGS
  which is then passed to CONFIGURE_ARGS.
- Remove --mandir and --infodir in ports' Makefile where applicable
  Few ports use REINPLACE_CMD to achieve the same effect, remove them too.
- Correct some manual pages location from PREFIX/man to MANPREFIX/man
- Define INFO_PATH where necessary
- Document that .info files are installed in a subdirectory relative to
  PREFIX/INFO_PATH and slightly change add-plist-info to use INFO_PATH and
  subdirectory detection.

PR:             ports/111470
Approved by:    portmgr
Discussed with: stas (Mk/*), gerald (info related stuffs)
Tested by:      pointyhat exp run

- Welcome X.org 7.2 \o/.
- Set X11BASE to ${LOCALBASE} for recent ${OSVERSION}.
- Bump PORTREVISION for ports intalling files in ${X11BASE}.

Fix MASTER_SITE_SUBDIR for the Englich dictionary.

PR:             ports/110067
Submitted by:   Eric P. Scott <eps+pbug0703 (at) ana.com>

Really normalize Aspell dictionaries ports PKGVERSION...
textproc/aspell/Makefile.inc had been forgotten in the previous commit.

PR:             ports/106573
Submitted by:   Marcin Wisnicki <mwisnicki+freebsd (at) gmail.com>
Reported by:    Michel TALON <talon (at) lpthe.jussieu.fr>
Pointyhat to:   /me

Back-out the s/@dirrm/@dirrmtry/ change

PR:             ports/106957
Submitted by:   John Merryweather Cooper <john_m_cooper (at) yahoo.com>

Upgrade Aspell to 0.60.5.

Changelog at <http://aspell.sourceforge.net/aspell-0.60.5.txt>.

- s/INSTALLS_SHLIB/USE_LDCONFIG/, although not yet recognized by
  portlint;

- deinstall share/locale/sl, which is not defined in
  /etc/mtree/BSD.local.dist.

PR:             ports/101497
Submitted by:   Stanislav Sedov <ssedov (at) mbsd.msk.ru>

All dictionaries can be installed separately:

  - by default, textproc/aspell installs the English dictionaries (no
    change);
  - thereafter you can install any foreign dictionary;
  - when you install a foreign dictionary, i.e. french/aspell or
    textproc/da-aspell, it installs only the dictionaries, and depends
    upon textproc/aspell for the programs;
  - if you don't need the English dictionaries, you can define
    WITHOUT_DICTEN or install textproc/aspell-without-dicten;
  - add a new port for textproc/en-aspell: if aspell had been installed
    without the English dictionaries, they can be added thereafter;
  - add a missing port for german/alt-aspell;
  - foreign dictionaries are almost independent from textproc/aspell,
    and their maintainership is available.

Credits:        special thanks to Serge Gagnon <ser_gagnon (at) sympatico.ca>

Fix build with gcc41.

PR:             95132
Submitted by:   Ron MacNeil <macro (at) hotmail.com>

Conversion to a single libtool environment.

Approved by:    portmgr (kris)

Replace ugly "@unexec rmdir %D... 2>/dev/null || true" with @dirrmtry

Approved by:    krion@
PR:             ports/88711 (related)

- Add a Gujarati (gu) dictionary;

- Update Lithuanian (lt) & Uzbek (uz) dictionaries.

Mass-conversion to the USE_AUTOTOOLS New World Order.  The code present
in bsd.autotools.mk essentially makes this a no-op given that all the
old variables set a USE_AUTOTOOLS_COMPAT variable, which is parsed in
exactly the same way as USE_AUTOTOOLS itself.

Moreover, USE_AUTOTOOLS has already been extensively tested by the GNOME
team -- all GNOME 2.12.x ports use it.

Preliminary documentation can be found at:
        http://people.FreeBSD.org/~ade/autotools.txt

which is in the process of being SGMLized before introduction into the
Porters Handbook.

Light blue touch-paper.  Run.

/usr/bin/bzip2 has been part of the base system since 4.4,
therefore it's not necessary to explicitely check for it.

PR:             88994
Submitted by:   edwin

- Update Ukrainian dictionary;

- Add Serbian and Telugu dictionaries.

Upgrade to 0.60.4.

Changelog at <http://aspell.sourceforge.net/aspell-0.60.4.txt>.

Add two missing translations files.

Reported by:    marcus

Upgrade to 0.60.3.

This release fixes several bugs involving some of the C API functions,
fixes a major bug and improves the speed of the suggestion code, and
fixes a number of other bugs.

- Update Irish (ga), Italian (it), Oriya (or), and Uzbek (uz)
  dictionaries.

- Add Kashubian (csb), Hindi (hi), Hiligaynon (hil), Marathi (mr), and
  Punjabi (pa) dictionaries.

Upgrade Hebrew (he) and Uzbek (uz) dictionaries.

ftp.gnu.org is down => add some mirrors for the dictionnaries.

Reported by:    Kris via pointyhat
Approved by:    portmgr (marcus)
Obtained from:  linux-aspell (mezz).

Adding three new dictionaries:

- Amharic (am);
- Oriya (or);
- Low Saxon (nds).

Upgrade to 0.60.2.

Don't remove system locale directories (not listed in the relevant
BSD.*.dist), but do remove locale directories that are not listed
there.  Moreover, don't try to unconditionally @dirrm these
directories since they're shared with other ports and are likely to
still be in use.

Clean up handling of locale directories at deinstall-time:

* Don't remove "system directories" (which were created by BSD.*.dist)
* Silently try to remove locale directories which we might have created

Fix plist.

Reported by:
<http://pointyhat.freebsd.org/errorlogs/i386-6-latest-logs/extras.html>.

Unbreak af-aspell.

Upgrade to 0.60.1.1.

This release contains an important bug fix involving checking of
capitalized word when affix compression is used.

Aspell can be linked again with the base ncurses, then WITH_NCURSES
has been removed.

- Update the german dictionary;

- Add two new dictionaries: Persian (Farsi) and alt-de (German using the
original spelling rules);

- A new slave port has been created for the Persian dictionary.

Remark: no new slave port for alt-de, because (1) it might get merged
with the normal de dictionary and (2) Serge Gagnon is working on a
reorganization of all these slaves-ports. To install it use the port
textproc/aspell.

Don't attempt to remove system directories

Upgrade to 0.60.1.

This release adds a new Nroff and Texinfo filter and fixes a number
of bugs and portability problems.

Warning: aspell-0.60.1 is now incompatible with the base ncurses.
To keep the ncurses interfaces, please define WITH_NCURSES: aspell
will then depend on the port devel/ncurses.
Since devel/ncurses is not packageable, this is not the default.

Fix configure to accept CXXFLAGS.
Since I'm there, use DATADIR.

PR:             ports/71787
Submitted by:   Alex Semenyaka.

Explicitly disable threading:

- on FreeBSD 4.x, it links with -pthread, but no link is
  retained in the resulting library;

- on FreeBSD 5.x and 6, it works, but since libaspell is
  used by un-threaded programs, this is not a good choice.

Reviewed by:    marcus.

Always USE_GETTEXT, even WITHOUT_NLS.

Force libaspell to link with libintl to fix gnomespell and balsa.

Bump PORTREVISION.

Reported by:    marcus and Volker Kindermann.

- Upgrade to 0.60;

- Add dictionaries for Azerbaijani, Belarusian, Bengali, Estonian,
  Finnish, Hebrew, Hungarian, Kinyarwanda, Latin, Latvian, Lithuanian,
  Macedonian, Mongolian, Nyanja, Quechua, Sardinian, Tagalog, Tamil,
  Tetum, Upper Sorbian, Uzbek, Vietnamese, and Yiddish.

Aspell English Dictionary Updated.

Changes from version 0.51:

- Updated to SCOWL 6 which avoided using the original Ispell
  dictionaries as they were a source of too many errors, among other
  changes.

- Added en_GB-ize dictionary (British with "ize" spelling).

- Added en-variant_* auxiliary dictionaries.

The version number of this dictionary is 6.0 to correspond to the SCOWL
version. Aspell-6.0 is coming soon.

- Actually use libtool15 [1]
- install static libraries [2]

PR:             ports/63944 [1]
Reported by:    many [2]

Security: fix  a buffer overflow in word-list-compress:
        - <http://marc.theaimsgroup.com/?l=bugtraq&m=108761564006503&w=2>
        - <http://nettwerked.mg2.org/advisories/wlc>

Since I'm there, switch from libtool 1.3 to 1.5, to cope with
PR ports/63944.

Obtained from:  Robert Nagy <robert@openbsd.org>.

Fix package building for textproc/nn-aspell
(remove no.alias and nynorsk.alias).

Approved by:    marcus (portmgr).

Add dictionaries for Scottish Gaelic (gd) and Manx Gaelic (gv),
and update the following dictionaries:
- Irish (ga)
- Indonesian (id)
- Croatian (hr)
- Italian (it)
- Slovak (sk).

Approved by:    mat (mentor).

Norwegian dictionaries have been upgraded.
No PORTREVISION bump, but users of these dictionaries are
encouraged to upgrade.

Noticed by:     Kris / bento
Approved by:    mat (implicit).

Adding new dictionaries:

. Interlingua (ia)
. Maltese (mt)
. Norwegian Bokmal (nb)
. Norwegian Nynorsk (nn)
. Swahili (sw)
. Tswana (tn)
. Turkish (tr)
. Walloon (wa)
. Zulu (zu)

Remark: Norwegian (no) is replaced by Norwegian Nynorsk (nn).

Approved by:    mat (mentor).