openjdk: remove need for fdescfs(5) and probably procfs(5)

Implement getCommittedVirtualMemorySize() directly using sysctl
kern.proc.vmmap
Implement getOpenFileDescriptorCount() directly using sysctl
kern.proc.nfds

Note on openjdk17 use closefrom where possible (note this use case is
only in openjdk 17, 21, 23 and 24)

Remove the message about the use of fdescfs(5) as this is not needed
for sure, keep the information about procfs(5) as I have not analysed
enough the source code to make sure it is not used anywhere else, but
I don't think it is.

java/openjdk8: Update to 8u452

java/openjdk8: Set USE_LDCONFIG to provide libjawt.so

It feels like it is java/openjdk8-jre that should provide this library, but
it'd require changes in Uses/java.mk to let consumers pick it up. Leave this
for java team for now.

Reported by:	pkg-devel exp-run

java/openjdk8: Update to 8u442

java/openjdk8: add support for powerpc

java/openjdk*: Update pkg-message information about fdescfs and procfs

OpenJDK installation inform that fdescfs(5) and procfs(5) should be
mounted when using OpenJDK.
After doing some test and some traces, it seems that this should be
no so usefull, some applications will require it, but most of java
applications doesn't seems to suffer to work or performance when
such pseudo FS is not mounted.

So this change request permit to let local administrator to decide if
it is really needed or not.

Sponsored by:	Entersekt (previously Modirum MDpay)
Sponsored by:	Klara Inc.
Approved by:	0mp (mentor)
PR:	283364

java/openjdk8: Update to 8u432

java/openjdk8: fix build on 32 bit arm

Fixes:
In file included from
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u422-b05.1/hotspot/src/os/bsd/vm/os_perf_bsd.cpp:61:
In file included from /usr/include/sys/user.h:51:
In file included from /usr/include/vm/pmap.h:88:
In file included from /usr/include/machine/pmap.h:48:
In file included from /usr/include/sys/systm.h:46:
/usr/include/machine/cpufunc.h:184:1: error: static declaration of 'breakpoint'
follows non-static declaration
  184 | breakpoint(void)
      | ^
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u422-b05.1/hotspot/src/share/vm/utilities/globalDefinitions_gcc.hpp:224:17:
note: previous declaration is here
  224 | extern "C" void breakpoint();
      |                 ^

- bumped portrevision to easily spot if future bug reports are about this
change.

PR:	281991
Approved by:	early maintainer timeout java@ (the build is broken and the patch
does not affect other architectures)
Obtained from:	Mikael Urankar <mikael@> via Attachment 254105 in bug #255662

java/openjdk8 java/openjdk11 java/openjdk17 java/openjdk18 java/openjdk19
java/openjdk20 java/openjdk21 java/openjdk22: disable warnings as errors

Generally disable warnings-as-errors for all openjdk ports, removing all
the conditionals we have now for particular architectures and/or
compilers. It does not make sense to have this on by default, unless you
are an upstream maintainer.

PR:		281188
Approved by:	maintainer timeout (2 weeks)
MFH:		2024Q3

java/openjdk8: (aarch64) builds fine with llvm from base

ran poudriere on FreeBSD 13.3/14.0/14.1/15.0
all failing ports mentioned in the issue are building fine now:
 benchmarks/scimark2
 devel/tijmp
 sysutils/javaservicewrapper
 www/jericho-html

PR:	264065
Differential Revision: https://reviews.freebsd.org/D46500

java/openjdk8: fix build with clang 19

Clang 19 is now more strict about undefined integral expressions used as
constants in enum, which results in errors compiling java/openjdk8,
similar to:

   
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u422-b05.1/hotspot/src/share/vm/oops/cpCache.hpp:195:34:
error: expression is not an integral constant expression
      195 |     option_bits_mask           = ~(((-1) << tos_state_shift) |
(field_index_mask | parameter_size_mask))
          |                                 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u422-b05.1/hotspot/src/share/vm/oops/cpCache.hpp:195:42:
note: left shift of negative value -1
      195 |     option_bits_mask           = ~(((-1) << tos_state_shift) |
(field_index_mask | parameter_size_mask))
          |                                          ^

   
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u422-b05.1/hotspot/src/share/vm/code/dependencies.hpp:173:27:
error: expression is not an integral constant expression
      173 |     all_types           = ((1 << TYPE_LIMIT) - 1) & ((-1) <<
FIRST_TYPE),

java/openjdk8: Update to 8u422

all: drop support for FreeBSD 13.2 which reached EOL today

Thanks again to jbeich for noticing various things I overlooked.

Reviewed by:	acm, ashish, eduardo, ehaupt, eugen, jbeich, martymac, mat,
nobukata, sunpoet, tagattie, yuri, arrowd, kde
Differential Revision:	https://reviews.freebsd.org/D45141

java/openjdk8: Update to 8u412

java/openjdk*: Allow users to specify an alternative cacerts file

Similar to certificate management with certctl(8) users can use custom
enterprise CAs. These need to be assembled into a custom cacerts file.
Therefore, an admin can install a custom truststore to an arbitrary
location and have the OpenJDK port symlink to it by adding
OPENJDK_SYMLINK_CACERTS to make.conf.
E.g., OPENJDK_SYMLINK_CACERTS=/usr/local/etc/ssl/cacerts.

PR:		229329
Approved by:	jrm (mentor), otis (mentor), glewis
Differential Revision:	https://reviews.freebsd.org/D42720

java/openjdk8: Update to 8u402

java/openjdk8: allow using DSCR on powerpc64

DSCR was disabled because of a bug in stable/12.
Additionally, remove ELFv1 support.

java/openjdk8: Update to 8u392

java/openjdk8: fix build with lld 17

Building java/openjdk8 with lld 17 results in the following link error:

  Making SA debugger back-end...
  ld: error: version script assignment of 'SUNWprivate_1.1' to symbol
'ps_getpid' failed: symbol not defined
  ld: error: version script assignment of 'SUNWprivate_1.1' to symbol
'ps_lcontinue' failed: symbol not defined
  ld: error: version script assignment of 'SUNWprivate_1.1' to symbol
'ps_lgetxmmregs' failed: symbol not defined
  ld: error: version script assignment of 'SUNWprivate_1.1' to symbol
'ps_lsetxmmregs' failed: symbol not defined
  cc: error: linker command failed with exit code 1 (use -v to see invocation)

This is because lld 17 defaults to errors when undefined symbols are
referenced in linker version scripts. Since there are many of these in
openjdk 8, suppress the errors by adding -Wl,--undefined-version to the
--with-extra-ldflags configure option.

PR:		274106
Approved by:	maintainer timeout (10 days)
MFH:		2023Q4

java/openjdk8: Update to 8u382

java/openjdk8: fix build with clang 16

Since clang 16 (and gcc 11) the default C++ standard is now gnu++17.
Because java/openjdk8's build infrastructure does not explicitly set its
C++ standard, this leads to several errors:

 
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u362-b09.1/hotspot/src/share/vm/adlc/arena.cpp:82:3:
error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
    register Chunk *k = _first;
    ^~~~~~~~~
 
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u362-b09.1/hotspot/src/share/vm/adlc/arena.cpp:96:3:
error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
    register Chunk *k = _chunk;   // Get filled-up chunk address
    ^~~~~~~~~
  2 errors generated.
 
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u362-b09.1/hotspot/src/share/vm/adlc/adlparse.cpp:4567:3:
error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
    register char c;

java/openjdk8: Update to 8u372

java/openjdk8: Fix use of printf (causes build failures for poudriere)

PR:             267690
Obtained from:  Michael Osipov <michael.osipov@siemens.com>

java/openjdk8: commit forgotten patch

Reported by:	mikael

java/openjdk8: fix build on powerpc64* with clang 15

/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u362-b09.1/hotspot/agent/src/os/bsd/symtab.c:266:14:
warning: call to undeclared function 'find_section_by_name'; ISO C99 and later
do not support implicit function declarations [-Wimplicit-function-declaration]
  opd_sect = find_section_by_name(".opd", fd, &ehdr, scn_cache);
             ^
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u362-b09.1/hotspot/agent/src/os/bsd/symtab.c:266:12:
error: incompatible integer to pointer conversion assigning to 'struct
elf_section *' from 'int' [-Wint-conversion]
  opd_sect = find_section_by_name(".opd", fd, &ehdr, scn_cache);
           ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Bump PORTREVISION because the issue actually existed with previous clang
versions, but didn't cause an error.
find_section_by_name() is copied from Linux's symtab.c.

java/openjdk8: Update to 8u362

java/openjdk8: fix build with clang 15

During an exp-run for llvm 15 (see bug 265425), it turned out that
java/openjdk8 failed to build with clang 15:

   
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u352-b08.1/jdk/src/share/bin/splashscreen_stubs.c:64:30:
error: incompatible pointer to integer conversion returning 'void *' from a
function with result type 'int' [-Wint-conversion]
        INVOKE(SplashLoadMemory, NULL)(pdata, size);
                                 ^~~~
    /usr/include/sys/_null.h:34:14: note: expanded from macro 'NULL'
    #define NULL    ((void *)0)
                    ^~~~~~~~~~~
   
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u352-b08.1/jdk/src/share/bin/splashscreen_stubs.c:60:39:
note: expanded from macro 'INVOKE'
    #define INVOKE(name,def) _INVOKE(name,def,return)
                                          ^~~
   
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u352-b08.1/jdk/src/share/bin/splashscreen_stubs.c:57:25:
note: expanded from macro '_INVOKE'

java/openjdk8: Use the distributed cacerts

PR:		266723
Reported by:	Michael Osipov <michael.osipov@siemens.com>

java/openjdk8: Update to 8u352

java/openjdk8: Bump PORTREVISION for previous change

PR:		264065
MFH:		2022Q3

java/openjdk8: Restore workaround for aarch64 assertions

See also <https://bugs.openjdk.org/browse/JDK-8247766>.

Even though the upstream fix has been applied to this version of the
JDK, some users still report the assertion "guarantee(val < (1U <<
nbits)) failed: Field too big for insn" occurring, when it is built with
recent versions of clang.

Therefore, restore the workaround that uses clang 12 to build the JDK on
aarch64.

PR:		264065
MFH:		2022Q3

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

java/openjdk{8,11}: Remove dependency on devel/llvm12 which is no longer
necessary

The workarounds committed in aa1ca89826b5 and 846ff4e95291 are no longer
necessary, as both the upstream commits for PR258954
(https://github.com/battleblow/jdk11u/commit/305a68a90c722aa7a7b75589e24d5b5d554c96c1)
and PR264065 (https://hg.openjdk.java.net/jdk/jdk/rev/40c07de877ab) are
now merged into the distribution tarballs.

PR:		258954, 264065
Approved by:	maintainer timeout (1 month)
MFH:		2022Q3

java/openjdk8: Update to 8u342

java/openjdk8: Bump PORTREVISION for previous change

java/openjdk8: Attempt to fix newer aarch64

Revert to forcing Clang 12 if Clang 13 or newer is detected.
This may fix problems with the built JDK on aarch64.

PR:		264065

java/openjdk8: Fix the build on aarch64

java/openjdk8: Update to 8u332 GA

java/openjdk8: enable jfr on powerpc64

java/openjdk8: enable jfr on powerpc64le

Now builds fine.

java/openjdk8: Update to 8u322 GA

This should also fix problems with LLVM/Clang 13

java/openjdk8: Update to 8u312

java/openjdk*: work around UB in markOopDesc, fix builds with clang 13

During an exp-run for llvm 13 (see bug 258209), it turned out that
java/openjdk11 through openjdk13 fail to build with clang 13:

=== Output from failing command(s) repeated here ===
* For target jdk__packages_attribute.done:

These crashes are all caused by the markOop/markOopDesc classes, which
are used to keep track of objects, and which are 'marked' using the low
few bits. (See
https://github.com/openjdk/jdk13u/blob/master/src/hotspot/share/oops/markOop.hpp
).

After some laborious bisecting, I found out that these crashes start

java/openjdk8: Add CPE information

Approved by:	portmgr (blanket)

java/openjdk8: fix runtime issues on powerpc64*

Running java or javac executables fails with:
Error: dl failure on line 910
Error: failed /usr/local/openjdk8/jre/lib/ppc64le/server/libjvm.so, because
/usr/local/openjdk8/jre/lib/ppc64le/server/libjvm.so: Undefined symbol
"_ZN5frameC1EPlPh"

java/openjdk8: Switch to server mode on aarch64

PR:		257929
Approved by:	java (maintainer timeout)
Tested by:	Ronald Klop <ronald-lists@klop.ws>

java/openjdk8: fix build on powerpc64*

/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u302-b08.1/hotspot/src/os_cpu/bsd_ppc/vm/thread_bsd_ppc.cpp:45:37:
error: use of undeclared identifier 'uc_mcontext'
    frame ret_frame((intptr_t*)uc->>uc_mcontext.mc_gpr[1/*REG_SP*/],
                                    ^
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u302-b08.1/hotspot/src/os_cpu/bsd_ppc/vm/thread_bsd_ppc.cpp:88:18:
error: redefinition of 'pd_get_top_frame_for_signal_handler'
bool JavaThread::pd_get_top_frame_for_signal_handler(frame* fr_addr, void*
ucontext, bool isInJava) {
                 ^
/wrkdirs/usr/ports/java/openjdk8/work/jdk8u-jdk8u302-b08.1/hotspot/src/os_cpu/bsd_ppc/vm/thread_bsd_ppc.cpp:83:18:
note: previous definition is here
bool JavaThread::pd_get_top_frame_for_signal_handler(frame* fr_addr, void*
ucontext, bool isInJava) {

java/openjdk8: unbreak TEST=on after 4dca33c0a4a3

$ make checksum WITH=TEST
===>  License GPLv2 accepted by the user
===>   openjdk8-8.302.08.1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by openjdk8-8.302.08.1 for building
=> No SHA256 checksum recorded for jtreg4.1-b08.tar.gz.
=> No suitable checksum found for jtreg4.1-b08.tar.gz.
=> SHA256 Checksum OK for battleblow-jdk8u-8.302.08.1-jdk8u302-b08.1_GH0.tar.gz.
*** Error code 1

Reported by:	Philipp Ost (via ports@ list)

java/openjdk8:  Update to 8u302

java/openjdk8: Fix build on armv6/7

PR:		255326
Reported by:	tech-lists@zyxst.net
Approved by:	portmgr (tier-2 / build fix blanket)

Update to 8u292

One more small cleanup, forgotten yesterday.
Reported by:	lwhsu

Remove # $FreeBSD$ from Makefiles.

Replace ${ECHO} with ${ECHO_CMD}.

${ECHO} may be no-op when "make -s" is used.

PR:		253588

Update to 8u282 GA

java/openjdk8: add support for powerpc64le

powerpc64le needs --disable-jfr and USE_PRECOMPILED_HEADER=0 - same as powerpc64
elfv2.

Clang refuses to build little-endian binaries for power7, this needs to be
bumped to power8 (this is a bug in openjdk, POWER7 is not LE-compatible).

-minsert-sched-nops=regroup_exact -mno-multiple -mno-string are not supported by
clang and need to be removed.

FreeBSD uses sys/endian.h instead of byteswap.h and bswap{16,32,64} instead of
bswap_{16,32,64}.

PR:		251247
Approved by:	java (maintainer timeout)

Update to 8u275

java/openjdk8: fix build on powerpc64 elfv1

Now elfv1 also fails to build with jfr enabled.

java/openjdk8: fix build on powerpc64 elfv2

Build with jfr fails on powerpc64 elfv2.

Fix the build for i386

* Disable jfr (at least for the moment)
* Bump PORTREVISION so the port will get rebuilt on the package builders

Update to 8u272

Add upstream patches to build with "-fno-common".

This is default with Clang 11 and GCC 10.

https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/41be6128f4c1
https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/d5c69bd5f7ad

java/openjdk8: fix patching on powerpc64 elfv2

Patching hotspot/src/cpu/ppc/vm/sharedRuntime_ppc.cpp is not necessary anymore.

Update to 8u265

java/openjdk8: fix patching

Remove files/patch-hotspot_src_cpu_ppc_vm_sharedRuntime__ppc.cpp to fix
patching.
I'm not sure why this patch was added. Removing it doesn't break build on
powerpc64 (both elfv1 and elfv2). There's no include for alloca.h in
sharedRuntime_ppc.cpp.

Fix the build for PowerPC64

Submitted by:	Curtis Hamilton

Update to 8u262

Don't print the company name in the version info

This evidently breaks some software that does parsing of -version output

PR:		244634
Submitted by:	Stefan Ehmann <shoesoft@gmx.net>

More accurate vendor information

I've tweaked the values suggested in the PR patch.

PR:		244634
Submitted by:	Michael Osipov <michael.osipov@siemens.com>

Chanse update of devel/libffi

Chase the devel/libffi update
Bump portrevision of all dependent ports to chace shard library version bump
in libffi.
Update LIB_DEPENDS lines where needed to not require a specific version of
libffi.so.

PR:		247028 (for tracking)

Update to 8u252

Fix linker errors with libinotify.

A patch was mismerged in the previous update.

PR:		243454

Update to 8u242

Security:	https://openjdk.java.net/groups/vulnerability/advisories/2020-01-14

java/openjdk8: add bootstrap and fix compilation for powerpc64 elfv2

Since the maintainer didn't respond, I'm adding the bootstrap to my own
directory on freefall.

PR:		242965
Submitted by:	Mikael Urankar (original version)
Approved by:	java (maintainer timeout)

Reinstate guidance to have /proc mounted

* Having /proc mounted is not generally critical, but there is at least one
  piece of functionality that does rely on its presence at the moment
  (e.g. OperatingSystemMXBean)

Sprinkle more USES=xorg

Remove unnecessary use of shebangfix

PR:		235453
Submitted by:	John Hein <jcfyecrayz@liamekaens.com>

Fix line numbers so patch can be applied

PR:		241324
Submitted by:	VVD <vvd@unislabs.com>

Fix build with FONTCONFIG

* This gets the fontconfig patch applying cleanly and building.  No idea
  if it actually works or not.

PR:		241294

Fix file interaction

* Load libnio in BsdNativeDispatcher, as per other OSes
* Export getmntonname0 from libnio

PR:		241317
Submitted by:	cmt@

Update to 8u232

java/openjdk8: Drop nop X11_MAKE_ENV_ON

Should have been X11_MAKE_ENV.  It has been that way since r451167
and this does not seem to have caused any trouble.  Just drop it.

Remove guidance about needing procfs

* Remove portions of pkg-message that mention needing /proc mounted.
  This hasn't been the case for a while afaik (I don't have it mounted
  and haven't observed any related problems).

Update cacerts

* Use the latest cacerts file from Oracle's public distribution of 8u221.

Convert to UCL & cleanup pkg-message (categories h-k)

Workaround for infinite recursion crash

* FreeBSD crashes on infinite recursion rather than throwing a stack
  overflow because the stack address of the fault is in the page below
  the guard area.  Workaround this by rounding down the fault address to
  the nearest page boundary.  Investigation is still under way into what
  may be causing this but this appears to prevent it in simple test cases.

PR:		222146

Fix the build for the FONTCONFIG option

* Updated the fontconfig.patch file
* Simplified FONTCONFIG to use EXTRA_PATCHES rather than a separate target

PR:		239358
Submitted by:	John Hein <jcfyecrayz@liamekaens.com>, fluffy

Fix the build for powerpc64

PR:		239368
Submitted by:	pkubaj

Update to 8u222

Use USE_GITHUB when appropriate.

Minor to whitespace to correct the PR for the previous commit.

Previous commit was:

Always depend on fontconfig

PR:		237436
Submitted by:   Dominik Lisiak <dominik.lisiak@bemsoft.pl>

Always depend on fontconfig

PR:		203862
Submitted by:	Dominik Lisiak <dominik.lisiak@bemsoft.pl>

Add back the dependency on zip.

Reported by:	Charlie Li <ml+freebsd@vishwin.info>

* Update to 8u212.
* Change master site to Github
* Remove patches and Makefile fixes that have been upstreamed to Github

Update WWW

Approved by:	portmgr (blanket)

. Update to 8u202.

. When upgrading to 8u192 the endianess definitions specific to BSD were
  missed during a large merge of the configuration file.  This resulted in,
  at least, macros affecting maths operations using the big endian rather
  than the little endian versions.

PR:		234689

Add a missing symbol in the linker map file.

PR:		234593

Add a WatchService implementation backed by kqueue,
leveraging the libinotify wrapper.

It's still possible to use the polling watchservice,
by defining the following system property:

 sun.nio.fs.watchservice=polling